[Pull][SRU][X/B/D linux-aws] Add EFA driver to linux-aws

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[Pull][SRU][X/B/D linux-aws] Add EFA driver to linux-aws

Connor Kuehl
BugLink: https://bugs.launchpad.net/bugs/1837638

[Impact]

* The open source EFA driver belongs in the AWS kernels (https://github.com/amzn/amzn-drivers/tree/master/kernel/linux/efa)

[Test Case]

 * Boot tested into each kernel. Loaded and unloaded the module.

[Regression Potential]

 * This is a new feature constrained to a custom kernel. Most of the patches have been reviewed and applied to mainline.
   The compatibility fixup sauce patch is big, but is all preprocessor directives for conditional compilation and these
   have been maintained in the Github repo during the driver's development. Basically, the blast radius of this pull
   request should be confined only to this new module and should not impact any other area of the kernel.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[Pull][SRU][Xenial/linux-aws] Add EFA driver to linux-aws

Connor Kuehl
The following changes since commit e89fe60b3c9b27dbac8b2766d9df6ad13ce6b65f:

  UBUNTU: Ubuntu-aws-4.4.0-1089.100 (2019-07-30 09:28:08 -0700)

are available in the Git repository at:

  git://git.launchpad.net/~connork/+git/xenial efa-aws

for you to fetch changes up to 0a5e6c8a3e9eba9e36492315a6bda717e7ec8a4e:

  UBUNTU: SAUCE: linux/efa: Fix modify QP udata check backport (2019-08-06 08:13:08 -0700)

----------------------------------------------------------------
Connor Kuehl (1):
      UBUNTU: [Config] aws: CONFIG_INFINIBAND_EFA=m

Daniel Kranzdorf (1):
      UBUNTU: SAUCE: linux/efa: Entropy in admin commands id

Gal Pressman (16):
      RDMA/efa: Add EFA device definitions
      RDMA/efa: Add the ABI definitions
      RDMA/efa: Add the efa.h header file
      RDMA/efa: Add the efa_com.h file
      RDMA/efa: Add the com service API definitions
      RDMA/efa: Implement functions that submit and complete admin commands
      RDMA/efa: Add common command handlers
      RDMA/efa: Add EFA verbs implementation
      RDMA/efa: Add the efa module
      RDMA/efa: Add driver to Kconfig/Makefile
      RDMA/efa: Remove MAYEXEC flag check from mmap flow
      RDMA/efa: Fix success return value in case of error
      RDMA/efa: Handle mmap insertions overflow
      UBUNTU: SAUCE: Add kernel compatibility fixups
      UBUNTU: SAUCE: linux/efa: Be consistent with success flow return value
      UBUNTU: SAUCE: linux/efa: Fix modify QP udata check backport

 MAINTAINERS                                     |    9 +
 debian.aws/config/config.common.ubuntu          |    1 +
 debian.aws/control.d/aws.inclusion-list         |    1 +
 drivers/infiniband/Kconfig                      |    1 +
 drivers/infiniband/hw/Makefile                  |    1 +
 drivers/infiniband/hw/efa/Kconfig               |   15 +
 drivers/infiniband/hw/efa/Makefile              |    9 +
 drivers/infiniband/hw/efa/efa.h                 |  310 +++
 drivers/infiniband/hw/efa/efa_admin_cmds_defs.h |  794 +++++++
 drivers/infiniband/hw/efa/efa_admin_defs.h      |  136 ++
 drivers/infiniband/hw/efa/efa_com.c             | 1162 ++++++++++
 drivers/infiniband/hw/efa/efa_com.h             |  145 ++
 drivers/infiniband/hw/efa/efa_com_cmd.c         |  704 ++++++
 drivers/infiniband/hw/efa/efa_com_cmd.h         |  270 +++
 drivers/infiniband/hw/efa/efa_common_defs.h     |   18 +
 drivers/infiniband/hw/efa/efa_main.c            |  857 ++++++++
 drivers/infiniband/hw/efa/efa_regs_defs.h       |  113 +
 drivers/infiniband/hw/efa/efa_verbs.c           | 2629 +++++++++++++++++++++++
 drivers/infiniband/hw/efa/kcompat.h             |  171 ++
 include/uapi/rdma/efa-abi.h                     |  143 ++
 20 files changed, 7489 insertions(+)
 create mode 100644 drivers/infiniband/hw/efa/Kconfig
 create mode 100644 drivers/infiniband/hw/efa/Makefile
 create mode 100644 drivers/infiniband/hw/efa/efa.h
 create mode 100644 drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
 create mode 100644 drivers/infiniband/hw/efa/efa_admin_defs.h
 create mode 100644 drivers/infiniband/hw/efa/efa_com.c
 create mode 100644 drivers/infiniband/hw/efa/efa_com.h
 create mode 100644 drivers/infiniband/hw/efa/efa_com_cmd.c
 create mode 100644 drivers/infiniband/hw/efa/efa_com_cmd.h
 create mode 100644 drivers/infiniband/hw/efa/efa_common_defs.h
 create mode 100644 drivers/infiniband/hw/efa/efa_main.c
 create mode 100644 drivers/infiniband/hw/efa/efa_regs_defs.h
 create mode 100644 drivers/infiniband/hw/efa/efa_verbs.c
 create mode 100644 drivers/infiniband/hw/efa/kcompat.h
 create mode 100644 include/uapi/rdma/efa-abi.h

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[Pull][SRU][Bionic/linux-aws] Add EFA driver to linux-aws

Connor Kuehl
In reply to this post by Connor Kuehl
The following changes since commit 1435a75c73c2da33279266d596f3e3edf2945e62:

  UBUNTU: SAUCE: [aws] arm64: acpi/pci: invoke _DSM whether to preserve firmware PCI setup (2019-07-23 02:01:29 -0400)

are available in the Git repository at:

  git://git.launchpad.net/~connork/+git/bionic efa-aws

for you to fetch changes up to 2112c105c11d53e42a9a340cbaab97ddd1d83e69:

  UBUNTU: SAUCE: linux/efa: Fix modify QP udata check backport (2019-07-23 11:50:57 -0700)

----------------------------------------------------------------
Connor Kuehl (1):
      UBUNTU: [Config] aws: CONFIG_INFINIBAND_EFA=m

Daniel Kranzdorf (1):
      UBUNTU: SAUCE: linux/efa: Entropy in admin commands id

Gal Pressman (16):
      RDMA/efa: Add EFA device definitions
      RDMA/efa: Add the ABI definitions
      RDMA/efa: Add the efa.h header file
      RDMA/efa: Add the efa_com.h file
      RDMA/efa: Add the com service API definitions
      RDMA/efa: Implement functions that submit and complete admin commands
      RDMA/efa: Add common command handlers
      RDMA/efa: Add EFA verbs implementation
      RDMA/efa: Add the efa module
      RDMA/efa: Add driver to Kconfig/Makefile
      RDMA/efa: Remove MAYEXEC flag check from mmap flow
      RDMA/efa: Fix success return value in case of error
      RDMA/efa: Handle mmap insertions overflow
      UBUNTU: SAUCE: Add kernel compatibility fixups
      UBUNTU: SAUCE: linux/efa: Be consistent with success flow return value
      UBUNTU: SAUCE: linux/efa: Fix modify QP udata check backport

 MAINTAINERS                                     |    9 +
 debian.aws/config/config.common.ubuntu          |    1 +
 debian.aws/control.d/aws.inclusion-list         |    1 +
 drivers/infiniband/Kconfig                      |    1 +
 drivers/infiniband/hw/Makefile                  |    1 +
 drivers/infiniband/hw/efa/Kconfig               |   15 +
 drivers/infiniband/hw/efa/Makefile              |    9 +
 drivers/infiniband/hw/efa/efa.h                 |  310 +++
 drivers/infiniband/hw/efa/efa_admin_cmds_defs.h |  794 +++++++
 drivers/infiniband/hw/efa/efa_admin_defs.h      |  136 ++
 drivers/infiniband/hw/efa/efa_com.c             | 1162 ++++++++++
 drivers/infiniband/hw/efa/efa_com.h             |  145 ++
 drivers/infiniband/hw/efa/efa_com_cmd.c         |  704 ++++++
 drivers/infiniband/hw/efa/efa_com_cmd.h         |  270 +++
 drivers/infiniband/hw/efa/efa_common_defs.h     |   18 +
 drivers/infiniband/hw/efa/efa_main.c            |  857 ++++++++
 drivers/infiniband/hw/efa/efa_regs_defs.h       |  113 +
 drivers/infiniband/hw/efa/efa_verbs.c           | 2629 +++++++++++++++++++++++
 drivers/infiniband/hw/efa/kcompat.h             |  171 ++
 include/uapi/rdma/efa-abi.h                     |  143 ++
 20 files changed, 7489 insertions(+)
 create mode 100644 drivers/infiniband/hw/efa/Kconfig
 create mode 100644 drivers/infiniband/hw/efa/Makefile
 create mode 100644 drivers/infiniband/hw/efa/efa.h
 create mode 100644 drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
 create mode 100644 drivers/infiniband/hw/efa/efa_admin_defs.h
 create mode 100644 drivers/infiniband/hw/efa/efa_com.c
 create mode 100644 drivers/infiniband/hw/efa/efa_com.h
 create mode 100644 drivers/infiniband/hw/efa/efa_com_cmd.c
 create mode 100644 drivers/infiniband/hw/efa/efa_com_cmd.h
 create mode 100644 drivers/infiniband/hw/efa/efa_common_defs.h
 create mode 100644 drivers/infiniband/hw/efa/efa_main.c
 create mode 100644 drivers/infiniband/hw/efa/efa_regs_defs.h
 create mode 100644 drivers/infiniband/hw/efa/efa_verbs.c
 create mode 100644 drivers/infiniband/hw/efa/kcompat.h
 create mode 100644 include/uapi/rdma/efa-abi.h

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[Pull][SRU][Disco/linux-aws] Add EFA driver to linux-aws

Connor Kuehl
In reply to this post by Connor Kuehl
The following changes since commit 4a118227578a7ef683859f12c525b56b4c2c5bc0:

  UBUNTU: SAUCE: [aws] arm64: acpi/pci: invoke _DSM whether to preserve firmware PCI setup (2019-07-23 01:59:25 -0400)

are available in the Git repository at:

  git://git.launchpad.net/~connork/+git/disco efa-aws

for you to fetch changes up to 97816cfb781fd66cc176ecaa0c253571f82a529e:

  UBUNTU: SAUCE: linux/efa: Fix modify QP udata check backport (2019-07-23 12:17:16 -0700)

----------------------------------------------------------------
Connor Kuehl (1):
      UBUNTU: [Config] aws: CONFIG_INFINIBAND_EFA=m

Daniel Kranzdorf (1):
      UBUNTU: SAUCE: linux/efa: Entropy in admin commands id

Gal Pressman (16):
      RDMA/efa: Add EFA device definitions
      RDMA/efa: Add the ABI definitions
      RDMA/efa: Add the efa.h header file
      RDMA/efa: Add the efa_com.h file
      RDMA/efa: Add the com service API definitions
      RDMA/efa: Implement functions that submit and complete admin commands
      RDMA/efa: Add common command handlers
      RDMA/efa: Add EFA verbs implementation
      RDMA/efa: Add the efa module
      RDMA/efa: Add driver to Kconfig/Makefile
      RDMA/efa: Remove MAYEXEC flag check from mmap flow
      RDMA/efa: Fix success return value in case of error
      RDMA/efa: Handle mmap insertions overflow
      UBUNTU: SAUCE: Add kernel compatibility fixups
      UBUNTU: SAUCE: linux/efa: Be consistent with success flow return value
      UBUNTU: SAUCE: linux/efa: Fix modify QP udata check backport

 MAINTAINERS                                     |    9 +
 debian.aws/config/config.common.ubuntu          |    1 +
 debian.aws/control.d/aws.inclusion-list         |    1 +
 drivers/infiniband/Kconfig                      |    1 +
 drivers/infiniband/hw/Makefile                  |    1 +
 drivers/infiniband/hw/efa/Kconfig               |   15 +
 drivers/infiniband/hw/efa/Makefile              |    9 +
 drivers/infiniband/hw/efa/efa.h                 |  310 +++
 drivers/infiniband/hw/efa/efa_admin_cmds_defs.h |  794 +++++++
 drivers/infiniband/hw/efa/efa_admin_defs.h      |  136 ++
 drivers/infiniband/hw/efa/efa_com.c             | 1162 ++++++++++
 drivers/infiniband/hw/efa/efa_com.h             |  145 ++
 drivers/infiniband/hw/efa/efa_com_cmd.c         |  704 ++++++
 drivers/infiniband/hw/efa/efa_com_cmd.h         |  270 +++
 drivers/infiniband/hw/efa/efa_common_defs.h     |   18 +
 drivers/infiniband/hw/efa/efa_main.c            |  857 ++++++++
 drivers/infiniband/hw/efa/efa_regs_defs.h       |  113 +
 drivers/infiniband/hw/efa/efa_verbs.c           | 2629 +++++++++++++++++++++++
 drivers/infiniband/hw/efa/kcompat.h             |  171 ++
 include/uapi/rdma/efa-abi.h                     |  143 ++
 20 files changed, 7489 insertions(+)
 create mode 100644 drivers/infiniband/hw/efa/Kconfig
 create mode 100644 drivers/infiniband/hw/efa/Makefile
 create mode 100644 drivers/infiniband/hw/efa/efa.h
 create mode 100644 drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
 create mode 100644 drivers/infiniband/hw/efa/efa_admin_defs.h
 create mode 100644 drivers/infiniband/hw/efa/efa_com.c
 create mode 100644 drivers/infiniband/hw/efa/efa_com.h
 create mode 100644 drivers/infiniband/hw/efa/efa_com_cmd.c
 create mode 100644 drivers/infiniband/hw/efa/efa_com_cmd.h
 create mode 100644 drivers/infiniband/hw/efa/efa_common_defs.h
 create mode 100644 drivers/infiniband/hw/efa/efa_main.c
 create mode 100644 drivers/infiniband/hw/efa/efa_regs_defs.h
 create mode 100644 drivers/infiniband/hw/efa/efa_verbs.c
 create mode 100644 drivers/infiniband/hw/efa/kcompat.h
 create mode 100644 include/uapi/rdma/efa-abi.h

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [Pull][SRU][X/B/D linux-aws] Add EFA driver to linux-aws

Kamal Mostafa-2
In reply to this post by Connor Kuehl
AWS-specific feature for AWS-specific hardware.  Looks good.

Acked-by: Kamal Mostafa <[hidden email]>

 -Kamal

On Tue, Aug 06, 2019 at 09:30:31AM -0700, Connor Kuehl wrote:

> BugLink: https://bugs.launchpad.net/bugs/1837638
>
> [Impact]
>
> * The open source EFA driver belongs in the AWS kernels (https://github.com/amzn/amzn-drivers/tree/master/kernel/linux/efa)
>
> [Test Case]
>
>  * Boot tested into each kernel. Loaded and unloaded the module.
>
> [Regression Potential]
>
>  * This is a new feature constrained to a custom kernel. Most of the patches have been reviewed and applied to mainline.
>    The compatibility fixup sauce patch is big, but is all preprocessor directives for conditional compilation and these
>    have been maintained in the Github repo during the driver's development. Basically, the blast radius of this pull
>    request should be confined only to this new module and should not impact any other area of the kernel.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [Pull][SRU][Xenial/linux-aws] Add EFA driver to linux-aws

Khaled Elmously
In reply to this post by Connor Kuehl
On 2019-08-06 09:30:32 , Connor Kuehl wrote:

> The following changes since commit e89fe60b3c9b27dbac8b2766d9df6ad13ce6b65f:
>
>   UBUNTU: Ubuntu-aws-4.4.0-1089.100 (2019-07-30 09:28:08 -0700)
>
> are available in the Git repository at:
>
>   git://git.launchpad.net/~connork/+git/xenial efa-aws
>
> for you to fetch changes up to 0a5e6c8a3e9eba9e36492315a6bda717e7ec8a4e:
>
>   UBUNTU: SAUCE: linux/efa: Fix modify QP udata check backport (2019-08-06 08:13:08 -0700)
>
> ----------------------------------------------------------------
> Connor Kuehl (1):
>       UBUNTU: [Config] aws: CONFIG_INFINIBAND_EFA=m
>
> Daniel Kranzdorf (1):
>       UBUNTU: SAUCE: linux/efa: Entropy in admin commands id
>
> Gal Pressman (16):
>       RDMA/efa: Add EFA device definitions
>       RDMA/efa: Add the ABI definitions
>       RDMA/efa: Add the efa.h header file
>       RDMA/efa: Add the efa_com.h file
>       RDMA/efa: Add the com service API definitions
>       RDMA/efa: Implement functions that submit and complete admin commands
>       RDMA/efa: Add common command handlers
>       RDMA/efa: Add EFA verbs implementation
>       RDMA/efa: Add the efa module
>       RDMA/efa: Add driver to Kconfig/Makefile
>       RDMA/efa: Remove MAYEXEC flag check from mmap flow
>       RDMA/efa: Fix success return value in case of error
>       RDMA/efa: Handle mmap insertions overflow
>       UBUNTU: SAUCE: Add kernel compatibility fixups
>       UBUNTU: SAUCE: linux/efa: Be consistent with success flow return value
>       UBUNTU: SAUCE: linux/efa: Fix modify QP udata check backport
>
>  MAINTAINERS                                     |    9 +
>  debian.aws/config/config.common.ubuntu          |    1 +
>  debian.aws/control.d/aws.inclusion-list         |    1 +
>  drivers/infiniband/Kconfig                      |    1 +
>  drivers/infiniband/hw/Makefile                  |    1 +
>  drivers/infiniband/hw/efa/Kconfig               |   15 +
>  drivers/infiniband/hw/efa/Makefile              |    9 +
>  drivers/infiniband/hw/efa/efa.h                 |  310 +++
>  drivers/infiniband/hw/efa/efa_admin_cmds_defs.h |  794 +++++++
>  drivers/infiniband/hw/efa/efa_admin_defs.h      |  136 ++
>  drivers/infiniband/hw/efa/efa_com.c             | 1162 ++++++++++
>  drivers/infiniband/hw/efa/efa_com.h             |  145 ++
>  drivers/infiniband/hw/efa/efa_com_cmd.c         |  704 ++++++
>  drivers/infiniband/hw/efa/efa_com_cmd.h         |  270 +++
>  drivers/infiniband/hw/efa/efa_common_defs.h     |   18 +
>  drivers/infiniband/hw/efa/efa_main.c            |  857 ++++++++
>  drivers/infiniband/hw/efa/efa_regs_defs.h       |  113 +
>  drivers/infiniband/hw/efa/efa_verbs.c           | 2629 +++++++++++++++++++++++
>  drivers/infiniband/hw/efa/kcompat.h             |  171 ++
>  include/uapi/rdma/efa-abi.h                     |  143 ++
>  20 files changed, 7489 insertions(+)
>  create mode 100644 drivers/infiniband/hw/efa/Kconfig
>  create mode 100644 drivers/infiniband/hw/efa/Makefile
>  create mode 100644 drivers/infiniband/hw/efa/efa.h
>  create mode 100644 drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
>  create mode 100644 drivers/infiniband/hw/efa/efa_admin_defs.h
>  create mode 100644 drivers/infiniband/hw/efa/efa_com.c
>  create mode 100644 drivers/infiniband/hw/efa/efa_com.h
>  create mode 100644 drivers/infiniband/hw/efa/efa_com_cmd.c
>  create mode 100644 drivers/infiniband/hw/efa/efa_com_cmd.h
>  create mode 100644 drivers/infiniband/hw/efa/efa_common_defs.h
>  create mode 100644 drivers/infiniband/hw/efa/efa_main.c
>  create mode 100644 drivers/infiniband/hw/efa/efa_regs_defs.h
>  create mode 100644 drivers/infiniband/hw/efa/efa_verbs.c
>  create mode 100644 drivers/infiniband/hw/efa/kcompat.h
>  create mode 100644 include/uapi/rdma/efa-abi.h
>

Just a minor issue and a question:
 1) Looks like the commits "UBUNTU: [Config] aws: CONFIG_INFINIBAND_EFA=m" and "RDMA/efa: Add driver to Kconfig/Makefile" are in reverse order - can be fixed when applying.
 2) I'm curious where those SAUCE patches come from. Any background info on them?

But basically:

Acked-by: Khalid Elmously <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: ACK: [Pull][SRU][Xenial/linux-aws] Add EFA driver to linux-aws

Connor Kuehl
On 8/6/19 8:15 PM, Khaled Elmously wrote:

> On 2019-08-06 09:30:32 , Connor Kuehl wrote:
>> The following changes since commit e89fe60b3c9b27dbac8b2766d9df6ad13ce6b65f:
>>
>>   UBUNTU: Ubuntu-aws-4.4.0-1089.100 (2019-07-30 09:28:08 -0700)
>>
>> are available in the Git repository at:
>>
>>   git://git.launchpad.net/~connork/+git/xenial efa-aws
>>
>> for you to fetch changes up to 0a5e6c8a3e9eba9e36492315a6bda717e7ec8a4e:
>>
>>   UBUNTU: SAUCE: linux/efa: Fix modify QP udata check backport (2019-08-06 08:13:08 -0700)
>>
>> ----------------------------------------------------------------
>> Connor Kuehl (1):
>>       UBUNTU: [Config] aws: CONFIG_INFINIBAND_EFA=m
>>
>> Daniel Kranzdorf (1):
>>       UBUNTU: SAUCE: linux/efa: Entropy in admin commands id
>>
>> Gal Pressman (16):
>>       RDMA/efa: Add EFA device definitions
>>       RDMA/efa: Add the ABI definitions
>>       RDMA/efa: Add the efa.h header file
>>       RDMA/efa: Add the efa_com.h file
>>       RDMA/efa: Add the com service API definitions
>>       RDMA/efa: Implement functions that submit and complete admin commands
>>       RDMA/efa: Add common command handlers
>>       RDMA/efa: Add EFA verbs implementation
>>       RDMA/efa: Add the efa module
>>       RDMA/efa: Add driver to Kconfig/Makefile
>>       RDMA/efa: Remove MAYEXEC flag check from mmap flow
>>       RDMA/efa: Fix success return value in case of error
>>       RDMA/efa: Handle mmap insertions overflow
>>       UBUNTU: SAUCE: Add kernel compatibility fixups
>>       UBUNTU: SAUCE: linux/efa: Be consistent with success flow return value
>>       UBUNTU: SAUCE: linux/efa: Fix modify QP udata check backport
>>
>>  MAINTAINERS                                     |    9 +
>>  debian.aws/config/config.common.ubuntu          |    1 +
>>  debian.aws/control.d/aws.inclusion-list         |    1 +
>>  drivers/infiniband/Kconfig                      |    1 +
>>  drivers/infiniband/hw/Makefile                  |    1 +
>>  drivers/infiniband/hw/efa/Kconfig               |   15 +
>>  drivers/infiniband/hw/efa/Makefile              |    9 +
>>  drivers/infiniband/hw/efa/efa.h                 |  310 +++
>>  drivers/infiniband/hw/efa/efa_admin_cmds_defs.h |  794 +++++++
>>  drivers/infiniband/hw/efa/efa_admin_defs.h      |  136 ++
>>  drivers/infiniband/hw/efa/efa_com.c             | 1162 ++++++++++
>>  drivers/infiniband/hw/efa/efa_com.h             |  145 ++
>>  drivers/infiniband/hw/efa/efa_com_cmd.c         |  704 ++++++
>>  drivers/infiniband/hw/efa/efa_com_cmd.h         |  270 +++
>>  drivers/infiniband/hw/efa/efa_common_defs.h     |   18 +
>>  drivers/infiniband/hw/efa/efa_main.c            |  857 ++++++++
>>  drivers/infiniband/hw/efa/efa_regs_defs.h       |  113 +
>>  drivers/infiniband/hw/efa/efa_verbs.c           | 2629 +++++++++++++++++++++++
>>  drivers/infiniband/hw/efa/kcompat.h             |  171 ++
>>  include/uapi/rdma/efa-abi.h                     |  143 ++
>>  20 files changed, 7489 insertions(+)
>>  create mode 100644 drivers/infiniband/hw/efa/Kconfig
>>  create mode 100644 drivers/infiniband/hw/efa/Makefile
>>  create mode 100644 drivers/infiniband/hw/efa/efa.h
>>  create mode 100644 drivers/infiniband/hw/efa/efa_admin_cmds_defs.h
>>  create mode 100644 drivers/infiniband/hw/efa/efa_admin_defs.h
>>  create mode 100644 drivers/infiniband/hw/efa/efa_com.c
>>  create mode 100644 drivers/infiniband/hw/efa/efa_com.h
>>  create mode 100644 drivers/infiniband/hw/efa/efa_com_cmd.c
>>  create mode 100644 drivers/infiniband/hw/efa/efa_com_cmd.h
>>  create mode 100644 drivers/infiniband/hw/efa/efa_common_defs.h
>>  create mode 100644 drivers/infiniband/hw/efa/efa_main.c
>>  create mode 100644 drivers/infiniband/hw/efa/efa_regs_defs.h
>>  create mode 100644 drivers/infiniband/hw/efa/efa_verbs.c
>>  create mode 100644 drivers/infiniband/hw/efa/kcompat.h
>>  create mode 100644 include/uapi/rdma/efa-abi.h
>>
>
> Just a minor issue and a question:
>  1) Looks like the commits "UBUNTU: [Config] aws: CONFIG_INFINIBAND_EFA=m" and "RDMA/efa: Add driver to Kconfig/Makefile" are in reverse order - can be fixed when applying.

My mistake!

>  2) I'm curious where those SAUCE patches come from. Any background info on them?

The sauce patches came from their github repository:
https://github.com/amzn/amzn-drivers/tree/master/kernel/linux/efa

I pulled in as much as I could from mainline and then pulled the few
commits that were in the repo but were not upstream (as far as I could
tell) to complete the port.

>
> But basically:
>
> Acked-by: Khalid Elmously <[hidden email]>
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED/cmt: [Pull][SRU][X/B/D linux-aws] Add EFA driver to linux-aws

Khaled Elmously
In reply to this post by Connor Kuehl

Applied, after moving the commit:

UBUNTU: [Config] aws: CONFIG_INFINIBAND_EFA=m

..to after the Makefile changes.


Kamal/Connor: does trusty/aws (which is a 4.4 kernel) not need this driver too?


Khaled



On 2019-08-06 09:30:31 , Connor Kuehl wrote:

> BugLink: https://bugs.launchpad.net/bugs/1837638
>
> [Impact]
>
> * The open source EFA driver belongs in the AWS kernels (https://github.com/amzn/amzn-drivers/tree/master/kernel/linux/efa)
>
> [Test Case]
>
>  * Boot tested into each kernel. Loaded and unloaded the module.
>
> [Regression Potential]
>
>  * This is a new feature constrained to a custom kernel. Most of the patches have been reviewed and applied to mainline.
>    The compatibility fixup sauce patch is big, but is all preprocessor directives for conditional compilation and these
>    have been maintained in the Github repo during the driver's development. Basically, the blast radius of this pull
>    request should be confined only to this new module and should not impact any other area of the kernel.
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team