[SRU][A/B/OEM-X][PATCH 0/2] Fix two front mics problem for more Lenovo m7/8/9xx machines

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][A/B/OEM-X][PATCH 0/2] Fix two front mics problem for more Lenovo m7/8/9xx machines

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1781316

Hope it can catch the last SRU of artful kernel and OEM-X kernel, since the oem
project needs them to be merged to OEM-X.

[Impact]
Recently lenovo project received a couple of lenovo machines, they all have
two mics on front panel, so all these machines need to apply a fixup, otherwise
one of the mics can't work.

[Fix]
apply a fixup from upstream driver, all these mics can work normally.

[Test Case]
plug mics or headset in front mic jacks, the mic/headset-mic can be detected
and can record sound normally.

[Regression Potential]
Very low, the changes are specific to lenovo m7/8/9xx machines with the same
subsystem id or the same init pin cfg table.


Hui Wang (2):
  ALSA: hda/realtek - Fix the problem of two front mics on more machines
  ALSA: hda/realtek - two more lenovo models need fixup of MIC_LOCATION

 sound/pci/hda/patch_realtek.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][A/B/OEM-X][PATCH 1/2] ALSA: hda/realtek - Fix the problem of two front mics on more machines

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1781316

We have 3 more Lenovo machines, they all have 2 front mics on them,
so they need the fixup to change the location for one of two mics.

Among these 3 Lenovo machines, one of them has the same pin cfg as the
machine with subid 0x17aa3138, so use the pin cfg table to apply fixup
for them. The rest machines don't share the same pin cfg, so far use
the subid to apply fixup for them.

Fixes: a3dafb2200bf ("ALSA: hda/realtek - adjust the location of one mic")
Cc: <[hidden email]>
Signed-off-by: Hui Wang <[hidden email]>
Signed-off-by: Takashi Iwai <[hidden email]>
(backported from commit e41fc8c5bd41b96bfae5ce4c66bee6edabc932e8)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 6082cdf..24ffcdb 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6443,7 +6443,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
  SND_PCI_QUIRK(0x17aa, 0x30bb, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
  SND_PCI_QUIRK(0x17aa, 0x30e2, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
  SND_PCI_QUIRK(0x17aa, 0x310c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
- SND_PCI_QUIRK(0x17aa, 0x3138, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
+ SND_PCI_QUIRK(0x17aa, 0x312a, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
+ SND_PCI_QUIRK(0x17aa, 0x3136, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
  SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
  SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
  SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
@@ -6611,6 +6612,12 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
  {0x14, 0x90170110},
  {0x19, 0x02a11030},
  {0x21, 0x02211020}),
+ SND_HDA_PIN_QUIRK(0x10ec0235, 0x17aa, "Lenovo", ALC294_FIXUP_LENOVO_MIC_LOCATION,
+ {0x14, 0x90170110},
+ {0x19, 0x02a11030},
+ {0x1a, 0x02a11040},
+ {0x1b, 0x01014020},
+ {0x21, 0x0221101f}),
  SND_HDA_PIN_QUIRK(0x10ec0236, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
  {0x12, 0x90a60140},
  {0x14, 0x90170110},
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][A/B/OEM-X][PATCH 2/2] ALSA: hda/realtek - two more lenovo models need fixup of MIC_LOCATION

Hui Wang
In reply to this post by Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1781316

We have two new lenovo desktop models which need to apply the fixup of
ALC294_FIXUP_LENOVO_MIC_LOCATION, and they have the same pin cfg as
the machine with subsystem id:0x17aa3136, now use the pincfg table
to apply the fixup for them.

Cc: <[hidden email]>
Signed-off-by: Hui Wang <[hidden email]>
Signed-off-by: Takashi Iwai <[hidden email]>
(backported from commit c6b17f1020d956f4113d478cae6171b9093817ba
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 24ffcdb..27a149a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6444,7 +6444,6 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
  SND_PCI_QUIRK(0x17aa, 0x30e2, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
  SND_PCI_QUIRK(0x17aa, 0x310c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
  SND_PCI_QUIRK(0x17aa, 0x312a, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
- SND_PCI_QUIRK(0x17aa, 0x3136, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
  SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
  SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
  SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
@@ -6618,6 +6617,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
  {0x1a, 0x02a11040},
  {0x1b, 0x01014020},
  {0x21, 0x0221101f}),
+ SND_HDA_PIN_QUIRK(0x10ec0235, 0x17aa, "Lenovo", ALC294_FIXUP_LENOVO_MIC_LOCATION,
+ {0x14, 0x90170110},
+ {0x19, 0x02a11020},
+ {0x1a, 0x02a11030},
+ {0x21, 0x0221101f}),
  SND_HDA_PIN_QUIRK(0x10ec0236, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
  {0x12, 0x90a60140},
  {0x14, 0x90170110},
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [SRU][A/B/OEM-X][PATCH 0/2] Fix two front mics problem for more Lenovo m7/8/9xx machines

Aaron Ma
In reply to this post by Hui Wang
Well backported, fix issue on specific hw.

Acked-by: Aaron Ma <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][A/B/OEM-X][PATCH 0/2] Fix two front mics problem for more Lenovo m7/8/9xx machines

Colin Ian King-2
In reply to this post by Hui Wang
On 12/07/18 04:49, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1781316
>
> Hope it can catch the last SRU of artful kernel and OEM-X kernel, since the oem
> project needs them to be merged to OEM-X.
>
> [Impact]
> Recently lenovo project received a couple of lenovo machines, they all have
> two mics on front panel, so all these machines need to apply a fixup, otherwise
> one of the mics can't work.
>
> [Fix]
> apply a fixup from upstream driver, all these mics can work normally.
>
> [Test Case]
> plug mics or headset in front mic jacks, the mic/headset-mic can be detected
> and can record sound normally.
>
> [Regression Potential]
> Very low, the changes are specific to lenovo m7/8/9xx machines with the same
> subsystem id or the same init pin cfg table.
>
>
> Hui Wang (2):
>   ALSA: hda/realtek - Fix the problem of two front mics on more machines
>   ALSA: hda/realtek - two more lenovo models need fixup of MIC_LOCATION
>
>  sound/pci/hda/patch_realtek.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
>
Limited to specific H/W, so regression potential is low.  Backport looks
good.

Acked-by: Colin Ian King <[hidden email]>



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK[B]/Cmnt: [SRU][A/B/OEM-X][PATCH 0/2] Fix two front mics problem for more Lenovo m7/8/9xx machines

Stefan Bader-2
In reply to this post by Hui Wang
On 12.07.2018 05:49, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1781316
>
> Hope it can catch the last SRU of artful kernel and OEM-X kernel, since the oem
> project needs them to be merged to OEM-X.
>
> [Impact]
> Recently lenovo project received a couple of lenovo machines, they all have
> two mics on front panel, so all these machines need to apply a fixup, otherwise
> one of the mics can't work.
>
> [Fix]
> apply a fixup from upstream driver, all these mics can work normally.
>
> [Test Case]
> plug mics or headset in front mic jacks, the mic/headset-mic can be detected
> and can record sound normally.
>
> [Regression Potential]
> Very low, the changes are specific to lenovo m7/8/9xx machines with the same
> subsystem id or the same init pin cfg table.
>
>
> Hui Wang (2):
>   ALSA: hda/realtek - Fix the problem of two front mics on more machines
>   ALSA: hda/realtek - two more lenovo models need fixup of MIC_LOCATION
>
>  sound/pci/hda/patch_realtek.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
>
Acked-by: Stefan Bader <[hidden email]>

Artful is EOL now, so no the patches will not make it there.


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED[Bionic]: [SRU][A/B/OEM-X][PATCH 0/2] Fix two front mics problem for more Lenovo m7/8/9xx machines

Kleber Souza
In reply to this post by Hui Wang
On 07/12/18 05:49, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1781316
>
> Hope it can catch the last SRU of artful kernel and OEM-X kernel, since the oem
> project needs them to be merged to OEM-X.
>
> [Impact]
> Recently lenovo project received a couple of lenovo machines, they all have
> two mics on front panel, so all these machines need to apply a fixup, otherwise
> one of the mics can't work.
>
> [Fix]
> apply a fixup from upstream driver, all these mics can work normally.
>
> [Test Case]
> plug mics or headset in front mic jacks, the mic/headset-mic can be detected
> and can record sound normally.
>
> [Regression Potential]
> Very low, the changes are specific to lenovo m7/8/9xx machines with the same
> subsystem id or the same init pin cfg table.
>
>
> Hui Wang (2):
>   ALSA: hda/realtek - Fix the problem of two front mics on more machines
>   ALSA: hda/realtek - two more lenovo models need fixup of MIC_LOCATION
>
>  sound/pci/hda/patch_realtek.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
>

Applied to bionic/master-next branch.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team