[SRU][A/B/OEM-X][PATCH v2] Enable mic-mute hotkey and led for Lenovo M810z, M820z and M920z

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][A/B/OEM-X][PATCH v2] Enable mic-mute hotkey and led for Lenovo M810z, M820z and M920z

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1774306

In the V2, I changed something as below:
 - changed all OEM-A to OEM-X in the patch subject
 - In the 1st patch ([SRU][A/OEM-X][PATCH v2] ALSA: hda/realtek...), I changed cherry picked to backported.
And BTW, the 2nd patch which is for bionic, it is "cherry picked" since there is no conflict when I run cherry-pick.


Because of patch conflicting, I sent two patches in this thread:
1st one is for artful and oem-artful kernel: [SRU][A/OEM-A][PATCH] ALSA: hda/realtek...
2nd one is for bionic kernel: [SRU][B][PATCH] ALSA: hda/realtek...

[Impact]
M810z, M820z and M920z are Lenovo AIO machines, there is a mic-mute button with
led on them, without this patch, the hotkey and led only works on M810z, if we
want 820z and 920z to work, we need to add their subsystem id in the driver, but
since they use same codec with same pin conf, we use a better way than adding id.

[Fix]
With this patch, all 3 machines applied ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY.

[Test Case]
press mic-mute button, then check sound-setting, we found the input will mute or
unmute as users press button, and led will on or off to indicate the input status.

[Regression Potential]
Very low, through the strictly match the pin conf, codec id and vendor id, this
fix only apply to M810z, M820z and M920z.

Hui Wang (1):
  ALSA: hda/realtek - Enable mic-mute hotkey for several Lenovo AIOs

 sound/pci/hda/patch_realtek.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][A/OEM-X][PATCH v2] ALSA: hda/realtek - Enable mic-mute hotkey for several Lenovo AIOs

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1774306

We have several Lenovo AIOs like M810z, M820z and M920z, they have
the same design for mic-mute hotkey and led and they use the same
codec with the same pin configuration, so use the pin conf table to
apply fix to all of them.

Fixes: 29693efcea0f ("ALSA: hda - Fix micmute hotkey problem for a lenovo AIO machine")
Cc: <[hidden email]>
Signed-off-by: Hui Wang <[hidden email]>
Signed-off-by: Takashi Iwai <[hidden email]>
(backported from commit 986376b68dcc95bb7df60ad30c2353c1f7578fa5
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 6a1f5ae..6082cdf 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6445,7 +6445,6 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
  SND_PCI_QUIRK(0x17aa, 0x310c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
  SND_PCI_QUIRK(0x17aa, 0x3138, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
  SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
- SND_PCI_QUIRK(0x17aa, 0x3112, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
  SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
  SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
  SND_PCI_QUIRK(0x17aa, 0x3978, "IdeaPad Y410P", ALC269_FIXUP_NO_SHUTUP),
@@ -6607,6 +6606,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
  ALC225_STANDARD_PINS,
  {0x12, 0xb7a60130},
  {0x1b, 0x90170110}),
+ SND_HDA_PIN_QUIRK(0x10ec0235, 0x17aa, "Lenovo", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY,
+ {0x12, 0x90a60140},
+ {0x14, 0x90170110},
+ {0x19, 0x02a11030},
+ {0x21, 0x02211020}),
  SND_HDA_PIN_QUIRK(0x10ec0236, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
  {0x12, 0x90a60140},
  {0x14, 0x90170110},
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][B][PATCH v2] ALSA: hda/realtek - Enable mic-mute hotkey for several Lenovo AIOs

Hui Wang
In reply to this post by Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1774306

We have several Lenovo AIOs like M810z, M820z and M920z, they have
the same design for mic-mute hotkey and led and they use the same
codec with the same pin configuration, so use the pin conf table to
apply fix to all of them.

Fixes: 29693efcea0f ("ALSA: hda - Fix micmute hotkey problem for a lenovo AIO machine")
Cc: <[hidden email]>
Signed-off-by: Hui Wang <[hidden email]>
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit 986376b68dcc95bb7df60ad30c2353c1f7578fa5
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 0a03a62..d1578f1 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6573,7 +6573,6 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
  SND_PCI_QUIRK(0x17aa, 0x310c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
  SND_PCI_QUIRK(0x17aa, 0x3138, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
  SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
- SND_PCI_QUIRK(0x17aa, 0x3112, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
  SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
  SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
  SND_PCI_QUIRK(0x17aa, 0x3978, "IdeaPad Y410P", ALC269_FIXUP_NO_SHUTUP),
@@ -6745,6 +6744,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
  {0x1b, 0x01111010},
  {0x1e, 0x01451130},
  {0x21, 0x02211020}),
+ SND_HDA_PIN_QUIRK(0x10ec0235, 0x17aa, "Lenovo", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY,
+ {0x12, 0x90a60140},
+ {0x14, 0x90170110},
+ {0x19, 0x02a11030},
+ {0x21, 0x02211020}),
  SND_HDA_PIN_QUIRK(0x10ec0236, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
  {0x12, 0x90a60140},
  {0x14, 0x90170110},
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][A/B/OEM-X][PATCH v2] Enable mic-mute hotkey and led for Lenovo M810z, M820z and M920z

Kleber Souza
In reply to this post by Hui Wang
On 06/05/18 18:01, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1774306
>
> In the V2, I changed something as below:
>  - changed all OEM-A to OEM-X in the patch subject
>  - In the 1st patch ([SRU][A/OEM-X][PATCH v2] ALSA: hda/realtek...), I changed cherry picked to backported.
> And BTW, the 2nd patch which is for bionic, it is "cherry picked" since there is no conflict when I run cherry-pick.
>
>
> Because of patch conflicting, I sent two patches in this thread:
> 1st one is for artful and oem-artful kernel: [SRU][A/OEM-A][PATCH] ALSA: hda/realtek...
> 2nd one is for bionic kernel: [SRU][B][PATCH] ALSA: hda/realtek...
>
> [Impact]
> M810z, M820z and M920z are Lenovo AIO machines, there is a mic-mute button with
> led on them, without this patch, the hotkey and led only works on M810z, if we
> want 820z and 920z to work, we need to add their subsystem id in the driver, but
> since they use same codec with same pin conf, we use a better way than adding id.
>
> [Fix]
> With this patch, all 3 machines applied ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY.
>
> [Test Case]
> press mic-mute button, then check sound-setting, we found the input will mute or
> unmute as users press button, and led will on or off to indicate the input status.
>
> [Regression Potential]
> Very low, through the strictly match the pin conf, codec id and vendor id, this
> fix only apply to M810z, M820z and M920z.
>
> Hui Wang (1):
>   ALSA: hda/realtek - Enable mic-mute hotkey for several Lenovo AIOs
>
>  sound/pci/hda/patch_realtek.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>

Thanks for the v2!

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][A/B/OEM-X][PATCH v2] Enable mic-mute hotkey and led for Lenovo M810z, M820z and M920z

Po-Hsu Lin (Sam)
In reply to this post by Hui Wang
Ack for both patches, thanks
Acked-by: Po-Hsu Lin <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU][A/B/OEM-X][PATCH v2] Enable mic-mute hotkey and led for Lenovo M810z, M820z and M920z

Khaled Elmously
In reply to this post by Hui Wang
Applied to A and B

On 2018-06-06 09:01:37 , Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1774306
>
> In the V2, I changed something as below:
>  - changed all OEM-A to OEM-X in the patch subject
>  - In the 1st patch ([SRU][A/OEM-X][PATCH v2] ALSA: hda/realtek...), I changed cherry picked to backported.
> And BTW, the 2nd patch which is for bionic, it is "cherry picked" since there is no conflict when I run cherry-pick.
>
>
> Because of patch conflicting, I sent two patches in this thread:
> 1st one is for artful and oem-artful kernel: [SRU][A/OEM-A][PATCH] ALSA: hda/realtek...
> 2nd one is for bionic kernel: [SRU][B][PATCH] ALSA: hda/realtek...
>
> [Impact]
> M810z, M820z and M920z are Lenovo AIO machines, there is a mic-mute button with
> led on them, without this patch, the hotkey and led only works on M810z, if we
> want 820z and 920z to work, we need to add their subsystem id in the driver, but
> since they use same codec with same pin conf, we use a better way than adding id.
>
> [Fix]
> With this patch, all 3 machines applied ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY.
>
> [Test Case]
> press mic-mute button, then check sound-setting, we found the input will mute or
> unmute as users press button, and led will on or off to indicate the input status.
>
> [Regression Potential]
> Very low, through the strictly match the pin conf, codec id and vendor id, this
> fix only apply to M810z, M820z and M920z.
>
> Hui Wang (1):
>   ALSA: hda/realtek - Enable mic-mute hotkey for several Lenovo AIOs
>
>  sound/pci/hda/patch_realtek.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> --
> 2.7.4
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

_NOT_ APPLIED: [OEM-X][PATCH v2] Enable mic-mute hotkey and led for Lenovo M810z, M820z and M920z

Khaled Elmously
Just sending another message to make it clear that this patchset was NOT applied to xenial/oem.



On 2018-06-06 19:13:42 , Khaled Elmously wrote:

> Applied to A and B
>
> On 2018-06-06 09:01:37 , Hui Wang wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1774306
> >
> > In the V2, I changed something as below:
> >  - changed all OEM-A to OEM-X in the patch subject
> >  - In the 1st patch ([SRU][A/OEM-X][PATCH v2] ALSA: hda/realtek...), I changed cherry picked to backported.
> > And BTW, the 2nd patch which is for bionic, it is "cherry picked" since there is no conflict when I run cherry-pick.
> >
> >
> > Because of patch conflicting, I sent two patches in this thread:
> > 1st one is for artful and oem-artful kernel: [SRU][A/OEM-A][PATCH] ALSA: hda/realtek...
> > 2nd one is for bionic kernel: [SRU][B][PATCH] ALSA: hda/realtek...
> >
> > [Impact]
> > M810z, M820z and M920z are Lenovo AIO machines, there is a mic-mute button with
> > led on them, without this patch, the hotkey and led only works on M810z, if we
> > want 820z and 920z to work, we need to add their subsystem id in the driver, but
> > since they use same codec with same pin conf, we use a better way than adding id.
> >
> > [Fix]
> > With this patch, all 3 machines applied ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY.
> >
> > [Test Case]
> > press mic-mute button, then check sound-setting, we found the input will mute or
> > unmute as users press button, and led will on or off to indicate the input status.
> >
> > [Regression Potential]
> > Very low, through the strictly match the pin conf, codec id and vendor id, this
> > fix only apply to M810z, M820z and M920z.
> >
> > Hui Wang (1):
> >   ALSA: hda/realtek - Enable mic-mute hotkey for several Lenovo AIOs
> >
> >  sound/pci/hda/patch_realtek.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > --
> > 2.7.4
> >
> >
> > --
> > kernel-team mailing list
> > [hidden email]
> > https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[U]: [SRU][B][PATCH v2] ALSA: hda/realtek - Enable mic-mute hotkey for several Lenovo AIOs

Thadeu Lima de Souza Cascardo-3
In reply to this post by Hui Wang
Applied to unstable master branch.

Thanks.
Cascardo.

Applied-to: unstable/master

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team