[SRU] [A/B] [PATCH 0/1] Remove confusing message from iwlwifi

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU] [A/B] [PATCH 0/1] Remove confusing message from iwlwifi

Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1720930

[Impact]
Message "wlp3s0: failed to remove key (1, ff:ff:ff:ff:ff:ff) from
hardware (-22)" showed when the system shutdown.

[Test]
Users confirmed the patch fixes their issue.

[Fix]
"Remove the error return value."

[Regression Potential]
Low. It's in mainline Linux, limited to iwlwifi, trivial change.

Sara Sharon (1):
  iwlwifi: mvm: fix "failed to remove key" message

 drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--
2.17.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU] [A/B] [PATCH 1/1] iwlwifi: mvm: fix "failed to remove key" message

Kai-Heng Feng
From: Sara Sharon <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1720930

When the GTK is installed, we install it to HW with the
station ID of the AP.

Mac80211 will try to remove it only after the AP sta is
removed, which will result in a failure to remove key
since we do not have any station for it.

This is a valid situation, but a previous commit removed
the early return and added a return with error value, which
resulted in an error message that is confusing to users.

Remove the error return value.

Fixes: 85aeb58cec1a ("iwlwifi: mvm: Enable security on new TX API")
Signed-off-by: Sara Sharon <[hidden email]>
Signed-off-by: Luca Coelho <[hidden email]>
(cherry picked from commit e4f13ad07823b24a1537518d2163bd164292fb10)
Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
index 027ee5e72172..f75b6f29675d 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/sta.c
@@ -3312,8 +3312,9 @@ static int __iwl_mvm_remove_sta_key(struct iwl_mvm *mvm, u8 sta_id,
  int ret, size;
  u32 status;
 
+ /* This is a valid situation for GTK removal */
  if (sta_id == IWL_MVM_INVALID_STA)
- return -EINVAL;
+ return 0;
 
  key_flags = cpu_to_le16((keyconf->keyidx << STA_KEY_FLG_KEYID_POS) &
  STA_KEY_FLG_KEYID_MSK);
--
2.17.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU] [A/B] [PATCH 0/1] Remove confusing message from iwlwifi

Po-Hsu Lin (Sam)
In reply to this post by Kai-Heng Feng
Clean cherry-pick + positive test result, thus:
Acked-by: Po-Hsu Lin <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU] [A/B] [PATCH 0/1] Remove confusing message from iwlwifi

Hui Wang
In reply to this post by Kai-Heng Feng
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU] [A/B] [PATCH 0/1] Remove confusing message from iwlwifi

Khaled Elmously
In reply to this post by Kai-Heng Feng
Applied to A and B


On 2018-05-29 16:43:57 , Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1720930
>
> [Impact]
> Message "wlp3s0: failed to remove key (1, ff:ff:ff:ff:ff:ff) from
> hardware (-22)" showed when the system shutdown.
>
> [Test]
> Users confirmed the patch fixes their issue.
>
> [Fix]
> "Remove the error return value."
>
> [Regression Potential]
> Low. It's in mainline Linux, limited to iwlwifi, trivial change.
>
> Sara Sharon (1):
>   iwlwifi: mvm: fix "failed to remove key" message
>
>  drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> --
> 2.17.0
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team