[SRU][Artful][Bionic][PATCH 0/1] UBUNTU: SAUCE: platform/x86: acer-wmi: add another KEY_POWER keycode

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][Artful][Bionic][PATCH 0/1] UBUNTU: SAUCE: platform/x86: acer-wmi: add another KEY_POWER keycode

Joseph Salisbury-3
BugLink: http://bugs.launchpad.net/bugs/1766054

== SRU Justification ==
It's impossible to use power button functionalities in Acer Swift Notebook
Series (tested on Acer Swift 3 sf314-52).  The keyboard button is not
managed at acer-wmi level:

[405.267887] acer_wmi: Unknown key number - 0x87]

This patch adds the KEY_POWER event in acer-wmi.  The patch will also be sent
upstream, but it is being requested in Ubuntu to not wait for it to come back
downstream.  This patch is also needed in Xenial, but Xenial requres a minor backport.

== Fix ==
UBUNTU: SAUCE: platform/x86: acer-wmi: add another KEY_POWER keycode

== Regression Potential ==
Low.  This is a oneliner that addes a new keymap.

== Test Case ==
A test kernel was built with this patch and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.

Antonio Rosario Intilisano (1):
  UBUNTU: SAUCE: platform/x86: acer-wmi: add another KEY_POWER keycode

 drivers/platform/x86/acer-wmi.c | 1 +
 1 file changed, 1 insertion(+)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][Artful][Bionic][PATCH 1/1] UBUNTU: SAUCE: platform/x86: acer-wmi: add another KEY_POWER keycode

Joseph Salisbury-3
From: Antonio Rosario Intilisano <[hidden email]>

BugLink: http://bugs.launchpad.net/bugs/1766054

Now that we have informed the firmware that the Power Button driver is
active, laptops such as the Acer Swift 3 will generate a WMI key event with
code 0x87 when the power button key is pressed.  Add this keycode to the
table so that it is converted to an appropriate input event.  

Signed-off-by: Antonio Rosario Intilisano <[hidden email]>
Acked-by: Gianfranco Costamagna <[hidden email]>
Cc: Chris Chiu <[hidden email]>
Cc: Daniel Drake <[hidden email]>
Cc: Andy Shevchenko <[hidden email]>
Signed-off-by: Joseph Salisbury <[hidden email]>
---
 drivers/platform/x86/acer-wmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 1be71f9..8952173 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -129,6 +129,7 @@ static const struct key_entry acer_wmi_keymap[] __initconst = {
  {KE_IGNORE, 0x83, {KEY_TOUCHPAD_TOGGLE} },
  {KE_KEY, 0x85, {KEY_TOUCHPAD_TOGGLE} },
  {KE_KEY, 0x86, {KEY_WLAN} },
+ {KE_KEY, 0x87, {KEY_POWER} },
  {KE_END, 0}
 };
 
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][Artful][Bionic][PATCH 1/1] UBUNTU: SAUCE: platform/x86: acer-wmi: add another KEY_POWER keycode

Colin Ian King-2
On 27/04/18 19:02, Joseph Salisbury wrote:

> From: Antonio Rosario Intilisano <[hidden email]>
>
> BugLink: http://bugs.launchpad.net/bugs/1766054
>
> Now that we have informed the firmware that the Power Button driver is
> active, laptops such as the Acer Swift 3 will generate a WMI key event with
> code 0x87 when the power button key is pressed.  Add this keycode to the
> table so that it is converted to an appropriate input event.  
>
> Signed-off-by: Antonio Rosario Intilisano <[hidden email]>
> Acked-by: Gianfranco Costamagna <[hidden email]>
> Cc: Chris Chiu <[hidden email]>
> Cc: Daniel Drake <[hidden email]>
> Cc: Andy Shevchenko <[hidden email]>
> Signed-off-by: Joseph Salisbury <[hidden email]>
> ---
>  drivers/platform/x86/acer-wmi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 1be71f9..8952173 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -129,6 +129,7 @@ static const struct key_entry acer_wmi_keymap[] __initconst = {
>   {KE_IGNORE, 0x83, {KEY_TOUCHPAD_TOGGLE} },
>   {KE_KEY, 0x85, {KEY_TOUCHPAD_TOGGLE} },
>   {KE_KEY, 0x86, {KEY_WLAN} },
> + {KE_KEY, 0x87, {KEY_POWER} },
>   {KE_END, 0}
>  };
>  
>

Limited to specific x86 platform, regression potential low. Can this be
upstreamed at some point?

Acked-by: Colin Ian King <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: ACK: [SRU][Artful][Bionic][PATCH 1/1] UBUNTU: SAUCE: platform/x86: acer-wmi: add another KEY_POWER keycode

Joseph Salisbury-3
On 04/27/2018 02:05 PM, Colin Ian King wrote:

> On 27/04/18 19:02, Joseph Salisbury wrote:
>> From: Antonio Rosario Intilisano <[hidden email]>
>>
>> BugLink: http://bugs.launchpad.net/bugs/1766054
>>
>> Now that we have informed the firmware that the Power Button driver is
>> active, laptops such as the Acer Swift 3 will generate a WMI key event with
>> code 0x87 when the power button key is pressed.  Add this keycode to the
>> table so that it is converted to an appropriate input event.  
>>
>> Signed-off-by: Antonio Rosario Intilisano <[hidden email]>
>> Acked-by: Gianfranco Costamagna <[hidden email]>
>> Cc: Chris Chiu <[hidden email]>
>> Cc: Daniel Drake <[hidden email]>
>> Cc: Andy Shevchenko <[hidden email]>
>> Signed-off-by: Joseph Salisbury <[hidden email]>
>> ---
>>  drivers/platform/x86/acer-wmi.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
>> index 1be71f9..8952173 100644
>> --- a/drivers/platform/x86/acer-wmi.c
>> +++ b/drivers/platform/x86/acer-wmi.c
>> @@ -129,6 +129,7 @@ static const struct key_entry acer_wmi_keymap[] __initconst = {
>>   {KE_IGNORE, 0x83, {KEY_TOUCHPAD_TOGGLE} },
>>   {KE_KEY, 0x85, {KEY_TOUCHPAD_TOGGLE} },
>>   {KE_KEY, 0x86, {KEY_WLAN} },
>> + {KE_KEY, 0x87, {KEY_POWER} },
>>   {KE_END, 0}
>>  };
>>  
>>
> Limited to specific x86 platform, regression potential low. Can this be
> upstreamed at some point?
>
> Acked-by: Colin Ian King <[hidden email]>

It is in the process of being upstream by the patch Author.


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: ACK: [SRU][Artful][Bionic][PATCH 1/1] UBUNTU: SAUCE: platform/x86: acer-wmi: add another KEY_POWER keycode

Colin Ian King-2
On 27/04/18 19:25, Joseph Salisbury wrote:

> On 04/27/2018 02:05 PM, Colin Ian King wrote:
>> On 27/04/18 19:02, Joseph Salisbury wrote:
>>> From: Antonio Rosario Intilisano <[hidden email]>
>>>
>>> BugLink: http://bugs.launchpad.net/bugs/1766054
>>>
>>> Now that we have informed the firmware that the Power Button driver is
>>> active, laptops such as the Acer Swift 3 will generate a WMI key event with
>>> code 0x87 when the power button key is pressed.  Add this keycode to the
>>> table so that it is converted to an appropriate input event.  
>>>
>>> Signed-off-by: Antonio Rosario Intilisano <[hidden email]>
>>> Acked-by: Gianfranco Costamagna <[hidden email]>
>>> Cc: Chris Chiu <[hidden email]>
>>> Cc: Daniel Drake <[hidden email]>
>>> Cc: Andy Shevchenko <[hidden email]>
>>> Signed-off-by: Joseph Salisbury <[hidden email]>
>>> ---
>>>  drivers/platform/x86/acer-wmi.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
>>> index 1be71f9..8952173 100644
>>> --- a/drivers/platform/x86/acer-wmi.c
>>> +++ b/drivers/platform/x86/acer-wmi.c
>>> @@ -129,6 +129,7 @@ static const struct key_entry acer_wmi_keymap[] __initconst = {
>>>   {KE_IGNORE, 0x83, {KEY_TOUCHPAD_TOGGLE} },
>>>   {KE_KEY, 0x85, {KEY_TOUCHPAD_TOGGLE} },
>>>   {KE_KEY, 0x86, {KEY_WLAN} },
>>> + {KE_KEY, 0x87, {KEY_POWER} },
>>>   {KE_END, 0}
>>>  };
>>>  
>>>
>> Limited to specific x86 platform, regression potential low. Can this be
>> upstreamed at some point?
>>
>> Acked-by: Colin Ian King <[hidden email]>
>
> It is in the process of being upstream by the patch Author.
>
That's good to know, thanks!



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][Artful][Bionic][PATCH 1/1] UBUNTU: SAUCE: platform/x86: acer-wmi: add another KEY_POWER keycode

Kleber Souza
In reply to this post by Joseph Salisbury-3
On 04/27/18 20:02, Joseph Salisbury wrote:

> From: Antonio Rosario Intilisano <[hidden email]>
>
> BugLink: http://bugs.launchpad.net/bugs/1766054
>
> Now that we have informed the firmware that the Power Button driver is
> active, laptops such as the Acer Swift 3 will generate a WMI key event with
> code 0x87 when the power button key is pressed.  Add this keycode to the
> table so that it is converted to an appropriate input event.  
>
> Signed-off-by: Antonio Rosario Intilisano <[hidden email]>
> Acked-by: Gianfranco Costamagna <[hidden email]>
> Cc: Chris Chiu <[hidden email]>
> Cc: Daniel Drake <[hidden email]>
> Cc: Andy Shevchenko <[hidden email]>
> Signed-off-by: Joseph Salisbury <[hidden email]>

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

> ---
>  drivers/platform/x86/acer-wmi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 1be71f9..8952173 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -129,6 +129,7 @@ static const struct key_entry acer_wmi_keymap[] __initconst = {
>   {KE_IGNORE, 0x83, {KEY_TOUCHPAD_TOGGLE} },
>   {KE_KEY, 0x85, {KEY_TOUCHPAD_TOGGLE} },
>   {KE_KEY, 0x86, {KEY_WLAN} },
> + {KE_KEY, 0x87, {KEY_POWER} },
>   {KE_END, 0}
>  };
>  
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU][Artful][Bionic][PATCH 0/1] UBUNTU: SAUCE: platform/x86: acer-wmi: add another KEY_POWER keycode

Kleber Souza
In reply to this post by Joseph Salisbury-3
On 04/27/18 20:02, Joseph Salisbury wrote:

> BugLink: http://bugs.launchpad.net/bugs/1766054
>
> == SRU Justification ==
> It's impossible to use power button functionalities in Acer Swift Notebook
> Series (tested on Acer Swift 3 sf314-52).  The keyboard button is not
> managed at acer-wmi level:
>
> [405.267887] acer_wmi: Unknown key number - 0x87]
>
> This patch adds the KEY_POWER event in acer-wmi.  The patch will also be sent
> upstream, but it is being requested in Ubuntu to not wait for it to come back
> downstream.  This patch is also needed in Xenial, but Xenial requres a minor backport.
>
> == Fix ==
> UBUNTU: SAUCE: platform/x86: acer-wmi: add another KEY_POWER keycode
>
> == Regression Potential ==
> Low.  This is a oneliner that addes a new keymap.
>
> == Test Case ==
> A test kernel was built with this patch and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
>
> Antonio Rosario Intilisano (1):
>   UBUNTU: SAUCE: platform/x86: acer-wmi: add another KEY_POWER keycode
>
>  drivers/platform/x86/acer-wmi.c | 1 +
>  1 file changed, 1 insertion(+)
>

Applied to artful/master-next and bionic/master-next branches.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[unstable]: [SRU][Artful][Bionic][PATCH 1/1] UBUNTU: SAUCE: platform/x86: acer-wmi: add another KEY_POWER keycode

Seth Forshee
In reply to this post by Joseph Salisbury-3
On Fri, Apr 27, 2018 at 02:02:37PM -0400, Joseph Salisbury wrote:

> From: Antonio Rosario Intilisano <[hidden email]>
>
> BugLink: http://bugs.launchpad.net/bugs/1766054
>
> Now that we have informed the firmware that the Power Button driver is
> active, laptops such as the Acer Swift 3 will generate a WMI key event with
> code 0x87 when the power button key is pressed.  Add this keycode to the
> table so that it is converted to an appropriate input event.  
>
> Signed-off-by: Antonio Rosario Intilisano <[hidden email]>
> Acked-by: Gianfranco Costamagna <[hidden email]>
> Cc: Chris Chiu <[hidden email]>
> Cc: Daniel Drake <[hidden email]>
> Cc: Andy Shevchenko <[hidden email]>
> Signed-off-by: Joseph Salisbury <[hidden email]>

Applied to unstable/master, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team