[SRU][Artful][Bionic][linux-oem][PATCH] Fix a wrong FIXUP for alc289 on Dell machines

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][Artful][Bionic][linux-oem][PATCH] Fix a wrong FIXUP for alc289 on Dell machines

Hui Wang
BugLink: https://launchpad.net/bugs/1748807

This patch is based on the two patches of
https://lists.ubuntu.com/archives/kernel-team/2018-February/090186.html, the two
patches are not sufficient to fix headset-mic problem on the machine with the
codec alc289, with those two patches, the driver can detect that the headset-mic
is plugged, but can't record sound with headset-mic.

Thanks to Kailang@realtek, he pointed out that FIXUP for alc289 is wrong, so
we need to apply this new patch to fix the problem.

[Test Case]
plug the headset and record the sound on the machine with the codec alc289

[Fix]
one commit from alsa repository, and this commit will be merged to upstream soon.

[Regression Potential]
very low, since this patch only change the FIXUP for the Dell machines with
alc289, and we already verified both plug detection and recording sound work
well with the new patch.

Hui Wang (1):
  ALSA: hda - Fix a wrong FIXUP for alc289 on Dell machines

 sound/pci/hda/patch_realtek.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.7.4

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][Artful][Bionic][linux-oem][PATCH] ALSA: hda - Fix a wrong FIXUP for alc289 on Dell machines

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1748807

With the alc289, the Pin 0x1b is Headphone-Mic, so we should assign
ALC269_FIXUP_DELL4_MIC_NO_PRESENCE rather than
ALC225_FIXUP_DELL1_MIC_NO_PRESENCE to it. And this change is suggested
by Kailang of Realtek and is verified on the machine.

Fixes: 3f2f7c553d07 ("ALSA: hda - Fix headset mic detection problem for two Dell machines")
Cc: Kailang Yang <[hidden email]>
Cc: <[hidden email]>
Signed-off-by: Hui Wang <[hidden email]>
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit d5078193e56bb24f4593f00102a3b5e07bb84ee0
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 37778fa..a8e1b1e 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6764,7 +6764,7 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
  {0x12, 0x90a60120},
  {0x14, 0x90170110},
  {0x21, 0x0321101f}),
- SND_HDA_PIN_QUIRK(0x10ec0289, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
+ SND_HDA_PIN_QUIRK(0x10ec0289, 0x1028, "Dell", ALC269_FIXUP_DELL4_MIC_NO_PRESENCE,
  {0x12, 0xb7a60130},
  {0x14, 0x90170110},
  {0x21, 0x04211020}),
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][Artful][Bionic][linux-oem][PATCH] Fix a wrong FIXUP for alc289 on Dell machines

Colin King
In reply to this post by Hui Wang
On 03/03/18 13:45, Hui Wang wrote:

> BugLink: https://launchpad.net/bugs/1748807
>
> This patch is based on the two patches of
> https://lists.ubuntu.com/archives/kernel-team/2018-February/090186.html, the two
> patches are not sufficient to fix headset-mic problem on the machine with the
> codec alc289, with those two patches, the driver can detect that the headset-mic
> is plugged, but can't record sound with headset-mic.
>
> Thanks to Kailang@realtek, he pointed out that FIXUP for alc289 is wrong, so
> we need to apply this new patch to fix the problem.
>
> [Test Case]
> plug the headset and record the sound on the machine with the codec alc289
>
> [Fix]
> one commit from alsa repository, and this commit will be merged to upstream soon.
>
> [Regression Potential]
> very low, since this patch only change the FIXUP for the Dell machines with
> alc289, and we already verified both plug detection and recording sound work
> well with the new patch.
>
> Hui Wang (1):
>   ALSA: hda - Fix a wrong FIXUP for alc289 on Dell machines
>
>  sound/pci/hda/patch_realtek.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Has positive test results, limited to specific hardware so regression
potential is very limited.

Acked-by: Colin Ian King <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [SRU][Artful][Bionic][linux-oem][PATCH] ALSA: hda - Fix a wrong FIXUP for alc289 on Dell machines

Aaron Ma
In reply to this post by Hui Wang
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][Artful][Bionic][linux-oem][PATCH] ALSA: hda - Fix a wrong FIXUP for alc289 on Dell machines

Aaron Ma
In reply to this post by Hui Wang
Reply | Threaded
Open this post in threaded view
|

APPLIED[B]: [SRU][Artful][Bionic][linux-oem][PATCH] Fix a wrong FIXUP for alc289 on Dell machines

Seth Forshee
In reply to this post by Hui Wang
On Sat, Mar 03, 2018 at 09:45:22PM +0800, Hui Wang wrote:

> BugLink: https://launchpad.net/bugs/1748807
>
> This patch is based on the two patches of
> https://lists.ubuntu.com/archives/kernel-team/2018-February/090186.html, the two
> patches are not sufficient to fix headset-mic problem on the machine with the
> codec alc289, with those two patches, the driver can detect that the headset-mic
> is plugged, but can't record sound with headset-mic.
>
> Thanks to Kailang@realtek, he pointed out that FIXUP for alc289 is wrong, so
> we need to apply this new patch to fix the problem.
>
> [Test Case]
> plug the headset and record the sound on the machine with the codec alc289
>
> [Fix]
> one commit from alsa repository, and this commit will be merged to upstream soon.
>
> [Regression Potential]
> very low, since this patch only change the FIXUP for the Dell machines with
> alc289, and we already verified both plug detection and recording sound work
> well with the new patch.

Applied to bionic/master-next, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[Artful/backlog]: [SRU][Artful][Bionic][linux-oem][PATCH] Fix a wrong FIXUP for alc289 on Dell machines

Kleber Souza
In reply to this post by Hui Wang
On 03/03/18 14:45, Hui Wang wrote:

> BugLink: https://launchpad.net/bugs/1748807
>
> This patch is based on the two patches of
> https://lists.ubuntu.com/archives/kernel-team/2018-February/090186.html, the two
> patches are not sufficient to fix headset-mic problem on the machine with the
> codec alc289, with those two patches, the driver can detect that the headset-mic
> is plugged, but can't record sound with headset-mic.
>
> Thanks to Kailang@realtek, he pointed out that FIXUP for alc289 is wrong, so
> we need to apply this new patch to fix the problem.
>
> [Test Case]
> plug the headset and record the sound on the machine with the codec alc289
>
> [Fix]
> one commit from alsa repository, and this commit will be merged to upstream soon.
>
> [Regression Potential]
> very low, since this patch only change the FIXUP for the Dell machines with
> alc289, and we already verified both plug detection and recording sound work
> well with the new patch.
>
> Hui Wang (1):
>   ALSA: hda - Fix a wrong FIXUP for alc289 on Dell machines
>
>  sound/pci/hda/patch_realtek.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Applied to artful/master-next-backlog branch.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team