[SRU][Artful][Bionic][linux-oem][PATCH v2 0/2] fix headset-mic detection problem for two Dell machines

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][Artful][Bionic][linux-oem][PATCH v2 0/2] fix headset-mic detection problem for two Dell machines

Hui Wang
BugLink: https://launchpad.net/bugs/1748807

In the v2, adding the alsa repository in the commit header for 0002-xxx.patch.

We have two Dell machines which can't detect the headset microphone, as a result
can't record sound via headset mic.

One machchine has codec alc256, and there is already a quirk for this codec in the
driver, we just add its pin definition to pin quirk table (0002-xxx.patch).

The other machine has the codec alc289, we need the 0001-xxx.patch to let driver
support headset mode for alc289 first, then we add its pin definition to pin quirk
table (0002-xxx.patch)

[Test Case]
plug the headset and record the sound

[Fix]
two upstream commits

[Regression Potential]
low, since the 0001-xxx.patch just adds vendor id to existing driver to let
them support headset mode, it doesn't change existing functions, the 0002-xxx.patch
adds a group of pin definition, it doesn't change existing funcitons too.

Hui Wang (1):
  ALSA: hda - Fix headset mic detection problem for two Dell machines

Kailang Yang (1):
  ALSA: hda/realtek - Support headset mode for ALC215/ALC285/ALC289

 sound/pci/hda/patch_realtek.c | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][Artful][Bionic][linux-oem][PATCH v2 1/2] ALSA: hda/realtek - Support headset mode for ALC215/ALC285/ALC289

Hui Wang
From: Kailang Yang <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1748807

This patch will enable headset mode for ALC215/ALC285/ALC289 platform.

Signed-off-by: Kailang Yang <[hidden email]>
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit c2b691ee35004ba3d5428cf48672cbbf1a50fbfb)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 3b07373..624d717 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -3963,8 +3963,11 @@ static void alc_headset_mode_unplugged(struct hda_codec *codec)
  case 0x10ec0668:
  alc_process_coef_fw(codec, coef0668);
  break;
+ case 0x10ec0215:
  case 0x10ec0225:
+ case 0x10ec0285:
  case 0x10ec0295:
+ case 0x10ec0289:
  case 0x10ec0299:
  alc_process_coef_fw(codec, coef0225);
  break;
@@ -4086,8 +4089,11 @@ static void alc_headset_mode_mic_in(struct hda_codec *codec, hda_nid_t hp_pin,
  alc_process_coef_fw(codec, coef0688);
  snd_hda_set_pin_ctl_cache(codec, mic_pin, PIN_VREF50);
  break;
+ case 0x10ec0215:
  case 0x10ec0225:
+ case 0x10ec0285:
  case 0x10ec0295:
+ case 0x10ec0289:
  case 0x10ec0299:
  alc_process_coef_fw(codec, alc225_pre_hsmode);
  alc_update_coef_idx(codec, 0x45, 0x3f<<10, 0x31<<10);
@@ -4158,8 +4164,11 @@ static void alc_headset_mode_default(struct hda_codec *codec)
  };
 
  switch (codec->core.vendor_id) {
+ case 0x10ec0215:
  case 0x10ec0225:
+ case 0x10ec0285:
  case 0x10ec0295:
+ case 0x10ec0289:
  case 0x10ec0299:
  alc_process_coef_fw(codec, alc225_pre_hsmode);
  alc_process_coef_fw(codec, coef0225);
@@ -4301,8 +4310,11 @@ static void alc_headset_mode_ctia(struct hda_codec *codec)
  case 0x10ec0668:
  alc_process_coef_fw(codec, coef0688);
  break;
+ case 0x10ec0215:
  case 0x10ec0225:
+ case 0x10ec0285:
  case 0x10ec0295:
+ case 0x10ec0289:
  case 0x10ec0299:
  val = alc_read_coef_idx(codec, 0x45);
  if (val & (1 << 9))
@@ -4405,8 +4417,11 @@ static void alc_headset_mode_omtp(struct hda_codec *codec)
  case 0x10ec0668:
  alc_process_coef_fw(codec, coef0688);
  break;
+ case 0x10ec0215:
  case 0x10ec0225:
+ case 0x10ec0285:
  case 0x10ec0295:
+ case 0x10ec0289:
  case 0x10ec0299:
  alc_process_coef_fw(codec, coef0225);
  break;
@@ -4535,8 +4550,11 @@ static void alc_determine_headset_type(struct hda_codec *codec)
  val = alc_read_coef_idx(codec, 0xbe);
  is_ctia = (val & 0x1c02) == 0x1c02;
  break;
+ case 0x10ec0215:
  case 0x10ec0225:
+ case 0x10ec0285:
  case 0x10ec0295:
+ case 0x10ec0289:
  case 0x10ec0299:
  alc_process_coef_fw(codec, alc225_pre_hsmode);
  alc_update_coef_idx(codec, 0x67, 0xf000, 0x1000);
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][Artful][Bionic][linux-oem][PATCH v2 2/2] ALSA: hda - Fix headset mic detection problem for two Dell machines

Hui Wang
In reply to this post by Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1748807

One of them has the codec of alc256 and the other one has the codec
of alc289.

Cc: <[hidden email]>
Signed-off-by: Hui Wang <[hidden email]>
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit 3f2f7c553d077be6a30cb96b2976a2c940bf5335
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)

Signed-off-by: Hui Wang <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 624d717..2eac412 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6549,6 +6549,11 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
  {0x14, 0x90170110},
  {0x21, 0x02211020}),
  SND_HDA_PIN_QUIRK(0x10ec0256, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
+ {0x12, 0x90a60130},
+ {0x14, 0x90170110},
+ {0x14, 0x01011020},
+ {0x21, 0x0221101f}),
+ SND_HDA_PIN_QUIRK(0x10ec0256, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
  ALC256_STANDARD_PINS),
  SND_HDA_PIN_QUIRK(0x10ec0256, 0x1043, "ASUS", ALC256_FIXUP_ASUS_MIC,
  {0x14, 0x90170110},
@@ -6617,6 +6622,10 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
  {0x12, 0x90a60120},
  {0x14, 0x90170110},
  {0x21, 0x0321101f}),
+ SND_HDA_PIN_QUIRK(0x10ec0289, 0x1028, "Dell", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE,
+ {0x12, 0xb7a60130},
+ {0x14, 0x90170110},
+ {0x21, 0x04211020}),
  SND_HDA_PIN_QUIRK(0x10ec0290, 0x103c, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC1,
  ALC290_STANDARD_PINS,
  {0x15, 0x04211040},
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/cmt / APPLIED[B]: [SRU][Artful][Bionic][linux-oem][PATCH v2 0/2] fix headset-mic detection problem for two Dell machines

Seth Forshee
In reply to this post by Hui Wang
On Tue, Feb 13, 2018 at 09:28:52AM +0800, Hui Wang wrote:

> BugLink: https://launchpad.net/bugs/1748807
>
> In the v2, adding the alsa repository in the commit header for 0002-xxx.patch.
>
> We have two Dell machines which can't detect the headset microphone, as a result
> can't record sound via headset mic.
>
> One machchine has codec alc256, and there is already a quirk for this codec in the
> driver, we just add its pin definition to pin quirk table (0002-xxx.patch).
>
> The other machine has the codec alc289, we need the 0001-xxx.patch to let driver
> support headset mode for alc289 first, then we add its pin definition to pin quirk
> table (0002-xxx.patch)
>
> [Test Case]
> plug the headset and record the sound
>
> [Fix]
> two upstream commits
>
> [Regression Potential]
> low, since the 0001-xxx.patch just adds vendor id to existing driver to let
> them support headset mode, it doesn't change existing functions, the 0002-xxx.patch
> adds a group of pin definition, it doesn't change existing funcitons too.

You need to add SRU justification to the bug, aside from that:

Acked-by: Seth Forshee <[hidden email]>

Applied to bionic/master-next, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/cmnt: [SRU][Artful][Bionic][linux-oem][PATCH v2 0/2] fix headset-mic detection problem for two Dell machines

Stefan Bader-2
In reply to this post by Hui Wang
On 13.02.2018 02:28, Hui Wang wrote:

> BugLink: https://launchpad.net/bugs/1748807
>
> In the v2, adding the alsa repository in the commit header for 0002-xxx.patch.
>
> We have two Dell machines which can't detect the headset microphone, as a result
> can't record sound via headset mic.
>
> One machchine has codec alc256, and there is already a quirk for this codec in the
> driver, we just add its pin definition to pin quirk table (0002-xxx.patch).
>
> The other machine has the codec alc289, we need the 0001-xxx.patch to let driver
> support headset mode for alc289 first, then we add its pin definition to pin quirk
> table (0002-xxx.patch)
>
> [Test Case]
> plug the headset and record the sound
>
> [Fix]
> two upstream commits
>
> [Regression Potential]
> low, since the 0001-xxx.patch just adds vendor id to existing driver to let
> them support headset mode, it doesn't change existing functions, the 0002-xxx.patch
> adds a group of pin definition, it doesn't change existing funcitons too.
>
> Hui Wang (1):
>   ALSA: hda - Fix headset mic detection problem for two Dell machines
>
> Kailang Yang (1):
>   ALSA: hda/realtek - Support headset mode for ALC215/ALC285/ALC289
>
>  sound/pci/hda/patch_realtek.c | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
Acked-by: Stefan Bader <[hidden email]>

Still misses the SRU info in the bug description!


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED[Artful/backlog]: [SRU][Artful][Bionic][linux-oem][PATCH v2 0/2] fix headset-mic detection problem for two Dell machines

Kleber Sacilotto de Souza
In reply to this post by Hui Wang
On 02/13/18 02:28, Hui Wang wrote:

> BugLink: https://launchpad.net/bugs/1748807
>
> In the v2, adding the alsa repository in the commit header for 0002-xxx.patch.
>
> We have two Dell machines which can't detect the headset microphone, as a result
> can't record sound via headset mic.
>
> One machchine has codec alc256, and there is already a quirk for this codec in the
> driver, we just add its pin definition to pin quirk table (0002-xxx.patch).
>
> The other machine has the codec alc289, we need the 0001-xxx.patch to let driver
> support headset mode for alc289 first, then we add its pin definition to pin quirk
> table (0002-xxx.patch)
>
> [Test Case]
> plug the headset and record the sound
>
> [Fix]
> two upstream commits
>
> [Regression Potential]
> low, since the 0001-xxx.patch just adds vendor id to existing driver to let
> them support headset mode, it doesn't change existing functions, the 0002-xxx.patch
> adds a group of pin definition, it doesn't change existing funcitons too.
>
> Hui Wang (1):
>   ALSA: hda - Fix headset mic detection problem for two Dell machines
>
> Kailang Yang (1):
>   ALSA: hda/realtek - Support headset mode for ALC215/ALC285/ALC289
>
>  sound/pci/hda/patch_realtek.c | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>

Applied to artful/master-next-backlog branch.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team