[SRU] [Artful] [PATCH 0/1] Fix sky2 ethernet stops working after system resume

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU] [Artful] [PATCH 0/1] Fix sky2 ethernet stops working after system resume

Kai Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1758507

[Impact]
sky2 ethernet stops working after system resume from suspend.

[Fix]
Increase the PCI D3 delay can workaround the issue.

[Test]
User responded that the D3 delay increase can solve the issue.

[Regression Potential]
Low. It only affects one device. The fix only increase the delay timer,
without any functional change.

Kai-Heng Feng (1):
  sky2: Increase D3 delay to sky2 stops working after suspend

 drivers/net/ethernet/marvell/sky2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.17.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU] [Artful] [PATCH 1/1] sky2: Increase D3 delay to sky2 stops working after suspend

Kai Heng Feng
The sky2 ethernet stops working after system resume from suspend:
[ 582.852065] sky2 0000:04:00.0: Refused to change power state, currently in D3

The current 150ms delay is not enough, change it to 200ms can solve the
issue.

BugLink: https://bugs.launchpad.net/bugs/1758507
Cc: Stable <[hidden email]>
Signed-off-by: Kai-Heng Feng <[hidden email]>
Signed-off-by: David S. Miller <[hidden email]>
(cherry picked from commit afb133637071be6deeb8b3d0e55593ffbf63c527)
Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/net/ethernet/marvell/sky2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
index 1145cde2274a..b12e3a4f9439 100644
--- a/drivers/net/ethernet/marvell/sky2.c
+++ b/drivers/net/ethernet/marvell/sky2.c
@@ -5087,7 +5087,7 @@ static int sky2_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
  INIT_WORK(&hw->restart_work, sky2_restart);
 
  pci_set_drvdata(pdev, hw);
- pdev->d3_delay = 150;
+ pdev->d3_delay = 200;
 
  return 0;
 
--
2.17.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU] [Artful] [PATCH 1/1] sky2: Increase D3 delay to sky2 stops working after suspend

Kleber Sacilotto de Souza
On 04/12/18 08:28, Kai-Heng Feng wrote:

> The sky2 ethernet stops working after system resume from suspend:
> [ 582.852065] sky2 0000:04:00.0: Refused to change power state, currently in D3
>
> The current 150ms delay is not enough, change it to 200ms can solve the
> issue.
>
> BugLink: https://bugs.launchpad.net/bugs/1758507
> Cc: Stable <[hidden email]>
> Signed-off-by: Kai-Heng Feng <[hidden email]>
> Signed-off-by: David S. Miller <[hidden email]>
> (cherry picked from commit afb133637071be6deeb8b3d0e55593ffbf63c527)
> Signed-off-by: Kai-Heng Feng <[hidden email]>

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

> ---
>  drivers/net/ethernet/marvell/sky2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
> index 1145cde2274a..b12e3a4f9439 100644
> --- a/drivers/net/ethernet/marvell/sky2.c
> +++ b/drivers/net/ethernet/marvell/sky2.c
> @@ -5087,7 +5087,7 @@ static int sky2_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   INIT_WORK(&hw->restart_work, sky2_restart);
>  
>   pci_set_drvdata(pdev, hw);
> - pdev->d3_delay = 150;
> + pdev->d3_delay = 200;
>  
>   return 0;
>  
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/cmnt: [SRU] [Artful] [PATCH 1/1] sky2: Increase D3 delay to sky2 stops working after suspend

Stefan Bader-2
In reply to this post by Kai Heng Feng
On 12.04.2018 08:28, Kai-Heng Feng wrote:

> The sky2 ethernet stops working after system resume from suspend:
> [ 582.852065] sky2 0000:04:00.0: Refused to change power state, currently in D3
>
> The current 150ms delay is not enough, change it to 200ms can solve the
> issue.
>
> BugLink: https://bugs.launchpad.net/bugs/1758507
> Cc: Stable <[hidden email]>
> Signed-off-by: Kai-Heng Feng <[hidden email]>
> Signed-off-by: David S. Miller <[hidden email]>
> (cherry picked from commit afb133637071be6deeb8b3d0e55593ffbf63c527)
> Signed-off-by: Kai-Heng Feng <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>

> ---

Just to be sure because there was no Artful task/nomination, this really is
meant to go into Artful?

-Stefan

>  drivers/net/ethernet/marvell/sky2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
> index 1145cde2274a..b12e3a4f9439 100644
> --- a/drivers/net/ethernet/marvell/sky2.c
> +++ b/drivers/net/ethernet/marvell/sky2.c
> @@ -5087,7 +5087,7 @@ static int sky2_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   INIT_WORK(&hw->restart_work, sky2_restart);
>  
>   pci_set_drvdata(pdev, hw);
> - pdev->d3_delay = 150;
> + pdev->d3_delay = 200;
>  
>   return 0;
>  
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: ACK/cmnt: [SRU] [Artful] [PATCH 1/1] sky2: Increase D3 delay to sky2 stops working after suspend

Kai Heng Feng

> On Apr 20, 2018, at 4:16 PM, Stefan Bader <[hidden email]>  
> wrote:
>
> On 12.04.2018 08:28, Kai-Heng Feng wrote:
>> The sky2 ethernet stops working after system resume from suspend:
>> [ 582.852065] sky2 0000:04:00.0: Refused to change power state,  
>> currently in D3
>>
>> The current 150ms delay is not enough, change it to 200ms can solve the
>> issue.
>>
>> BugLink: https://bugs.launchpad.net/bugs/1758507
>> Cc: Stable <[hidden email]>
>> Signed-off-by: Kai-Heng Feng <[hidden email]>
>> Signed-off-by: David S. Miller <[hidden email]>
>> (cherry picked from commit afb133637071be6deeb8b3d0e55593ffbf63c527)
>> Signed-off-by: Kai-Heng Feng <[hidden email]>
> Acked-by: Stefan Bader <[hidden email]>
>
>> ---
>
> Just to be sure because there was no Artful task/nomination, this really is
> meant to go into Artful?

Yes. Let me do the nomination now...

Kai-Heng

>
> -Stefan
>
>> drivers/net/ethernet/marvell/sky2.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/marvell/sky2.c  
>> b/drivers/net/ethernet/marvell/sky2.c
>> index 1145cde2274a..b12e3a4f9439 100644
>> --- a/drivers/net/ethernet/marvell/sky2.c
>> +++ b/drivers/net/ethernet/marvell/sky2.c
>> @@ -5087,7 +5087,7 @@ static int sky2_probe(struct pci_dev *pdev, const  
>> struct pci_device_id *ent)
>>   INIT_WORK(&hw->restart_work, sky2_restart);
>>
>>   pci_set_drvdata(pdev, hw);
>> - pdev->d3_delay = 150;
>> + pdev->d3_delay = 200;
>>
>>   return 0;

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[A]: [SRU] [Artful] [PATCH 1/1] sky2: Increase D3 delay to sky2 stops working after suspend

Stefan Bader-2
In reply to this post by Kai Heng Feng
On 12.04.2018 08:28, Kai-Heng Feng wrote:

> The sky2 ethernet stops working after system resume from suspend:
> [ 582.852065] sky2 0000:04:00.0: Refused to change power state, currently in D3
>
> The current 150ms delay is not enough, change it to 200ms can solve the
> issue.
>
> BugLink: https://bugs.launchpad.net/bugs/1758507
> Cc: Stable <[hidden email]>
> Signed-off-by: Kai-Heng Feng <[hidden email]>
> Signed-off-by: David S. Miller <[hidden email]>
> (cherry picked from commit afb133637071be6deeb8b3d0e55593ffbf63c527)
> Signed-off-by: Kai-Heng Feng <[hidden email]>
> ---
Applied to artful/master-next

>  drivers/net/ethernet/marvell/sky2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/sky2.c b/drivers/net/ethernet/marvell/sky2.c
> index 1145cde2274a..b12e3a4f9439 100644
> --- a/drivers/net/ethernet/marvell/sky2.c
> +++ b/drivers/net/ethernet/marvell/sky2.c
> @@ -5087,7 +5087,7 @@ static int sky2_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   INIT_WORK(&hw->restart_work, sky2_restart);
>  
>   pci_set_drvdata(pdev, hw);
> - pdev->d3_delay = 150;
> + pdev->d3_delay = 200;
>  
>   return 0;
>  
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment