[SRU] [B/C/D/Unstable] [PATCH 0/1] Support new Realtek ethernet chips

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU] [B/C/D/Unstable] [PATCH 0/1] Support new Realtek ethernet chips

Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1811055

[Impact]
New Realtek ethernet chips don't work.

[Fix]
Add new IDs to r8169.ko.

[Test]
The r8169 is loaded for the Realtek ethernet chip.
It works, and I haven't seen any issues so far.

[Regression Potential]
Low. New IDs to existing driver, no functional change.

Kai-Heng Feng (1):
  r8169: Add support for new Realtek Ethernet

 drivers/net/ethernet/realtek/r8169.c | 2 ++
 1 file changed, 2 insertions(+)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/1] r8169: Add support for new Realtek Ethernet

Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1811055

There are two new Realtek Ethernet devices which are re-branded r8168h.
Add the IDs to to support them.

Signed-off-by: Kai-Heng Feng <[hidden email]>
Reviewed-by: Heiner Kallweit <[hidden email]>
Signed-off-by: David S. Miller <[hidden email]>
(backported from commit 36352991835ce99e46b4441dd0eb6980f9a83e8f)
Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/net/ethernet/realtek/r8169.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 64826f4f23bc..a264f90a750c 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -324,6 +324,8 @@ enum cfg_version {
 };
 
 static const struct pci_device_id rtl8169_pci_tbl[] = {
+ { PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x2502), 0, 0, RTL_CFG_1 },
+ { PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x2600), 0, 0, RTL_CFG_1 },
  { PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8129), 0, 0, RTL_CFG_0 },
  { PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8136), 0, 0, RTL_CFG_2 },
  { PCI_DEVICE(PCI_VENDOR_ID_REALTEK, 0x8161), 0, 0, RTL_CFG_1 },
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU] [B/C/D/Unstable] [PATCH 0/1] Support new Realtek ethernet chips

AceLan Kao
In reply to this post by Kai-Heng Feng
Acked-By: AceLan Kao <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/cmnt: [PATCH 1/1] r8169: Add support for new Realtek Ethernet

Po-Hsu Lin (Sam)
In reply to this post by Kai-Heng Feng
On Wed, Jan 9, 2019 at 2:18 PM Kai-Heng Feng <[hidden email]> wrote:

>
> BugLink: https://bugs.launchpad.net/bugs/1811055
>
> There are two new Realtek Ethernet devices which are re-branded r8168h.
> Add the IDs to to support them.
>
> Signed-off-by: Kai-Heng Feng <[hidden email]>
> Reviewed-by: Heiner Kallweit <[hidden email]>
> Signed-off-by: David S. Miller <[hidden email]>
> (backported from commit 36352991835ce99e46b4441dd0eb6980f9a83e8f)
(backported from commit 36352991835ce99e46b4441dd0eb6980f9a83e8f linux-next)
Looks like this patch came from linux-next[1], ack with the commit message fixed as above

Acked-by: Po-Hsu Lin <[hidden email]>

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=36352991835ce99e46b4441dd0eb6980f9a83e8f

> Signed-off-by: Kai-Heng Feng <[hidden email]>
> ---
>  drivers/net/ethernet/realtek/r8169.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 64826f4f23bc..a264f90a750c 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -324,6 +324,8 @@ enum cfg_version {
>  };
>
>  static const struct pci_device_id rtl8169_pci_tbl[] = {
> +       { PCI_DEVICE(PCI_VENDOR_ID_REALTEK,     0x2502), 0, 0, RTL_CFG_1 },
> +       { PCI_DEVICE(PCI_VENDOR_ID_REALTEK,     0x2600), 0, 0, RTL_CFG_1 },
>         { PCI_DEVICE(PCI_VENDOR_ID_REALTEK,     0x8129), 0, 0, RTL_CFG_0 },
>         { PCI_DEVICE(PCI_VENDOR_ID_REALTEK,     0x8136), 0, 0, RTL_CFG_2 },
>         { PCI_DEVICE(PCI_VENDOR_ID_REALTEK,     0x8161), 0, 0, RTL_CFG_1 },
> --
> 2.17.1
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: ACK/cmnt: [PATCH 1/1] r8169: Add support for new Realtek Ethernet

Kai-Heng Feng


> On Jan 9, 2019, at 3:35 PM, Po-Hsu Lin <[hidden email]> wrote:
>
> On Wed, Jan 9, 2019 at 2:18 PM Kai-Heng Feng <[hidden email]> wrote:
>>
>> BugLink: https://bugs.launchpad.net/bugs/1811055
>>
>> There are two new Realtek Ethernet devices which are re-branded r8168h.
>> Add the IDs to to support them.
>>
>> Signed-off-by: Kai-Heng Feng <[hidden email]>
>> Reviewed-by: Heiner Kallweit <[hidden email]>
>> Signed-off-by: David S. Miller <[hidden email]>
>> (backported from commit 36352991835ce99e46b4441dd0eb6980f9a83e8f)
> (backported from commit 36352991835ce99e46b4441dd0eb6980f9a83e8f linux-next)

I missed that one, thanks for pointing out.

Kai-Heng

> Looks like this patch came from linux-next[1], ack with the commit message fixed as above
>
> Acked-by: Po-Hsu Lin <[hidden email]>
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=36352991835ce99e46b4441dd0eb6980f9a83e8f
>
>> Signed-off-by: Kai-Heng Feng <[hidden email]>
>> ---
>> drivers/net/ethernet/realtek/r8169.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
>> index 64826f4f23bc..a264f90a750c 100644
>> --- a/drivers/net/ethernet/realtek/r8169.c
>> +++ b/drivers/net/ethernet/realtek/r8169.c
>> @@ -324,6 +324,8 @@ enum cfg_version {
>> };
>>
>> static const struct pci_device_id rtl8169_pci_tbl[] = {
>> +       { PCI_DEVICE(PCI_VENDOR_ID_REALTEK,     0x2502), 0, 0, RTL_CFG_1 },
>> +       { PCI_DEVICE(PCI_VENDOR_ID_REALTEK,     0x2600), 0, 0, RTL_CFG_1 },
>>        { PCI_DEVICE(PCI_VENDOR_ID_REALTEK,     0x8129), 0, 0, RTL_CFG_0 },
>>        { PCI_DEVICE(PCI_VENDOR_ID_REALTEK,     0x8136), 0, 0, RTL_CFG_2 },
>>        { PCI_DEVICE(PCI_VENDOR_ID_REALTEK,     0x8161), 0, 0, RTL_CFG_1 },
>> --
>> 2.17.1
>>
>>
>> --
>> kernel-team mailing list
>> [hidden email]
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU] [B/C/D/Unstable] [PATCH 0/1] Support new Realtek ethernet chips

Khaled Elmously
In reply to this post by Kai-Heng Feng
On 2019-01-09 14:18:01 , Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1811055
>
> [Impact]
> New Realtek ethernet chips don't work.
>
> [Fix]
> Add new IDs to r8169.ko.
>
> [Test]
> The r8169 is loaded for the Realtek ethernet chip.
> It works, and I haven't seen any issues so far.
>
> [Regression Potential]
> Low. New IDs to existing driver, no functional change.
>
> Kai-Heng Feng (1):
>   r8169: Add support for new Realtek Ethernet
>
>  drivers/net/ethernet/realtek/r8169.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> --
> 2.17.1
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: APPLIED: [SRU] [B/C/D/Unstable] [PATCH 0/1] Support new Realtek ethernet chips

Stefan Bader-2
On 09.01.19 09:31, Khaled Elmously wrote:

> On 2019-01-09 14:18:01 , Kai-Heng Feng wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1811055
>>
>> [Impact]
>> New Realtek ethernet chips don't work.
>>
>> [Fix]
>> Add new IDs to r8169.ko.
>>
>> [Test]
>> The r8169 is loaded for the Realtek ethernet chip.
>> It works, and I haven't seen any issues so far.
>>
>> [Regression Potential]
>> Low. New IDs to existing driver, no functional change.
>>
>> Kai-Heng Feng (1):
>>   r8169: Add support for new Realtek Ethernet
>>
>>  drivers/net/ethernet/realtek/r8169.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> --
>> 2.17.1
>>
>>
>> --
>> kernel-team mailing list
>> [hidden email]
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
>
Fixed up nominations and I assume you only applied to B/C and not D.


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: APPLIED: [SRU] [B/C/D/Unstable] [PATCH 0/1] Support new Realtek ethernet chips

Khaled Elmously
On 2019-01-09 10:21:28 , Stefan Bader wrote:

> On 09.01.19 09:31, Khaled Elmously wrote:
> > On 2019-01-09 14:18:01 , Kai-Heng Feng wrote:
> >> BugLink: https://bugs.launchpad.net/bugs/1811055
> >>
> >> [Impact]
> >> New Realtek ethernet chips don't work.
> >>
> >> [Fix]
> >> Add new IDs to r8169.ko.
> >>
> >> [Test]
> >> The r8169 is loaded for the Realtek ethernet chip.
> >> It works, and I haven't seen any issues so far.
> >>
> >> [Regression Potential]
> >> Low. New IDs to existing driver, no functional change.
> >>
> >> Kai-Heng Feng (1):
> >>   r8169: Add support for new Realtek Ethernet
> >>
> >>  drivers/net/ethernet/realtek/r8169.c | 2 ++
> >>  1 file changed, 2 insertions(+)
> >>
> >> --
> >> 2.17.1
> >>
> >>
> >> --
> >> kernel-team mailing list
> >> [hidden email]
> >> https://lists.ubuntu.com/mailman/listinfo/kernel-team
> >
> Fixed up nominations and I assume you only applied to B/C and not D.
>

Actually, I applied this to D and unstable as well.

I thought I might as well since I'm applying it to the stable trees and it has 2 ACKs.
 



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team