[SRU][B/D/OEM-OSP1-B/E/unstable][PATCH 0/1] The alsa hda driver is not loaded due to the missing of PCIID for Comet-S [8086:a3f0]

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][B/D/OEM-OSP1-B/E/unstable][PATCH 0/1] The alsa hda driver is not loaded due to the missing of PCIID for Comet-S [8086:a3f0]

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1852070

[Impact]
Intel Comet-S platform has the sound controller with PCIID 0x8086:a3f0,
the ID is not in the alsa hda driver yet. When we run the linux on the
Comet-S platform, the alsa hda driver will not be loaded.

[Fix]
Adding the PCIID into the alsa hda driver.

[Test Case]
We already tested this driver on a Dell Comet-S machine with the codec
RT274, all audio devices worked well.

[Regression Risk]
Low, adding a new PCIID, will not introduce regression.



Chiou, Cooper (1):
  ALSA: hda: Add Cometlake-S PCI ID

 sound/pci/hda/hda_intel.c | 3 +++
 1 file changed, 3 insertions(+)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][B/D/OEM-OSP1-B/E/unstable][PATCH 1/1] UBUNTU: SAUCE: ALSA: hda: Add Cometlake-S PCI ID

Hui Wang
From: "Chiou, Cooper" <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1852070

Add HD Audio Device PCI ID for the Intel Cometlake-S platform

Signed-off-by: Chiou, Cooper <[hidden email]>
Link: https://lore.kernel.org/r/20191108071349.12840-1-cooper.chiou@...
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit b73a58549ea37a44434c7afab3c7ad9af210cfd9
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/pci/hda/hda_intel.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 783f9a9c40ec..8fca092d1edf 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2428,6 +2428,9 @@ static const struct pci_device_id azx_ids[] = {
  /* CometLake-H */
  { PCI_DEVICE(0x8086, 0x06C8),
   .driver_data = AZX_DRIVER_SKL | AZX_DCAPS_INTEL_SKYLAKE},
+ /* CometLake-S */
+ { PCI_DEVICE(0x8086, 0xa3f0),
+  .driver_data = AZX_DRIVER_SKL | AZX_DCAPS_INTEL_SKYLAKE},
  /* Icelake */
  { PCI_DEVICE(0x8086, 0x34c8),
   .driver_data = AZX_DRIVER_SKL | AZX_DCAPS_INTEL_SKYLAKE},
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK / APPLIED[Unstable]: [SRU][B/D/OEM-OSP1-B/E/unstable][PATCH 0/1] The alsa hda driver is not loaded due to the missing of PCIID for Comet-S [8086:a3f0]

Seth Forshee
In reply to this post by Hui Wang
On Mon, Nov 11, 2019 at 08:35:49PM +0800, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1852070
>
> [Impact]
> Intel Comet-S platform has the sound controller with PCIID 0x8086:a3f0,
> the ID is not in the alsa hda driver yet. When we run the linux on the
> Comet-S platform, the alsa hda driver will not be loaded.
>
> [Fix]
> Adding the PCIID into the alsa hda driver.
>
> [Test Case]
> We already tested this driver on a Dell Comet-S machine with the codec
> RT274, all audio devices worked well.
>
> [Regression Risk]
> Low, adding a new PCIID, will not introduce regression.

Seems like this should also go upstream.

Acked-by: Seth Forshee <[hidden email]>

Applied to unstable/master, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/Cmnt: [SRU][B/D/OEM-OSP1-B/E/unstable][PATCH 1/1] UBUNTU: SAUCE: ALSA: hda: Add Cometlake-S PCI ID

Stefan Bader-2
In reply to this post by Hui Wang
On 11.11.19 13:35, Hui Wang wrote:

> From: "Chiou, Cooper" <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1852070
>
> Add HD Audio Device PCI ID for the Intel Cometlake-S platform
>
> Signed-off-by: Chiou, Cooper <[hidden email]>
> Link: https://lore.kernel.org/r/20191108071349.12840-1-cooper.chiou@...
> Signed-off-by: Takashi Iwai <[hidden email]>
> (cherry picked from commit b73a58549ea37a44434c7afab3c7ad9af210cfd9
> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
> Signed-off-by: Hui Wang <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>
> ---

Fixed up the bug report to have the right tasks.

>  sound/pci/hda/hda_intel.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 783f9a9c40ec..8fca092d1edf 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -2428,6 +2428,9 @@ static const struct pci_device_id azx_ids[] = {
>   /* CometLake-H */
>   { PCI_DEVICE(0x8086, 0x06C8),
>    .driver_data = AZX_DRIVER_SKL | AZX_DCAPS_INTEL_SKYLAKE},
> + /* CometLake-S */
> + { PCI_DEVICE(0x8086, 0xa3f0),
> +  .driver_data = AZX_DRIVER_SKL | AZX_DCAPS_INTEL_SKYLAKE},
>   /* Icelake */
>   { PCI_DEVICE(0x8086, 0x34c8),
>    .driver_data = AZX_DRIVER_SKL | AZX_DCAPS_INTEL_SKYLAKE},
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][B/D/OEM-OSP1-B/E/unstable][PATCH 0/1] The alsa hda driver is not loaded due to the missing of PCIID for Comet-S [8086:a3f0]

You-Sheng Yang
In reply to this post by Hui Wang
Acked-By: You-Sheng Yang <[hidden email]>

On 2019-11-11 20:35, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1852070
>
> [Impact]
> Intel Comet-S platform has the sound controller with PCIID 0x8086:a3f0,
> the ID is not in the alsa hda driver yet. When we run the linux on the
> Comet-S platform, the alsa hda driver will not be loaded.
>
> [Fix]
> Adding the PCIID into the alsa hda driver.
>
> [Test Case]
> We already tested this driver on a Dell Comet-S machine with the codec
> RT274, all audio devices worked well.
>
> [Regression Risk]
> Low, adding a new PCIID, will not introduce regression.
>
>
>
> Chiou, Cooper (1):
>   ALSA: hda: Add Cometlake-S PCI ID
>
>  sound/pci/hda/hda_intel.c | 3 +++
>  1 file changed, 3 insertions(+)
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (499 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED[OSP1] Re: [SRU][B/D/OEM-OSP1-B/E/unstable][PATCH 0/1] The alsa hda driver is not loaded due to the missing of PCIID for Comet-S [8086:a3f0]

Timo Aaltonen-6
In reply to this post by Hui Wang
On 11.11.2019 14.35, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1852070
>
> [Impact]
> Intel Comet-S platform has the sound controller with PCIID 0x8086:a3f0,
> the ID is not in the alsa hda driver yet. When we run the linux on the
> Comet-S platform, the alsa hda driver will not be loaded.
>
> [Fix]
> Adding the PCIID into the alsa hda driver.
>
> [Test Case]
> We already tested this driver on a Dell Comet-S machine with the codec
> RT274, all audio devices worked well.
>
> [Regression Risk]
> Low, adding a new PCIID, will not introduce regression.
>
>
>
> Chiou, Cooper (1):
>   ALSA: hda: Add Cometlake-S PCI ID
>
>  sound/pci/hda/hda_intel.c | 3 +++
>  1 file changed, 3 insertions(+)
>

applied to osp1 oem-next, thanks

--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED/Cmnt: [SRU][B/D/E][PATCH 0/1] The alsa hda driver is not loaded due to the missing of PCIID for Comet-S [8086:a3f0]

Stefan Bader-2
In reply to this post by Hui Wang
On 11.11.19 13:35, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1852070
>
> [Impact]
> Intel Comet-S platform has the sound controller with PCIID 0x8086:a3f0,
> the ID is not in the alsa hda driver yet. When we run the linux on the
> Comet-S platform, the alsa hda driver will not be loaded.
>
> [Fix]
> Adding the PCIID into the alsa hda driver.
>
> [Test Case]
> We already tested this driver on a Dell Comet-S machine with the codec
> RT274, all audio devices worked well.
>
> [Regression Risk]
> Low, adding a new PCIID, will not introduce regression.
>
>
>
> Chiou, Cooper (1):
>   ALSA: hda: Add Cometlake-S PCI ID
>
>  sound/pci/hda/hda_intel.c | 3 +++
>  1 file changed, 3 insertions(+)
>
Applied to eoan,disco,bionic/master-next. This change was upstream by now with
SHA1 b73a58549ea37a44434c7afab3c7ad9af210cfd9. Adjusted the commit accordingly.
Thanks.

-Stefan


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment