[SRU][B/OEM-B/C/D][PATCH 0/1] The noise keeps occurring when Headset is plugged in on a Dell machine

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][B/OEM-B/C/D][PATCH 0/1] The noise keeps occurring when Headset is plugged in on a Dell machine

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1827972

[Impact]
On a Dell machine with the codec of alc274, when we plug the headset, the speaker
will output noise.

[Fix]
Realtek sent a fix to upstream, here we cherry-pick it.

[Test Case]
I have integrated this fix to the oem project image via dkms, and QA tested this
image, and verified this bug is fixed by this image.

[Regression Risk]
Low. This fix is specific to a couple of machines which applied the fixup
ALC274_FIXUP_DELL_BIND_DACS.



Kailang Yang (1):
  ALSA: hda/realtek - Fixed Dell AIO speaker noise

 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][B/OEM-B/C/D][PATCH 1/1] ALSA: hda/realtek - Fixed Dell AIO speaker noise

Hui Wang
From: Kailang Yang <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1827972

Fixed Dell AIO speaker noise.
spec->gen.auto_mute_via_amp = 1, this option was solved speaker white
noise at boot.
codec->power_save_node = 0, this option was solved speaker noise at
resume back.

Fixes: 9226665159f0 ("ALSA: hda/realtek - Fix Dell AIO LineOut issue")
Signed-off-by: Kailang Yang <[hidden email]>
Cc: <[hidden email]>
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit 0700d3d117a7f110ddddbd83873e13652f69c54b)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index e1285808c5a0..79a8b76106a9 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5409,6 +5409,8 @@ static void alc274_fixup_bind_dacs(struct hda_codec *codec,
  return;
 
  spec->gen.preferred_dacs = preferred_pairs;
+ spec->gen.auto_mute_via_amp = 1;
+ codec->power_save_node = 0;
 }
 
 /* The DAC of NID 0x3 will introduce click/pop noise on headphones, so invalidate it */
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][B/OEM-B/C/D][PATCH 1/1] ALSA: hda/realtek - Fixed Dell AIO speaker noise

Kleber Souza
On 5/7/19 5:58 AM, Hui Wang wrote:

> From: Kailang Yang <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1827972
>
> Fixed Dell AIO speaker noise.
> spec->gen.auto_mute_via_amp = 1, this option was solved speaker white
> noise at boot.
> codec->power_save_node = 0, this option was solved speaker noise at
> resume back.
>
> Fixes: 9226665159f0 ("ALSA: hda/realtek - Fix Dell AIO LineOut issue")
> Signed-off-by: Kailang Yang <[hidden email]>
> Cc: <[hidden email]>
> Signed-off-by: Takashi Iwai <[hidden email]>
> (cherry picked from commit 0700d3d117a7f110ddddbd83873e13652f69c54b)
> Signed-off-by: Hui Wang <[hidden email]>

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

> ---
>  sound/pci/hda/patch_realtek.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index e1285808c5a0..79a8b76106a9 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5409,6 +5409,8 @@ static void alc274_fixup_bind_dacs(struct hda_codec *codec,
>   return;
>  
>   spec->gen.preferred_dacs = preferred_pairs;
> + spec->gen.auto_mute_via_amp = 1;
> + codec->power_save_node = 0;
>  }
>  
>  /* The DAC of NID 0x3 will introduce click/pop noise on headphones, so invalidate it */
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][B/OEM-B/C/D][PATCH 1/1] ALSA: hda/realtek - Fixed Dell AIO speaker noise

Connor Kuehl
In reply to this post by Hui Wang
On 5/6/19 8:58 PM, Hui Wang wrote:

> From: Kailang Yang <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1827972
>
> Fixed Dell AIO speaker noise.
> spec->gen.auto_mute_via_amp = 1, this option was solved speaker white
> noise at boot.
> codec->power_save_node = 0, this option was solved speaker noise at
> resume back.
>
> Fixes: 9226665159f0 ("ALSA: hda/realtek - Fix Dell AIO LineOut issue")
> Signed-off-by: Kailang Yang <[hidden email]>
> Cc: <[hidden email]>
> Signed-off-by: Takashi Iwai <[hidden email]>
> (cherry picked from commit 0700d3d117a7f110ddddbd83873e13652f69c54b)
> Signed-off-by: Hui Wang <[hidden email]>
> ---
Acked-by: Connor Kuehl <[hidden email]>

>  sound/pci/hda/patch_realtek.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index e1285808c5a0..79a8b76106a9 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5409,6 +5409,8 @@ static void alc274_fixup_bind_dacs(struct hda_codec *codec,
>   return;
>  
>   spec->gen.preferred_dacs = preferred_pairs;
> + spec->gen.auto_mute_via_amp = 1;
> + codec->power_save_node = 0;
>  }
>  
>  /* The DAC of NID 0x3 will introduce click/pop noise on headphones, so invalidate it */
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

pEpkey.asc (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED(B,C,D): [SRU][B/OEM-B/C/D][PATCH 0/1] The noise keeps occurring when Headset is plugged in on a Dell machine

Khalid Elmously
In reply to this post by Hui Wang
On 2019-05-07 11:58:30 , Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1827972
>
> [Impact]
> On a Dell machine with the codec of alc274, when we plug the headset, the speaker
> will output noise.
>
> [Fix]
> Realtek sent a fix to upstream, here we cherry-pick it.
>
> [Test Case]
> I have integrated this fix to the oem project image via dkms, and QA tested this
> image, and verified this bug is fixed by this image.
>
> [Regression Risk]
> Low. This fix is specific to a couple of machines which applied the fixup
> ALC274_FIXUP_DELL_BIND_DACS.
>
>
>
> Kailang Yang (1):
>   ALSA: hda/realtek - Fixed Dell AIO speaker noise
>
>  sound/pci/hda/patch_realtek.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> --
> 2.17.1
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team