[SRU][B/OEM-B/D/E/unstable][PATCH 0/1] The microphone and mic of headset are uesless on a ThinkCentre

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][B/OEM-B/D/E/unstable][PATCH 0/1] The microphone and mic of headset are uesless on a ThinkCentre

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1842998

[Impact]
This machine user a new realtek codec and has two
front mics, the PA can't handle two front mics, then it
can't record sound via these two mics.

[Fix]
Apply an existing fixup to fix this issue.

[Test Case]
After applying the patch, plug an external mic or headset-mic
to the mic jack or headset jack, system can detect them and can
record the sound from it too.


[Regression Risk]
Low. just add an existing fixup to this new machine.


Hui Wang (1):
  UBUNTU: SAUCE: ALSA: hda/realtek - Fix the problem of two front mics
    on a ThinkCentre

 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][B/OEM-B/D/E/unstable][PATCH 1/1] UBUNTU: SAUCE: ALSA: hda/realtek - Fix the problem of two front mics on a ThinkCentre

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1842998

This ThinkCentre machine has a new realtek codec alc222, it is not
in the support list, we add it in the realtek.c then this machine
can apply FIXUPs for the realtek codec.

And this machine has two front mics which can't be handled
by PA so far, it uses the pin 0x18 and 0x19 as the front mics, as
a result the existing FIXUP ALC294_FIXUP_LENOVO_MIC_LOCATION doesn't
work on this machine. Fortunately another FIXUP
ALC283_FIXUP_HEADSET_MIC also can change the location for one of the
two mics on this machine.

Link: https://lore.kernel.org/r/20190904055327.9883-1-hui.wang@...
Signed-off-by: Hui Wang <[hidden email]>
Cc: <[hidden email]>
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit 2a36c16efab254dd6017efeb35ad88ecc96f2328
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f8aa0ab026d9..8f7a08159152 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7071,6 +7071,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
  SND_PCI_QUIRK(0x17aa, 0x312a, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
  SND_PCI_QUIRK(0x17aa, 0x312f, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
  SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
+ SND_PCI_QUIRK(0x17aa, 0x3151, "ThinkCentre Station", ALC283_FIXUP_HEADSET_MIC),
  SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
  SND_PCI_QUIRK(0x17aa, 0x3977, "IdeaPad S210", ALC283_FIXUP_INT_MIC),
  SND_PCI_QUIRK(0x17aa, 0x3978, "Lenovo B50-70", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
@@ -8945,6 +8946,7 @@ static int patch_alc680(struct hda_codec *codec)
 static const struct hda_device_id snd_hda_id_realtek[] = {
  HDA_CODEC_ENTRY(0x10ec0215, "ALC215", patch_alc269),
  HDA_CODEC_ENTRY(0x10ec0221, "ALC221", patch_alc269),
+ HDA_CODEC_ENTRY(0x10ec0222, "ALC222", patch_alc269),
  HDA_CODEC_ENTRY(0x10ec0225, "ALC225", patch_alc269),
  HDA_CODEC_ENTRY(0x10ec0231, "ALC231", patch_alc269),
  HDA_CODEC_ENTRY(0x10ec0233, "ALC233", patch_alc269),
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/cmt: [SRU][B/OEM-B/D/E/unstable][PATCH 0/1] The microphone and mic of headset are uesless on a ThinkCentre

Seth Forshee
In reply to this post by Hui Wang
On Fri, Sep 06, 2019 at 11:51:13AM +0800, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1842998
>
> [Impact]
> This machine user a new realtek codec and has two
> front mics, the PA can't handle two front mics, then it
> can't record sound via these two mics.
>
> [Fix]
> Apply an existing fixup to fix this issue.
>
> [Test Case]
> After applying the patch, plug an external mic or headset-mic
> to the mic jack or headset jack, system can detect them and can
> record the sound from it too.
>
>
> [Regression Risk]
> Low. just add an existing fixup to this new machine.

This commit is upstream in v5.3-rc8, so not needed for eoan. This
therefore does not need to be sauce and can be an upstream cherry pick.
With those changes:

Acked-by: Seth Forshee <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team