[SRU][B/OEM-B/D/OEM-OSP1/E/unstable][PATCH 0/1] headphone has noise as not mute on dell machines with alc236/256

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][B/OEM-B/D/OEM-OSP1/E/unstable][PATCH 0/1] headphone has noise as not mute on dell machines with alc236/256

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1854401

[Impact]
There is noise in the headphone on some dell machines with the
codec alc256 or alc236

[Fix]
Realtek provide a patch to disable PCBEEP_IN to heapdhone.

[Test Case]
tested the kernel with this patch, the noise disappeared.

[Regression Risk]
Low, Realtek provided the patch, and it is limited to apply
to alc236 and 256, and just disable the PCBEEP_IN to headphone..


Kailang Yang (1):
  UBUNTU: SAUCE: ALSA: hda/realtek - Dell headphone has noise on unmute
    for ALC236

 sound/pci/hda/patch_realtek.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][B/OEM-B/D/OEM-OSP1/E/unstable][PATCH 1/1] UBUNTU: SAUCE: ALSA: hda/realtek - Dell headphone has noise on unmute for ALC236

Hui Wang
From: Kailang Yang <[hidden email]>

BugLink: https://launchpad.net/bugs/1854401

headphone have noise even the volume is very small.
Let it fill up pcbeep hidden register to default value.
The issue was gone.

Fixes: 4344aec84bd8 ("ALSA: hda/realtek - New codec support for ALC256")
Fixes: 736f20a70608 ("ALSA: hda/realtek - Add support for ALC236/ALC3204")
Signed-off-by: Kailang Yang <[hidden email]>
Cc: <[hidden email]>
Link: https://lore.kernel.org/r/9ae47f23a64d4e41a9c81e263cd8a250@...
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit e1e8c1fdce8b00fce08784d9d738c60ebf598ebc
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index c38eab8e5e47..03734e63a12a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -367,9 +367,7 @@ static void alc_fill_eapd_coef(struct hda_codec *codec)
  case 0x10ec0215:
  case 0x10ec0233:
  case 0x10ec0235:
- case 0x10ec0236:
  case 0x10ec0255:
- case 0x10ec0256:
  case 0x10ec0257:
  case 0x10ec0282:
  case 0x10ec0283:
@@ -381,6 +379,11 @@ static void alc_fill_eapd_coef(struct hda_codec *codec)
  case 0x10ec0300:
  alc_update_coef_idx(codec, 0x10, 1<<9, 0);
  break;
+ case 0x10ec0236:
+ case 0x10ec0256:
+ alc_write_coef_idx(codec, 0x36, 0x5757);
+ alc_update_coef_idx(codec, 0x10, 1<<9, 0);
+ break;
  case 0x10ec0275:
  alc_update_coef_idx(codec, 0xe, 0, 1<<0);
  break;
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][B/OEM-B/D/OEM-OSP1/E/unstable][PATCH 0/1] headphone has noise as not mute on dell machines with alc236/256

Sultan Alsawaf
In reply to this post by Hui Wang
On Fri, Nov 29, 2019 at 09:16:24AM +0800, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1854401
>
> [Impact]
> There is noise in the headphone on some dell machines with the
> codec alc256 or alc236
>
> [Fix]
> Realtek provide a patch to disable PCBEEP_IN to heapdhone.
>
> [Test Case]
> tested the kernel with this patch, the noise disappeared.
>
> [Regression Risk]
> Low, Realtek provided the patch, and it is limited to apply
> to alc236 and 256, and just disable the PCBEEP_IN to headphone..
>
>
> Kailang Yang (1):
>   UBUNTU: SAUCE: ALSA: hda/realtek - Dell headphone has noise on unmute
>     for ALC236
>
>  sound/pci/hda/patch_realtek.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> --
> 2.17.1
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Sultan Alsawaf <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [SRU][B/OEM-B/D/OEM-OSP1/E/unstable][PATCH 0/1] headphone has noise as not mute on dell machines with alc236/256

Timo Aaltonen-6
In reply to this post by Hui Wang
On 29.11.2019 3.16, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1854401
>
> [Impact]
> There is noise in the headphone on some dell machines with the
> codec alc256 or alc236
>
> [Fix]
> Realtek provide a patch to disable PCBEEP_IN to heapdhone.
>
> [Test Case]
> tested the kernel with this patch, the noise disappeared.
>
> [Regression Risk]
> Low, Realtek provided the patch, and it is limited to apply
> to alc236 and 256, and just disable the PCBEEP_IN to headphone..
>
>
> Kailang Yang (1):
>   UBUNTU: SAUCE: ALSA: hda/realtek - Dell headphone has noise on unmute
>     for ALC236
>
>  sound/pci/hda/patch_realtek.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>

applied to osp1 oem-next, thanks

--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][B/OEM-B/D/OEM-OSP1/E/unstable][PATCH 0/1] headphone has noise as not mute on dell machines with alc236/256

Seth Forshee
In reply to this post by Hui Wang
On Fri, Nov 29, 2019 at 09:16:24AM +0800, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1854401
>
> [Impact]
> There is noise in the headphone on some dell machines with the
> codec alc256 or alc236
>
> [Fix]
> Realtek provide a patch to disable PCBEEP_IN to heapdhone.
>
> [Test Case]
> tested the kernel with this patch, the noise disappeared.
>
> [Regression Risk]
> Low, Realtek provided the patch, and it is limited to apply
> to alc236 and 256, and just disable the PCBEEP_IN to headphone..

Scope limited to specific hardware, positive testing.

Acked-by: Seth Forshee <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[Unstable]: [SRU][B/OEM-B/D/OEM-OSP1/E/unstable][PATCH 0/1] headphone has noise as not mute on dell machines with alc236/256

Seth Forshee
In reply to this post by Hui Wang
On Fri, Nov 29, 2019 at 09:16:24AM +0800, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1854401
>
> [Impact]
> There is noise in the headphone on some dell machines with the
> codec alc256 or alc236
>
> [Fix]
> Realtek provide a patch to disable PCBEEP_IN to heapdhone.
>
> [Test Case]
> tested the kernel with this patch, the noise disappeared.
>
> [Regression Risk]
> Low, Realtek provided the patch, and it is limited to apply
> to alc236 and 256, and just disable the PCBEEP_IN to headphone..

Applied to unstable/master, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED/cmnt: [SRU][B/OEM-B/D/OEM-OSP1/E/unstable][PATCH 0/1] headphone has noise as not mute on dell machines with alc236/256

Kleber Souza
In reply to this post by Hui Wang
On 2019-11-29 02:16, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1854401
>
> [Impact]
> There is noise in the headphone on some dell machines with the
> codec alc256 or alc236
>
> [Fix]
> Realtek provide a patch to disable PCBEEP_IN to heapdhone.
>
> [Test Case]
> tested the kernel with this patch, the noise disappeared.
>
> [Regression Risk]
> Low, Realtek provided the patch, and it is limited to apply
> to alc236 and 256, and just disable the PCBEEP_IN to headphone..
>
>
> Kailang Yang (1):
>   UBUNTU: SAUCE: ALSA: hda/realtek - Dell headphone has noise on unmute
>     for ALC236
>
>  sound/pci/hda/patch_realtek.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>

Applied to bionic, disco and eoan master-next branches. I have
also fixed the nominations on the bug report.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team