[SRU] [B/OEM-B] [PATCH 0/1] Add GeminiLake support on Intel int340x thermal device

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU] [B/OEM-B] [PATCH 0/1] Add GeminiLake support on Intel int340x thermal device

Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1851506

[Impact]
Intel GLK systems may overheat and trigger a shutdown when doing CPU
stress test. It's because the CPU thermal zone is missing.

[Fix]
Add missing ID to let int340x device work.

[Test]
With the patch, the thermal zone "TCPU" is corretly created. In
conjunction with latest thermald, the system doesn't get shutdown by
overheating anymore.

[Regression Potenial]
Minimal. This patch only adds a missing ID, no functional change.

Sumeet Pawnikar (1):
  thermal: int340x: processor_thermal: Add GeminiLake support

 drivers/thermal/int340x_thermal/processor_thermal_device.c | 4 ++++
 1 file changed, 4 insertions(+)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[B/OEM-B] [PATCH 1/1] thermal: int340x: processor_thermal: Add GeminiLake support

Kai-Heng Feng
From: Sumeet Pawnikar <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1851506

Added PCI device id of GeminiLake thermal device.

Signed-off-by: Sumeet Pawnikar <[hidden email]>
Signed-off-by: Zhang Rui <[hidden email]>
(cherry picked from commit ce7d35fa4e60b08ed3f3c568e9fa6cdabf753e7e)
Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/thermal/int340x_thermal/processor_thermal_device.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/thermal/int340x_thermal/processor_thermal_device.c b/drivers/thermal/int340x_thermal/processor_thermal_device.c
index 489d6e388294..d9076e784335 100644
--- a/drivers/thermal/int340x_thermal/processor_thermal_device.c
+++ b/drivers/thermal/int340x_thermal/processor_thermal_device.c
@@ -43,6 +43,9 @@
 #define PCI_DEVICE_ID_PROC_BXTX_THERMAL  0x4A8C
 #define PCI_DEVICE_ID_PROC_BXTP_THERMAL  0x5A8C
 
+/* GeminiLake thermal reporting device */
+#define PCI_DEVICE_ID_PROC_GLK_THERMAL 0x318C
+
 struct power_config {
  u32 index;
  u32 min_uw;
@@ -469,6 +472,7 @@ static const struct pci_device_id proc_thermal_pci_ids[] = {
  { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_PROC_BXTP_THERMAL)},
  { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_PROC_CNL_THERMAL)},
  { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_PROC_CFL_THERMAL)},
+ { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_PROC_GLK_THERMAL)},
  { 0, },
 };
 
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [B/OEM-B] [PATCH 1/1] thermal: int340x: processor_thermal: Add GeminiLake support

Connor Kuehl
On 11/6/19 5:24 AM, Kai-Heng Feng wrote:

> From: Sumeet Pawnikar <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1851506
>
> Added PCI device id of GeminiLake thermal device.
>
> Signed-off-by: Sumeet Pawnikar <[hidden email]>
> Signed-off-by: Zhang Rui <[hidden email]>
> (cherry picked from commit ce7d35fa4e60b08ed3f3c568e9fa6cdabf753e7e)
> Signed-off-by: Kai-Heng Feng <[hidden email]>

Acked-by: Connor Kuehl <[hidden email]>

> ---
>   drivers/thermal/int340x_thermal/processor_thermal_device.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/thermal/int340x_thermal/processor_thermal_device.c b/drivers/thermal/int340x_thermal/processor_thermal_device.c
> index 489d6e388294..d9076e784335 100644
> --- a/drivers/thermal/int340x_thermal/processor_thermal_device.c
> +++ b/drivers/thermal/int340x_thermal/processor_thermal_device.c
> @@ -43,6 +43,9 @@
>   #define PCI_DEVICE_ID_PROC_BXTX_THERMAL  0x4A8C
>   #define PCI_DEVICE_ID_PROC_BXTP_THERMAL  0x5A8C
>  
> +/* GeminiLake thermal reporting device */
> +#define PCI_DEVICE_ID_PROC_GLK_THERMAL 0x318C
> +
>   struct power_config {
>   u32 index;
>   u32 min_uw;
> @@ -469,6 +472,7 @@ static const struct pci_device_id proc_thermal_pci_ids[] = {
>   { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_PROC_BXTP_THERMAL)},
>   { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_PROC_CNL_THERMAL)},
>   { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_PROC_CFL_THERMAL)},
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_PROC_GLK_THERMAL)},
>   { 0, },
>   };
>  
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [B/OEM-B] [PATCH 1/1] thermal: int340x: processor_thermal: Add GeminiLake support

Stefan Bader-2
In reply to this post by Kai-Heng Feng
On 06.11.19 14:24, Kai-Heng Feng wrote:

> From: Sumeet Pawnikar <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1851506
>
> Added PCI device id of GeminiLake thermal device.
>
> Signed-off-by: Sumeet Pawnikar <[hidden email]>
> Signed-off-by: Zhang Rui <[hidden email]>
> (cherry picked from commit ce7d35fa4e60b08ed3f3c568e9fa6cdabf753e7e)
> Signed-off-by: Kai-Heng Feng <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>

> ---
>  drivers/thermal/int340x_thermal/processor_thermal_device.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/thermal/int340x_thermal/processor_thermal_device.c b/drivers/thermal/int340x_thermal/processor_thermal_device.c
> index 489d6e388294..d9076e784335 100644
> --- a/drivers/thermal/int340x_thermal/processor_thermal_device.c
> +++ b/drivers/thermal/int340x_thermal/processor_thermal_device.c
> @@ -43,6 +43,9 @@
>  #define PCI_DEVICE_ID_PROC_BXTX_THERMAL  0x4A8C
>  #define PCI_DEVICE_ID_PROC_BXTP_THERMAL  0x5A8C
>  
> +/* GeminiLake thermal reporting device */
> +#define PCI_DEVICE_ID_PROC_GLK_THERMAL 0x318C
> +
>  struct power_config {
>   u32 index;
>   u32 min_uw;
> @@ -469,6 +472,7 @@ static const struct pci_device_id proc_thermal_pci_ids[] = {
>   { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_PROC_BXTP_THERMAL)},
>   { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_PROC_CNL_THERMAL)},
>   { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_PROC_CFL_THERMAL)},
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_PROC_GLK_THERMAL)},
>   { 0, },
>  };
>  
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED(B): [SRU] [B/OEM-B] [PATCH 0/1] Add GeminiLake support on Intel int340x thermal device

Khaled Elmously
In reply to this post by Kai-Heng Feng
On 2019-11-06 21:24:47 , Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1851506
>
> [Impact]
> Intel GLK systems may overheat and trigger a shutdown when doing CPU
> stress test. It's because the CPU thermal zone is missing.
>
> [Fix]
> Add missing ID to let int340x device work.
>
> [Test]
> With the patch, the thermal zone "TCPU" is corretly created. In
> conjunction with latest thermald, the system doesn't get shutdown by
> overheating anymore.
>
> [Regression Potenial]
> Minimal. This patch only adds a missing ID, no functional change.
>
> Sumeet Pawnikar (1):
>   thermal: int340x: processor_thermal: Add GeminiLake support
>
>  drivers/thermal/int340x_thermal/processor_thermal_device.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> --
> 2.17.1
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team