[SRU][B][Patch 0/1] Ubuntu 18.04 - wrong cpu-mf counter number (LP: 1847109)

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][B][Patch 0/1] Ubuntu 18.04 - wrong cpu-mf counter number (LP: 1847109)

frank.heimes
Buglink: https://bugs.launchpad.net/bugs/1847109

SRU Justification:

[Impact]

* wrong cpu-mf counter number of LAST_HOST_TRANSLATIONS

[Fix]

* 81507f38d427ebed3291a3c153a798937c998140 81507f38 "s390/cpum_cf: correct counter number of LAST_HOST_TRANSLATIONS"

[Test Case]

* inspect the counter number of the LAST_HOST_TRANSLATIONS (virtual) file

* cat /sys/devices/cpum_cf/events/LAST_HOST_TRANSLATIONS

* returns 'event=0x00e9', but should be 'event=0x00e8'

* event is only available on z14 and higher, hence Canonical can only do regression testing - IBM the functional verification

[Regression Potential]

* very minimal, patch just changes one hex number in one code line

* change is limited to z14 (and higher) hardware counters only

[Other Info]

* fix/patch got upstream accepted with 4.16

* hence it's already in (cosmic and) disco and eoan and only need to be applied to bionic 4.15

Hendrik Brueckner (1):
  From: Hendrik Brueckner <[hidden email]>

 arch/s390/kernel/perf_cpum_cf_events.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][B][Patch 1/1] s390/cpum_cf: correct counter number of LAST_HOST_TRANSLATIONS

frank.heimes
From: Hendrik Brueckner <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1847109

Signed-off-by: Hendrik Brueckner <[hidden email]>
Signed-off-by: Martin Schwidefsky <[hidden email]>
(cherry picked from commit 81507f38d427ebed3291a3c153a798937c998140)
Signed-off-by: Frank Heimes <[hidden email]>
---
 arch/s390/kernel/perf_cpum_cf_events.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/s390/kernel/perf_cpum_cf_events.c b/arch/s390/kernel/perf_cpum_cf_events.c
index d54b097..1bafe96 100644
--- a/arch/s390/kernel/perf_cpum_cf_events.c
+++ b/arch/s390/kernel/perf_cpum_cf_events.c
@@ -230,7 +230,7 @@ CPUMF_EVENT_ATTR(cf_z14, L1I_OFFDRAWER_L4_SOURCED_WRITES, 0x00af);
 CPUMF_EVENT_ATTR(cf_z14, BCD_DFP_EXECUTION_SLOTS, 0x00e0);
 CPUMF_EVENT_ATTR(cf_z14, VX_BCD_EXECUTION_SLOTS, 0x00e1);
 CPUMF_EVENT_ATTR(cf_z14, DECIMAL_INSTRUCTIONS, 0x00e2);
-CPUMF_EVENT_ATTR(cf_z14, LAST_HOST_TRANSLATIONS, 0x00e9);
+CPUMF_EVENT_ATTR(cf_z14, LAST_HOST_TRANSLATIONS, 0x00e8);
 CPUMF_EVENT_ATTR(cf_z14, TX_NC_TABORT, 0x00f3);
 CPUMF_EVENT_ATTR(cf_z14, TX_C_TABORT_NO_SPECIAL, 0x00f4);
 CPUMF_EVENT_ATTR(cf_z14, TX_C_TABORT_SPECIAL, 0x00f5);
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][B][Patch 1/1] s390/cpum_cf: correct counter number of LAST_HOST_TRANSLATIONS

Stefan Bader-2
On 08.10.19 14:47, [hidden email] wrote:
> From: Hendrik Brueckner <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1847109
>
> Signed-off-by: Hendrik Brueckner <[hidden email]>
> Signed-off-by: Martin Schwidefsky <[hidden email]>
> (cherry picked from commit 81507f38d427ebed3291a3c153a798937c998140)
> Signed-off-by: Frank Heimes <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>

> ---
>  arch/s390/kernel/perf_cpum_cf_events.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/kernel/perf_cpum_cf_events.c b/arch/s390/kernel/perf_cpum_cf_events.c
> index d54b097..1bafe96 100644
> --- a/arch/s390/kernel/perf_cpum_cf_events.c
> +++ b/arch/s390/kernel/perf_cpum_cf_events.c
> @@ -230,7 +230,7 @@ CPUMF_EVENT_ATTR(cf_z14, L1I_OFFDRAWER_L4_SOURCED_WRITES, 0x00af);
>  CPUMF_EVENT_ATTR(cf_z14, BCD_DFP_EXECUTION_SLOTS, 0x00e0);
>  CPUMF_EVENT_ATTR(cf_z14, VX_BCD_EXECUTION_SLOTS, 0x00e1);
>  CPUMF_EVENT_ATTR(cf_z14, DECIMAL_INSTRUCTIONS, 0x00e2);
> -CPUMF_EVENT_ATTR(cf_z14, LAST_HOST_TRANSLATIONS, 0x00e9);
> +CPUMF_EVENT_ATTR(cf_z14, LAST_HOST_TRANSLATIONS, 0x00e8);
>  CPUMF_EVENT_ATTR(cf_z14, TX_NC_TABORT, 0x00f3);
>  CPUMF_EVENT_ATTR(cf_z14, TX_C_TABORT_NO_SPECIAL, 0x00f4);
>  CPUMF_EVENT_ATTR(cf_z14, TX_C_TABORT_SPECIAL, 0x00f5);
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][B][Patch 1/1] s390/cpum_cf: correct counter number of LAST_HOST_TRANSLATIONS

Kleber Souza
In reply to this post by frank.heimes
On 08.10.19 14:47, [hidden email] wrote:
> From: Hendrik Brueckner <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1847109
>
> Signed-off-by: Hendrik Brueckner <[hidden email]>
> Signed-off-by: Martin Schwidefsky <[hidden email]>
> (cherry picked from commit 81507f38d427ebed3291a3c153a798937c998140)
> Signed-off-by: Frank Heimes <[hidden email]>

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

> ---
>  arch/s390/kernel/perf_cpum_cf_events.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/s390/kernel/perf_cpum_cf_events.c b/arch/s390/kernel/perf_cpum_cf_events.c
> index d54b097..1bafe96 100644
> --- a/arch/s390/kernel/perf_cpum_cf_events.c
> +++ b/arch/s390/kernel/perf_cpum_cf_events.c
> @@ -230,7 +230,7 @@ CPUMF_EVENT_ATTR(cf_z14, L1I_OFFDRAWER_L4_SOURCED_WRITES, 0x00af);
>  CPUMF_EVENT_ATTR(cf_z14, BCD_DFP_EXECUTION_SLOTS, 0x00e0);
>  CPUMF_EVENT_ATTR(cf_z14, VX_BCD_EXECUTION_SLOTS, 0x00e1);
>  CPUMF_EVENT_ATTR(cf_z14, DECIMAL_INSTRUCTIONS, 0x00e2);
> -CPUMF_EVENT_ATTR(cf_z14, LAST_HOST_TRANSLATIONS, 0x00e9);
> +CPUMF_EVENT_ATTR(cf_z14, LAST_HOST_TRANSLATIONS, 0x00e8);
>  CPUMF_EVENT_ATTR(cf_z14, TX_NC_TABORT, 0x00f3);
>  CPUMF_EVENT_ATTR(cf_z14, TX_C_TABORT_NO_SPECIAL, 0x00f4);
>  CPUMF_EVENT_ATTR(cf_z14, TX_C_TABORT_SPECIAL, 0x00f5);
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU][B][Patch 0/1] Ubuntu 18.04 - wrong cpu-mf counter number (LP: 1847109)

Kleber Souza
In reply to this post by frank.heimes
On 08.10.19 14:47, [hidden email] wrote:

> Buglink: https://bugs.launchpad.net/bugs/1847109
>
> SRU Justification:
>
> [Impact]
>
> * wrong cpu-mf counter number of LAST_HOST_TRANSLATIONS
>
> [Fix]
>
> * 81507f38d427ebed3291a3c153a798937c998140 81507f38 "s390/cpum_cf: correct counter number of LAST_HOST_TRANSLATIONS"
>
> [Test Case]
>
> * inspect the counter number of the LAST_HOST_TRANSLATIONS (virtual) file
>
> * cat /sys/devices/cpum_cf/events/LAST_HOST_TRANSLATIONS
>
> * returns 'event=0x00e9', but should be 'event=0x00e8'
>
> * event is only available on z14 and higher, hence Canonical can only do regression testing - IBM the functional verification
>
> [Regression Potential]
>
> * very minimal, patch just changes one hex number in one code line
>
> * change is limited to z14 (and higher) hardware counters only
>
> [Other Info]
>
> * fix/patch got upstream accepted with 4.16
>
> * hence it's already in (cosmic and) disco and eoan and only need to be applied to bionic 4.15
>
> Hendrik Brueckner (1):
>   From: Hendrik Brueckner <[hidden email]>
>
>  arch/s390/kernel/perf_cpum_cf_events.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Applied to bionic/master-next branch.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team