[SRU][B/aws, F, G] EFA: add support for 0xefa1 devices

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][B/aws, F, G] EFA: add support for 0xefa1 devices

Kamal Mostafa-2
BugLink: https://bugs.launchpad.net/bugs/1896791

AWS RDMA/efa driver: add support for new AWS EFA '0xefa1' devices.

These are cherry-picks and simple context backports of mainline commits
to the AWS 'efa' driver, needed to support future AWS EFA Infiniband
devices.

 -Kamal


[Impact]

The following 4 mainline commits are required to support the new device
features and ID:

d4f9cb5c5b22 RDMA/efa: Add EFA 0xefa1 PCI ID
a5d87b698547 RDMA/efa: User/kernel compatibility handshake mechanism
da2924bdca99 RDMA/efa: Expose minimum SQ size
556c811f24b3 RDMA/efa: Expose maximum TX doorbell batch

[Test Case]

New device is not yet generally available, but has been tested by AWS.

[Regression Potential]

Low regression potential; Affects only the EFA driver.

[Other Info]

Focal and Groovy generic kernels can easily support this patch set, so
lets do that, to provide wider support and an updated driver source
baseline for those.

Bionic can only support it in bionic/linux-aws (not generic), so lets do
that.

-----

Gal Pressman (4):
  RDMA/efa: Expose maximum TX doorbell batch
  RDMA/efa: Expose minimum SQ size
  RDMA/efa: User/kernel compatibility handshake mechanism
  RDMA/efa: Add EFA 0xefa1 PCI ID

 .../infiniband/hw/efa/efa_admin_cmds_defs.h   | 15 ++++++-
 drivers/infiniband/hw/efa/efa_com_cmd.c       |  2 +
 drivers/infiniband/hw/efa/efa_com_cmd.h       |  2 +
 drivers/infiniband/hw/efa/efa_main.c          |  6 ++-
 drivers/infiniband/hw/efa/efa_verbs.c         | 42 +++++++++++++++++++
 include/uapi/rdma/efa-abi.h                   | 15 ++++++-
 6 files changed, 77 insertions(+), 5 deletions(-)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][Groovy][PULL] EFA: add support for 0xefa1 devices

Kamal Mostafa-2
The following changes since commit 2af8f501bbca48f112bd9255efb97579b582cd19:

  Linux 5.8.11 (2020-09-23 17:49:24 +0200)

are available in the Git repository at:

  git://git.launchpad.net/~kamalmostafa/ubuntu/+source/linux/+git/groovy aws-0xefa1

for you to fetch changes up to 5816ef310e741202be6cb979bd86fdca6c715a07:

  RDMA/efa: Add EFA 0xefa1 PCI ID (2020-09-23 09:27:02 -0700)

----------------------------------------------------------------
Gal Pressman (4):
      RDMA/efa: Expose maximum TX doorbell batch
      RDMA/efa: Expose minimum SQ size
      RDMA/efa: User/kernel compatibility handshake mechanism
      RDMA/efa: Add EFA 0xefa1 PCI ID

 drivers/infiniband/hw/efa/efa_admin_cmds_defs.h | 15 +++++++--
 drivers/infiniband/hw/efa/efa_com_cmd.c         |  2 ++
 drivers/infiniband/hw/efa/efa_com_cmd.h         |  2 ++
 drivers/infiniband/hw/efa/efa_main.c            |  6 ++--
 drivers/infiniband/hw/efa/efa_verbs.c           | 42 +++++++++++++++++++++++++
 include/uapi/rdma/efa-abi.h                     | 15 ++++++++-
 6 files changed, 77 insertions(+), 5 deletions(-)

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][Focal][PULL] EFA: add support for 0xefa1 devices

Kamal Mostafa-2
In reply to this post by Kamal Mostafa-2
The following changes since commit fd386a64a1ed3f2f047318508ebd733f56a4fab2:

  UBUNTU: Ubuntu-5.4.0-49.53 (2020-09-18 10:17:01 +0200)

are available in the Git repository at:

  git://git.launchpad.net/~kamalmostafa/ubuntu/+source/linux/+git/focal aws-0xefa1

for you to fetch changes up to 576d95742e71d9c123006b2db5598140be9be013:

  RDMA/efa: Add EFA 0xefa1 PCI ID (2020-09-21 12:17:03 -0700)

----------------------------------------------------------------
Gal Pressman (4):
      RDMA/efa: Expose maximum TX doorbell batch
      RDMA/efa: Expose minimum SQ size
      RDMA/efa: User/kernel compatibility handshake mechanism
      RDMA/efa: Add EFA 0xefa1 PCI ID

 drivers/infiniband/hw/efa/efa_admin_cmds_defs.h | 14 ++++++++-
 drivers/infiniband/hw/efa/efa_com_cmd.c         |  2 ++
 drivers/infiniband/hw/efa/efa_com_cmd.h         |  2 ++
 drivers/infiniband/hw/efa/efa_main.c            |  6 ++--
 drivers/infiniband/hw/efa/efa_verbs.c           | 42 +++++++++++++++++++++++++
 include/uapi/rdma/efa-abi.h                     | 15 ++++++++-
 6 files changed, 77 insertions(+), 4 deletions(-)

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][Bionic/linux-aws][PULL] EFA: add support for 0xefa1 devices

Kamal Mostafa-2
In reply to this post by Kamal Mostafa-2
The following changes since commit 42928841201aa575365f55a32f3daa49d9eb9350:

  UBUNTU: Ubuntu-aws-4.15.0-1084.88 (2020-09-21 14:17:05 -0400)

are available in the Git repository at:

  git://git.launchpad.net/~kamalmostafa/ubuntu/+source/linux-aws/+git/bionic aws-0xefa1

for you to fetch changes up to 88a2bc4fd799d99fe8cd65c6f7729c689d78b4d6:

  RDMA/efa: Add EFA 0xefa1 PCI ID (2020-09-23 07:52:04 -0700)

----------------------------------------------------------------
Gal Pressman (4):
      RDMA/efa: Expose maximum TX doorbell batch
      RDMA/efa: Expose minimum SQ size
      RDMA/efa: User/kernel compatibility handshake mechanism
      RDMA/efa: Add EFA 0xefa1 PCI ID

 drivers/infiniband/hw/efa/efa_admin_cmds_defs.h | 14 ++++++++-
 drivers/infiniband/hw/efa/efa_com_cmd.c         |  2 ++
 drivers/infiniband/hw/efa/efa_com_cmd.h         |  2 ++
 drivers/infiniband/hw/efa/efa_main.c            |  6 ++--
 drivers/infiniband/hw/efa/efa_verbs.c           | 42 +++++++++++++++++++++++++
 include/uapi/rdma/efa-abi.h                     | 15 ++++++++-
 6 files changed, 77 insertions(+), 4 deletions(-)

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/Cmnt: [SRU][B/aws, F, G] EFA: add support for 0xefa1 devices

Stefan Bader-2
In reply to this post by Kamal Mostafa-2
On 23.09.20 18:48, Kamal Mostafa wrote:

> BugLink: https://bugs.launchpad.net/bugs/1896791
>
> AWS RDMA/efa driver: add support for new AWS EFA '0xefa1' devices.
>
> These are cherry-picks and simple context backports of mainline commits
> to the AWS 'efa' driver, needed to support future AWS EFA Infiniband
> devices.
>
>  -Kamal
>
>
> [Impact]
>
> The following 4 mainline commits are required to support the new device
> features and ID:
>
> d4f9cb5c5b22 RDMA/efa: Add EFA 0xefa1 PCI ID
> a5d87b698547 RDMA/efa: User/kernel compatibility handshake mechanism
> da2924bdca99 RDMA/efa: Expose minimum SQ size
> 556c811f24b3 RDMA/efa: Expose maximum TX doorbell batch
>
> [Test Case]
>
> New device is not yet generally available, but has been tested by AWS.
>
> [Regression Potential]
>
> Low regression potential; Affects only the EFA driver.
>
> [Other Info]
>
> Focal and Groovy generic kernels can easily support this patch set, so
> lets do that, to provide wider support and an updated driver source
> baseline for those.
>
> Bionic can only support it in bionic/linux-aws (not generic), so lets do
> that.
>
> -----
>
> Gal Pressman (4):
>   RDMA/efa: Expose maximum TX doorbell batch
>   RDMA/efa: Expose minimum SQ size
>   RDMA/efa: User/kernel compatibility handshake mechanism
>   RDMA/efa: Add EFA 0xefa1 PCI ID
>
>  .../infiniband/hw/efa/efa_admin_cmds_defs.h   | 15 ++++++-
>  drivers/infiniband/hw/efa/efa_com_cmd.c       |  2 +
>  drivers/infiniband/hw/efa/efa_com_cmd.h       |  2 +
>  drivers/infiniband/hw/efa/efa_main.c          |  6 ++-
>  drivers/infiniband/hw/efa/efa_verbs.c         | 42 +++++++++++++++++++
>  include/uapi/rdma/efa-abi.h                   | 15 ++++++-
>  6 files changed, 77 insertions(+), 5 deletions(-)
>
While adding new drivers in SRU is always something I would frown upon, I guess
this is okay'ish. At least these changes are upstream so there is less danger of
things becoming stale and forgotten. And it is a very specific driver. And we
already <retracted> included the ENA stuff.

Acked-by: Stefan Bader <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][B/aws, F, G] EFA: add support for 0xefa1 devices

Kleber Souza
In reply to this post by Kamal Mostafa-2
On 23.09.20 18:48, Kamal Mostafa wrote:

> BugLink: https://bugs.launchpad.net/bugs/1896791
>
> AWS RDMA/efa driver: add support for new AWS EFA '0xefa1' devices.
>
> These are cherry-picks and simple context backports of mainline commits
> to the AWS 'efa' driver, needed to support future AWS EFA Infiniband
> devices.
>
>  -Kamal
>
>
> [Impact]
>
> The following 4 mainline commits are required to support the new device
> features and ID:
>
> d4f9cb5c5b22 RDMA/efa: Add EFA 0xefa1 PCI ID
> a5d87b698547 RDMA/efa: User/kernel compatibility handshake mechanism
> da2924bdca99 RDMA/efa: Expose minimum SQ size
> 556c811f24b3 RDMA/efa: Expose maximum TX doorbell batch
>
> [Test Case]
>
> New device is not yet generally available, but has been tested by AWS.
>
> [Regression Potential]
>
> Low regression potential; Affects only the EFA driver.
>
> [Other Info]
>
> Focal and Groovy generic kernels can easily support this patch set, so
> lets do that, to provide wider support and an updated driver source
> baseline for those.
>
> Bionic can only support it in bionic/linux-aws (not generic), so lets do
> that.
>

Clean cherry-picks from upstream, relatively simple changes and tested
by AWS.

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

> -----
>
> Gal Pressman (4):
>   RDMA/efa: Expose maximum TX doorbell batch
>   RDMA/efa: Expose minimum SQ size
>   RDMA/efa: User/kernel compatibility handshake mechanism
>   RDMA/efa: Add EFA 0xefa1 PCI ID
>
>  .../infiniband/hw/efa/efa_admin_cmds_defs.h   | 15 ++++++-
>  drivers/infiniband/hw/efa/efa_com_cmd.c       |  2 +
>  drivers/infiniband/hw/efa/efa_com_cmd.h       |  2 +
>  drivers/infiniband/hw/efa/efa_main.c          |  6 ++-
>  drivers/infiniband/hw/efa/efa_verbs.c         | 42 +++++++++++++++++++
>  include/uapi/rdma/efa-abi.h                   | 15 ++++++-
>  6 files changed, 77 insertions(+), 5 deletions(-)
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU][Groovy][PULL] EFA: add support for 0xefa1 devices

Seth Forshee
In reply to this post by Kamal Mostafa-2
On Wed, Sep 23, 2020 at 09:48:06AM -0700, Kamal Mostafa wrote:

> The following changes since commit 2af8f501bbca48f112bd9255efb97579b582cd19:
>
>   Linux 5.8.11 (2020-09-23 17:49:24 +0200)
>
> are available in the Git repository at:
>
>   git://git.launchpad.net/~kamalmostafa/ubuntu/+source/linux/+git/groovy aws-0xefa1
>
> for you to fetch changes up to 5816ef310e741202be6cb979bd86fdca6c715a07:
>
>   RDMA/efa: Add EFA 0xefa1 PCI ID (2020-09-23 09:27:02 -0700)

Applied to groovy/master-next, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[F]: [SRU][Focal][PULL] EFA: add support for 0xefa1 devices

Ian May
In reply to this post by Kamal Mostafa-2
Applied to Focal/master-next.  Thanks!

Ian

On 2020-09-23 09:48:07 , Kamal Mostafa wrote:

> The following changes since commit fd386a64a1ed3f2f047318508ebd733f56a4fab2:
>
>   UBUNTU: Ubuntu-5.4.0-49.53 (2020-09-18 10:17:01 +0200)
>
> are available in the Git repository at:
>
>   git://git.launchpad.net/~kamalmostafa/ubuntu/+source/linux/+git/focal aws-0xefa1
>
> for you to fetch changes up to 576d95742e71d9c123006b2db5598140be9be013:
>
>   RDMA/efa: Add EFA 0xefa1 PCI ID (2020-09-21 12:17:03 -0700)
>
> ----------------------------------------------------------------
> Gal Pressman (4):
>       RDMA/efa: Expose maximum TX doorbell batch
>       RDMA/efa: Expose minimum SQ size
>       RDMA/efa: User/kernel compatibility handshake mechanism
>       RDMA/efa: Add EFA 0xefa1 PCI ID
>
>  drivers/infiniband/hw/efa/efa_admin_cmds_defs.h | 14 ++++++++-
>  drivers/infiniband/hw/efa/efa_com_cmd.c         |  2 ++
>  drivers/infiniband/hw/efa/efa_com_cmd.h         |  2 ++
>  drivers/infiniband/hw/efa/efa_main.c            |  6 ++--
>  drivers/infiniband/hw/efa/efa_verbs.c           | 42 +++++++++++++++++++++++++
>  include/uapi/rdma/efa-abi.h                     | 15 ++++++++-
>  6 files changed, 77 insertions(+), 4 deletions(-)
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[AWS-B]: [SRU][Bionic/linux-aws][PULL] EFA: add support for 0xefa1 devices

Ian May
In reply to this post by Kamal Mostafa-2
Applied to aws-bionic

Thanks!
Ian

On 2020-09-23 09:48:08 , Kamal Mostafa wrote:

> The following changes since commit 42928841201aa575365f55a32f3daa49d9eb9350:
>
>   UBUNTU: Ubuntu-aws-4.15.0-1084.88 (2020-09-21 14:17:05 -0400)
>
> are available in the Git repository at:
>
>   git://git.launchpad.net/~kamalmostafa/ubuntu/+source/linux-aws/+git/bionic aws-0xefa1
>
> for you to fetch changes up to 88a2bc4fd799d99fe8cd65c6f7729c689d78b4d6:
>
>   RDMA/efa: Add EFA 0xefa1 PCI ID (2020-09-23 07:52:04 -0700)
>
> ----------------------------------------------------------------
> Gal Pressman (4):
>       RDMA/efa: Expose maximum TX doorbell batch
>       RDMA/efa: Expose minimum SQ size
>       RDMA/efa: User/kernel compatibility handshake mechanism
>       RDMA/efa: Add EFA 0xefa1 PCI ID
>
>  drivers/infiniband/hw/efa/efa_admin_cmds_defs.h | 14 ++++++++-
>  drivers/infiniband/hw/efa/efa_com_cmd.c         |  2 ++
>  drivers/infiniband/hw/efa/efa_com_cmd.h         |  2 ++
>  drivers/infiniband/hw/efa/efa_main.c            |  6 ++--
>  drivers/infiniband/hw/efa/efa_verbs.c           | 42 +++++++++++++++++++++++++
>  include/uapi/rdma/efa-abi.h                     | 15 ++++++++-
>  6 files changed, 77 insertions(+), 4 deletions(-)
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team