[SRU][Bionic][Cosmic][PATCH 0/1] UBUNTU: [Config:] d-i: Add ax88179_178a and r8152 to nic-modules

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][Bionic][Cosmic][PATCH 0/1] UBUNTU: [Config:] d-i: Add ax88179_178a and r8152 to nic-modules

Joseph Salisbury-3
BugLink: http://bugs.launchpad.net/bugs/1771823

== SRU Justification ==
The r8152 module is used in a thunderbolt-connected docking station and
ax88179_178a by an external USB dongle.

Despite having two nics connected the bug reporter can't install Bionic.

This SRU request is to add the modules to the debian installer.

== Fix ==
UBUNTU: [Config:] d-i: Add ax88179_178a and r8152 to nic-modules

== Regression Potential ==
Low.  This is adding a module to the installer.

== Test Case ==
A test kernel was built with this patch and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.


Joseph Salisbury (1):
  UBUNTU: d-i: Add ax88179_178a and r8152 to nic-modules

 debian.master/d-i/modules/nic-modules | 2 ++
 1 file changed, 2 insertions(+)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][Bionic][Cosmic][PATCH 1/1] UBUNTU: [Config:] d-i: Add ax88179_178a and r8152 to nic-modules

Joseph Salisbury-3
BugLink: http://bugs.launchpad.net/bugs/1771823

The user is unable to install Bionic.  r8152 is used in a
thunderbolt-connected docking station and ax88179_178a by an external USB dongle.

Signed-off-by: Joseph Salisbury <[hidden email]>
---
 debian.master/d-i/modules/nic-modules | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/debian.master/d-i/modules/nic-modules b/debian.master/d-i/modules/nic-modules
index acfa2ec..f0ca0ec 100644
--- a/debian.master/d-i/modules/nic-modules
+++ b/debian.master/d-i/modules/nic-modules
@@ -34,6 +34,7 @@ atl1e ?
 atl2 ?
 atmel ?
 atmel_pci ?
+ax88179_178a ?
 b44 ?
 bcm87xx ?
 be2net ?
@@ -163,6 +164,7 @@ rt2500 ?
 rt2500pci ?
 rt2800pci ?
 rt61pci ?
+r8152 ?
 s2io ?
 sfc ?
 shaper ?
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

NACK: [SRU][Bionic][Cosmic][PATCH 1/1] UBUNTU: [Config:] d-i: Add ax88179_178a and r8152 to nic-modules

Seth Forshee
On Fri, Jun 22, 2018 at 01:34:43PM -0400, Joseph Salisbury wrote:

> BugLink: http://bugs.launchpad.net/bugs/1771823
>
> The user is unable to install Bionic.  r8152 is used in a
> thunderbolt-connected docking station and ax88179_178a by an external USB dongle.
>
> Signed-off-by: Joseph Salisbury <[hidden email]>
> ---
>  debian.master/d-i/modules/nic-modules | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/debian.master/d-i/modules/nic-modules b/debian.master/d-i/modules/nic-modules

It looks like these should go in
debian.master/d-i/modules/nic-usb-modules instead.

Thanks,
Seth

> index acfa2ec..f0ca0ec 100644
> --- a/debian.master/d-i/modules/nic-modules
> +++ b/debian.master/d-i/modules/nic-modules
> @@ -34,6 +34,7 @@ atl1e ?
>  atl2 ?
>  atmel ?
>  atmel_pci ?
> +ax88179_178a ?
>  b44 ?
>  bcm87xx ?
>  be2net ?
> @@ -163,6 +164,7 @@ rt2500 ?
>  rt2500pci ?
>  rt2800pci ?
>  rt61pci ?
> +r8152 ?
>  s2io ?
>  sfc ?
>  shaper ?
> --
> 2.7.4
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

NAK: [SRU][Bionic][Cosmic][PATCH 0/1] UBUNTU: [Config:] d-i: Add ax88179_178a and r8152 to nic-modules

Joseph Salisbury-3
In reply to this post by Joseph Salisbury-3
I will be sending a v2 with corrections pointed out by sforshee.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team