[SRU][Bionic][Cosmic][PATCH 0/1] UBUNTU: SAUCE: cpuidle/powernv : init all present cpus for deep states

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][Bionic][Cosmic][PATCH 0/1] UBUNTU: SAUCE: cpuidle/powernv : init all present cpus for deep states

Joseph Salisbury-3
BugLink: http://bugs.launchpad.net/bugs/1771780

== SRU Justification ==
During testing, IBM found that cpupower idle-info is not listing stop4 and
stop5 idle states when all CORES are guarded.  A patch has been
submitted upstream by IBM.  However, the patch has not landed in
linux-next or mainline as of yet.  For that reason, this SRU request is
being sent as a SAUCE patch request.


== Fix ==
UBUNTU: SAUCE: cpuidle/powernv : init all present cpus for deep states

== Regression Potential ==
Low.  Limited to powerpc.

== Test Case ==
A test kernel was built with this patch and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.

Akshay Adiga (1):
  UBUNTU: SAUCE: cpuidle/powernv : init all present cpus for deep states

 arch/powerpc/platforms/powernv/idle.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][Bionic][Cosmic][PATCH 1/1] UBUNTU: SAUCE: cpuidle/powernv : init all present cpus for deep states

Joseph Salisbury-3
From: Akshay Adiga <[hidden email]>

BugLink: http://bugs.launchpad.net/bugs/1771780

Init all present cpus for deep states instead of "all possible" cpus.
Init fails if the possible cpu is gaurded. Resulting in making only
non-deep states available for cpuidle/hotplug.

Signed-off-by: Akshay Adiga <[hidden email]>
Signed-off-by: Joseph Salisbury <[hidden email]>
---
 arch/powerpc/platforms/powernv/idle.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/platforms/powernv/idle.c b/arch/powerpc/platforms/powernv/idle.c
index 99a760e..3776a58 100644
--- a/arch/powerpc/platforms/powernv/idle.c
+++ b/arch/powerpc/platforms/powernv/idle.c
@@ -79,7 +79,7 @@ static int pnv_save_sprs_for_deep_states(void)
  uint64_t msr_val = MSR_IDLE;
  uint64_t psscr_val = pnv_deepest_stop_psscr_val;
 
- for_each_possible_cpu(cpu) {
+ for_each_present_cpu(cpu) {
  uint64_t pir = get_hard_smp_processor_id(cpu);
  uint64_t hsprg0_val = (uint64_t)&paca[cpu];
 
@@ -822,7 +822,7 @@ static int __init pnv_init_idle_states(void)
  int cpu;
 
  pr_info("powernv: idle: Saving PACA pointers of all CPUs in their thread sibling PACA\n");
- for_each_possible_cpu(cpu) {
+ for_each_present_cpu(cpu) {
  int base_cpu = cpu_first_thread_sibling(cpu);
  int idx = cpu_thread_in_core(cpu);
  int i;
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][Bionic][Cosmic][PATCH 1/1] UBUNTU: SAUCE: cpuidle/powernv : init all present cpus for deep states

Stefan Bader-2
On 23.05.2018 10:33, Joseph Salisbury wrote:

> From: Akshay Adiga <[hidden email]>
>
> BugLink: http://bugs.launchpad.net/bugs/1771780
>
> Init all present cpus for deep states instead of "all possible" cpus.
> Init fails if the possible cpu is gaurded. Resulting in making only
> non-deep states available for cpuidle/hotplug.
>
> Signed-off-by: Akshay Adiga <[hidden email]>
> Signed-off-by: Joseph Salisbury <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>

> ---
>  arch/powerpc/platforms/powernv/idle.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powernv/idle.c b/arch/powerpc/platforms/powernv/idle.c
> index 99a760e..3776a58 100644
> --- a/arch/powerpc/platforms/powernv/idle.c
> +++ b/arch/powerpc/platforms/powernv/idle.c
> @@ -79,7 +79,7 @@ static int pnv_save_sprs_for_deep_states(void)
>   uint64_t msr_val = MSR_IDLE;
>   uint64_t psscr_val = pnv_deepest_stop_psscr_val;
>  
> - for_each_possible_cpu(cpu) {
> + for_each_present_cpu(cpu) {
>   uint64_t pir = get_hard_smp_processor_id(cpu);
>   uint64_t hsprg0_val = (uint64_t)&paca[cpu];
>  
> @@ -822,7 +822,7 @@ static int __init pnv_init_idle_states(void)
>   int cpu;
>  
>   pr_info("powernv: idle: Saving PACA pointers of all CPUs in their thread sibling PACA\n");
> - for_each_possible_cpu(cpu) {
> + for_each_present_cpu(cpu) {
>   int base_cpu = cpu_first_thread_sibling(cpu);
>   int idx = cpu_thread_in_core(cpu);
>   int i;
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][Bionic][Cosmic][PATCH 1/1] UBUNTU: SAUCE: cpuidle/powernv : init all present cpus for deep states

Kleber Sacilotto de Souza
In reply to this post by Joseph Salisbury-3
On 05/23/18 10:33, Joseph Salisbury wrote:

> From: Akshay Adiga <[hidden email]>
>
> BugLink: http://bugs.launchpad.net/bugs/1771780
>
> Init all present cpus for deep states instead of "all possible" cpus.
> Init fails if the possible cpu is gaurded. Resulting in making only
> non-deep states available for cpuidle/hotplug.
>
> Signed-off-by: Akshay Adiga <[hidden email]>
> Signed-off-by: Joseph Salisbury <[hidden email]>

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

> ---
>  arch/powerpc/platforms/powernv/idle.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powernv/idle.c b/arch/powerpc/platforms/powernv/idle.c
> index 99a760e..3776a58 100644
> --- a/arch/powerpc/platforms/powernv/idle.c
> +++ b/arch/powerpc/platforms/powernv/idle.c
> @@ -79,7 +79,7 @@ static int pnv_save_sprs_for_deep_states(void)
>   uint64_t msr_val = MSR_IDLE;
>   uint64_t psscr_val = pnv_deepest_stop_psscr_val;
>  
> - for_each_possible_cpu(cpu) {
> + for_each_present_cpu(cpu) {
>   uint64_t pir = get_hard_smp_processor_id(cpu);
>   uint64_t hsprg0_val = (uint64_t)&paca[cpu];
>  
> @@ -822,7 +822,7 @@ static int __init pnv_init_idle_states(void)
>   int cpu;
>  
>   pr_info("powernv: idle: Saving PACA pointers of all CPUs in their thread sibling PACA\n");
> - for_each_possible_cpu(cpu) {
> + for_each_present_cpu(cpu) {
>   int base_cpu = cpu_first_thread_sibling(cpu);
>   int idx = cpu_thread_in_core(cpu);
>   int i;
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU][Bionic][Cosmic][PATCH 0/1] UBUNTU: SAUCE: cpuidle/powernv : init all present cpus for deep states

Khaled Elmously
In reply to this post by Joseph Salisbury-3
Applied to Bionic


On 2018-05-23 13:32:59 , Joseph Salisbury wrote:

> BugLink: http://bugs.launchpad.net/bugs/1771780
>
> == SRU Justification ==
> During testing, IBM found that cpupower idle-info is not listing stop4 and
> stop5 idle states when all CORES are guarded.  A patch has been
> submitted upstream by IBM.  However, the patch has not landed in
> linux-next or mainline as of yet.  For that reason, this SRU request is
> being sent as a SAUCE patch request.
>
>
> == Fix ==
> UBUNTU: SAUCE: cpuidle/powernv : init all present cpus for deep states
>
> == Regression Potential ==
> Low.  Limited to powerpc.
>
> == Test Case ==
> A test kernel was built with this patch and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
>
> Akshay Adiga (1):
>   UBUNTU: SAUCE: cpuidle/powernv : init all present cpus for deep states
>
>  arch/powerpc/platforms/powernv/idle.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --
> 2.7.4
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[U]: [SRU][Bionic][Cosmic][PATCH 0/1] UBUNTU: SAUCE: cpuidle/powernv : init all present cpus for deep states

Thadeu Lima de Souza Cascardo-3
In reply to this post by Joseph Salisbury-3
Applied to unstable master branch, but as a cherry-pick of
ac9816dcbab53c57bcf1d7b15370b08f1e284318 ("powerpc/powernv/cpuidle: Init all
present cpus for deep states"), as it went upstream.

Thanks.
Cascardo.

Applied-to: unstable/master

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team