Ubuntu › kernel-team

[SRU][Bionic][Disco][Eoan][Patch 0/1] UBUNTU: [Config] Change Config Option CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE for s390x from yes to no

classic Classic list List threaded Threaded
♦
♦
 7 messages Options
frank.heimes
Reply | Threaded
Open this post in threaded view
♦
♦
|

[SRU][Bionic][Disco][Eoan][Patch 0/1] UBUNTU: [Config] Change Config Option CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE for s390x from yes to no

frank.heimes
Buglink: https://bugs.launchpad.net/bugs/1848492

SRU Justification:

[Impact]

* By default all standby memory that is configured to an LPAR is used at boot (IPL) time.

* But the standby memory is meant to be added and used on demand later (after IPL).

[Fix]

* 0001-Ubuntu-Config-Disabled-CONFIG_MEMORY_HOTPLUG_DEFAULT.patch

[Test Case]

* Configure an LPAR in it's Activation Profile with a certain amount of 'Initial' memory and some 'Reserved' memory on top.

* Re-activate the LPAR to make the changes take effect and boot (IPL) Ubuntu.

* Check with the help of free whether the reported memory is only the initial memory (actual) or initial+reserved (desired).

[Regression Potential]

* There is a certain regression potential, since some systems may have Initial and Reserved memory already defined today and have it already all in use under Linux (today obviously w/o having it dynamically added).

* If such a system got re-activated and rebooted, the memory size will then be what's defined as Initial memory and no longer Initial+Reserved.

* To be able to use the same size of the memory than before, the Reserved memory need to be either dynamically be added or the Initial memory re-configured to the sum of former Initial+Reserved.

* The latter case requires a re-activation of the LPAR, but since this corner case only happens after a reboot, a downtime is already in place for the re-activation.

* But overall the regression potential is low since it's for s390x only and the 'Reserved' memory option in the Activation Profile is rarely used.

[Other Info]

* In the past this config option was diabled for ppc64el, too.

Frank Heimes (1):
  Ubuntu: [Config] Disabled CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE on
    s390x

 debian.master/config/annotations               | 4 ++--
 debian.master/config/s390x/config.common.s390x | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
frank.heimes
Reply | Threaded
Open this post in threaded view
♦
♦
|

[SRU][Bionic][Disco][Eoan][Patch 1/1] UBUNTU: [Config] Change Config Option CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE for s390x from yes to no

frank.heimes
BugLink: https://bugs.launchpad.net/bugs/1848492

Signed-off-by: Frank Heimes <[hidden email]>
---
 debian.master/config/annotations               | 4 ++--
 debian.master/config/s390x/config.common.s390x | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/debian.master/config/annotations b/debian.master/config/annotations
index 43016a9..22ddb2b 100644
--- a/debian.master/config/annotations
+++ b/debian.master/config/annotations
@@ -11165,12 +11165,12 @@ CONFIG_ARM64_PMEM                               policy<{'arm64': 'y'}>
 
 # Menu: Processor type and features >> Allow for memory hot-add
 CONFIG_MEMORY_HOTPLUG                           policy<{'amd64': 'y', 'i386': 'y', 'ppc64el': 'y', 's390x': 'y'}>
-CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE            policy<{'amd64': 'y', 'i386': 'y', 'ppc64el': 'n', 's390x': 'y'}>
+CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE            policy<{'amd64': 'y', 'i386': 'y', 'ppc64el': 'n', 's390x': 'n'}>
 CONFIG_MEMORY_HOTREMOVE                         policy<{'amd64': 'y', 'i386': 'y', 'ppc64el': 'y', 's390x': 'y'}>
 CONFIG_DEFERRED_STRUCT_PAGE_INIT                policy<{'amd64': 'n', 'i386': 'n', 'ppc64el': 'n', 's390x': 'n'}>
 CONFIG_ZONE_DEVICE                              policy<{'amd64': 'y', 'ppc64el': 'y'}>
 #
-CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE            mark<ENFORCED> note<LP:1709171>
+CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE            mark<ENFORCED> note<LP:1709171 LP:1848492>
 
 # Menu: Processor type and features >> Architecture: arm
 CONFIG_HAVE_ARM_ARCH_TIMER                      policy<{'armhf': 'y'}>
diff --git a/debian.master/config/s390x/config.common.s390x b/debian.master/config/s390x/config.common.s390x
index 00e4ce1..afbe49820 100644
--- a/debian.master/config/s390x/config.common.s390x
+++ b/debian.master/config/s390x/config.common.s390x
@@ -177,7 +177,7 @@ CONFIG_MD_MULTIPATH=y
 # CONFIG_MEGARAID_NEWGEN is not set
 # CONFIG_MEGARAID_SAS is not set
 # CONFIG_MEMORY is not set
-CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE=y
+# CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE is not set
 # CONFIG_MEMSTICK is not set
 CONFIG_MEM_SOFT_DIRTY=y
 CONFIG_MFD_CORE=m
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Kleber Souza
Reply | Threaded
Open this post in threaded view
♦
♦
|

ACK: [SRU][Bionic][Disco][Eoan][Patch 1/1] UBUNTU: [Config] Change Config Option CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE for s390x from yes to no

Kleber Souza
On 18.10.19 09:05, [hidden email] wrote:
> BugLink: https://bugs.launchpad.net/bugs/1848492
>
> Signed-off-by: Frank Heimes <[hidden email]>

Simple change affecting only the platform.

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

> ---
>  debian.master/config/annotations               | 4 ++--
>  debian.master/config/s390x/config.common.s390x | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/debian.master/config/annotations b/debian.master/config/annotations
> index 43016a9..22ddb2b 100644
> --- a/debian.master/config/annotations
> +++ b/debian.master/config/annotations
> @@ -11165,12 +11165,12 @@ CONFIG_ARM64_PMEM                               policy<{'arm64': 'y'}>
>  
>  # Menu: Processor type and features >> Allow for memory hot-add
>  CONFIG_MEMORY_HOTPLUG                           policy<{'amd64': 'y', 'i386': 'y', 'ppc64el': 'y', 's390x': 'y'}>
> -CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE            policy<{'amd64': 'y', 'i386': 'y', 'ppc64el': 'n', 's390x': 'y'}>
> +CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE            policy<{'amd64': 'y', 'i386': 'y', 'ppc64el': 'n', 's390x': 'n'}>
>  CONFIG_MEMORY_HOTREMOVE                         policy<{'amd64': 'y', 'i386': 'y', 'ppc64el': 'y', 's390x': 'y'}>
>  CONFIG_DEFERRED_STRUCT_PAGE_INIT                policy<{'amd64': 'n', 'i386': 'n', 'ppc64el': 'n', 's390x': 'n'}>
>  CONFIG_ZONE_DEVICE                              policy<{'amd64': 'y', 'ppc64el': 'y'}>
>  #
> -CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE            mark<ENFORCED> note<LP:1709171>
> +CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE            mark<ENFORCED> note<LP:1709171 LP:1848492>
>  
>  # Menu: Processor type and features >> Architecture: arm
>  CONFIG_HAVE_ARM_ARCH_TIMER                      policy<{'armhf': 'y'}>
> diff --git a/debian.master/config/s390x/config.common.s390x b/debian.master/config/s390x/config.common.s390x
> index 00e4ce1..afbe49820 100644
> --- a/debian.master/config/s390x/config.common.s390x
> +++ b/debian.master/config/s390x/config.common.s390x
> @@ -177,7 +177,7 @@ CONFIG_MD_MULTIPATH=y
>  # CONFIG_MEGARAID_NEWGEN is not set
>  # CONFIG_MEGARAID_SAS is not set
>  # CONFIG_MEMORY is not set
> -CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE=y
> +# CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE is not set
>  # CONFIG_MEMSTICK is not set
>  CONFIG_MEM_SOFT_DIRTY=y
>  CONFIG_MFD_CORE=m
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Stefan Bader-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

ACK/Cmnt: [SRU][Bionic][Disco][Eoan][Patch 1/1] UBUNTU: [Config] Change Config Option CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE for s390x from yes to no

Stefan Bader-2
In reply to this post by frank.heimes
On 18.10.19 09:05, [hidden email] wrote:
> BugLink: https://bugs.launchpad.net/bugs/1848492
>
> Signed-off-by: Frank Heimes <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>
> ---

I would put some of the explanation about what this change does into the commit
message so people not have to go in circles.

-Stefan

>  debian.master/config/annotations               | 4 ++--
>  debian.master/config/s390x/config.common.s390x | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/debian.master/config/annotations b/debian.master/config/annotations
> index 43016a9..22ddb2b 100644
> --- a/debian.master/config/annotations
> +++ b/debian.master/config/annotations
> @@ -11165,12 +11165,12 @@ CONFIG_ARM64_PMEM                               policy<{'arm64': 'y'}>
>  
>  # Menu: Processor type and features >> Allow for memory hot-add
>  CONFIG_MEMORY_HOTPLUG                           policy<{'amd64': 'y', 'i386': 'y', 'ppc64el': 'y', 's390x': 'y'}>
> -CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE            policy<{'amd64': 'y', 'i386': 'y', 'ppc64el': 'n', 's390x': 'y'}>
> +CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE            policy<{'amd64': 'y', 'i386': 'y', 'ppc64el': 'n', 's390x': 'n'}>
>  CONFIG_MEMORY_HOTREMOVE                         policy<{'amd64': 'y', 'i386': 'y', 'ppc64el': 'y', 's390x': 'y'}>
>  CONFIG_DEFERRED_STRUCT_PAGE_INIT                policy<{'amd64': 'n', 'i386': 'n', 'ppc64el': 'n', 's390x': 'n'}>
>  CONFIG_ZONE_DEVICE                              policy<{'amd64': 'y', 'ppc64el': 'y'}>
>  #
> -CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE            mark<ENFORCED> note<LP:1709171>
> +CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE            mark<ENFORCED> note<LP:1709171 LP:1848492>
>  
>  # Menu: Processor type and features >> Architecture: arm
>  CONFIG_HAVE_ARM_ARCH_TIMER                      policy<{'armhf': 'y'}>
> diff --git a/debian.master/config/s390x/config.common.s390x b/debian.master/config/s390x/config.common.s390x
> index 00e4ce1..afbe49820 100644
> --- a/debian.master/config/s390x/config.common.s390x
> +++ b/debian.master/config/s390x/config.common.s390x
> @@ -177,7 +177,7 @@ CONFIG_MD_MULTIPATH=y
>  # CONFIG_MEGARAID_NEWGEN is not set
>  # CONFIG_MEGARAID_SAS is not set
>  # CONFIG_MEMORY is not set
> -CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE=y
> +# CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE is not set
>  # CONFIG_MEMSTICK is not set
>  CONFIG_MEM_SOFT_DIRTY=y
>  CONFIG_MFD_CORE=m
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
frank.heimes
Reply | Threaded
Open this post in threaded view
♦
♦
|

Re: ACK/Cmnt: [SRU][Bionic][Disco][Eoan][Patch 1/1] UBUNTU: [Config] Change Config Option CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE for s390x from yes to no

frank.heimes
I agree - the commit msg is a bit limited, so:

"Having CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE disabled makes sure that memory that is configured as 'Reserved' to an s390x LPAR (on top of memory that is configured as 'Initial') is no longer automatically consumed (means set online) at boot time and can now be dynamically added later on demand."


On Fri, Oct 18, 2019 at 9:54 AM Stefan Bader <[hidden email]> wrote:
On 18.10.19 09:05, [hidden email] wrote:
> BugLink: https://bugs.launchpad.net/bugs/1848492
>
> Signed-off-by: Frank Heimes <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>
> ---

I would put some of the explanation about what this change does into the commit
message so people not have to go in circles.

-Stefan

>  debian.master/config/annotations               | 4 ++--
>  debian.master/config/s390x/config.common.s390x | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/debian.master/config/annotations b/debian.master/config/annotations
> index 43016a9..22ddb2b 100644
> --- a/debian.master/config/annotations
> +++ b/debian.master/config/annotations
> @@ -11165,12 +11165,12 @@ CONFIG_ARM64_PMEM                               policy<{'arm64': 'y'}>
> 
>  # Menu: Processor type and features >> Allow for memory hot-add
>  CONFIG_MEMORY_HOTPLUG                           policy<{'amd64': 'y', 'i386': 'y', 'ppc64el': 'y', 's390x': 'y'}>
> -CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE            policy<{'amd64': 'y', 'i386': 'y', 'ppc64el': 'n', 's390x': 'y'}>
> +CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE            policy<{'amd64': 'y', 'i386': 'y', 'ppc64el': 'n', 's390x': 'n'}>
>  CONFIG_MEMORY_HOTREMOVE                         policy<{'amd64': 'y', 'i386': 'y', 'ppc64el': 'y', 's390x': 'y'}>
>  CONFIG_DEFERRED_STRUCT_PAGE_INIT                policy<{'amd64': 'n', 'i386': 'n', 'ppc64el': 'n', 's390x': 'n'}>
>  CONFIG_ZONE_DEVICE                              policy<{'amd64': 'y', 'ppc64el': 'y'}>
>  #
> -CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE            mark<ENFORCED> note<LP:1709171>
> +CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE            mark<ENFORCED> note<LP:1709171 LP:1848492>
> 
>  # Menu: Processor type and features >> Architecture: arm
>  CONFIG_HAVE_ARM_ARCH_TIMER                      policy<{'armhf': 'y'}>
> diff --git a/debian.master/config/s390x/config.common.s390x b/debian.master/config/s390x/config.common.s390x
> index 00e4ce1..afbe49820 100644
> --- a/debian.master/config/s390x/config.common.s390x
> +++ b/debian.master/config/s390x/config.common.s390x
> @@ -177,7 +177,7 @@ CONFIG_MD_MULTIPATH=y
>  # CONFIG_MEGARAID_NEWGEN is not set
>  # CONFIG_MEGARAID_SAS is not set
>  # CONFIG_MEMORY is not set
> -CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE=y
> +# CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE is not set
>  # CONFIG_MEMSTICK is not set
>  CONFIG_MEM_SOFT_DIRTY=y
>  CONFIG_MFD_CORE=m
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Khaled Elmously
Reply | Threaded
Open this post in threaded view
♦
♦
|

APPLIED/cmt: [SRU][Bionic][Disco][Eoan][Patch 0/1] UBUNTU: [Config] Change Config Option CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE for s390x from yes to no

Khaled Elmously
In reply to this post by frank.heimes
Applied to B,D,E.

This change wasn't applying cleanly to D or E - however I was able to massage it to apply.

Also added a commit message from Frank's response.



On 2019-10-18 09:05:20 , [hidden email] wrote:

> Buglink: https://bugs.launchpad.net/bugs/1848492
>
> SRU Justification:
>
> [Impact]
>
> * By default all standby memory that is configured to an LPAR is used at boot (IPL) time.
>
> * But the standby memory is meant to be added and used on demand later (after IPL).
>
> [Fix]
>
> * 0001-Ubuntu-Config-Disabled-CONFIG_MEMORY_HOTPLUG_DEFAULT.patch
>
> [Test Case]
>
> * Configure an LPAR in it's Activation Profile with a certain amount of 'Initial' memory and some 'Reserved' memory on top.
>
> * Re-activate the LPAR to make the changes take effect and boot (IPL) Ubuntu.
>
> * Check with the help of free whether the reported memory is only the initial memory (actual) or initial+reserved (desired).
>
> [Regression Potential]
>
> * There is a certain regression potential, since some systems may have Initial and Reserved memory already defined today and have it already all in use under Linux (today obviously w/o having it dynamically added).
>
> * If such a system got re-activated and rebooted, the memory size will then be what's defined as Initial memory and no longer Initial+Reserved.
>
> * To be able to use the same size of the memory than before, the Reserved memory need to be either dynamically be added or the Initial memory re-configured to the sum of former Initial+Reserved.
>
> * The latter case requires a re-activation of the LPAR, but since this corner case only happens after a reboot, a downtime is already in place for the re-activation.
>
> * But overall the regression potential is low since it's for s390x only and the 'Reserved' memory option in the Activation Profile is rarely used.
>
> [Other Info]
>
> * In the past this config option was diabled for ppc64el, too.
>
> Frank Heimes (1):
>   Ubuntu: [Config] Disabled CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE on
>     s390x
>
>  debian.master/config/annotations               | 4 ++--
>  debian.master/config/s390x/config.common.s390x | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> --
> 2.7.4
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Seth Forshee
Reply | Threaded
Open this post in threaded view
♦
♦
|

APPLIED[Unstable]: [SRU][Bionic][Disco][Eoan][Patch 0/1] UBUNTU: [Config] Change Config Option CONFIG_MEMORY_HOTPLUG_DEFAULT_ONLINE for s390x from yes to no

Seth Forshee
In reply to this post by frank.heimes
On Fri, Oct 18, 2019 at 09:05:20AM +0200, [hidden email] wrote:

> Buglink: https://bugs.launchpad.net/bugs/1848492
>
> SRU Justification:
>
> [Impact]
>
> * By default all standby memory that is configured to an LPAR is used at boot (IPL) time.
>
> * But the standby memory is meant to be added and used on demand later (after IPL).
>
> [Fix]
>
> * 0001-Ubuntu-Config-Disabled-CONFIG_MEMORY_HOTPLUG_DEFAULT.patch
>
> [Test Case]
>
> * Configure an LPAR in it's Activation Profile with a certain amount of 'Initial' memory and some 'Reserved' memory on top.
>
> * Re-activate the LPAR to make the changes take effect and boot (IPL) Ubuntu.
>
> * Check with the help of free whether the reported memory is only the initial memory (actual) or initial+reserved (desired).
>
> [Regression Potential]
>
> * There is a certain regression potential, since some systems may have Initial and Reserved memory already defined today and have it already all in use under Linux (today obviously w/o having it dynamically added).
>
> * If such a system got re-activated and rebooted, the memory size will then be what's defined as Initial memory and no longer Initial+Reserved.
>
> * To be able to use the same size of the memory than before, the Reserved memory need to be either dynamically be added or the Initial memory re-configured to the sum of former Initial+Reserved.
>
> * The latter case requires a re-activation of the LPAR, but since this corner case only happens after a reboot, a downtime is already in place for the re-activation.
>
> * But overall the regression potential is low since it's for s390x only and the 'Reserved' memory option in the Activation Profile is rarely used.
>
> [Other Info]
>
> * In the past this config option was diabled for ppc64el, too.

Applied to unstable/master with context adjustments. Thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Free forum by Nabble Edit this page