[SRU] [Bionic/OEM-B] [PATCH 0/1] Fix "incomplete report" noise after S3

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU] [Bionic/OEM-B] [PATCH 0/1] Fix "incomplete report" noise after S3

Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1802813

[Impact]
I2C HID devices may keep spewing out error "i2c_hid_get_input:
incomplete report (30/2)" after system S3.

[Fix]
It a regression caused by commit ac75a041048b, backport commmit
ef6eaf27274c to fix it. Input report length 2 is a valid length.

[Test]
With the fix the issue can no longer be observed on Alps touchpads.

[Regression Potential]
None. Input report lenght 2 is valid per spec.

Jason Andryuk (1):
  HID: i2c-hid: Fix "incomplete report" noise

 drivers/hid/i2c-hid/i2c-hid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/1] HID: i2c-hid: Fix "incomplete report" noise

Kai-Heng Feng
From: Jason Andryuk <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1802813

Commit ac75a041048b ("HID: i2c-hid: fix size check and type usage") started
writing messages when the ret_size is <= 2 from i2c_master_recv.  However, my
device i2c-DLL07D1 returns 2 for a short period of time (~0.5s) after I stop
moving the pointing stick or touchpad.  It varies, but you get ~50 messages
each time which spams the log hard.

[  95.925055] i2c_hid i2c-DLL07D1:01: i2c_hid_get_input: incomplete report (83/2)

This has also been observed with a i2c-ALP0017.

[ 1781.266353] i2c_hid i2c-ALP0017:00: i2c_hid_get_input: incomplete report (30/2)

Only print the message when ret_size is totally invalid and less than 2 to cut
down on the log spam.

Fixes: ac75a041048b ("HID: i2c-hid: fix size check and type usage")
Reported-by: John Smith <[hidden email]>
Cc: [hidden email]
Signed-off-by: Jason Andryuk <[hidden email]>
Signed-off-by: Jiri Kosina <[hidden email]>
(cherry picked from commit ef6eaf27274c0351f7059163918f3795da13199c)
Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/hid/i2c-hid/i2c-hid.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
index 46037a692384..48e155ee2e39 100644
--- a/drivers/hid/i2c-hid/i2c-hid.c
+++ b/drivers/hid/i2c-hid/i2c-hid.c
@@ -484,7 +484,7 @@ static void i2c_hid_get_input(struct i2c_hid *ihid)
  return;
  }
 
- if ((ret_size > size) || (ret_size <= 2)) {
+ if ((ret_size > size) || (ret_size < 2)) {
  dev_err(&ihid->client->dev, "%s: incomplete report (%d/%d)\n",
  __func__, size, ret_size);
  return;
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU] [Bionic/OEM-B] [PATCH 0/1] Fix "incomplete report" noise after S3

AceLan Kao
In reply to this post by Kai-Heng Feng
Acked-By: AceLan Kao <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACKed: [PATCH 1/1] HID: i2c-hid: Fix "incomplete report" noise

Aaron Ma
In reply to this post by Kai-Heng Feng
Reply | Threaded
Open this post in threaded view
|

APPLIED[OEM-B]: [SRU] [Bionic/OEM-B] [PATCH 0/1] Fix "incomplete report" noise after S3

AceLan Kao
In reply to this post by Kai-Heng Feng
Applied on oem kernel 4.15.0-1029.34

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [PATCH 1/1] HID: i2c-hid: Fix "incomplete report" noise

Stefan Bader-2
In reply to this post by Kai-Heng Feng
On 12.11.18 03:53, Kai-Heng Feng wrote:

> From: Jason Andryuk <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1802813
>
> Commit ac75a041048b ("HID: i2c-hid: fix size check and type usage") started
> writing messages when the ret_size is <= 2 from i2c_master_recv.  However, my
> device i2c-DLL07D1 returns 2 for a short period of time (~0.5s) after I stop
> moving the pointing stick or touchpad.  It varies, but you get ~50 messages
> each time which spams the log hard.
>
> [  95.925055] i2c_hid i2c-DLL07D1:01: i2c_hid_get_input: incomplete report (83/2)
>
> This has also been observed with a i2c-ALP0017.
>
> [ 1781.266353] i2c_hid i2c-ALP0017:00: i2c_hid_get_input: incomplete report (30/2)
>
> Only print the message when ret_size is totally invalid and less than 2 to cut
> down on the log spam.
>
> Fixes: ac75a041048b ("HID: i2c-hid: fix size check and type usage")
> Reported-by: John Smith <[hidden email]>
> Cc: [hidden email]
> Signed-off-by: Jason Andryuk <[hidden email]>
> Signed-off-by: Jiri Kosina <[hidden email]>
> (cherry picked from commit ef6eaf27274c0351f7059163918f3795da13199c)
> Signed-off-by: Kai-Heng Feng <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>
> ---

I hope there is no other "doh" coming from tha.

>  drivers/hid/i2c-hid/i2c-hid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
> index 46037a692384..48e155ee2e39 100644
> --- a/drivers/hid/i2c-hid/i2c-hid.c
> +++ b/drivers/hid/i2c-hid/i2c-hid.c
> @@ -484,7 +484,7 @@ static void i2c_hid_get_input(struct i2c_hid *ihid)
>   return;
>   }
>  
> - if ((ret_size > size) || (ret_size <= 2)) {
> + if ((ret_size > size) || (ret_size < 2)) {
>   dev_err(&ihid->client->dev, "%s: incomplete report (%d/%d)\n",
>   __func__, size, ret_size);
>   return;
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

NAK[B]: [SRU] [Bionic/OEM-B] [PATCH 0/1] Fix "incomplete report" noise after S3

Kleber Souza
In reply to this post by Kai-Heng Feng
On 11/12/18 3:53 AM, Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1802813
>
> [Impact]
> I2C HID devices may keep spewing out error "i2c_hid_get_input:
> incomplete report (30/2)" after system S3.
>
> [Fix]
> It a regression caused by commit ac75a041048b, backport commmit
> ef6eaf27274c to fix it. Input report length 2 is a valid length.
>
> [Test]
> With the fix the issue can no longer be observed on Alps touchpads.
>
> [Regression Potential]
> None. Input report lenght 2 is valid per spec.
>
> Jason Andryuk (1):
>   HID: i2c-hid: Fix "incomplete report" noise
>
>  drivers/hid/i2c-hid/i2c-hid.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
This patch has already been applied to bionic as part of LP: #1808399
("Bionic update: upstream stable patchset 2018-12-13") so it can be skipped.


Thanks,

Kleber


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team