[SRU] [Bionic] [PATCH 0/1] Fix Ryzen/Raven Ridge USB ports do not work

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU] [Bionic] [PATCH 0/1] Fix Ryzen/Raven Ridge USB ports do not work

Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1756700

[Impact]
USB controller stops working once a USB device gets plugged.

[Fix]
Add a delay for xHC can workaround the issue.

[Test]
Plug a USB device to affected system. USB controller stop working
afterward.
With the patch, the issue is solved.
It's also tested on 4.13 based linux-oem kernel.

[Regression Potential]
Low. Trivial patch which adds a delay. No functional change.

Kai-Heng Feng (1):
  xhci: Fix USB ports for Dell Inspiron 5775

 drivers/usb/host/xhci-pci.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

--
2.17.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU] [Bionic] [PATCH 1/1] xhci: Fix USB ports for Dell Inspiron 5775

Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1756700

The Dell Inspiron 5775 is a Raven Ridge. The Enable Slot command timed
out when a USB device gets plugged:
[ 212.156326] xhci_hcd 0000:03:00.3: Error while assigning device slot ID
[ 212.156340] xhci_hcd 0000:03:00.3: Max number of devices this xHCI host supports is 64.
[ 212.156348] usb usb2-port3: couldn't allocate usb_device

AMD suggests that a delay before xHC suspends can fix the issue.

I can confirm it fixes the issue, so use the suspend delay quirk for
Raven Ridge's xHC.

Cc: [hidden email]
Signed-off-by: Kai-Heng Feng <[hidden email]>
Signed-off-by: Mathias Nyman <[hidden email]>
Signed-off-by: Greg Kroah-Hartman <[hidden email]>
(cherry picked from commit 621faf4f6a181b6e012c1d1865213f36f4159b7f)
Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/usb/host/xhci-pci.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index f68f364c77d5..53f1420064f9 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -122,7 +122,10 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
  if (pdev->vendor == PCI_VENDOR_ID_AMD && usb_amd_find_chipset_info())
  xhci->quirks |= XHCI_AMD_PLL_FIX;
 
- if (pdev->vendor == PCI_VENDOR_ID_AMD && pdev->device == 0x43bb)
+ if (pdev->vendor == PCI_VENDOR_ID_AMD &&
+ (pdev->device == 0x15e0 ||
+ pdev->device == 0x15e1 ||
+ pdev->device == 0x43bb))
  xhci->quirks |= XHCI_SUSPEND_DELAY;
 
  if (pdev->vendor == PCI_VENDOR_ID_AMD)
--
2.17.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU] [Bionic] [PATCH 0/1] Fix Ryzen/Raven Ridge USB ports do not work

Po-Hsu Lin (Sam)
In reply to this post by Kai-Heng Feng
Positive test result, clean cherry pick.
Acked-by: Po-Hsu Lin <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU] [Bionic] [PATCH 0/1] Fix Ryzen/Raven Ridge USB ports do not work

Anthony Wong-2
In reply to this post by Kai-Heng Feng
On Sat, Jun 23, 2018 at 02:50:46AM +0800, Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1756700
>
> [Impact]
> USB controller stops working once a USB device gets plugged.
>
> [Fix]
> Add a delay for xHC can workaround the issue.
>
> [Test]
> Plug a USB device to affected system. USB controller stop working
> afterward.
> With the patch, the issue is solved.
> It's also tested on 4.13 based linux-oem kernel.
>
> [Regression Potential]
> Low. Trivial patch which adds a delay. No functional change.
>
> Kai-Heng Feng (1):
>   xhci: Fix USB ports for Dell Inspiron 5775
>
>  drivers/usb/host/xhci-pci.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

Clean cherry-pick, thanks.

Acked-by: Anthony Wong <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU] [Bionic] [PATCH 0/1] Fix Ryzen/Raven Ridge USB ports do not work

Khaled Elmously
In reply to this post by Kai-Heng Feng
Applied to Bionic

On 2018-06-23 02:50:46 , Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1756700
>
> [Impact]
> USB controller stops working once a USB device gets plugged.
>
> [Fix]
> Add a delay for xHC can workaround the issue.
>
> [Test]
> Plug a USB device to affected system. USB controller stop working
> afterward.
> With the patch, the issue is solved.
> It's also tested on 4.13 based linux-oem kernel.
>
> [Regression Potential]
> Low. Trivial patch which adds a delay. No functional change.
>
> Kai-Heng Feng (1):
>   xhci: Fix USB ports for Dell Inspiron 5775
>
>  drivers/usb/host/xhci-pci.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> --
> 2.17.0
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team