[SRU][Bionic][PATCH 0/1] UBUNTU: SAUCE: Add Lenovo V330 to the ideapad_laptop rfkill blacklist

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][Bionic][PATCH 0/1] UBUNTU: SAUCE: Add Lenovo V330 to the ideapad_laptop rfkill blacklist

Joseph Salisbury-3
BugLink: http://bugs.launchpad.net/bugs/1774636

== SRU Justification ==
The quite new Lenovo V330 is not yet completely supported by the
ideapad_laptop module. Without an explicit rule, this module assumes that
a hardware kill switch for wireless devices exists and thus sometimes boots
up with all devices hard blocked and no way to reenable them at runtime.

This requested patch has been sent upstream, but it is not in mainline as of yet.  
Since this laptop is available now and the bug is a real blocker for
unexperienced users, this patch is being request as SAUCE.

== Fix ==
UBUNTU: SAUCE: Add Lenovo V330 to the ideapad_laptop rfkill blacklist

== Regression Potential ==
Low.  This patch just adds an additon DMI entry.

== Test Case ==
A test kernel was built with this patch and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.

Johannes Wienke (1):
  Add Lenovo V330 to the ideapad_laptop rfkill blacklist

 drivers/platform/x86/ideapad-laptop.c | 7 +++++++
 1 file changed, 7 insertions(+)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][Bionic][PATCH 1/1] UBUNTU: SAUCE: Add Lenovo V330 to the ideapad_laptop rfkill blacklist

Joseph Salisbury-3
From: Johannes Wienke <[hidden email]>

BugLink: http://bugs.launchpad.net/bugs/1774636

This laptop doesn't have a working hardware kill switch and thus the
wifi and bluetooth might become hard blocked without an option to revert
this state at runtime.

Signed-off-by: Johannes Wienke <[hidden email]>
---
 drivers/platform/x86/ideapad-laptop.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index 4c477f4..724baa9 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -1006,6 +1006,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
  },
  },
  {
+ .ident = "Lenovo V330-14IKB",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo V330-14IKB"),
+ },
+ },
+ {
  .ident = "Lenovo V510-15IKB",
  .matches = {
  DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/Cmnt: [SRU][Bionic][PATCH 1/1] UBUNTU: SAUCE: Add Lenovo V330 to the ideapad_laptop rfkill blacklist

Stefan Bader-2
On 08.06.2018 12:55, Joseph Salisbury wrote:
> From: Johannes Wienke <[hidden email]>
>
> BugLink: http://bugs.launchpad.net/bugs/1774636
>
> This laptop doesn't have a working hardware kill switch and thus the
> wifi and bluetooth might become hard blocked without an option to revert
> this state at runtime.
>
> Signed-off-by: Johannes Wienke <[hidden email]>
Signed-off-by: Joseph Salisbury <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>
> ---

Not sure but would/should there not be another s-o-b for forwarding?

-Stefan

>  drivers/platform/x86/ideapad-laptop.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index 4c477f4..724baa9 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -1006,6 +1006,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
>   },
>   },
>   {
> + .ident = "Lenovo V330-14IKB",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo V330-14IKB"),
> + },
> + },
> + {
>   .ident = "Lenovo V510-15IKB",
>   .matches = {
>   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK/cmnt: [SRU][Bionic][PATCH 1/1] UBUNTU: SAUCE: Add Lenovo V330 to the ideapad_laptop rfkill blacklist

Kleber Sacilotto de Souza
In reply to this post by Joseph Salisbury-3
On 06/08/18 12:55, Joseph Salisbury wrote:
> From: Johannes Wienke <[hidden email]>
>
> BugLink: http://bugs.launchpad.net/bugs/1774636
>
> This laptop doesn't have a working hardware kill switch and thus the
> wifi and bluetooth might become hard blocked without an option to revert
> this state at runtime.
>
> Signed-off-by: Johannes Wienke <[hidden email]>

Same comment as Stefan regarding the additional s-o-b.

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

> ---
>  drivers/platform/x86/ideapad-laptop.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index 4c477f4..724baa9 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -1006,6 +1006,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
>   },
>   },
>   {
> + .ident = "Lenovo V330-14IKB",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo V330-14IKB"),
> + },
> + },
> + {
>   .ident = "Lenovo V510-15IKB",
>   .matches = {
>   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: ACK/Cmnt: [SRU][Bionic][PATCH 1/1] UBUNTU: SAUCE: Add Lenovo V330 to the ideapad_laptop rfkill blacklist

Joseph Salisbury-3
In reply to this post by Stefan Bader-2
On 06/08/2018 04:23 PM, Stefan Bader wrote:

> On 08.06.2018 12:55, Joseph Salisbury wrote:
>> From: Johannes Wienke <[hidden email]>
>>
>> BugLink: http://bugs.launchpad.net/bugs/1774636
>>
>> This laptop doesn't have a working hardware kill switch and thus the
>> wifi and bluetooth might become hard blocked without an option to revert
>> this state at runtime.
>>
>> Signed-off-by: Johannes Wienke <[hidden email]>
> Signed-off-by: Joseph Salisbury <[hidden email]>
> Acked-by: Stefan Bader <[hidden email]>
>> ---
> Not sure but would/should there not be another s-o-b for forwarding?
>
> -Stefan
>
>>  drivers/platform/x86/ideapad-laptop.c | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
>> index 4c477f4..724baa9 100644
>> --- a/drivers/platform/x86/ideapad-laptop.c
>> +++ b/drivers/platform/x86/ideapad-laptop.c
>> @@ -1006,6 +1006,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
>>   },
>>   },
>>   {
>> + .ident = "Lenovo V330-14IKB",
>> + .matches = {
>> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>> + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo V330-14IKB"),
>> + },
>> + },
>> + {
>>   .ident = "Lenovo V510-15IKB",
>>   .matches = {
>>   DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>>
>
>
>
Thanks for adding my sob!



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU][Bionic][PATCH 0/1] UBUNTU: SAUCE: Add Lenovo V330 to the ideapad_laptop rfkill blacklist

Khaled Elmously
In reply to this post by Joseph Salisbury-3
Applied to Bionic

On 2018-06-08 15:55:15 , Joseph Salisbury wrote:

> BugLink: http://bugs.launchpad.net/bugs/1774636
>
> == SRU Justification ==
> The quite new Lenovo V330 is not yet completely supported by the
> ideapad_laptop module. Without an explicit rule, this module assumes that
> a hardware kill switch for wireless devices exists and thus sometimes boots
> up with all devices hard blocked and no way to reenable them at runtime.
>
> This requested patch has been sent upstream, but it is not in mainline as of yet.  
> Since this laptop is available now and the bug is a real blocker for
> unexperienced users, this patch is being request as SAUCE.
>
> == Fix ==
> UBUNTU: SAUCE: Add Lenovo V330 to the ideapad_laptop rfkill blacklist
>
> == Regression Potential ==
> Low.  This patch just adds an additon DMI entry.
>
> == Test Case ==
> A test kernel was built with this patch and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
>
> Johannes Wienke (1):
>   Add Lenovo V330 to the ideapad_laptop rfkill blacklist
>
>  drivers/platform/x86/ideapad-laptop.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> --
> 2.7.4
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[U]: [SRU][Bionic][PATCH 1/1] UBUNTU: SAUCE: Add Lenovo V330 to the ideapad_laptop rfkill blacklist

Thadeu Lima de Souza Cascardo-3
In reply to this post by Joseph Salisbury-3
Applied to unstable master branch.

Thanks.
Cascardo.

Applied-to: unstable/master

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team