[SRU][Bionic][PATCH 0/1] fix arm64 ext4 regression

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][Bionic][PATCH 0/1] fix arm64 ext4 regression

Kamal Mostafa-2
BugLink: http://bugs.launchpad.net/bugs/1780137

Fix regression triggered by the stress-ng[*] "chdir" test, with LKML test
patch.

Patch has been tested and verified by Dann Frazier.

LKML discussion:
https://lore.kernel.org/lkml/20180706174324.GA3049@.../

 -Kamal

---

Theodore Y. Ts'o (1):
  UBUNTU: SAUCE: ext4: fix ext4_validate_inode_bitmap: comm stress-ng:
    Corrupt inode bitmap

 fs/ext4/ialloc.c | 3 +++
 1 file changed, 3 insertions(+)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][Bionic][PATCH 1/1] UBUNTU: SAUCE: ext4: fix ext4_validate_inode_bitmap: comm stress-ng: Corrupt inode bitmap

Kamal Mostafa-2
From: "Theodore Y. Ts'o" <[hidden email]>

BugLink: http://bugs.launchpad.net/bugs/1780137

Fix regression triggered by the stress-ng[*] "chdir" test, with LKML test
patch.

Regression observed on some arm64 server platforms:

    EXT4-fs error (device sda1): ext4_validate_inode_bitmap:99: comm stress-ng: Corrupt inode bitmap

Reference: https://lkml.org/lkml/2018/7/7/2

Reported-by: dann frazier <[hidden email]>
Tested-by: dann frazier <[hidden email]>
Fixes: 044e6e3d74a3 ext4: don't update checksum of new initialized bitmaps
Signed-off-by: Kamal Mostafa <[hidden email]>
---
 fs/ext4/ialloc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index 5559313..b5e2cc2 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -91,6 +91,8 @@ static int ext4_validate_inode_bitmap(struct super_block *sb,
  return -EFSCORRUPTED;
 
  ext4_lock_group(sb, block_group);
+ if (buffer_verified(bh))
+ goto verified;
  blk = ext4_inode_bitmap(sb, desc);
  if (!ext4_inode_bitmap_csum_verify(sb, block_group, desc, bh,
    EXT4_INODES_PER_GROUP(sb) / 8)) {
@@ -108,6 +110,7 @@ static int ext4_validate_inode_bitmap(struct super_block *sb,
  return -EFSBADCRC;
  }
  set_buffer_verified(bh);
+verified:
  ext4_unlock_group(sb, block_group);
  return 0;
 }
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][Bionic][PATCH 0/1] fix arm64 ext4 regression

Khalid Elmously
In reply to this post by Kamal Mostafa-2
On 2018-07-10 15:11:30 , Kamal Mostafa wrote:

> BugLink: http://bugs.launchpad.net/bugs/1780137
>
> Fix regression triggered by the stress-ng[*] "chdir" test, with LKML test
> patch.
>
> Patch has been tested and verified by Dann Frazier.
>
> LKML discussion:
> https://lore.kernel.org/lkml/20180706174324.GA3049@.../
>
>  -Kamal
>
> ---
>
> Theodore Y. Ts'o (1):
>   UBUNTU: SAUCE: ext4: fix ext4_validate_inode_bitmap: comm stress-ng:
>     Corrupt inode bitmap
>
>  fs/ext4/ialloc.c | 3 +++
>  1 file changed, 3 insertions(+)
>
Acked-by: Khalid Elmously <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][Bionic][PATCH 1/1] UBUNTU: SAUCE: ext4: fix ext4_validate_inode_bitmap: comm stress-ng: Corrupt inode bitmap

Colin Ian King-2
In reply to this post by Kamal Mostafa-2
On 10/07/18 23:11, Kamal Mostafa wrote:

> From: "Theodore Y. Ts'o" <[hidden email]>
>
> BugLink: http://bugs.launchpad.net/bugs/1780137
>
> Fix regression triggered by the stress-ng[*] "chdir" test, with LKML test
> patch.
>
> Regression observed on some arm64 server platforms:
>
>     EXT4-fs error (device sda1): ext4_validate_inode_bitmap:99: comm stress-ng: Corrupt inode bitmap
>
> Reference: https://lkml.org/lkml/2018/7/7/2
>
> Reported-by: dann frazier <[hidden email]>
> Tested-by: dann frazier <[hidden email]>
> Fixes: 044e6e3d74a3 ext4: don't update checksum of new initialized bitmaps
> Signed-off-by: Kamal Mostafa <[hidden email]>
> ---
>  fs/ext4/ialloc.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
> index 5559313..b5e2cc2 100644
> --- a/fs/ext4/ialloc.c
> +++ b/fs/ext4/ialloc.c
> @@ -91,6 +91,8 @@ static int ext4_validate_inode_bitmap(struct super_block *sb,
>   return -EFSCORRUPTED;
>  
>   ext4_lock_group(sb, block_group);
> + if (buffer_verified(bh))
> + goto verified;
>   blk = ext4_inode_bitmap(sb, desc);
>   if (!ext4_inode_bitmap_csum_verify(sb, block_group, desc, bh,
>     EXT4_INODES_PER_GROUP(sb) / 8)) {
> @@ -108,6 +110,7 @@ static int ext4_validate_inode_bitmap(struct super_block *sb,
>   return -EFSBADCRC;
>   }
>   set_buffer_verified(bh);
> +verified:
>   ext4_unlock_group(sb, block_group);
>   return 0;
>  }
>
Fixes the reported issue, can't argue with that.

Acked-by: Colin Ian King <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][Bionic][PATCH 0/1] fix arm64 ext4 regression

Po-Hsu Lin (Sam)
In reply to this post by Kamal Mostafa-2
Acked-by: Po-Hsu Lin <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU][Bionic][PATCH 0/1] fix arm64 ext4 regression

Kleber Souza
In reply to this post by Kamal Mostafa-2
On 07/11/18 00:11, Kamal Mostafa wrote:

> BugLink: http://bugs.launchpad.net/bugs/1780137
>
> Fix regression triggered by the stress-ng[*] "chdir" test, with LKML test
> patch.
>
> Patch has been tested and verified by Dann Frazier.
>
> LKML discussion:
> https://lore.kernel.org/lkml/20180706174324.GA3049@.../
>
>  -Kamal
>
> ---
>
> Theodore Y. Ts'o (1):
>   UBUNTU: SAUCE: ext4: fix ext4_validate_inode_bitmap: comm stress-ng:
>     Corrupt inode bitmap
>
>  fs/ext4/ialloc.c | 3 +++
>  1 file changed, 3 insertions(+)
>

Applied to bionic/master-next branch.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[C/Unstable]: [SRU][Bionic][PATCH 0/1] fix arm64 ext4 regression

Seth Forshee
In reply to this post by Kamal Mostafa-2
On Tue, Jul 10, 2018 at 03:11:30PM -0700, Kamal Mostafa wrote:
> BugLink: http://bugs.launchpad.net/bugs/1780137
>
> Fix regression triggered by the stress-ng[*] "chdir" test, with LKML test
> patch.
>
> Patch has been tested and verified by Dann Frazier.
>
> LKML discussion:
> https://lore.kernel.org/lkml/20180706174324.GA3049@.../

Applied to cosmic/master-next and unstable/master, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team