[SRU][Bionic][PATCH 0/1] fix uio locking

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][Bionic][PATCH 0/1] fix uio locking

Kamal Mostafa-2
BugLink: https://bugs.launchpad.net/bugs/1843487

Fix a "scheduling while atomic" locking bug in uio.  Original
bug-reporter has verified that this patch resolves the problem.

Weird bit: The fix for this landed in mainline lumped into another
commit -- a revert of a commit that Bionic doesn't actually carry.
This patch for Bionic is a "backport" of that mainline revert,
picking up just that lumped-in part from the revert.

 -Kamal

-----

Xiubo Li (1):
  Revert "uio: use request_threaded_irq instead"

 drivers/uio/uio.c | 3 ---
 1 file changed, 3 deletions(-)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][Bionic][PATCH 1/1] Revert "uio: use request_threaded_irq instead"

Kamal Mostafa-2
From: Xiubo Li <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1843487

Since mutex lock in irq hanler is useless currently, here will
remove it together with it.

This reverts commit 9421e45f5ff3d558cf8b75a8cc0824530caf3453.

Reported-by: [hidden email]
CC: Ahsan Atta <[hidden email]>
Signed-off-by: Xiubo Li <[hidden email]>
Signed-off-by: Greg Kroah-Hartman <[hidden email]>
(backported from commit 3d27c4de8d4fb2d4099ff324671792aa2578c6f9)
[kamal: applied just the mutex removal bit.]
Signed-off-by: Kamal Mostafa <[hidden email]>
---
 drivers/uio/uio.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index c7bc6b8f8d22..fb5c9701b1fb 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -445,13 +445,10 @@ static irqreturn_t uio_interrupt(int irq, void *dev_id)
  struct uio_device *idev = (struct uio_device *)dev_id;
  irqreturn_t ret;
 
- mutex_lock(&idev->info_lock);
-
  ret = idev->info->handler(irq, idev->info);
  if (ret == IRQ_HANDLED)
  uio_event_notify(idev->info);
 
- mutex_unlock(&idev->info_lock);
  return ret;
 }
 
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/Cmnt: [SRU][Bionic][PATCH 1/1] Revert "uio: use request_threaded_irq instead"

Stefan Bader-2
On 31.10.19 17:23, Kamal Mostafa wrote:

> From: Xiubo Li <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1843487
>
> Since mutex lock in irq hanler is useless currently, here will
> remove it together with it.
>
> This reverts commit 9421e45f5ff3d558cf8b75a8cc0824530caf3453.
>
> Reported-by: [hidden email]
> CC: Ahsan Atta <[hidden email]>
> Signed-off-by: Xiubo Li <[hidden email]>
> Signed-off-by: Greg Kroah-Hartman <[hidden email]>
> (backported from commit 3d27c4de8d4fb2d4099ff324671792aa2578c6f9)
> [kamal: applied just the mutex removal bit.]
> Signed-off-by: Kamal Mostafa <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>
> ---

SRU justification in bug report!

>  drivers/uio/uio.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
> index c7bc6b8f8d22..fb5c9701b1fb 100644
> --- a/drivers/uio/uio.c
> +++ b/drivers/uio/uio.c
> @@ -445,13 +445,10 @@ static irqreturn_t uio_interrupt(int irq, void *dev_id)
>   struct uio_device *idev = (struct uio_device *)dev_id;
>   irqreturn_t ret;
>  
> - mutex_lock(&idev->info_lock);
> -
>   ret = idev->info->handler(irq, idev->info);
>   if (ret == IRQ_HANDLED)
>   uio_event_notify(idev->info);
>  
> - mutex_unlock(&idev->info_lock);
>   return ret;
>  }
>  
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][Bionic][PATCH 0/1] fix uio locking

Khaled Elmously
In reply to this post by Kamal Mostafa-2
On 2019-10-31 09:22:59 , Kamal Mostafa wrote:

> BugLink: https://bugs.launchpad.net/bugs/1843487
>
> Fix a "scheduling while atomic" locking bug in uio.  Original
> bug-reporter has verified that this patch resolves the problem.
>
> Weird bit: The fix for this landed in mainline lumped into another
> commit -- a revert of a commit that Bionic doesn't actually carry.
> This patch for Bionic is a "backport" of that mainline revert,
> picking up just that lumped-in part from the revert.
>
>  -Kamal
>
> -----
>
> Xiubo Li (1):
>   Revert "uio: use request_threaded_irq instead"
>
>  drivers/uio/uio.c | 3 ---
>  1 file changed, 3 deletions(-)
>
Acked-by: Khalid Elmously <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU][Bionic][PATCH 0/1] fix uio locking

Khaled Elmously
In reply to this post by Kamal Mostafa-2
On 2019-10-31 09:22:59 , Kamal Mostafa wrote:

> BugLink: https://bugs.launchpad.net/bugs/1843487
>
> Fix a "scheduling while atomic" locking bug in uio.  Original
> bug-reporter has verified that this patch resolves the problem.
>
> Weird bit: The fix for this landed in mainline lumped into another
> commit -- a revert of a commit that Bionic doesn't actually carry.
> This patch for Bionic is a "backport" of that mainline revert,
> picking up just that lumped-in part from the revert.
>
>  -Kamal
>
> -----
>
> Xiubo Li (1):
>   Revert "uio: use request_threaded_irq instead"
>
>  drivers/uio/uio.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> --
> 2.17.1
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team