[SRU][Bionic][PATCH 0/1] nvme: Use admin command effects for admin commands

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][Bionic][PATCH 0/1] nvme: Use admin command effects for admin commands

Joseph Salisbury-3
BugLink: https://bugs.launchpad.net/bugs/1797587

== SRU Justification ==
Dell reports that every time they run a nvme format on an Intel
NVMe drive (whether specifying the secure/crypto erase options or not), the
format apparently works (drive is wiped clean). The drive's admin queue
(queue 0) times out, making the nvme device driver flag an error and reset the controller.

This bug is fixed by commit 62843c2e4226, which is in mainline as of
v4.17-rc1.

== Fix ==
62843c2e4226 ("nvme: Use admin command effects for admin commands")

== Regression Potential ==
Low.  Limited to nvme driver.

== Test Case ==
A test kernel was built with this patch and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.

Keith Busch (1):
  nvme: Use admin command effects for admin commands

 drivers/nvme/host/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][Bionic][PATCH 1/1] nvme: Use admin command effects for admin commands

Joseph Salisbury-3
From: Keith Busch <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1797587

Signed-off-by: Keith Busch <[hidden email]>
Signed-off-by: Jens Axboe <[hidden email]>
(cherry picked from commit 62843c2e4226057c83f520c74fe9c81a1891c331)
Signed-off-by: Joseph Salisbury <[hidden email]>
---
 drivers/nvme/host/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index c5dfca8..42f6202 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1054,7 +1054,7 @@ static u32 nvme_passthru_start(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
  }
 
  if (ctrl->effects)
- effects = le32_to_cpu(ctrl->effects->iocs[opcode]);
+ effects = le32_to_cpu(ctrl->effects->acs[opcode]);
  else
  effects = nvme_known_admin_effects(opcode);
 
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [SRU][Bionic][PATCH 1/1] nvme: Use admin command effects for admin commands

Colin King
On 08/01/2019 19:57, Joseph Salisbury wrote:
> From: Keith Busch <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1797587
>

The patch is missing the following text from the commit message:

"nvme: Use admin command effects for admin commands"

> Signed-off-by: Keith Busch <[hidden email]>
> Signed-off-by: Jens Axboe <[hidden email]>
> (cherry picked from commit 62843c2e4226057c83f520c74fe9c81a1891c331)
> Signed-off-by: Joseph Salisbury <[hidden email]>
> ---
>  drivers/nvme/host/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index c5dfca8..42f6202 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -1054,7 +1054,7 @@ static u32 nvme_passthru_start(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
>   }
>  
>   if (ctrl->effects)
> - effects = le32_to_cpu(ctrl->effects->iocs[opcode]);
> + effects = le32_to_cpu(ctrl->effects->acs[opcode]);
>   else
>   effects = nvme_known_admin_effects(opcode);
>  
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/cmnt: [SRU][Bionic][PATCH 1/1] nvme: Use admin command effects for admin commands

Kleber Souza
In reply to this post by Joseph Salisbury-3
On 1/8/19 8:57 PM, Joseph Salisbury wrote:
> From: Keith Busch <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1797587
>
> Signed-off-by: Keith Busch <[hidden email]>
> Signed-off-by: Jens Axboe <[hidden email]>
> (cherry picked from commit 62843c2e4226057c83f520c74fe9c81a1891c331)
> Signed-off-by: Joseph Salisbury <[hidden email]>

The commit doesn't really have a message apart from the s-o-b's, the
missing line pointed out by Colin is actually the subject line, so the
patch looks fine:

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

> ---
>  drivers/nvme/host/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index c5dfca8..42f6202 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -1054,7 +1054,7 @@ static u32 nvme_passthru_start(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
>   }
>  
>   if (ctrl->effects)
> - effects = le32_to_cpu(ctrl->effects->iocs[opcode]);
> + effects = le32_to_cpu(ctrl->effects->acs[opcode]);
>   else
>   effects = nvme_known_admin_effects(opcode);
>  



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/Cmnt: [SRU][Bionic][PATCH 1/1] nvme: Use admin command effects for admin commands

Stefan Bader-2
In reply to this post by Joseph Salisbury-3
On 08.01.19 20:57, Joseph Salisbury wrote:
> From: Keith Busch <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1797587
>
> Signed-off-by: Keith Busch <[hidden email]>
> Signed-off-by: Jens Axboe <[hidden email]>
> (cherry picked from commit 62843c2e4226057c83f520c74fe9c81a1891c331)
> Signed-off-by: Joseph Salisbury <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>
> ---

As Kleber already pouinted out there is nothing but the subject and s-o-b in the
original patch. Does not make it much  nicer to read but meh.

>  drivers/nvme/host/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index c5dfca8..42f6202 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -1054,7 +1054,7 @@ static u32 nvme_passthru_start(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
>   }
>  
>   if (ctrl->effects)
> - effects = le32_to_cpu(ctrl->effects->iocs[opcode]);
> + effects = le32_to_cpu(ctrl->effects->acs[opcode]);
>   else
>   effects = nvme_known_admin_effects(opcode);
>  
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU][Bionic][PATCH 0/1] nvme: Use admin command effects for admin commands

Khaled Elmously
In reply to this post by Joseph Salisbury-3
On 2019-01-08 14:57:49 , Joseph Salisbury wrote:

> BugLink: https://bugs.launchpad.net/bugs/1797587
>
> == SRU Justification ==
> Dell reports that every time they run a nvme format on an Intel
> NVMe drive (whether specifying the secure/crypto erase options or not), the
> format apparently works (drive is wiped clean). The drive's admin queue
> (queue 0) times out, making the nvme device driver flag an error and reset the controller.
>
> This bug is fixed by commit 62843c2e4226, which is in mainline as of
> v4.17-rc1.
>
> == Fix ==
> 62843c2e4226 ("nvme: Use admin command effects for admin commands")
>
> == Regression Potential ==
> Low.  Limited to nvme driver.
>
> == Test Case ==
> A test kernel was built with this patch and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
>
> Keith Busch (1):
>   nvme: Use admin command effects for admin commands
>
>  drivers/nvme/host/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.7.4
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team