[SRU][Bionic][PATCH 0/1] scsi: aacraid: Correct hba_send to include iu_type

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][Bionic][PATCH 0/1] scsi: aacraid: Correct hba_send to include iu_type

Joseph Salisbury-3
BugLink: http://bugs.launchpad.net/bugs/1770095

== SRU Justification ==
A commit introduced in mainline v4.14-rc1 to aacraid
(b60710ec7d7ab1ca277b458338563ac21b393906) introduced a regression whereby a
panic may happen under certain recovery situations.

This regression is fixed by linux-next commit  7d3af7d96af7.


== Fix ==
7d3af7d96af7 ("scsi: aacraid: Correct hba_send to include iu_type")

== Regression Potential ==
Low.  This patch fixes a current regression.  It was cc'd to upstream
stable, so it has had additonal upstream review.

== Test Case ==
A test kernel was built with this patch and tested by the original bug reporter.
The bug reporter states the test kernel resolved the bug.

Dave Carroll (1):
  scsi: aacraid: Correct hba_send to include iu_type

 drivers/scsi/aacraid/commsup.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][Bionic][PATCH 1/1] scsi: aacraid: Correct hba_send to include iu_type

Joseph Salisbury-3
From: Dave Carroll <[hidden email]>

BugLink: http://bugs.launchpad.net/bugs/1770095

commit b60710ec7d7a ("scsi: aacraid: enable sending of TMFs from
aac_hba_send()") allows aac_hba_send() to send scsi commands, and TMF
requests, but the existing code only updates the iu_type for scsi
commands. For TMF requests we are sending an unknown iu_type to
firmware, which causes a fault.

Include iu_type prior to determining the validity of the command

Reported-by: Noah Misner <[hidden email]>
Fixes: b60710ec7d7ab ("aacraid: enable sending of TMFs from aac_hba_send()")
Fixes: 423400e64d377 ("aacraid: Include HBA direct interface")
Tested-by: Noah Misner <[hidden email]>
cc: [hidden email]
Signed-off-by: Dave Carroll <[hidden email]>
Reviewed-by: Raghava Aditya Renukunta <[hidden email]>
Reviewed-by: Brian King <[hidden email]>
Signed-off-by: Martin K. Petersen <[hidden email]>
(cherry picked from linux-next commit 7d3af7d96af7b9f51e1ef67b6f4725f545737da2)
Signed-off-by: Joseph Salisbury <[hidden email]>

---
 drivers/scsi/aacraid/commsup.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
index 84858d5..d9f22296 100644
--- a/drivers/scsi/aacraid/commsup.c
+++ b/drivers/scsi/aacraid/commsup.c
@@ -724,6 +724,8 @@ int aac_hba_send(u8 command, struct fib *fibptr, fib_callback callback,
  int wait;
  unsigned long flags = 0;
  unsigned long mflags = 0;
+ struct aac_hba_cmd_req *hbacmd = (struct aac_hba_cmd_req *)
+ fibptr->hw_fib_va;
 
  fibptr->flags = (FIB_CONTEXT_FLAG | FIB_CONTEXT_FLAG_NATIVE_HBA);
  if (callback) {
@@ -734,11 +736,9 @@ int aac_hba_send(u8 command, struct fib *fibptr, fib_callback callback,
  wait = 1;
 
 
- if (command == HBA_IU_TYPE_SCSI_CMD_REQ) {
- struct aac_hba_cmd_req *hbacmd =
- (struct aac_hba_cmd_req *)fibptr->hw_fib_va;
+ hbacmd->iu_type = command;
 
- hbacmd->iu_type = command;
+ if (command == HBA_IU_TYPE_SCSI_CMD_REQ) {
  /* bit1 of request_id must be 0 */
  hbacmd->request_id =
  cpu_to_le32((((u32)(fibptr - dev->fibs)) << 2) + 1);
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][Bionic][PATCH 1/1] scsi: aacraid: Correct hba_send to include iu_type

Stefan Bader-2
On 13.06.2018 17:21, Joseph Salisbury wrote:

> From: Dave Carroll <[hidden email]>
>
> BugLink: http://bugs.launchpad.net/bugs/1770095
>
> commit b60710ec7d7a ("scsi: aacraid: enable sending of TMFs from
> aac_hba_send()") allows aac_hba_send() to send scsi commands, and TMF
> requests, but the existing code only updates the iu_type for scsi
> commands. For TMF requests we are sending an unknown iu_type to
> firmware, which causes a fault.
>
> Include iu_type prior to determining the validity of the command
>
> Reported-by: Noah Misner <[hidden email]>
> Fixes: b60710ec7d7ab ("aacraid: enable sending of TMFs from aac_hba_send()")
> Fixes: 423400e64d377 ("aacraid: Include HBA direct interface")
> Tested-by: Noah Misner <[hidden email]>
> cc: [hidden email]
> Signed-off-by: Dave Carroll <[hidden email]>
> Reviewed-by: Raghava Aditya Renukunta <[hidden email]>
> Reviewed-by: Brian King <[hidden email]>
> Signed-off-by: Martin K. Petersen <[hidden email]>
> (cherry picked from linux-next commit 7d3af7d96af7b9f51e1ef67b6f4725f545737da2)
> Signed-off-by: Joseph Salisbury <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>

>
> ---
>  drivers/scsi/aacraid/commsup.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/aacraid/commsup.c b/drivers/scsi/aacraid/commsup.c
> index 84858d5..d9f22296 100644
> --- a/drivers/scsi/aacraid/commsup.c
> +++ b/drivers/scsi/aacraid/commsup.c
> @@ -724,6 +724,8 @@ int aac_hba_send(u8 command, struct fib *fibptr, fib_callback callback,
>   int wait;
>   unsigned long flags = 0;
>   unsigned long mflags = 0;
> + struct aac_hba_cmd_req *hbacmd = (struct aac_hba_cmd_req *)
> + fibptr->hw_fib_va;
>  
>   fibptr->flags = (FIB_CONTEXT_FLAG | FIB_CONTEXT_FLAG_NATIVE_HBA);
>   if (callback) {
> @@ -734,11 +736,9 @@ int aac_hba_send(u8 command, struct fib *fibptr, fib_callback callback,
>   wait = 1;
>  
>  
> - if (command == HBA_IU_TYPE_SCSI_CMD_REQ) {
> - struct aac_hba_cmd_req *hbacmd =
> - (struct aac_hba_cmd_req *)fibptr->hw_fib_va;
> + hbacmd->iu_type = command;
>  
> - hbacmd->iu_type = command;
> + if (command == HBA_IU_TYPE_SCSI_CMD_REQ) {
>   /* bit1 of request_id must be 0 */
>   hbacmd->request_id =
>   cpu_to_le32((((u32)(fibptr - dev->fibs)) << 2) + 1);
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][Bionic][PATCH 0/1] scsi: aacraid: Correct hba_send to include iu_type

Khalid Elmously
In reply to this post by Joseph Salisbury-3
On 2018-06-13 11:21:08 , Joseph Salisbury wrote:

> BugLink: http://bugs.launchpad.net/bugs/1770095
>
> == SRU Justification ==
> A commit introduced in mainline v4.14-rc1 to aacraid
> (b60710ec7d7ab1ca277b458338563ac21b393906) introduced a regression whereby a
> panic may happen under certain recovery situations.
>
> This regression is fixed by linux-next commit  7d3af7d96af7.
>
>
> == Fix ==
> 7d3af7d96af7 ("scsi: aacraid: Correct hba_send to include iu_type")
>
> == Regression Potential ==
> Low.  This patch fixes a current regression.  It was cc'd to upstream
> stable, so it has had additonal upstream review.
>
> == Test Case ==
> A test kernel was built with this patch and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
>
> Dave Carroll (1):
>   scsi: aacraid: Correct hba_send to include iu_type
>
>  drivers/scsi/aacraid/commsup.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
Acked-by: Khalid Elmously <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU][Bionic][PATCH 0/1] scsi: aacraid: Correct hba_send to include iu_type

Khalid Elmously
In reply to this post by Joseph Salisbury-3
Applied to Bionic

On 2018-06-13 11:21:08 , Joseph Salisbury wrote:

> BugLink: http://bugs.launchpad.net/bugs/1770095
>
> == SRU Justification ==
> A commit introduced in mainline v4.14-rc1 to aacraid
> (b60710ec7d7ab1ca277b458338563ac21b393906) introduced a regression whereby a
> panic may happen under certain recovery situations.
>
> This regression is fixed by linux-next commit  7d3af7d96af7.
>
>
> == Fix ==
> 7d3af7d96af7 ("scsi: aacraid: Correct hba_send to include iu_type")
>
> == Regression Potential ==
> Low.  This patch fixes a current regression.  It was cc'd to upstream
> stable, so it has had additonal upstream review.
>
> == Test Case ==
> A test kernel was built with this patch and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
>
> Dave Carroll (1):
>   scsi: aacraid: Correct hba_send to include iu_type
>
>  drivers/scsi/aacraid/commsup.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> --
> 2.7.4
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

NAK: [Cosmic][PATCH 0/1] scsi: aacraid: Correct hba_send to include iu_type

Seth Forshee
In reply to this post by Joseph Salisbury-3
On Fri, Jul 06, 2018 at 12:31:24PM -0400, Joseph Salisbury wrote:

> BugLink: http://bugs.launchpad.net/bugs/1770095
>
> == SRU Justification ==
> A commit introduced in mainline v4.14-rc1 to aacraid
> (b60710ec7d7ab1ca277b458338563ac21b393906) introduced a regression whereby a
> panic may happen under certain recovery situations.
>
> This regression is fixed by linux-next commit  7d3af7d96af7.
>
> This fix has already been SRU'd to Bionic, but is also needed in
> unstable.

The commit was merged in v4.17-rc6 ... cosmic/master-next is on v4.17.5
and unstable/master on 4.18-rc4, so both already have this commit.

> == Fix ==
> 7d3af7d96af7 ("scsi: aacraid: Correct hba_send to include iu_type")
>
> == Regression Potential ==
> Low.  This patch fixes a current regression.  It was cc'd to upstream
> stable, so it has had additonal upstream review.
>
> == Test Case ==
> A test kernel was built with this patch and tested by the original bug reporter.
> The bug reporter states the test kernel resolved the bug.
>
> Dave Carroll (1):
>   scsi: aacraid: Correct hba_send to include iu_type
>
>  drivers/scsi/aacraid/commsup.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> --
> 2.7.4
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team