[SRU] [Bionic] [PATCH 0/4] Keyboard backlight sysfs sometimes is missing on Dell laptops

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU] [Bionic] [PATCH 0/4] Keyboard backlight sysfs sometimes is missing on Dell laptops

Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1797304

[Impact]
When the keyboard backlight sysfs is missing, userspace does not know
the current keyboard backlight brightness.

[Fix]
There's a loading order race condition, between the dell-smbios and its
backends, dell-smbios-{smm,wmi}.
Build them as one module can solve the issue.

The last patch is what we want, but pulls the entire series as a whole.

[Test]
The backlight sysfs always exists with the patch. Userspace now knows
the current keyboard backlight brightness.

[Regression Potential]
Low. No functional change, as it simply links the modules together.
Limits to Dell machines.

Kai-Heng Feng (1):
  UBUNTU: [Config] CONFIG_DELL_SMBIOS_SMM=y, CONFIG_DELL_SMBIOS_WMI=y

Mario Limonciello (3):
  platform/x86: dell-smbios: Correct some style warnings
  platform/x86: dell-smbios: Rename dell-smbios source to
    dell-smbios-base
  platform/x86: dell-smbios: Link all dell-smbios-* modules together

 debian.master/config/config.common.ubuntu     |  4 +--
 drivers/platform/x86/Kconfig                  | 15 ++++++----
 drivers/platform/x86/Makefile                 |  5 ++--
 .../x86/{dell-smbios.c => dell-smbios-base.c} | 29 ++++++++++++++++---
 drivers/platform/x86/dell-smbios-smm.c        | 18 +++---------
 drivers/platform/x86/dell-smbios-wmi.c        | 14 +++------
 drivers/platform/x86/dell-smbios.h            | 27 ++++++++++++++++-
 7 files changed, 74 insertions(+), 38 deletions(-)
 rename drivers/platform/x86/{dell-smbios.c => dell-smbios-base.c} (96%)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/4] platform/x86: dell-smbios: Correct some style warnings

Kai-Heng Feng
From: Mario Limonciello <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1797304

WARNING: function definition argument 'struct calling_interface_buffer *'
should also have an identifier name
+       int (*call_fn)(struct calling_interface_buffer *);

WARNING: Block comments use * on subsequent lines
+       /* 4 bytes of table header, plus 7 bytes of Dell header,
        plus at least
+          6 bytes of entry */

WARNING: Block comments use a trailing */ on a separate line
+          6 bytes of entry */

Signed-off-by: Mario Limonciello <[hidden email]>
Signed-off-by: Darren Hart (VMware) <[hidden email]>
(cherry picked from commit b53539625e7fb62880af0599202b8cf06efb94a0)
Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/platform/x86/dell-smbios.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c
index 2ad2855d1cd3..30dc65cb90d6 100644
--- a/drivers/platform/x86/dell-smbios.c
+++ b/drivers/platform/x86/dell-smbios.c
@@ -36,7 +36,7 @@ static DEFINE_MUTEX(smbios_mutex);
 struct smbios_device {
  struct list_head list;
  struct device *device;
- int (*call_fn)(struct calling_interface_buffer *);
+ int (*call_fn)(struct calling_interface_buffer *arg);
 };
 
 struct smbios_call {
@@ -352,8 +352,10 @@ static void __init parse_da_table(const struct dmi_header *dm)
  struct calling_interface_structure *table =
  container_of(dm, struct calling_interface_structure, header);
 
- /* 4 bytes of table header, plus 7 bytes of Dell header, plus at least
-   6 bytes of entry */
+ /*
+ * 4 bytes of table header, plus 7 bytes of Dell header
+ * plus at least 6 bytes of entry
+ */
 
  if (dm->length < 17)
  return;
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 2/4] platform/x86: dell-smbios: Rename dell-smbios source to dell-smbios-base

Kai-Heng Feng
In reply to this post by Kai-Heng Feng
From: Mario Limonciello <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1797304

This is being done to faciliate a later change to link all the dell-smbios
drivers together.

Signed-off-by: Mario Limonciello <[hidden email]>
Signed-off-by: Darren Hart (VMware) <[hidden email]>
(cherry picked from commit 94f77cb16838065cdde514c97284481705c43200)
Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/platform/x86/Makefile                              | 1 +
 drivers/platform/x86/{dell-smbios.c => dell-smbios-base.c} | 0
 2 files changed, 1 insertion(+)
 rename drivers/platform/x86/{dell-smbios.c => dell-smbios-base.c} (100%)

diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile
index 85329fd26afd..06cb4070ff92 100644
--- a/drivers/platform/x86/Makefile
+++ b/drivers/platform/x86/Makefile
@@ -13,6 +13,7 @@ obj-$(CONFIG_MSI_LAPTOP) += msi-laptop.o
 obj-$(CONFIG_ACPI_CMPC) += classmate-laptop.o
 obj-$(CONFIG_COMPAL_LAPTOP) += compal-laptop.o
 obj-$(CONFIG_DELL_SMBIOS) += dell-smbios.o
+dell-smbios-objs := dell-smbios-base.o
 obj-$(CONFIG_DELL_SMBIOS_WMI) += dell-smbios-wmi.o
 obj-$(CONFIG_DELL_SMBIOS_SMM) += dell-smbios-smm.o
 obj-$(CONFIG_DELL_LAPTOP) += dell-laptop.o
diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios-base.c
similarity index 100%
rename from drivers/platform/x86/dell-smbios.c
rename to drivers/platform/x86/dell-smbios-base.c
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 3/4] platform/x86: dell-smbios: Link all dell-smbios-* modules together

Kai-Heng Feng
In reply to this post by Kai-Heng Feng
From: Mario Limonciello <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1797304

Some race conditions were raised due to dell-smbios and its backends
not being ready by the time that a consumer would call one of the
exported methods.

To avoid this problem, guarantee that all initialization has been
done by linking them all together and running init for them all.

As part of this change the Kconfig needs to be adjusted so that
CONFIG_DELL_SMBIOS_SMM and CONFIG_DELL_SMBIOS_WMI are boolean
rather than modules.

CONFIG_DELL_SMBIOS is a visually selectable option again and both
CONFIG_DELL_SMBIOS_WMI and CONFIG_DELL_SMBIOS_SMM are optional.

Signed-off-by: Mario Limonciello <[hidden email]>
[dvhart: Update prompt and help text for DELL_SMBIOS_* backends]
Signed-off-by: Darren Hart (VMware) <[hidden email]>
(cherry picked from commit 25d47027e1003546bfd8964b4423cb39bc2d53e9)
Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/platform/x86/Kconfig            | 15 +++++++++-----
 drivers/platform/x86/Makefile           |  4 ++--
 drivers/platform/x86/dell-smbios-base.c | 21 ++++++++++++++++++-
 drivers/platform/x86/dell-smbios-smm.c  | 18 ++++-------------
 drivers/platform/x86/dell-smbios-wmi.c  | 14 ++++---------
 drivers/platform/x86/dell-smbios.h      | 27 ++++++++++++++++++++++++-
 6 files changed, 66 insertions(+), 33 deletions(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 4e43987da523..da435a741986 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -92,10 +92,15 @@ config ASUS_LAPTOP
   If you have an ACPI-compatible ASUS laptop, say Y or M here.
 
 config DELL_SMBIOS
- tristate
+ tristate "Dell SMBIOS driver"
+ ---help---
+ This provides support for the Dell SMBIOS calling interface.
+ If you have a Dell computer you should enable this option.
+
+ Be sure to select at least one backend for it to work properly.
 
 config DELL_SMBIOS_WMI
- tristate "Dell SMBIOS calling interface (WMI implementation)"
+ bool "Dell SMBIOS driver WMI backend"
  depends on ACPI_WMI
  select DELL_WMI_DESCRIPTOR
  select DELL_SMBIOS
@@ -103,19 +108,19 @@ config DELL_SMBIOS_WMI
  This provides an implementation for the Dell SMBIOS calling interface
  communicated over ACPI-WMI.
 
- If you have a Dell computer from >2007 you should say Y or M here.
+ If you have a Dell computer from >2007 you should say Y here.
  If you aren't sure and this module doesn't work for your computer
  it just won't load.
 
 config DELL_SMBIOS_SMM
- tristate "Dell SMBIOS calling interface (SMM implementation)"
+ bool "Dell SMBIOS driver SMM backend"
  depends on DCDBAS
  select DELL_SMBIOS
  ---help---
  This provides an implementation for the Dell SMBIOS calling interface
  communicated over SMI/SMM.
 
- If you have a Dell computer from <=2017 you should say Y or M here.
+ If you have a Dell computer from <=2017 you should say Y here.
  If you aren't sure and this module doesn't work for your computer
  it just won't load.
 
diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile
index 06cb4070ff92..8cb9fb7cbe6d 100644
--- a/drivers/platform/x86/Makefile
+++ b/drivers/platform/x86/Makefile
@@ -14,8 +14,8 @@ obj-$(CONFIG_ACPI_CMPC) += classmate-laptop.o
 obj-$(CONFIG_COMPAL_LAPTOP) += compal-laptop.o
 obj-$(CONFIG_DELL_SMBIOS) += dell-smbios.o
 dell-smbios-objs := dell-smbios-base.o
-obj-$(CONFIG_DELL_SMBIOS_WMI) += dell-smbios-wmi.o
-obj-$(CONFIG_DELL_SMBIOS_SMM) += dell-smbios-smm.o
+dell-smbios-$(CONFIG_DELL_SMBIOS_WMI) += dell-smbios-wmi.o
+dell-smbios-$(CONFIG_DELL_SMBIOS_SMM) += dell-smbios-smm.o
 obj-$(CONFIG_DELL_LAPTOP) += dell-laptop.o
 obj-$(CONFIG_DELL_WMI) += dell-wmi.o
 obj-$(CONFIG_DELL_WMI_DESCRIPTOR) += dell-wmi-descriptor.o
diff --git a/drivers/platform/x86/dell-smbios-base.c b/drivers/platform/x86/dell-smbios-base.c
index 30dc65cb90d6..db508e7411ab 100644
--- a/drivers/platform/x86/dell-smbios-base.c
+++ b/drivers/platform/x86/dell-smbios-base.c
@@ -556,7 +556,7 @@ static void free_group(struct platform_device *pdev)
 static int __init dell_smbios_init(void)
 {
  const struct dmi_device *valid;
- int ret;
+ int ret, wmi, smm;
 
  valid = dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Dell System", NULL);
  if (!valid) {
@@ -591,8 +591,24 @@ static int __init dell_smbios_init(void)
  if (ret)
  goto fail_create_group;
 
+ /* register backends */
+ wmi = init_dell_smbios_wmi();
+ if (wmi)
+ pr_debug("Failed to initialize WMI backend: %d\n", wmi);
+ smm = init_dell_smbios_smm();
+ if (smm)
+ pr_debug("Failed to initialize SMM backend: %d\n", smm);
+ if (wmi && smm) {
+ pr_err("No SMBIOS backends available (wmi: %d, smm: %d)\n",
+ wmi, smm);
+ goto fail_sysfs;
+ }
+
  return 0;
 
+fail_sysfs:
+ free_group(platform_device);
+
 fail_create_group:
  platform_device_del(platform_device);
 
@@ -609,6 +625,8 @@ static int __init dell_smbios_init(void)
 
 static void __exit dell_smbios_exit(void)
 {
+ exit_dell_smbios_wmi();
+ exit_dell_smbios_smm();
  mutex_lock(&smbios_mutex);
  if (platform_device) {
  free_group(platform_device);
@@ -625,5 +643,6 @@ module_exit(dell_smbios_exit);
 MODULE_AUTHOR("Matthew Garrett <[hidden email]>");
 MODULE_AUTHOR("Gabriele Mazzotta <[hidden email]>");
 MODULE_AUTHOR("Pali Rohár <[hidden email]>");
+MODULE_AUTHOR("Mario Limonciello <[hidden email]>");
 MODULE_DESCRIPTION("Common functions for kernel modules using Dell SMBIOS");
 MODULE_LICENSE("GPL");
diff --git a/drivers/platform/x86/dell-smbios-smm.c b/drivers/platform/x86/dell-smbios-smm.c
index 89f65c4651a0..e9e9da556318 100644
--- a/drivers/platform/x86/dell-smbios-smm.c
+++ b/drivers/platform/x86/dell-smbios-smm.c
@@ -58,7 +58,7 @@ static const struct dmi_system_id dell_device_table[] __initconst = {
 };
 MODULE_DEVICE_TABLE(dmi, dell_device_table);
 
-static void __init parse_da_table(const struct dmi_header *dm)
+static void parse_da_table(const struct dmi_header *dm)
 {
  struct calling_interface_structure *table =
  container_of(dm, struct calling_interface_structure, header);
@@ -73,7 +73,7 @@ static void __init parse_da_table(const struct dmi_header *dm)
  da_command_code = table->cmdIOCode;
 }
 
-static void __init find_cmd_address(const struct dmi_header *dm, void *dummy)
+static void find_cmd_address(const struct dmi_header *dm, void *dummy)
 {
  switch (dm->type) {
  case 0xda: /* Calling interface */
@@ -128,7 +128,7 @@ static bool test_wsmt_enabled(void)
  return false;
 }
 
-static int __init dell_smbios_smm_init(void)
+int init_dell_smbios_smm(void)
 {
  int ret;
  /*
@@ -176,7 +176,7 @@ static int __init dell_smbios_smm_init(void)
  return ret;
 }
 
-static void __exit dell_smbios_smm_exit(void)
+void exit_dell_smbios_smm(void)
 {
  if (platform_device) {
  dell_smbios_unregister_device(&platform_device->dev);
@@ -184,13 +184,3 @@ static void __exit dell_smbios_smm_exit(void)
  free_page((unsigned long)buffer);
  }
 }
-
-subsys_initcall(dell_smbios_smm_init);
-module_exit(dell_smbios_smm_exit);
-
-MODULE_AUTHOR("Matthew Garrett <[hidden email]>");
-MODULE_AUTHOR("Gabriele Mazzotta <[hidden email]>");
-MODULE_AUTHOR("Pali Rohár <[hidden email]>");
-MODULE_AUTHOR("Mario Limonciello <[hidden email]>");
-MODULE_DESCRIPTION("Dell SMBIOS communications over SMI");
-MODULE_LICENSE("GPL");
diff --git a/drivers/platform/x86/dell-smbios-wmi.c b/drivers/platform/x86/dell-smbios-wmi.c
index 609557aa5868..fbefedb1c172 100644
--- a/drivers/platform/x86/dell-smbios-wmi.c
+++ b/drivers/platform/x86/dell-smbios-wmi.c
@@ -228,7 +228,7 @@ static const struct wmi_device_id dell_smbios_wmi_id_table[] = {
  { },
 };
 
-static void __init parse_b1_table(const struct dmi_header *dm)
+static void parse_b1_table(const struct dmi_header *dm)
 {
  struct misc_bios_flags_structure *flags =
  container_of(dm, struct misc_bios_flags_structure, header);
@@ -242,7 +242,7 @@ static void __init parse_b1_table(const struct dmi_header *dm)
  wmi_supported = 1;
 }
 
-static void __init find_b1(const struct dmi_header *dm, void *dummy)
+static void find_b1(const struct dmi_header *dm, void *dummy)
 {
  switch (dm->type) {
  case 0xb1: /* misc bios flags */
@@ -261,7 +261,7 @@ static struct wmi_driver dell_smbios_wmi_driver = {
  .filter_callback = dell_smbios_wmi_filter,
 };
 
-static int __init init_dell_smbios_wmi(void)
+int init_dell_smbios_wmi(void)
 {
  dmi_walk(find_b1, NULL);
 
@@ -271,15 +271,9 @@ static int __init init_dell_smbios_wmi(void)
  return wmi_driver_register(&dell_smbios_wmi_driver);
 }
 
-static void __exit exit_dell_smbios_wmi(void)
+void exit_dell_smbios_wmi(void)
 {
  wmi_driver_unregister(&dell_smbios_wmi_driver);
 }
 
-module_init(init_dell_smbios_wmi);
-module_exit(exit_dell_smbios_wmi);
-
 MODULE_ALIAS("wmi:" DELL_WMI_SMBIOS_GUID);
-MODULE_AUTHOR("Mario Limonciello <[hidden email]>");
-MODULE_DESCRIPTION("Dell SMBIOS communications over WMI");
-MODULE_LICENSE("GPL");
diff --git a/drivers/platform/x86/dell-smbios.h b/drivers/platform/x86/dell-smbios.h
index 138d478d9adc..d8adaf959740 100644
--- a/drivers/platform/x86/dell-smbios.h
+++ b/drivers/platform/x86/dell-smbios.h
@@ -75,4 +75,29 @@ int dell_laptop_register_notifier(struct notifier_block *nb);
 int dell_laptop_unregister_notifier(struct notifier_block *nb);
 void dell_laptop_call_notifier(unsigned long action, void *data);
 
-#endif
+/* for the supported backends */
+#ifdef CONFIG_DELL_SMBIOS_WMI
+int init_dell_smbios_wmi(void);
+void exit_dell_smbios_wmi(void);
+#else /* CONFIG_DELL_SMBIOS_WMI */
+static inline int init_dell_smbios_wmi(void)
+{
+ return -ENODEV;
+}
+static inline void exit_dell_smbios_wmi(void)
+{}
+#endif /* CONFIG_DELL_SMBIOS_WMI */
+
+#ifdef CONFIG_DELL_SMBIOS_SMM
+int init_dell_smbios_smm(void);
+void exit_dell_smbios_smm(void);
+#else /* CONFIG_DELL_SMBIOS_SMM */
+static inline int init_dell_smbios_smm(void)
+{
+ return -ENODEV;
+}
+static inline void exit_dell_smbios_smm(void)
+{}
+#endif /* CONFIG_DELL_SMBIOS_SMM */
+
+#endif /* _DELL_SMBIOS_H_ */
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 4/4] UBUNTU: [Config] CONFIG_DELL_SMBIOS_SMM=y, CONFIG_DELL_SMBIOS_WMI=y

Kai-Heng Feng
In reply to this post by Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1797304

Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 debian.master/config/config.common.ubuntu | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index 49e10e43ebeb..d3aee2bb6d85 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -2120,8 +2120,8 @@ CONFIG_DELL_LAPTOP=m
 CONFIG_DELL_RBTN=m
 CONFIG_DELL_RBU=m
 CONFIG_DELL_SMBIOS=m
-CONFIG_DELL_SMBIOS_SMM=m
-CONFIG_DELL_SMBIOS_WMI=m
+CONFIG_DELL_SMBIOS_SMM=y
+CONFIG_DELL_SMBIOS_WMI=y
 CONFIG_DELL_SMO8800=m
 CONFIG_DELL_UART_BACKLIGHT=m
 CONFIG_DELL_WMI=m
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU] [Bionic] [PATCH 0/4] Keyboard backlight sysfs sometimes is missing on Dell laptops

Khaled Elmously
In reply to this post by Kai-Heng Feng
On 2018-10-11 13:37:04 , Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1797304
>
> [Impact]
> When the keyboard backlight sysfs is missing, userspace does not know
> the current keyboard backlight brightness.
>
> [Fix]
> There's a loading order race condition, between the dell-smbios and its
> backends, dell-smbios-{smm,wmi}.
> Build them as one module can solve the issue.
>
> The last patch is what we want, but pulls the entire series as a whole.
>
> [Test]
> The backlight sysfs always exists with the patch. Userspace now knows
> the current keyboard backlight brightness.
>
> [Regression Potential]
> Low. No functional change, as it simply links the modules together.
> Limits to Dell machines.
>
> Kai-Heng Feng (1):
>   UBUNTU: [Config] CONFIG_DELL_SMBIOS_SMM=y, CONFIG_DELL_SMBIOS_WMI=y
>
> Mario Limonciello (3):
>   platform/x86: dell-smbios: Correct some style warnings
>   platform/x86: dell-smbios: Rename dell-smbios source to
>     dell-smbios-base
>   platform/x86: dell-smbios: Link all dell-smbios-* modules together
>
>  debian.master/config/config.common.ubuntu     |  4 +--
>  drivers/platform/x86/Kconfig                  | 15 ++++++----
>  drivers/platform/x86/Makefile                 |  5 ++--
>  .../x86/{dell-smbios.c => dell-smbios-base.c} | 29 ++++++++++++++++---
>  drivers/platform/x86/dell-smbios-smm.c        | 18 +++---------
>  drivers/platform/x86/dell-smbios-wmi.c        | 14 +++------
>  drivers/platform/x86/dell-smbios.h            | 27 ++++++++++++++++-
>  7 files changed, 74 insertions(+), 38 deletions(-)
>  rename drivers/platform/x86/{dell-smbios.c => dell-smbios-base.c} (96%)
>
Acked-by: Khalid Elmously <[hidden email]>
 

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU] [Bionic] [PATCH 0/4] Keyboard backlight sysfs sometimes is missing on Dell laptops

Kleber Souza
In reply to this post by Kai-Heng Feng
On 10/11/18 07:37, Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1797304
>
> [Impact]
> When the keyboard backlight sysfs is missing, userspace does not know
> the current keyboard backlight brightness.
>
> [Fix]
> There's a loading order race condition, between the dell-smbios and its
> backends, dell-smbios-{smm,wmi}.
> Build them as one module can solve the issue.
>
> The last patch is what we want, but pulls the entire series as a whole.
>
> [Test]
> The backlight sysfs always exists with the patch. Userspace now knows
> the current keyboard backlight brightness.
>
> [Regression Potential]
> Low. No functional change, as it simply links the modules together.
> Limits to Dell machines.
>
> Kai-Heng Feng (1):
>   UBUNTU: [Config] CONFIG_DELL_SMBIOS_SMM=y, CONFIG_DELL_SMBIOS_WMI=y
>
> Mario Limonciello (3):
>   platform/x86: dell-smbios: Correct some style warnings
>   platform/x86: dell-smbios: Rename dell-smbios source to
>     dell-smbios-base
>   platform/x86: dell-smbios: Link all dell-smbios-* modules together
>
>  debian.master/config/config.common.ubuntu     |  4 +--
>  drivers/platform/x86/Kconfig                  | 15 ++++++----
>  drivers/platform/x86/Makefile                 |  5 ++--
>  .../x86/{dell-smbios.c => dell-smbios-base.c} | 29 ++++++++++++++++---
>  drivers/platform/x86/dell-smbios-smm.c        | 18 +++---------
>  drivers/platform/x86/dell-smbios-wmi.c        | 14 +++------
>  drivers/platform/x86/dell-smbios.h            | 27 ++++++++++++++++-
>  7 files changed, 74 insertions(+), 38 deletions(-)
>  rename drivers/platform/x86/{dell-smbios.c => dell-smbios-base.c} (96%)
>

All clean cherry-picks.

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[OEM-B]: [SRU] [Bionic] [PATCH 0/4] Keyboard backlight sysfs sometimes is missing on Dell laptops

AceLan Kao
In reply to this post by Kai-Heng Feng
Applied on Ubuntu-oem-4.15.0-1024.27

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team