[SRU][Bionic][PATCH] UBUNTU: SAUCE: drm/i915/glk: Add MODULE_FIRMWARE for Geminilake's DMC

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][Bionic][PATCH] UBUNTU: SAUCE: drm/i915/glk: Add MODULE_FIRMWARE for Geminilake's DMC

Seth Forshee
BugLink: http://bugs.launchpad.net/bugs/1760545

The firmware is available in linux-firmware now, so add back the
MODULE_FIRMWARE statement.

Signed-off-by: Seth Forshee <[hidden email]>
---
Will also submit this patch upstream.

 drivers/gpu/drm/i915/intel_csr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
index da9de47562b8..f9ee56fdf3ab 100644
--- a/drivers/gpu/drm/i915/intel_csr.c
+++ b/drivers/gpu/drm/i915/intel_csr.c
@@ -35,6 +35,7 @@
  */
 
 #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
+MODULE_FIRMWARE(I915_CSR_GLK);
 #define GLK_CSR_VERSION_REQUIRED CSR_VERSION(1, 4)
 
 #define I915_CSR_CNL "i915/cnl_dmc_ver1_04.bin"
--
2.15.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

NACK: [SRU][Bionic][PATCH] UBUNTU: SAUCE: drm/i915/glk: Add MODULE_FIRMWARE for Geminilake's DMC

Kleber Souza
On 04/13/18 14:01, Seth Forshee wrote:

> BugLink: http://bugs.launchpad.net/bugs/1760545
>
> The firmware is available in linux-firmware now, so add back the
> MODULE_FIRMWARE statement.
>
> Signed-off-by: Seth Forshee <[hidden email]>
> ---
> Will also submit this patch upstream.
>
>  drivers/gpu/drm/i915/intel_csr.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c
> index da9de47562b8..f9ee56fdf3ab 100644
> --- a/drivers/gpu/drm/i915/intel_csr.c
> +++ b/drivers/gpu/drm/i915/intel_csr.c
> @@ -35,6 +35,7 @@
>   */
>  
>  #define I915_CSR_GLK "i915/glk_dmc_ver1_04.bin"
> +MODULE_FIRMWARE(I915_CSR_GLK);
>  #define GLK_CSR_VERSION_REQUIRED CSR_VERSION(1, 4)
>  
>  #define I915_CSR_CNL "i915/cnl_dmc_ver1_04.bin"
>

This change has made upstream as
b607990c76ceda0a7a7ceacabab174cdc8b9beee, we can have it cherry-picked
instead of a SAUCE patch.


Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team