[SRU] [Bionic/Unstable] [PATCH 0/1] Disable RX aggregation on new

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU] [Bionic/Unstable] [PATCH 0/1] Disable RX aggregation on new

Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1785780

[Impact]
Packets are silently corrupted on Dell TB16's ethernet.

[Fix]
Disable RX aggregation on new Dell TB16 dock.

[Test]
User confirms the patch fixes the issue.

[Regression Potential]
Low. The workaround already works, we just add a new USB serial to let
new TB16 dock also uses this workaround.

Kai-Heng Feng (1):
  r8152: disable RX aggregation on new Dell TB16 dock

 drivers/net/usb/r8152.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/1] r8152: disable RX aggregation on new Dell TB16 dock

Kai-Heng Feng
There's a new Dell TB16 dock with a different iSerialNumber.

Apply the same fix from commit 0b1655143df0 ("r8152: disable RX
aggregation on Dell TB16 dock") to this model.

BugLink: https://bugs.launchpad.net/bugs/1785780
Signed-off-by: Kai-Heng Feng <[hidden email]>
Signed-off-by: David S. Miller <[hidden email]>
(cherry picked from commit 176eb614b118c96e7797f5ddefd10708c316f621)
Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/net/usb/r8152.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index d4e00f5ba5d4..ca817274b635 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -5214,8 +5214,8 @@ static int rtl8152_probe(struct usb_interface *intf,
  netdev->hw_features &= ~NETIF_F_RXCSUM;
  }
 
- if (le16_to_cpu(udev->descriptor.bcdDevice) == 0x3011 &&
-    udev->serial && !strcmp(udev->serial, "000001000000")) {
+ if (le16_to_cpu(udev->descriptor.bcdDevice) == 0x3011 && udev->serial &&
+    (!strcmp(udev->serial, "000001000000") || !strcmp(udev->serial, "000002000000"))) {
  dev_info(&udev->dev, "Dell TB16 Dock, disable RX aggregation");
  set_bit(DELL_TB_RX_AGG_BUG, &tp->flags);
  }
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU] [Bionic/Unstable] [PATCH 0/1] Disable RX aggregation on new

Hui Wang
In reply to this post by Kai-Heng Feng
Acked-by: Hui Wang<[hidden email]>


On 2018年08月28日 16:24, Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1785780
>
> [Impact]
> Packets are silently corrupted on Dell TB16's ethernet.
>
> [Fix]
> Disable RX aggregation on new Dell TB16 dock.
>
> [Test]
> User confirms the patch fixes the issue.
>
> [Regression Potential]
> Low. The workaround already works, we just add a new USB serial to let
> new TB16 dock also uses this workaround.
>
> Kai-Heng Feng (1):
>    r8152: disable RX aggregation on new Dell TB16 dock
>
>   drivers/net/usb/r8152.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU] [Bionic/Unstable] [PATCH 0/1] Disable RX aggregation on new

Anthony Wong-2
In reply to this post by Kai-Heng Feng
On Tue, Aug 28, 2018 at 08:24:54AM +0000, Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1785780
>
> [Impact]
> Packets are silently corrupted on Dell TB16's ethernet.
>
> [Fix]
> Disable RX aggregation on new Dell TB16 dock.
>
> [Test]
> User confirms the patch fixes the issue.
>
> [Regression Potential]
> Low. The workaround already works, we just add a new USB serial to let
> new TB16 dock also uses this workaround.
>
> Kai-Heng Feng (1):
>   r8152: disable RX aggregation on new Dell TB16 dock
>
>  drivers/net/usb/r8152.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Clean cherry-pick.

Acked-by: Anthony Wong <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU] [Bionic/Unstable] [PATCH 0/1] Disable RX aggregation on new

Seth Forshee
In reply to this post by Kai-Heng Feng
On Tue, Aug 28, 2018 at 08:24:54AM +0000, Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1785780
>
> [Impact]
> Packets are silently corrupted on Dell TB16's ethernet.
>
> [Fix]
> Disable RX aggregation on new Dell TB16 dock.
>
> [Test]
> User confirms the patch fixes the issue.
>
> [Regression Potential]
> Low. The workaround already works, we just add a new USB serial to let
> new TB16 dock also uses this workaround.

Applied to cosmic/master-next and unstable/master, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU] [Bionic/Unstable] [PATCH 0/1] Disable RX aggregation on new

Kleber Souza
In reply to this post by Kai-Heng Feng
On 08/28/18 10:24, Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1785780
>
> [Impact]
> Packets are silently corrupted on Dell TB16's ethernet.
>
> [Fix]
> Disable RX aggregation on new Dell TB16 dock.
>
> [Test]
> User confirms the patch fixes the issue.
>
> [Regression Potential]
> Low. The workaround already works, we just add a new USB serial to let
> new TB16 dock also uses this workaround.
>
> Kai-Heng Feng (1):
>   r8152: disable RX aggregation on new Dell TB16 dock
>
>  drivers/net/usb/r8152.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

Applied to bionic/master-next branch.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team