SRU: Bug #241981 - HVR950Q channel scan takes a very long time to complete

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

SRU: Bug #241981 - HVR950Q channel scan takes a very long time to complete

Tim Gardner-6


SRU Justification:

Impact: Channel scan time is very long

Patch Description: prevent false-positive lock status

Patch:
http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy-lum.git;a=commit;h=3d99a2e719e910101789fc1d741ddfcf23472c7b

Test case: See bug description

--
Tim Gardner [hidden email]

From 3d99a2e719e910101789fc1d741ddfcf23472c7b Mon Sep 17 00:00:00 2001
From: Tim Gardner <[hidden email]>
Date: Mon, 23 Jun 2008 11:49:35 -0600
Subject: [PATCH] UBUNTU: prevent false-positive lock status
 OriginalAuthor: Steven Toth <[hidden email]>
 OriginalLocation: http://launchpadlibrarian.net/15499324/au8522-prevent-false-positive-lock-status
 Bug: #241981

This decreases scan time in Queens, New York from 28 minutes to 7 minutes,
with the exact same services found.

Signed-off-by: Michael Krufky <[hidden email]>
Signed-off-by: Tim Gardner <[hidden email]>
---
 ubuntu/media/au0828/au8522.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/ubuntu/media/au0828/au8522.c b/ubuntu/media/au0828/au8522.c
index 6d80ca2..37f6260 100644
--- a/ubuntu/media/au0828/au8522.c
+++ b/ubuntu/media/au0828/au8522.c
@@ -526,10 +526,8 @@ static int au8522_read_status(struct dvb_frontend *fe, fe_status_t *status)
  if (state->current_modulation == VSB_8) {
  dprintk("%s() Checking VSB_8\n", __func__);
  reg = au8522_readreg(state, 0x4088);
- if (reg & 0x01)
- *status |= FE_HAS_VITERBI;
- if (reg & 0x02)
- *status |= FE_HAS_LOCK | FE_HAS_SYNC;
+ if ((reg & 0x03) == 0x03)
+ *status |= FE_HAS_LOCK | FE_HAS_SYNC | FE_HAS_VITERBI;
  } else {
  dprintk("%s() Checking QAM\n", __func__);
  reg = au8522_readreg(state, 0x4541);
--
1.5.4.3


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: SRU: Bug #241981 - HVR950Q channel scan takes a very long time to complete

Stefan Bader-2
Tim Gardner wrote:

>
> SRU Justification:
>
> Impact: Channel scan time is very long
>
> Patch Description: prevent false-positive lock status
>
> Patch:
> http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy-lum.git;a=commit;h=3d99a2e719e910101789fc1d741ddfcf23472c7b
>
> Test case: See bug description
>
>

Err, public ack this time

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: SRU: Bug #241981 - HVR950Q channel scan takes a very long time to complete

Ben Collins-5
In reply to this post by Tim Gardner-6
On Mon, 2008-06-23 at 11:56 -0600, Tim Gardner wrote:

>
> SRU Justification:
>
> Impact: Channel scan time is very long
>
> Patch Description: prevent false-positive lock status
>
> Patch:
> http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-hardy-lum.git;a=commit;h=3d99a2e719e910101789fc1d741ddfcf23472c7b
>
> Test case: See bug description

ACK as well.


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team