[SRU][Cosmic][Patch] tools/kvm_stat: switch to python3

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][Cosmic][Patch] tools/kvm_stat: switch to python3

Juerg Haefliger
From: Stefan Raspl <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1798776

The current shebang does not work in environments that only support python3
and have no python2 installed. Plus there does not seem to be a way to
support python2 and python3 at the same time. Since all known python3 issues
were fixed, and as python3 is the way to go, let's switch over.
Note that the code is still python2 compliant, so folks in bad use can
simply revert the shebang.

Suggested-by: Christian Ehrhardt <[hidden email]>
Signed-off-by: Stefan Raspl <[hidden email]>
Signed-off-by: Paolo Bonzini <[hidden email]>
(cherry picked from commit 09f70c3b70e7d9e209a820b54dda42502fa40711)
Signed-off-by: Juerg Haefliger <[hidden email]>
---
 tools/kvm/kvm_stat/kvm_stat | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat
index 7c92545931e3..fb25837df44f 100755
--- a/tools/kvm/kvm_stat/kvm_stat
+++ b/tools/kvm/kvm_stat/kvm_stat
@@ -1,4 +1,4 @@
-#!/usr/bin/python
+#!/usr/bin/env python3
 #
 # top-like utility for displaying kvm statistics
 #
--
2.19.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/Cmnt: [SRU][Cosmic][Patch] tools/kvm_stat: switch to python3

Stefan Bader-2
On 15.01.19 11:15, Juerg Haefliger wrote:

> From: Stefan Raspl <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1798776
>
> The current shebang does not work in environments that only support python3
> and have no python2 installed. Plus there does not seem to be a way to
> support python2 and python3 at the same time. Since all known python3 issues
> were fixed, and as python3 is the way to go, let's switch over.
> Note that the code is still python2 compliant, so folks in bad use can
> simply revert the shebang.
>
> Suggested-by: Christian Ehrhardt <[hidden email]>
> Signed-off-by: Stefan Raspl <[hidden email]>
> Signed-off-by: Paolo Bonzini <[hidden email]>
> (cherry picked from commit 09f70c3b70e7d9e209a820b54dda42502fa40711)
> Signed-off-by: Juerg Haefliger <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>
> ---

Formally, there should be a SRU justification section in the bug description
even for things as simple as that.

-Stefan

>  tools/kvm/kvm_stat/kvm_stat | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat
> index 7c92545931e3..fb25837df44f 100755
> --- a/tools/kvm/kvm_stat/kvm_stat
> +++ b/tools/kvm/kvm_stat/kvm_stat
> @@ -1,4 +1,4 @@
> -#!/usr/bin/python
> +#!/usr/bin/env python3
>  #
>  # top-like utility for displaying kvm statistics
>  #
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][Cosmic][Patch] tools/kvm_stat: switch to python3

Kleber Souza
In reply to this post by Juerg Haefliger
On 1/15/19 11:15 AM, Juerg Haefliger wrote:

> From: Stefan Raspl <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1798776
>
> The current shebang does not work in environments that only support python3
> and have no python2 installed. Plus there does not seem to be a way to
> support python2 and python3 at the same time. Since all known python3 issues
> were fixed, and as python3 is the way to go, let's switch over.
> Note that the code is still python2 compliant, so folks in bad use can
> simply revert the shebang.
>
> Suggested-by: Christian Ehrhardt <[hidden email]>
> Signed-off-by: Stefan Raspl <[hidden email]>
> Signed-off-by: Paolo Bonzini <[hidden email]>
> (cherry picked from commit 09f70c3b70e7d9e209a820b54dda42502fa40711)
> Signed-off-by: Juerg Haefliger <[hidden email]>
Acked-by: Kleber Sacilotto de Souza <[hidden email]>

> ---
>  tools/kvm/kvm_stat/kvm_stat | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat
> index 7c92545931e3..fb25837df44f 100755
> --- a/tools/kvm/kvm_stat/kvm_stat
> +++ b/tools/kvm/kvm_stat/kvm_stat
> @@ -1,4 +1,4 @@
> -#!/usr/bin/python
> +#!/usr/bin/env python3
>  #
>  # top-like utility for displaying kvm statistics
>  #



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU][Cosmic][Patch] tools/kvm_stat: switch to python3

Khaled Elmously
In reply to this post by Juerg Haefliger
On 2019-01-15 11:15:48 , Juerg Haefliger wrote:

> From: Stefan Raspl <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1798776
>
> The current shebang does not work in environments that only support python3
> and have no python2 installed. Plus there does not seem to be a way to
> support python2 and python3 at the same time. Since all known python3 issues
> were fixed, and as python3 is the way to go, let's switch over.
> Note that the code is still python2 compliant, so folks in bad use can
> simply revert the shebang.
>
> Suggested-by: Christian Ehrhardt <[hidden email]>
> Signed-off-by: Stefan Raspl <[hidden email]>
> Signed-off-by: Paolo Bonzini <[hidden email]>
> (cherry picked from commit 09f70c3b70e7d9e209a820b54dda42502fa40711)
> Signed-off-by: Juerg Haefliger <[hidden email]>
> ---
>  tools/kvm/kvm_stat/kvm_stat | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/kvm/kvm_stat/kvm_stat b/tools/kvm/kvm_stat/kvm_stat
> index 7c92545931e3..fb25837df44f 100755
> --- a/tools/kvm/kvm_stat/kvm_stat
> +++ b/tools/kvm/kvm_stat/kvm_stat
> @@ -1,4 +1,4 @@
> -#!/usr/bin/python
> +#!/usr/bin/env python3
>  #
>  # top-like utility for displaying kvm statistics
>  #
> --
> 2.19.1
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team