[SRU][D/C/B/X linux-kvm][PATCH] UBUNTU: [Config]: enable KEXEC and KEXEC_FILE

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][D/C/B/X linux-kvm][PATCH] UBUNTU: [Config]: enable KEXEC and KEXEC_FILE

Connor Kuehl
BugLink: https://bugs.launchpad.net/bugs/1799791

== SRU Justification ==

This option was initially turned off as part of the minimal KVM config.
However, it is enabled in the master/generic config and its enablement
could allow for some creative applications of linux-kvm.

The launchpad bug mentions Cosmic, but for consistency I've also named
Disco, Bionic, and Xenial.

== Regression Potential ==

Low. This enables a config change for a derivative. The config is already
enabled in the generic/master.

== Test Case ==

Compile-tested all architectures for each series with this patch applied.

Signed-off-by: Connor Kuehl <[hidden email]>



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][D/C/B linux-kvm][PATCH] UBUNTU: [Config]: enable KEXEC and KEXEC_FILE

Connor Kuehl
BugLink: https://bugs.launchpad.net/bugs/1799791

This option was initially turned off as part of the minimal KVM config.
However, it is enabled in the master/generic config and its enablement
could allow for some creative applications of linux-kvm.

Signed-off-by: Connor Kuehl <[hidden email]>
---
 debian.kvm/config/config.common.ubuntu | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
index 6eb250217353..0e227e8a7d0c 100644
--- a/debian.kvm/config/config.common.ubuntu
+++ b/debian.kvm/config/config.common.ubuntu
@@ -1240,8 +1240,8 @@ CONFIG_KERNEL_GZIP=y
 # CONFIG_KERNEL_LZO is not set
 # CONFIG_KERNEL_XZ is not set
 CONFIG_KERNFS=y
-# CONFIG_KEXEC is not set
-# CONFIG_KEXEC_FILE is not set
+CONFIG_KEXEC=y
+CONFIG_KEXEC_FILE=y
 CONFIG_KEYS=y
 CONFIG_KEYS_COMPAT=y
 # CONFIG_KEY_DH_OPERATIONS is not set
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][X linux-kvm][PATCH] UBUNTU: [Config]: enable KEXEC and KEXEC_FILE

Connor Kuehl
In reply to this post by Connor Kuehl
BugLink: https://bugs.launchpad.net/bugs/1799791

This option was initially turned off as part of the minimal KVM config.
However, it is enabled in the master/generic config and its enablement
could allow for some creative applications of linux-kvm.

Signed-off-by: Connor Kuehl <[hidden email]>
---
 debian.kvm/config/config.common.ubuntu | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
index cbdfe860ef82..d2e04d179f61 100644
--- a/debian.kvm/config/config.common.ubuntu
+++ b/debian.kvm/config/config.common.ubuntu
@@ -1100,7 +1100,8 @@ CONFIG_KERNEL_GZIP=y
 # CONFIG_KERNEL_LZO is not set
 # CONFIG_KERNEL_XZ is not set
 CONFIG_KERNFS=y
-# CONFIG_KEXEC is not set
+CONFIG_KEXEC=y
+COFNIG_KEXEC_FILE=y
 CONFIG_KEYS=y
 CONFIG_KEYS_COMPAT=y
 # CONFIG_KGDB is not set
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

NACK: [SRU][X linux-kvm][PATCH] UBUNTU: [Config]: enable KEXEC and KEXEC_FILE

Connor Kuehl
NACK'ing this for Xenial because of the spelling error that I didn't
catch. Will send a v2.

On 4/23/19 9:49 AM, Connor Kuehl wrote:

> BugLink: https://bugs.launchpad.net/bugs/1799791
>
> This option was initially turned off as part of the minimal KVM config.
> However, it is enabled in the master/generic config and its enablement
> could allow for some creative applications of linux-kvm.
>
> Signed-off-by: Connor Kuehl <[hidden email]>
> ---
>  debian.kvm/config/config.common.ubuntu | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
> index cbdfe860ef82..d2e04d179f61 100644
> --- a/debian.kvm/config/config.common.ubuntu
> +++ b/debian.kvm/config/config.common.ubuntu
> @@ -1100,7 +1100,8 @@ CONFIG_KERNEL_GZIP=y
>  # CONFIG_KERNEL_LZO is not set
>  # CONFIG_KERNEL_XZ is not set
>  CONFIG_KERNFS=y
> -# CONFIG_KEXEC is not set
> +CONFIG_KEXEC=y
> +COFNIG_KEXEC_FILE=y
>  CONFIG_KEYS=y
>  CONFIG_KEYS_COMPAT=y
>  # CONFIG_KGDB is not set
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

pEpkey.asc (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

[SRU][X linux-kvm][PATCH v2] UBUNTU: [Config]: enable KEXEC and KEXEC_FILE

Connor Kuehl
In reply to this post by Connor Kuehl
BugLink: https://bugs.launchpad.net/bugs/1799791

This option was initially turned off as part of the minimal KVM config.
However, it is enabled in the master/generic config and its enablement
could allow for some creative applications of linux-kvm.

Signed-off-by: Connor Kuehl <[hidden email]>
---
Fixed the typo "COFNIG_KEXEC_FILE" -> "CONFIG_KEXEC_FILE"

 debian.kvm/config/config.common.ubuntu | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
index cbdfe860ef82..676034af56c4 100644
--- a/debian.kvm/config/config.common.ubuntu
+++ b/debian.kvm/config/config.common.ubuntu
@@ -1100,7 +1100,8 @@ CONFIG_KERNEL_GZIP=y
 # CONFIG_KERNEL_LZO is not set
 # CONFIG_KERNEL_XZ is not set
 CONFIG_KERNFS=y
-# CONFIG_KEXEC is not set
+CONFIG_KEXEC=y
+CONFIG_KEXEC_FILE=y
 CONFIG_KEYS=y
 CONFIG_KEYS_COMPAT=y
 # CONFIG_KGDB is not set
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: NACK: [SRU][X linux-kvm][PATCH] UBUNTU: [Config]: enable KEXEC and KEXEC_FILE

Seth Forshee
In reply to this post by Connor Kuehl
On Tue, Apr 23, 2019 at 10:24:19AM -0700, Connor Kuehl wrote:
> NACK'ing this for Xenial because of the spelling error that I didn't
> catch. Will send a v2.

This implies that you didn't run 'cranky updateconfigs' after your
config changes, which you should always do. For instance, I tried your
patch for disco and got prompted for several additional options. So that
patch at least needs to be updated, it's likely that the others will as
well.

Thanks,
Seth

>
> On 4/23/19 9:49 AM, Connor Kuehl wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1799791
> >
> > This option was initially turned off as part of the minimal KVM config.
> > However, it is enabled in the master/generic config and its enablement
> > could allow for some creative applications of linux-kvm.
> >
> > Signed-off-by: Connor Kuehl <[hidden email]>
> > ---
> >  debian.kvm/config/config.common.ubuntu | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
> > index cbdfe860ef82..d2e04d179f61 100644
> > --- a/debian.kvm/config/config.common.ubuntu
> > +++ b/debian.kvm/config/config.common.ubuntu
> > @@ -1100,7 +1100,8 @@ CONFIG_KERNEL_GZIP=y
> >  # CONFIG_KERNEL_LZO is not set
> >  # CONFIG_KERNEL_XZ is not set
> >  CONFIG_KERNFS=y
> > -# CONFIG_KEXEC is not set
> > +CONFIG_KEXEC=y
> > +COFNIG_KEXEC_FILE=y
> >  CONFIG_KEYS=y
> >  CONFIG_KEYS_COMPAT=y
> >  # CONFIG_KGDB is not set
> >
>

pub   RSA 4096/1FE09B94 2019-04-01 Connor Kuehl <[hidden email]>
> sub   RSA 4096/0E9A453C 2019-04-01
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

NACK: [SRU][D/C/B/X linux-kvm][PATCH] UBUNTU: [Config]: enable KEXEC and KEXEC_FILE

Connor Kuehl
In reply to this post by Connor Kuehl
NACK'ing all of these, will return with another version which is more
appropriately prepared after running updateconfigs.

On 4/23/19 9:49 AM, Connor Kuehl wrote:

> BugLink: https://bugs.launchpad.net/bugs/1799791
>
> == SRU Justification ==
>
> This option was initially turned off as part of the minimal KVM config.
> However, it is enabled in the master/generic config and its enablement
> could allow for some creative applications of linux-kvm.
>
> The launchpad bug mentions Cosmic, but for consistency I've also named
> Disco, Bionic, and Xenial.
>
> == Regression Potential ==
>
> Low. This enables a config change for a derivative. The config is already
> enabled in the generic/master.
>
> == Test Case ==
>
> Compile-tested all architectures for each series with this patch applied.
>
> Signed-off-by: Connor Kuehl <[hidden email]>
>
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

pEpkey.asc (5K) Download Attachment