[SRU][D/C/B/X linux-kvm][PATCH v2] UBUNTU: [Config]: enable KEXEC and KEXEC_FILE

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][D/C/B/X linux-kvm][PATCH v2] UBUNTU: [Config]: enable KEXEC and KEXEC_FILE

Connor Kuehl
BugLink: https://bugs.launchpad.net/bugs/1799791

== SRU Justification ==

The enablement of these options could allow for some creative
applications of linux-kvm.

The launchpad bug mentions Cosmic, but for consistency I've also named
Disco, Bionic, and Xenial.

Note: Xenial's patch required just a little more work, but not much.

== Regression Potential ==

Low. This enables a config change for a derivative. The config is already
enabled in the generic/master.

== Test Case ==

Ran "cranky updateconfigs" to make sure the config changes applied cleanly.
Compile-tested all architectures for each series with this patch applied.

Signed-off-by: Connor Kuehl <[hidden email]>



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][Disco linux-kvm][PATCH] UBUNTU: [Config]: enable KEXEC and KEXEC_FILE

Connor Kuehl
BugLink: https://bugs.launchpad.net/bugs/1799791

The enablement of these options could allow for some creative
applications of linux-kvm.

Signed-off-by: Connor Kuehl <[hidden email]>
---
 debian.kvm/config/config.common.ubuntu | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
index aad8c2259760..3208f3205ede 100644
--- a/debian.kvm/config/config.common.ubuntu
+++ b/debian.kvm/config/config.common.ubuntu
@@ -89,6 +89,7 @@ CONFIG_ARCH_HAS_FILTER_PGPROT=y
 CONFIG_ARCH_HAS_FORTIFY_SOURCE=y
 CONFIG_ARCH_HAS_GCOV_PROFILE_ALL=y
 CONFIG_ARCH_HAS_KCOV=y
+CONFIG_ARCH_HAS_KEXEC_PURGATORY=y
 CONFIG_ARCH_HAS_MEMBARRIER_SYNC_CORE=y
 CONFIG_ARCH_HAS_MEM_ENCRYPT=y
 CONFIG_ARCH_HAS_PMEM_API=y
@@ -381,6 +382,7 @@ CONFIG_CPU_SUP_CENTAUR=y
 CONFIG_CPU_SUP_HYGON=y
 CONFIG_CPU_SUP_INTEL=y
 # CONFIG_CRAMFS is not set
+CONFIG_CRASH_CORE=y
 # CONFIG_CRASH_DUMP is not set
 CONFIG_CRC16=y
 CONFIG_CRC32=y
@@ -668,6 +670,7 @@ CONFIG_EFI_ESRT=y
 # CONFIG_EFI_FAKE_MEMMAP is not set
 CONFIG_EFI_PARTITION=y
 # CONFIG_EFI_PGT_DUMP is not set
+# CONFIG_EFI_RUNTIME_MAP is not set
 CONFIG_EFI_RUNTIME_WRAPPERS=y
 CONFIG_EFI_SIGNATURE_LIST_PARSER=y
 # CONFIG_EFI_STUB is not set
@@ -1241,8 +1244,10 @@ CONFIG_KERNEL_GZIP=y
 # CONFIG_KERNEL_LZO is not set
 # CONFIG_KERNEL_XZ is not set
 CONFIG_KERNFS=y
-# CONFIG_KEXEC is not set
-# CONFIG_KEXEC_FILE is not set
+CONFIG_KEXEC=y
+CONFIG_KEXEC_CORE=y
+CONFIG_KEXEC_FILE=y
+# CONFIG_KEXEC_VERIFY_SIG is not set
 CONFIG_KEYS=y
 CONFIG_KEYS_COMPAT=y
 # CONFIG_KEY_DH_OPERATIONS is not set
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][Cosmic linux-kvm][PATCH] UBUNTU: [Config]: enable KEXEC and KEXEC_FILE

Connor Kuehl
In reply to this post by Connor Kuehl
BugLink: https://bugs.launchpad.net/bugs/1799791

The enablement of these options could allow for some creative
applications of linux-kvm.

Signed-off-by: Connor Kuehl <[hidden email]>
---
 debian.kvm/config/config.common.ubuntu | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
index 6eb250217353..88c196e8c432 100644
--- a/debian.kvm/config/config.common.ubuntu
+++ b/debian.kvm/config/config.common.ubuntu
@@ -87,6 +87,7 @@ CONFIG_ARCH_HAS_FILTER_PGPROT=y
 CONFIG_ARCH_HAS_FORTIFY_SOURCE=y
 CONFIG_ARCH_HAS_GCOV_PROFILE_ALL=y
 CONFIG_ARCH_HAS_KCOV=y
+CONFIG_ARCH_HAS_KEXEC_PURGATORY=y
 CONFIG_ARCH_HAS_MEMBARRIER_SYNC_CORE=y
 CONFIG_ARCH_HAS_MEM_ENCRYPT=y
 CONFIG_ARCH_HAS_PMEM_API=y
@@ -378,6 +379,7 @@ CONFIG_CPU_SUP_AMD=y
 CONFIG_CPU_SUP_CENTAUR=y
 CONFIG_CPU_SUP_INTEL=y
 # CONFIG_CRAMFS is not set
+CONFIG_CRASH_CORE=y
 # CONFIG_CRASH_DUMP is not set
 CONFIG_CRC16=y
 CONFIG_CRC32=y
@@ -675,6 +677,7 @@ CONFIG_EFI_ESRT=y
 # CONFIG_EFI_FAKE_MEMMAP is not set
 CONFIG_EFI_PARTITION=y
 # CONFIG_EFI_PGT_DUMP is not set
+# CONFIG_EFI_RUNTIME_MAP is not set
 CONFIG_EFI_RUNTIME_WRAPPERS=y
 CONFIG_EFI_SIGNATURE_LIST_PARSER=y
 # CONFIG_EFI_STUB is not set
@@ -1240,8 +1243,10 @@ CONFIG_KERNEL_GZIP=y
 # CONFIG_KERNEL_LZO is not set
 # CONFIG_KERNEL_XZ is not set
 CONFIG_KERNFS=y
-# CONFIG_KEXEC is not set
-# CONFIG_KEXEC_FILE is not set
+CONFIG_KEXEC=y
+CONFIG_KEXEC_CORE=y
+CONFIG_KEXEC_FILE=y
+# CONFIG_KEXEC_VERIFY_SIG is not set
 CONFIG_KEYS=y
 CONFIG_KEYS_COMPAT=y
 # CONFIG_KEY_DH_OPERATIONS is not set
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][Bionic linux-kvm][PATCH] UBUNTU: [Config]: enable KEXEC and KEXEC_FILE

Connor Kuehl
In reply to this post by Connor Kuehl
BugLink: https://bugs.launchpad.net/bugs/1799791

The enablement of these options could allow for some creative
applications of linux-kvm.

Signed-off-by: Connor Kuehl <[hidden email]>
---
 debian.kvm/config/config.common.ubuntu | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
index d1c70707f91a..4dcba30d60ad 100644
--- a/debian.kvm/config/config.common.ubuntu
+++ b/debian.kvm/config/config.common.ubuntu
@@ -389,6 +389,7 @@ CONFIG_CPU_SUP_AMD=y
 CONFIG_CPU_SUP_CENTAUR=y
 CONFIG_CPU_SUP_INTEL=y
 # CONFIG_CRAMFS is not set
+CONFIG_CRASH_CORE=y
 # CONFIG_CRASH_DUMP is not set
 CONFIG_CRC16=y
 CONFIG_CRC32=y
@@ -670,6 +671,7 @@ CONFIG_EFI_ESRT=y
 # CONFIG_EFI_FAKE_MEMMAP is not set
 CONFIG_EFI_PARTITION=y
 # CONFIG_EFI_PGT_DUMP is not set
+# CONFIG_EFI_RUNTIME_MAP is not set
 CONFIG_EFI_RUNTIME_WRAPPERS=y
 CONFIG_EFI_SIGNATURE_LIST_PARSER=y
 # CONFIG_EFI_STUB is not set
@@ -1242,8 +1244,10 @@ CONFIG_KERNEL_GZIP=y
 # CONFIG_KERNEL_LZO is not set
 # CONFIG_KERNEL_XZ is not set
 CONFIG_KERNFS=y
-# CONFIG_KEXEC is not set
-# CONFIG_KEXEC_FILE is not set
+CONFIG_KEXEC=y
+CONFIG_KEXEC_CORE=y
+CONFIG_KEXEC_FILE=y
+# CONFIG_KEXEC_VERIFY_SIG is not set
 CONFIG_KEYS=y
 CONFIG_KEYS_COMPAT=y
 # CONFIG_KEY_DH_OPERATIONS is not set
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][Xenial linux-kvm][PATCH] UBUNTU: [Config]: enable KEXEC and KEXEC_FILE

Connor Kuehl
In reply to this post by Connor Kuehl
BugLink: https://bugs.launchpad.net/bugs/1799791

The enablement of these options could allow for some creative
applications of linux-kvm.

Set CONFIG_CRYPTO_SHA256=y instead of 'm' because KEXEC_FILE depends
on it being 'y' otherwise it precludes KEXEC_FILE. This also makes it
more consistent with Bionic as Bionic has it set to 'y' as well.

Finally, remove "sha256_generic" from the modules list as it is now
"built-in" after being set ='y'

Signed-off-by: Connor Kuehl <[hidden email]>
---
 debian.kvm/abi/4.4.0-1044.50/amd64/kvm.modules | 1 -
 debian.kvm/config/config.common.ubuntu         | 8 ++++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/debian.kvm/abi/4.4.0-1044.50/amd64/kvm.modules b/debian.kvm/abi/4.4.0-1044.50/amd64/kvm.modules
index 07723b563dab..96d237e5b5c3 100644
--- a/debian.kvm/abi/4.4.0-1044.50/amd64/kvm.modules
+++ b/debian.kvm/abi/4.4.0-1044.50/amd64/kvm.modules
@@ -385,7 +385,6 @@ sata_uli
 sata_via
 sata_vsc
 seqiv
-sha256_generic
 spl
 splat
 sunrpc
diff --git a/debian.kvm/config/config.common.ubuntu b/debian.kvm/config/config.common.ubuntu
index cbdfe860ef82..61dd2d545ed1 100644
--- a/debian.kvm/config/config.common.ubuntu
+++ b/debian.kvm/config/config.common.ubuntu
@@ -449,7 +449,7 @@ CONFIG_CRYPTO_SEQIV=m
 CONFIG_CRYPTO_SHA1=y
 # CONFIG_CRYPTO_SHA1_MB is not set
 # CONFIG_CRYPTO_SHA1_SSSE3 is not set
-CONFIG_CRYPTO_SHA256=m
+CONFIG_CRYPTO_SHA256=y
 # CONFIG_CRYPTO_SHA256_SSSE3 is not set
 CONFIG_CRYPTO_SHA512=y
 # CONFIG_CRYPTO_SHA512_SSSE3 is not set
@@ -604,6 +604,7 @@ CONFIG_EFI_ESRT=y
 # CONFIG_EFI_FAKE_MEMMAP is not set
 CONFIG_EFI_PARTITION=y
 # CONFIG_EFI_PGT_DUMP is not set
+# CONFIG_EFI_RUNTIME_MAP is not set
 CONFIG_EFI_RUNTIME_WRAPPERS=y
 # CONFIG_EFI_SECURE_BOOT_SIG_ENFORCE is not set
 CONFIG_EFI_SIGNATURE_LIST_PARSER=y
@@ -1100,7 +1101,10 @@ CONFIG_KERNEL_GZIP=y
 # CONFIG_KERNEL_LZO is not set
 # CONFIG_KERNEL_XZ is not set
 CONFIG_KERNFS=y
-# CONFIG_KEXEC is not set
+CONFIG_KEXEC=y
+CONFIG_KEXEC_CORE=y
+CONFIG_KEXEC_FILE=y
+# CONFIG_KEXEC_VERIFY_SIG is not set
 CONFIG_KEYS=y
 CONFIG_KEYS_COMPAT=y
 # CONFIG_KGDB is not set
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][D/C/B/X linux-kvm][PATCH v2] UBUNTU: [Config]: enable KEXEC and KEXEC_FILE

Kleber Souza
In reply to this post by Connor Kuehl
On 4/29/19 6:23 PM, Connor Kuehl wrote:

> BugLink: https://bugs.launchpad.net/bugs/1799791
>
> == SRU Justification ==
>
> The enablement of these options could allow for some creative
> applications of linux-kvm.
>
> The launchpad bug mentions Cosmic, but for consistency I've also named
> Disco, Bionic, and Xenial.
>
> Note: Xenial's patch required just a little more work, but not much.
>
> == Regression Potential ==
>
> Low. This enables a config change for a derivative. The config is already
> enabled in the generic/master.
>
> == Test Case ==
>
> Ran "cranky updateconfigs" to make sure the config changes applied cleanly.
> Compile-tested all architectures for each series with this patch applied.
>
> Signed-off-by: Connor Kuehl <[hidden email]>
>
>
>

The changes look fine to me.

I would just like to hear the opinion from other people more familiar
to the KVM kernels to check if it makes sense to enable these configs
on all series, including the older ones. Otherwise we should enable
only on the series requested (Cosmic and earlier).

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/Cmnt: [SRU][D/C linux-kvm][PATCH v2] UBUNTU: [Config]: enable KEXEC and KEXEC_FILE

Stefan Bader-2
In reply to this post by Connor Kuehl
On 29.04.19 18:23, Connor Kuehl wrote:

> BugLink: https://bugs.launchpad.net/bugs/1799791
>
> == SRU Justification ==
>
> The enablement of these options could allow for some creative
> applications of linux-kvm.
>
> The launchpad bug mentions Cosmic, but for consistency I've also named
> Disco, Bionic, and Xenial.
>
> Note: Xenial's patch required just a little more work, but not much.
>
> == Regression Potential ==
>
> Low. This enables a config change for a derivative. The config is already
> enabled in the generic/master.
>
> == Test Case ==
>
> Ran "cranky updateconfigs" to make sure the config changes applied cleanly.
> Compile-tested all architectures for each series with this patch applied.
>
> Signed-off-by: Connor Kuehl <[hidden email]>
>
>
>
The kvm kernel is the one supposed to boot "really fast". While it sounds
unlikely to slow that down much, I would agree with Kleber and let this in
staged. If we don't get any trouble the next cycle we could go ahead and pull it
back into bionic and xenial.

So for this time for C/D:

Acked-by: Stefan Bader <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED[D/C]/cmnt: [SRU][D/C/B/X linux-kvm][PATCH v2] UBUNTU: [Config]: enable KEXEC and KEXEC_FILE

Kleber Souza
In reply to this post by Connor Kuehl
On 4/29/19 6:23 PM, Connor Kuehl wrote:

> BugLink: https://bugs.launchpad.net/bugs/1799791
>
> == SRU Justification ==
>
> The enablement of these options could allow for some creative
> applications of linux-kvm.
>
> The launchpad bug mentions Cosmic, but for consistency I've also named
> Disco, Bionic, and Xenial.
>
> Note: Xenial's patch required just a little more work, but not much.
>
> == Regression Potential ==
>
> Low. This enables a config change for a derivative. The config is already
> enabled in the generic/master.
>
> == Test Case ==
>
> Ran "cranky updateconfigs" to make sure the config changes applied cleanly.
> Compile-tested all architectures for each series with this patch applied.
>
> Signed-off-by: Connor Kuehl <[hidden email]>
>
>
>

Applied to linux-kvm/master-next branch for Cosmic and Disco only.
For the older series we can apply for a future SRU cycle if we do not
experience any problems with these changes.

Thanks,
Kleber

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [SRU][B/X linux-kvm][PATCH v2] UBUNTU: [Config]: enable KEXEC and KEXEC_FILE

Connor Kuehl
In reply to this post by Connor Kuehl
On 4/29/19 9:23 AM, Connor Kuehl wrote:

> BugLink: https://bugs.launchpad.net/bugs/1799791
>
> == SRU Justification ==
>
> The enablement of these options could allow for some creative
> applications of linux-kvm.
>
> The launchpad bug mentions Cosmic, but for consistency I've also named
> Disco, Bionic, and Xenial.
>
> Note: Xenial's patch required just a little more work, but not much.
>
> == Regression Potential ==
>
> Low. This enables a config change for a derivative. The config is already
> enabled in the generic/master.
>
> == Test Case ==
>
> Ran "cranky updateconfigs" to make sure the config changes applied cleanly.
> Compile-tested all architectures for each series with this patch applied.
>
> Signed-off-by: Connor Kuehl <[hidden email]>
>
>
Ping for Xenial and Bionic. Is there any way I can help benchmark these
changes for their consideration into X/B? Where's a good place to start
with that?

--
Connor

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

pEpkey.asc (5K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [SRU][B/X linux-kvm][PATCH v2] UBUNTU: [Config]: enable KEXEC and KEXEC_FILE

Stefan Bader-2
On 06.06.19 22:57, Connor Kuehl wrote:

> On 4/29/19 9:23 AM, Connor Kuehl wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1799791
>>
>> == SRU Justification ==
>>
>> The enablement of these options could allow for some creative
>> applications of linux-kvm.
>>
>> The launchpad bug mentions Cosmic, but for consistency I've also named
>> Disco, Bionic, and Xenial.
>>
>> Note: Xenial's patch required just a little more work, but not much.
>>
>> == Regression Potential ==
>>
>> Low. This enables a config change for a derivative. The config is already
>> enabled in the generic/master.
>>
>> == Test Case ==
>>
>> Ran "cranky updateconfigs" to make sure the config changes applied cleanly.
>> Compile-tested all architectures for each series with this patch applied.
>>
>> Signed-off-by: Connor Kuehl <[hidden email]>
>>
>>
>
> Ping for Xenial and Bionic. Is there any way I can help benchmark these
> changes for their consideration into X/B? Where's a good place to start
> with that?
Not that much that you can do. Just looking at the dates I assume the idea was
to get this out in Disco and Cosmic for one cycle and then follow up with Bionic
and Xenial. However, due to all the other interruptions, we never got that cycle
out, so everything moves out by one cycle. :(

-Stefan
>
>



--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU][B/X linux-kvm][PATCH v2] UBUNTU: [Config]: enable KEXEC and KEXEC_FILE

Stefan Bader-2
In reply to this post by Connor Kuehl
On 29.04.19 18:23, Connor Kuehl wrote:

> BugLink: https://bugs.launchpad.net/bugs/1799791
>
> == SRU Justification ==
>
> The enablement of these options could allow for some creative
> applications of linux-kvm.
>
> The launchpad bug mentions Cosmic, but for consistency I've also named
> Disco, Bionic, and Xenial.
>
> Note: Xenial's patch required just a little more work, but not much.
>
> == Regression Potential ==
>
> Low. This enables a config change for a derivative. The config is already
> enabled in the generic/master.
>
> == Test Case ==
>
> Ran "cranky updateconfigs" to make sure the config changes applied cleanly.
> Compile-tested all architectures for each series with this patch applied.
>
> Signed-off-by: Connor Kuehl <[hidden email]>
>
>
>
Applied to bionic+xenial/linux-kvm/master-next. Thanks.

-Stefan


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment