[SRU] [D/E/Unstable/OEM-OSP1-B] [PATCH 0/1] Add Intel Comet Lake ethernet support

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU] [D/E/Unstable/OEM-OSP1-B] [PATCH 0/1] Add Intel Comet Lake ethernet support

Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1848555

[Impact]
e1000e.ko doesn't load for Intel CML ethernet.

[Fix]
Add missing ID for the device.

[Test]
The driver loads and works once the ID is added.

[Regression Potential]
Minimal. Only adds some IDs, no functional change at all.

Sasha Neftin (1):
  e1000e: Add support for Comet Lake

 drivers/net/ethernet/intel/e1000e/hw.h     | 6 ++++++
 drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
 2 files changed, 12 insertions(+)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[D/E/Unstable/OEM-OSP1-B] [PATCH 1/1] e1000e: Add support for Comet Lake

Kai-Heng Feng
From: Sasha Neftin <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1848555

Add devices ID's for the next LOM generations that will be
available on the next Intel Client platform (Comet Lake)
This patch provides the initial support for these devices

Signed-off-by: Sasha Neftin <[hidden email]>
(cherry picked from commit bc2f297b47e74df31363e5c0a7eec083c9fc81d2 https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue)
Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/net/ethernet/intel/e1000e/hw.h     | 6 ++++++
 drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
 2 files changed, 12 insertions(+)

diff --git a/drivers/net/ethernet/intel/e1000e/hw.h b/drivers/net/ethernet/intel/e1000e/hw.h
index e3c71fd093ee..d3b566200174 100644
--- a/drivers/net/ethernet/intel/e1000e/hw.h
+++ b/drivers/net/ethernet/intel/e1000e/hw.h
@@ -86,6 +86,12 @@ struct e1000_hw;
 #define E1000_DEV_ID_PCH_ICP_I219_V8 0x15E0
 #define E1000_DEV_ID_PCH_ICP_I219_LM9 0x15E1
 #define E1000_DEV_ID_PCH_ICP_I219_V9 0x15E2
+#define E1000_DEV_ID_PCH_CMP_I219_LM10 0x0D4E
+#define E1000_DEV_ID_PCH_CMP_I219_V10 0x0D4F
+#define E1000_DEV_ID_PCH_CMP_I219_LM11 0x0D4C
+#define E1000_DEV_ID_PCH_CMP_I219_V11 0x0D4D
+#define E1000_DEV_ID_PCH_CMP_I219_LM12 0x0D53
+#define E1000_DEV_ID_PCH_CMP_I219_V12 0x0D55
 
 #define E1000_REVISION_4 4
 
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index d7d56e42a6aa..92a9c7ca8617 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -7567,6 +7567,12 @@ static const struct pci_device_id e1000_pci_tbl[] = {
  { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_V8), board_pch_cnp },
  { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_LM9), board_pch_cnp },
  { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_ICP_I219_V9), board_pch_cnp },
+ { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM10), board_pch_cnp },
+ { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V10), board_pch_cnp },
+ { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM11), board_pch_cnp },
+ { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V11), board_pch_cnp },
+ { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_LM12), board_pch_spt },
+ { PCI_VDEVICE(INTEL, E1000_DEV_ID_PCH_CMP_I219_V12), board_pch_spt },
 
  { 0, 0, 0, 0, 0, 0, 0 } /* terminate list */
 };
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED [OEM-OSP1-B] Re: [SRU] [D/E/Unstable/OEM-OSP1-B] [PATCH 0/1] Add Intel Comet Lake ethernet support

Timo Aaltonen-6
In reply to this post by Kai-Heng Feng
On 17.10.2019 20.48, Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1848555
>
> [Impact]
> e1000e.ko doesn't load for Intel CML ethernet.
>
> [Fix]
> Add missing ID for the device.
>
> [Test]
> The driver loads and works once the ID is added.
>
> [Regression Potential]
> Minimal. Only adds some IDs, no functional change at all.
>
> Sasha Neftin (1):
>   e1000e: Add support for Comet Lake
>
>  drivers/net/ethernet/intel/e1000e/hw.h     | 6 ++++++
>  drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
>  2 files changed, 12 insertions(+)

applied to osp1 oem-next, thanks


--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/cmt / APPLIED[Unstable]: [SRU] [D/E/Unstable/OEM-OSP1-B] [PATCH 0/1] Add Intel Comet Lake ethernet support

Seth Forshee
In reply to this post by Kai-Heng Feng
On Fri, Oct 18, 2019 at 01:48:34AM +0800, Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1848555
>
> [Impact]
> e1000e.ko doesn't load for Intel CML ethernet.
>
> [Fix]
> Add missing ID for the device.
>
> [Test]
> The driver loads and works once the ID is added.
>
> [Regression Potential]
> Minimal. Only adds some IDs, no functional change at all.

This is not upstream or in linux-next, so it should be marked as sauce.
With that fixed:

Acked-by: Seth Forshee <[hidden email]>

Applied to unstable/master, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU] [D/E/Unstable/OEM-OSP1-B] [PATCH 0/1] Add Intel Comet Lake ethernet support

Connor Kuehl
In reply to this post by Kai-Heng Feng
On 10/17/19 10:48 AM, Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1848555
>
> [Impact]
> e1000e.ko doesn't load for Intel CML ethernet.
>
> [Fix]
> Add missing ID for the device.
>
> [Test]
> The driver loads and works once the ID is added.
>
> [Regression Potential]
> Minimal. Only adds some IDs, no functional change at all.
>
> Sasha Neftin (1):
>    e1000e: Add support for Comet Lake
>
>   drivers/net/ethernet/intel/e1000e/hw.h     | 6 ++++++
>   drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
>   2 files changed, 12 insertions(+)
>

Acked-by: Connor Kuehl <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED(D,E): [SRU] [D/E/Unstable/OEM-OSP1-B] [PATCH 0/1] Add Intel Comet Lake ethernet support

Khaled Elmously
In reply to this post by Kai-Heng Feng
On 2019-10-18 01:48:34 , Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1848555
>
> [Impact]
> e1000e.ko doesn't load for Intel CML ethernet.
>
> [Fix]
> Add missing ID for the device.
>
> [Test]
> The driver loads and works once the ID is added.
>
> [Regression Potential]
> Minimal. Only adds some IDs, no functional change at all.
>
> Sasha Neftin (1):
>   e1000e: Add support for Comet Lake
>
>  drivers/net/ethernet/intel/e1000e/hw.h     | 6 ++++++
>  drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++
>  2 files changed, 12 insertions(+)
>
> --
> 2.17.1
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team