[SRU][D/OEM-OSP1-B/E][PATCH 0/3] alsa/hdmi: add icelake hdmi audio support for a Dell machine

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][D/OEM-OSP1-B/E][PATCH 0/3] alsa/hdmi: add icelake hdmi audio support for a Dell machine

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1836916

This patch is needed to be merged to oem-osp1-b kernel ASAP, since
our oem project is waiting for this patch.

And Since this patch is to support icl hdmi audio and it depends on
i915 to support icl first, and our bionic and oem-b kernel doesn't
support icl in their i915 driver, so these patchset doesn't work for
B/OEM-B, as a result, I don't send them for B/OEM-B.

And the 0001-xxx.patch is already in the kernel-v5.1, so EAON kernel
doesn't need to apply 0001-xxx.patch, only need to apply 0002 and 0003
to EAON kernel.

[Impact]
On a Dell icelake platform, the hdmi audio doesn't work at all, when users
plug hdmi cable, they can't find hdmi audio from gnome-sound-setting.

[Fix]
add icl hdmi audio id and related support patch to alsa driver.

[Test Case]
after applying the patchset, we plug hdmi cable and the hdmi audio shows up
in the sound-setting and works well, after unplugging the cable, the hdmi
audio disappears as expected.

[Regression Risk]
Low. this patchset is specific to a icl hdmi audio codec.



Jaroslav Kysela (1):
  ALSA: hda: hdmi - add Icelake support

Takashi Iwai (2):
  ALSA: hda/hdmi - Remove duplicated define
  ALSA: hda/hdmi - Fix i915 reverse port/pin mapping

 sound/pci/hda/patch_hdmi.c | 90 +++++++++++++++++++++++++++++---------
 1 file changed, 69 insertions(+), 21 deletions(-)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][D/OEM-OSP1-B/E][PATCH 1/3] ALSA: hda: hdmi - add Icelake support

Hui Wang
From: Jaroslav Kysela <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1836916

This is just a port of the ASoC Icelake HDMI codec code to the legacy
HDA driver with some cleanups.

ASoC commit 019033c854a20e10f691f6cc0e897df8817d9521:
  "ASoC: Intel: hdac_hdmi: add Icelake support"

Signed-off-by: Jaroslav Kysela <[hidden email]>
Cc: Bard liao <[hidden email]>
Cc: Pierre-Louis Bossart <[hidden email]>
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit b0d8bc50b9f221e3af76afe0473f7c171cebbb40)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/pci/hda/patch_hdmi.c | 67 +++++++++++++++++++++++++++++---------
 1 file changed, 51 insertions(+), 16 deletions(-)

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index af17265b829c..83d2faa673ab 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -57,10 +57,11 @@ MODULE_PARM_DESC(static_hdmi_pcm, "Don't restrict PCM parameters per ELD info");
 #define is_geminilake(codec) (((codec)->core.vendor_id == 0x8086280d) || \
  ((codec)->core.vendor_id == 0x80862800))
 #define is_cannonlake(codec) ((codec)->core.vendor_id == 0x8086280c)
+#define is_icelake(codec) ((codec)->core.vendor_id == 0x8086280f)
 #define is_haswell_plus(codec) (is_haswell(codec) || is_broadwell(codec) \
  || is_skylake(codec) || is_broxton(codec) \
- || is_kabylake(codec)) || is_geminilake(codec) \
- || is_cannonlake(codec)
+ || is_kabylake(codec) || is_geminilake(codec) \
+ || is_cannonlake(codec) || is_icelake(codec))
 #define is_valleyview(codec) ((codec)->core.vendor_id == 0x80862882)
 #define is_cherryview(codec) ((codec)->core.vendor_id == 0x80862883)
 #define is_valleyview_plus(codec) (is_valleyview(codec) || is_cherryview(codec))
@@ -181,6 +182,8 @@ struct hdmi_spec {
 
  struct hdac_chmap chmap;
  hda_nid_t vendor_nid;
+ const int *port_map;
+ int port_num;
 };
 
 #ifdef CONFIG_SND_HDA_COMPONENT
@@ -2417,12 +2420,11 @@ static void intel_haswell_fixup_connect_list(struct hda_codec *codec,
  snd_hda_override_conn_list(codec, nid, spec->num_cvts, spec->cvt_nids);
 }
 
-#define INTEL_VENDOR_NID 0x08
-#define INTEL_GLK_VENDOR_NID 0x0B
-#define INTEL_GET_VENDOR_VERB 0xf81
-#define INTEL_SET_VENDOR_VERB 0x781
-#define INTEL_EN_DP12 0x02 /* enable DP 1.2 features */
-#define INTEL_EN_ALL_PIN_CVTS 0x01 /* enable 2nd & 3rd pins and convertors */
+#define INTEL_GET_VENDOR_VERB 0xf81
+#define INTEL_GET_VENDOR_VERB 0xf81
+#define INTEL_SET_VENDOR_VERB 0x781
+#define INTEL_EN_DP12 0x02 /* enable DP 1.2 features */
+#define INTEL_EN_ALL_PIN_CVTS 0x01 /* enable 2nd & 3rd pins and convertors */
 
 static void intel_haswell_enable_all_pins(struct hda_codec *codec,
   bool update_tree)
@@ -2502,11 +2504,29 @@ static int intel_base_nid(struct hda_codec *codec)
 
 static int intel_pin2port(void *audio_ptr, int pin_nid)
 {
- int base_nid = intel_base_nid(audio_ptr);
+ struct hda_codec *codec = audio_ptr;
+ struct hdmi_spec *spec = codec->spec;
+ int base_nid, i;
 
- if (WARN_ON(pin_nid < base_nid || pin_nid >= base_nid + 3))
- return -1;
- return pin_nid - base_nid + 1; /* intel port is 1-based */
+ if (!spec->port_num) {
+ base_nid = intel_base_nid(codec);
+ if (WARN_ON(pin_nid < base_nid || pin_nid >= base_nid + 3))
+ return -1;
+ return pin_nid - base_nid + 1; /* intel port is 1-based */
+ }
+
+ /*
+ * looking for the pin number in the mapping table and return
+ * the index which indicate the port number
+ */
+ for (i = 0; i < spec->port_num; i++) {
+ if (pin_nid == spec->port_map[i])
+ return i + 1;
+ }
+
+ /* return -1 if pin number exceeds our expectation */
+ codec_info(codec, "Can't find the HDMI/DP port for pin %d\n", pin_nid);
+ return -1;
 }
 
 static void intel_pin_eld_notify(void *audio_ptr, int port, int pipe)
@@ -2607,7 +2627,8 @@ static int parse_intel_hdmi(struct hda_codec *codec)
 }
 
 /* Intel Haswell and onwards; audio component with eld notifier */
-static int intel_hsw_common_init(struct hda_codec *codec, hda_nid_t vendor_nid)
+static int intel_hsw_common_init(struct hda_codec *codec, hda_nid_t vendor_nid,
+ const int *port_map, int port_num)
 {
  struct hdmi_spec *spec;
  int err;
@@ -2619,6 +2640,8 @@ static int intel_hsw_common_init(struct hda_codec *codec, hda_nid_t vendor_nid)
  codec->dp_mst = true;
  spec->dyn_pcm_assign = true;
  spec->vendor_nid = vendor_nid;
+ spec->port_map = port_map;
+ spec->port_num = port_num;
 
  intel_haswell_enable_all_pins(codec, true);
  intel_haswell_fixup_enable_dp12(codec);
@@ -2637,12 +2660,23 @@ static int intel_hsw_common_init(struct hda_codec *codec, hda_nid_t vendor_nid)
 
 static int patch_i915_hsw_hdmi(struct hda_codec *codec)
 {
- return intel_hsw_common_init(codec, INTEL_VENDOR_NID);
+ return intel_hsw_common_init(codec, 0x08, NULL, 0);
 }
 
 static int patch_i915_glk_hdmi(struct hda_codec *codec)
 {
- return intel_hsw_common_init(codec, INTEL_GLK_VENDOR_NID);
+ return intel_hsw_common_init(codec, 0x0b, NULL, 0);
+}
+
+static int patch_i915_icl_hdmi(struct hda_codec *codec)
+{
+ /*
+ * pin to port mapping table where the value indicate the pin number and
+ * the index indicate the port number with 1 base.
+ */
+ static const int map[] = {0x4, 0x6, 0x8, 0xa, 0xb};
+
+ return intel_hsw_common_init(codec, 0x02, map, ARRAY_SIZE(map));
 }
 
 /* Intel Baytrail and Braswell; with eld notifier */
@@ -3885,6 +3919,7 @@ HDA_CODEC_ENTRY(0x11069f81, "VX900 HDMI/DP", patch_via_hdmi),
 HDA_CODEC_ENTRY(0x11069f84, "VX11 HDMI/DP", patch_generic_hdmi),
 HDA_CODEC_ENTRY(0x11069f85, "VX11 HDMI/DP", patch_generic_hdmi),
 HDA_CODEC_ENTRY(0x80860054, "IbexPeak HDMI", patch_i915_cpt_hdmi),
+HDA_CODEC_ENTRY(0x80862800, "Geminilake HDMI", patch_i915_glk_hdmi),
 HDA_CODEC_ENTRY(0x80862801, "Bearlake HDMI", patch_generic_hdmi),
 HDA_CODEC_ENTRY(0x80862802, "Cantiga HDMI", patch_generic_hdmi),
 HDA_CODEC_ENTRY(0x80862803, "Eaglelake HDMI", patch_generic_hdmi),
@@ -3898,7 +3933,7 @@ HDA_CODEC_ENTRY(0x8086280a, "Broxton HDMI", patch_i915_hsw_hdmi),
 HDA_CODEC_ENTRY(0x8086280b, "Kabylake HDMI", patch_i915_hsw_hdmi),
 HDA_CODEC_ENTRY(0x8086280c, "Cannonlake HDMI", patch_i915_glk_hdmi),
 HDA_CODEC_ENTRY(0x8086280d, "Geminilake HDMI", patch_i915_glk_hdmi),
-HDA_CODEC_ENTRY(0x80862800, "Geminilake HDMI", patch_i915_glk_hdmi),
+HDA_CODEC_ENTRY(0x8086280f, "Icelake HDMI", patch_i915_icl_hdmi),
 HDA_CODEC_ENTRY(0x80862880, "CedarTrail HDMI", patch_generic_hdmi),
 HDA_CODEC_ENTRY(0x80862882, "Valleyview2 HDMI", patch_i915_byt_hdmi),
 HDA_CODEC_ENTRY(0x80862883, "Braswell HDMI", patch_i915_byt_hdmi),
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][D/OEM-OSP1-B/E][PATCH 2/3] ALSA: hda/hdmi - Remove duplicated define

Hui Wang
In reply to this post by Hui Wang
From: Takashi Iwai <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1836916

INTEL_GET_VENDOR_VERB is defined twice identically.
Let's remove a superfluous line.

Fixes: b0d8bc50b9f2 ("ALSA: hda: hdmi - add Icelake support")
Cc: <[hidden email]>
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit eb4177116bf568a413c544eca3f4446cb4064be9
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/pci/hda/patch_hdmi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index 83d2faa673ab..c1d38b2251ea 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -2420,7 +2420,6 @@ static void intel_haswell_fixup_connect_list(struct hda_codec *codec,
  snd_hda_override_conn_list(codec, nid, spec->num_cvts, spec->cvt_nids);
 }
 
-#define INTEL_GET_VENDOR_VERB 0xf81
 #define INTEL_GET_VENDOR_VERB 0xf81
 #define INTEL_SET_VENDOR_VERB 0x781
 #define INTEL_EN_DP12 0x02 /* enable DP 1.2 features */
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][D/OEM-OSP1-B/E][PATCH 3/3] ALSA: hda/hdmi - Fix i915 reverse port/pin mapping

Hui Wang
In reply to this post by Hui Wang
From: Takashi Iwai <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1836916

The recent fix for Icelake HDMI codec introduced the mapping from pin
NID to the i915 gfx port number.  However, it forgot the reverse
mapping from the port number to the pin NID that is used in the ELD
notifier callback.  As a result, it's processed to a wrong widget and
gives a warning like
  snd_hda_codec_hdmi hdaudioC0D2: HDMI: pin nid 5 not registered

This patch corrects it with a proper reverse mapping function.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204133
Fixes: b0d8bc50b9f2 ("ALSA: hda: hdmi - add Icelake support")
Reviewed-by: Kai Vehmanen <[hidden email]>
Cc: <[hidden email]>
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit 3140aafb22edeab0cc41f15f53b12a118c0ac215
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/pci/hda/patch_hdmi.c | 24 +++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)

diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index c1d38b2251ea..b107a6154924 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -2528,18 +2528,32 @@ static int intel_pin2port(void *audio_ptr, int pin_nid)
  return -1;
 }
 
+static int intel_port2pin(struct hda_codec *codec, int port)
+{
+ struct hdmi_spec *spec = codec->spec;
+
+ if (!spec->port_num) {
+ /* we assume only from port-B to port-D */
+ if (port < 1 || port > 3)
+ return 0;
+ /* intel port is 1-based */
+ return port + intel_base_nid(codec) - 1;
+ }
+
+ if (port < 1 || port > spec->port_num)
+ return 0;
+ return spec->port_map[port - 1];
+}
+
 static void intel_pin_eld_notify(void *audio_ptr, int port, int pipe)
 {
  struct hda_codec *codec = audio_ptr;
  int pin_nid;
  int dev_id = pipe;
 
- /* we assume only from port-B to port-D */
- if (port < 1 || port > 3)
+ pin_nid = intel_port2pin(codec, port);
+ if (!pin_nid)
  return;
-
- pin_nid = port + intel_base_nid(codec) - 1; /* intel port is 1-based */
-
  /* skip notification during system suspend (but not in runtime PM);
  * the state will be updated at resume
  */
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [SRU][D/OEM-OSP1-B/E][PATCH 0/3] alsa/hdmi: add icelake hdmi audio support for a Dell machine

Stefan Bader-2
In reply to this post by Hui Wang
On 17.07.19 16:42, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1836916
>
> This patch is needed to be merged to oem-osp1-b kernel ASAP, since
> our oem project is waiting for this patch.
>
> And Since this patch is to support icl hdmi audio and it depends on
> i915 to support icl first, and our bionic and oem-b kernel doesn't
> support icl in their i915 driver, so these patchset doesn't work for
> B/OEM-B, as a result, I don't send them for B/OEM-B.
>
> And the 0001-xxx.patch is already in the kernel-v5.1, so EAON kernel
> doesn't need to apply 0001-xxx.patch, only need to apply 0002 and 0003
> to EAON kernel.
>
> [Impact]
> On a Dell icelake platform, the hdmi audio doesn't work at all, when users
> plug hdmi cable, they can't find hdmi audio from gnome-sound-setting.
>
> [Fix]
> add icl hdmi audio id and related support patch to alsa driver.
>
> [Test Case]
> after applying the patchset, we plug hdmi cable and the hdmi audio shows up
> in the sound-setting and works well, after unplugging the cable, the hdmi
> audio disappears as expected.
>
> [Regression Risk]
> Low. this patchset is specific to a icl hdmi audio codec.
>
>
>
> Jaroslav Kysela (1):
>   ALSA: hda: hdmi - add Icelake support
>
> Takashi Iwai (2):
>   ALSA: hda/hdmi - Remove duplicated define
>   ALSA: hda/hdmi - Fix i915 reverse port/pin mapping
>
>  sound/pci/hda/patch_hdmi.c | 90 +++++++++++++++++++++++++++++---------
>  1 file changed, 69 insertions(+), 21 deletions(-)
>
With 2/3 of a set coming from subsystem maintainers tip and not fully buying
into a low regression potential (it changes a driver which at least is shared
across similar HW and Intel is not unknown to break older stuff when adding new
stuff) I am wondering whether this really is Sru material...


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [SRU][D/OEM-OSP1-B/E][PATCH 0/3] alsa/hdmi: add icelake hdmi audio support for a Dell machine

Hui Wang

On 2019/7/19 下午4:42, Stefan Bader wrote:

> On 17.07.19 16:42, Hui Wang wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1836916
>>
>> This patch is needed to be merged to oem-osp1-b kernel ASAP, since
>> our oem project is waiting for this patch.
>>
>> And Since this patch is to support icl hdmi audio and it depends on
>> i915 to support icl first, and our bionic and oem-b kernel doesn't
>> support icl in their i915 driver, so these patchset doesn't work for
>> B/OEM-B, as a result, I don't send them for B/OEM-B.
>>
>> And the 0001-xxx.patch is already in the kernel-v5.1, so EAON kernel
>> doesn't need to apply 0001-xxx.patch, only need to apply 0002 and 0003
>> to EAON kernel.
>>
>> [Impact]
>> On a Dell icelake platform, the hdmi audio doesn't work at all, when users
>> plug hdmi cable, they can't find hdmi audio from gnome-sound-setting.
>>
>> [Fix]
>> add icl hdmi audio id and related support patch to alsa driver.
>>
>> [Test Case]
>> after applying the patchset, we plug hdmi cable and the hdmi audio shows up
>> in the sound-setting and works well, after unplugging the cable, the hdmi
>> audio disappears as expected.
>>
>> [Regression Risk]
>> Low. this patchset is specific to a icl hdmi audio codec.
>>
>>
>>
>> Jaroslav Kysela (1):
>>    ALSA: hda: hdmi - add Icelake support
>>
>> Takashi Iwai (2):
>>    ALSA: hda/hdmi - Remove duplicated define
>>    ALSA: hda/hdmi - Fix i915 reverse port/pin mapping
>>
>>   sound/pci/hda/patch_hdmi.c | 90 +++++++++++++++++++++++++++++---------
>>   1 file changed, 69 insertions(+), 21 deletions(-)
>>
> With 2/3 of a set coming from subsystem maintainers tip and not fully buying
> into a low regression potential (it changes a driver which at least is shared
> across similar HW and Intel is not unknown to break older stuff when adding new
> stuff) I am wondering whether this really is Sru material...

Our OEM project needs this patchset, otherwise the hdmi audio doesn't
work on Dell icl laptop.

The 0001 patch is specific to icl codec by adding the new codec id, and
the 0003 has no change  for codec  with port_num==0, that means there is
no change for non-icl codec after applying this patch.

If you think it is too early to merge these patches to generic kernel,
it is fine to drop them. let the OEM-OSP1-B merge them first.

Thanks



>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[E]/cmt: [SRU][D/OEM-OSP1-B/E][PATCH 0/3] alsa/hdmi: add icelake hdmi audio support for a Dell machine

Seth Forshee
In reply to this post by Hui Wang
On Wed, Jul 17, 2019 at 10:42:08PM +0800, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1836916
>
> This patch is needed to be merged to oem-osp1-b kernel ASAP, since
> our oem project is waiting for this patch.
>
> And Since this patch is to support icl hdmi audio and it depends on
> i915 to support icl first, and our bionic and oem-b kernel doesn't
> support icl in their i915 driver, so these patchset doesn't work for
> B/OEM-B, as a result, I don't send them for B/OEM-B.
>
> And the 0001-xxx.patch is already in the kernel-v5.1, so EAON kernel
> doesn't need to apply 0001-xxx.patch, only need to apply 0002 and 0003
> to EAON kernel.
>
> [Impact]
> On a Dell icelake platform, the hdmi audio doesn't work at all, when users
> plug hdmi cable, they can't find hdmi audio from gnome-sound-setting.
>
> [Fix]
> add icl hdmi audio id and related support patch to alsa driver.
>
> [Test Case]
> after applying the patchset, we plug hdmi cable and the hdmi audio shows up
> in the sound-setting and works well, after unplugging the cable, the hdmi
> audio disappears as expected.
>
> [Regression Risk]
> Low. this patchset is specific to a icl hdmi audio codec.

One of these patches is upstream but the others are not, so please
remember to include the development release!

I see that Stefan has reservations for these for stable, but they seem
appropriate for the development release, so I have applied them to
eoan/master-next.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/Cmnt: [SRU][D][PATCH 0/3] alsa/hdmi: add icelake hdmi audio support for a Dell machine

Stefan Bader-2
In reply to this post by Hui Wang
On 17.07.19 16:42, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1836916
>
> This patch is needed to be merged to oem-osp1-b kernel ASAP, since
> our oem project is waiting for this patch.
>
> And Since this patch is to support icl hdmi audio and it depends on
> i915 to support icl first, and our bionic and oem-b kernel doesn't
> support icl in their i915 driver, so these patchset doesn't work for
> B/OEM-B, as a result, I don't send them for B/OEM-B.
>
> And the 0001-xxx.patch is already in the kernel-v5.1, so EAON kernel
> doesn't need to apply 0001-xxx.patch, only need to apply 0002 and 0003
> to EAON kernel.
>
> [Impact]
> On a Dell icelake platform, the hdmi audio doesn't work at all, when users
> plug hdmi cable, they can't find hdmi audio from gnome-sound-setting.
>
> [Fix]
> add icl hdmi audio id and related support patch to alsa driver.
>
> [Test Case]
> after applying the patchset, we plug hdmi cable and the hdmi audio shows up
> in the sound-setting and works well, after unplugging the cable, the hdmi
> audio disappears as expected.
>
> [Regression Risk]
> Low. this patchset is specific to a icl hdmi audio codec.
>
>
The latter 2 patches are now upstream. So with updated sha1 references, I think
its ok now for disco.

>
> Jaroslav Kysela (1):
>   ALSA: hda: hdmi - add Icelake support
>
> Takashi Iwai (2):

commit eb4177116bf568a413c544eca3f4446cb4064be9
>   ALSA: hda/hdmi - Remove duplicated define
commit 3140aafb22edeab0cc41f15f53b12a118c0ac215
>   ALSA: hda/hdmi - Fix i915 reverse port/pin mapping
>
>  sound/pci/hda/patch_hdmi.c | 90 +++++++++++++++++++++++++++++---------
>  1 file changed, 69 insertions(+), 21 deletions(-)
>
Acked-by: Stefan Bader <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][D/OEM-OSP1-B/E][PATCH 0/3] alsa/hdmi: add icelake hdmi audio support for a Dell machine

Kleber Sacilotto de Souza
In reply to this post by Hui Wang
On 7/17/19 4:42 PM, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1836916
>
> This patch is needed to be merged to oem-osp1-b kernel ASAP, since
> our oem project is waiting for this patch.
>
> And Since this patch is to support icl hdmi audio and it depends on
> i915 to support icl first, and our bionic and oem-b kernel doesn't
> support icl in their i915 driver, so these patchset doesn't work for
> B/OEM-B, as a result, I don't send them for B/OEM-B.
>
> And the 0001-xxx.patch is already in the kernel-v5.1, so EAON kernel
> doesn't need to apply 0001-xxx.patch, only need to apply 0002 and 0003
> to EAON kernel.
>
> [Impact]
> On a Dell icelake platform, the hdmi audio doesn't work at all, when users
> plug hdmi cable, they can't find hdmi audio from gnome-sound-setting.
>
> [Fix]
> add icl hdmi audio id and related support patch to alsa driver.
>
> [Test Case]
> after applying the patchset, we plug hdmi cable and the hdmi audio shows up
> in the sound-setting and works well, after unplugging the cable, the hdmi
> audio disappears as expected.
>
> [Regression Risk]
> Low. this patchset is specific to a icl hdmi audio codec.
>
>
>
> Jaroslav Kysela (1):
>   ALSA: hda: hdmi - add Icelake support
>
> Takashi Iwai (2):
>   ALSA: hda/hdmi - Remove duplicated define
>   ALSA: hda/hdmi - Fix i915 reverse port/pin mapping
>
>  sound/pci/hda/patch_hdmi.c | 90 +++++++++++++++++++++++++++++---------
>  1 file changed, 69 insertions(+), 21 deletions(-)
>

With the sha1 references updated as mentioned by Stefan:

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[D]/cmnt: [SRU][D/OEM-OSP1-B/E][PATCH 0/3] alsa/hdmi: add icelake hdmi audio support for a Dell machine

Kleber Sacilotto de Souza
In reply to this post by Hui Wang
On 7/17/19 4:42 PM, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1836916
>
> This patch is needed to be merged to oem-osp1-b kernel ASAP, since
> our oem project is waiting for this patch.
>
> And Since this patch is to support icl hdmi audio and it depends on
> i915 to support icl first, and our bionic and oem-b kernel doesn't
> support icl in their i915 driver, so these patchset doesn't work for
> B/OEM-B, as a result, I don't send them for B/OEM-B.
>
> And the 0001-xxx.patch is already in the kernel-v5.1, so EAON kernel
> doesn't need to apply 0001-xxx.patch, only need to apply 0002 and 0003
> to EAON kernel.
>
> [Impact]
> On a Dell icelake platform, the hdmi audio doesn't work at all, when users
> plug hdmi cable, they can't find hdmi audio from gnome-sound-setting.
>
> [Fix]
> add icl hdmi audio id and related support patch to alsa driver.
>
> [Test Case]
> after applying the patchset, we plug hdmi cable and the hdmi audio shows up
> in the sound-setting and works well, after unplugging the cable, the hdmi
> audio disappears as expected.
>
> [Regression Risk]
> Low. this patchset is specific to a icl hdmi audio codec.
>
>
>
> Jaroslav Kysela (1):
>   ALSA: hda: hdmi - add Icelake support
>
> Takashi Iwai (2):
>   ALSA: hda/hdmi - Remove duplicated define
>   ALSA: hda/hdmi - Fix i915 reverse port/pin mapping
>
>  sound/pci/hda/patch_hdmi.c | 90 +++++++++++++++++++++++++++++---------
>  1 file changed, 69 insertions(+), 21 deletions(-)
>

Applied to disco/master-next branch, removing the additional
maintainer repo info from patches 2 and 3 (the sha1 was kept
the same).

Thanks,
Kleber


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team