[SRU][D][linux-kvm][PATCH] mm/zsmalloc.c: fix build when CONFIG_COMPACTION=n

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][D][linux-kvm][PATCH] mm/zsmalloc.c: fix build when CONFIG_COMPACTION=n

Andrea Righi
Fixes: 701d678599d0c1 ("mm/zsmalloc.c: fix race condition in zs_destroy_pool")
Link: http://lkml.kernel.org/r/201908251039.5oSbEEUT%25lkp@...
Reported-by: kbuild test robot <[hidden email]>
Cc: Sergey Senozhatsky <[hidden email]>
Cc: Henry Burns <[hidden email]>
Cc: Minchan Kim <[hidden email]>
Cc: Shakeel Butt <[hidden email]>
Cc: Jonathan Adams <[hidden email]>
Signed-off-by: Andrew Morton <[hidden email]>
Signed-off-by: Linus Torvalds <[hidden email]>
(cherry picked from commit 441e254cd40dc03beec3c650ce6ce6074bc6517f)
Signed-off-by: Andrea Righi <[hidden email]>
---
 mm/zsmalloc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 515b00801af2..7d62ef2daf83 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -2432,7 +2432,9 @@ struct zs_pool *zs_create_pool(const char *name)
  if (!pool->name)
  goto err;
 
+#ifdef CONFIG_COMPACTION
  init_waitqueue_head(&pool->migration_wait);
+#endif
 
  if (create_cache(pool))
  goto err;
--
2.20.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][D][linux-kvm][PATCH] mm/zsmalloc.c: fix build when CONFIG_COMPACTION=n

Colin Ian King-2
On 06/09/2019 16:47, Andrea Righi wrote:

> Fixes: 701d678599d0c1 ("mm/zsmalloc.c: fix race condition in zs_destroy_pool")
> Link: http://lkml.kernel.org/r/201908251039.5oSbEEUT%25lkp@...
> Reported-by: kbuild test robot <[hidden email]>
> Cc: Sergey Senozhatsky <[hidden email]>
> Cc: Henry Burns <[hidden email]>
> Cc: Minchan Kim <[hidden email]>
> Cc: Shakeel Butt <[hidden email]>
> Cc: Jonathan Adams <[hidden email]>
> Signed-off-by: Andrew Morton <[hidden email]>
> Signed-off-by: Linus Torvalds <[hidden email]>
> (cherry picked from commit 441e254cd40dc03beec3c650ce6ce6074bc6517f)
> Signed-off-by: Andrea Righi <[hidden email]>
> ---
>  mm/zsmalloc.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index 515b00801af2..7d62ef2daf83 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -2432,7 +2432,9 @@ struct zs_pool *zs_create_pool(const char *name)
>   if (!pool->name)
>   goto err;
>  
> +#ifdef CONFIG_COMPACTION
>   init_waitqueue_head(&pool->migration_wait);
> +#endif
>  
>   if (create_cache(pool))
>   goto err;
>
Thanks Andrea for the speedy turnaround.

Acked-by: Colin Ian King <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][D][linux-kvm][PATCH] mm/zsmalloc.c: fix build when CONFIG_COMPACTION=n

Sultan Alsawaf
In reply to this post by Andrea Righi
Acked-by: Sultan Alsawaf <[hidden email]>

On Fri, Sep 6, 2019, 8:48 AM Andrea Righi <[hidden email]> wrote:
Fixes: 701d678599d0c1 ("mm/zsmalloc.c: fix race condition in zs_destroy_pool")
Link: http://lkml.kernel.org/r/201908251039.5oSbEEUT%25lkp@...
Reported-by: kbuild test robot <[hidden email]>
Cc: Sergey Senozhatsky <[hidden email]>
Cc: Henry Burns <[hidden email]>
Cc: Minchan Kim <[hidden email]>
Cc: Shakeel Butt <[hidden email]>
Cc: Jonathan Adams <[hidden email]>
Signed-off-by: Andrew Morton <[hidden email]>
Signed-off-by: Linus Torvalds <[hidden email]>
(cherry picked from commit 441e254cd40dc03beec3c650ce6ce6074bc6517f)
Signed-off-by: Andrea Righi <[hidden email]>
---
 mm/zsmalloc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
index 515b00801af2..7d62ef2daf83 100644
--- a/mm/zsmalloc.c
+++ b/mm/zsmalloc.c
@@ -2432,7 +2432,9 @@ struct zs_pool *zs_create_pool(const char *name)
        if (!pool->name)
                goto err;

+#ifdef CONFIG_COMPACTION
        init_waitqueue_head(&pool->migration_wait);
+#endif

        if (create_cache(pool))
                goto err;
--
2.20.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK+comment: [SRU][D][linux-kvm][PATCH] mm/zsmalloc.c: fix build when CONFIG_COMPACTION=n

Thadeu Lima de Souza Cascardo-3
In reply to this post by Andrea Righi

Acked-by: Thadeu Lima de Souza Cascardo <[hidden email]>

Just shove the buglink there.

BugLink: https://bugs.launchpad.net/bugs/1843069

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU][D][linux-kvm][PATCH] mm/zsmalloc.c: fix build when CONFIG_COMPACTION=n

Stefan Bader-2
In reply to this post by Andrea Righi
On 06.09.19 17:47, Andrea Righi wrote:

> Fixes: 701d678599d0c1 ("mm/zsmalloc.c: fix race condition in zs_destroy_pool")
> Link: http://lkml.kernel.org/r/201908251039.5oSbEEUT%25lkp@...
> Reported-by: kbuild test robot <[hidden email]>
> Cc: Sergey Senozhatsky <[hidden email]>
> Cc: Henry Burns <[hidden email]>
> Cc: Minchan Kim <[hidden email]>
> Cc: Shakeel Butt <[hidden email]>
> Cc: Jonathan Adams <[hidden email]>
> Signed-off-by: Andrew Morton <[hidden email]>
> Signed-off-by: Linus Torvalds <[hidden email]>
> (cherry picked from commit 441e254cd40dc03beec3c650ce6ce6074bc6517f)
> Signed-off-by: Andrea Righi <[hidden email]>
> ---
This already was applied to disco/linux-kvm/master-next for the 2019.09.02
cycle. So just to have this documented in the mailing list.

-Stefan

>  mm/zsmalloc.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index 515b00801af2..7d62ef2daf83 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -2432,7 +2432,9 @@ struct zs_pool *zs_create_pool(const char *name)
>   if (!pool->name)
>   goto err;
>  
> +#ifdef CONFIG_COMPACTION
>   init_waitqueue_head(&pool->migration_wait);
> +#endif
>  
>   if (create_cache(pool))
>   goto err;
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment