[SRU] [F/G/H/U/OEM-5.10] [PATCH 0/1] Fix right sounds and mute/micmute LEDs for HP platforms

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU] [F/G/H/U/OEM-5.10] [PATCH 0/1] Fix right sounds and mute/micmute LEDs for HP platforms

Jeremy Szu
BugLink: https://bugs.launchpad.net/bugs/1910561

[Impact]
* Mute and micmute LED are not work accurately on HP ZBook Fury 15/17 G7
  Mobile Workstation when muting corresponding audio devices.
* The right channel of internal speaker has not sound.

[Fix]
Apply ALC285_FIXUP_HP_GPIO_AMP_INIT quirk to expose GPIOs for controlling
LEDs and initialing AMP.

[Test]
Built a test kernel with applying this patch, the mute/micmute LEDs are
work as expected.
The internal speaker could play the sounds from left and right channels.

[Where problems could occur]
This quirk is specific for these two platforms. It should not cause the
regression to other systems.

Jeremy Szu (1):
  ALSA: hda/realtek: fix right sounds and mute/micmute LEDs for HP
    machines

 sound/pci/hda/patch_realtek.c | 4 ++++
 1 file changed, 4 insertions(+)

--
2.29.2


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[PATCH 1/1] ALSA: hda/realtek: fix right sounds and mute/micmute LEDs for HP machines

Jeremy Szu
 * The HP ZBook Fury 15/17 G7 Mobile Workstation are using ALC285 codec
   which is using 0x04 to control mute LED and 0x01 to control micmute LED.

 * The right channel speaker is no sound and it needs to expose GPIO1 for
   initialing AMP.

Add quirks to support them.

Signed-off-by: Jeremy Szu <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 3c1d2a3fb1a4..dd82ff2bd5d6 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7970,6 +7970,10 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
  SND_PCI_QUIRK(0x103c, 0x8760, "HP", ALC285_FIXUP_HP_MUTE_LED),
  SND_PCI_QUIRK(0x103c, 0x877a, "HP", ALC285_FIXUP_HP_MUTE_LED),
  SND_PCI_QUIRK(0x103c, 0x877d, "HP", ALC236_FIXUP_HP_MUTE_LED),
+ SND_PCI_QUIRK(0x103c, 0x8780, "HP ZBook Fury 17 G7 Mobile Workstation",
+      ALC285_FIXUP_HP_GPIO_AMP_INIT),
+ SND_PCI_QUIRK(0x103c, 0x8783, "HP ZBook Fury 15 G7 Mobile Workstation",
+      ALC285_FIXUP_HP_GPIO_AMP_INIT),
  SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
  SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
  SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
--
2.29.2


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

NACK: [SRU] [F/G/H/U/OEM-5.10] [PATCH 0/1] Fix right sounds and mute/micmute LEDs for HP platforms

Jeremy Szu
In reply to this post by Jeremy Szu
Missing cherry-pick.

On Fri, Jan 8, 2021 at 12:36 AM Jeremy Szu <[hidden email]> wrote:
BugLink: https://bugs.launchpad.net/bugs/1910561

[Impact]
* Mute and micmute LED are not work accurately on HP ZBook Fury 15/17 G7
  Mobile Workstation when muting corresponding audio devices.
* The right channel of internal speaker has not sound.

[Fix]
Apply ALC285_FIXUP_HP_GPIO_AMP_INIT quirk to expose GPIOs for controlling
LEDs and initialing AMP.

[Test]
Built a test kernel with applying this patch, the mute/micmute LEDs are
work as expected.
The internal speaker could play the sounds from left and right channels.

[Where problems could occur]
This quirk is specific for these two platforms. It should not cause the
regression to other systems.

Jeremy Szu (1):
  ALSA: hda/realtek: fix right sounds and mute/micmute LEDs for HP
    machines

 sound/pci/hda/patch_realtek.c | 4 ++++
 1 file changed, 4 insertions(+)

--
2.29.2


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team


--
Sincerely,
Jeremy Su

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team