[SRU][F/G/H/U/OEM-5.10][PATCH 0/1] Fix right sounds and mute/micmute LEDs for HP platforms

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][F/G/H/U/OEM-5.10][PATCH 0/1] Fix right sounds and mute/micmute LEDs for HP platforms

Jeremy Szu
BugLink: https://bugs.launchpad.net/bugs/1910561

[Impact]
* Mute and micmute LED are not work accurately on HP ZBook Fury 15/17 G7
  Mobile Workstation when muting corresponding audio devices.
* The right channel of internal speaker has not sound.

[Fix]
Apply ALC285_FIXUP_HP_GPIO_AMP_INIT quirk to expose GPIOs for controlling
LEDs and initialing AMP.

[Test]
Built a test kernel with applying this patch, the mute/micmute LEDs are
work as expected.
The internal speaker could play the sounds from left and right channels.

[Where problems could occur]
This quirk is specific for these two platforms. It should not cause the
regression to other systems.

Jeremy Szu (1):
  ALSA: hda/realtek: fix right sounds and mute/micmute LEDs for HP
    machines

 sound/pci/hda/patch_realtek.c | 4 ++++
 1 file changed, 4 insertions(+)

--
2.29.2


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][F/G/H/U/OEM-5.10][PATCH 1/1] UBUNTU: SAUCE: ALSA: hda/realtek: fix right sounds and mute/micmute LEDs for HP machines

Jeremy Szu
 * The HP ZBook Fury 15/17 G7 Mobile Workstation are using ALC285 codec
   which is using 0x04 to control mute LED and 0x01 to control micmute LED.

 * The right channel speaker is no sound and it needs to expose GPIO1 for
   initialing AMP.

Add quirks to support them.

Signed-off-by: Jeremy Szu <[hidden email]>
Cc: <[hidden email]>
Link: https://lore.kernel.org/r/20210106130549.100532-1-jeremy.szu@...
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit 91bc156817a3c2007332b64b4f85c32aafbbbea6
 git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
Signed-off-by: Jeremy Szu <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 8616c5624870..f7a934d70db3 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7946,6 +7946,10 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
  SND_PCI_QUIRK(0x103c, 0x8760, "HP", ALC285_FIXUP_HP_MUTE_LED),
  SND_PCI_QUIRK(0x103c, 0x877a, "HP", ALC285_FIXUP_HP_MUTE_LED),
  SND_PCI_QUIRK(0x103c, 0x877d, "HP", ALC236_FIXUP_HP_MUTE_LED),
+ SND_PCI_QUIRK(0x103c, 0x8780, "HP ZBook Fury 17 G7 Mobile Workstation",
+      ALC285_FIXUP_HP_GPIO_AMP_INIT),
+ SND_PCI_QUIRK(0x103c, 0x8783, "HP ZBook Fury 15 G7 Mobile Workstation",
+      ALC285_FIXUP_HP_GPIO_AMP_INIT),
  SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
  SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
  SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC),
--
2.29.2


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED U: Re: [SRU][F/G/H/U/OEM-5.10][PATCH 0/1] Fix right sounds and mute/micmute LEDs for HP platforms

Paolo Pisati-5
In reply to this post by Jeremy Szu
On Fri, Jan 08, 2021 at 01:48:25AM +0800, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1910561

--
bye,
p.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/Cmnt: [SRU][F/G/H/U/OEM-5.10][PATCH 1/1] UBUNTU: SAUCE: ALSA: hda/realtek: fix right sounds and mute/micmute LEDs for HP machines

Stefan Bader-2
In reply to this post by Jeremy Szu
On 07.01.21 18:48, Jeremy Szu wrote:

>  * The HP ZBook Fury 15/17 G7 Mobile Workstation are using ALC285 codec
>    which is using 0x04 to control mute LED and 0x01 to control micmute LED.
>
>  * The right channel speaker is no sound and it needs to expose GPIO1 for
>    initialing AMP.
>
> Add quirks to support them.
>
> Signed-off-by: Jeremy Szu <[hidden email]>
> Cc: <[hidden email]>
> Link: https://lore.kernel.org/r/20210106130549.100532-1-jeremy.szu@...
> Signed-off-by: Takashi Iwai <[hidden email]>
> (cherry picked from commit 91bc156817a3c2007332b64b4f85c32aafbbbea6
>  git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git)
> Signed-off-by: Jeremy Szu <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>
> ---

This is by now upstream (v5.11-rc4) same SHA1, so reference to alsa git as well
as SAUCE can be dropped when applying. Generally, can't we just wait until
things are at least in linux-next before doing a SRU? That would make things
much simpler.

-Stefan

>  sound/pci/hda/patch_realtek.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 8616c5624870..f7a934d70db3 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -7946,6 +7946,10 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>   SND_PCI_QUIRK(0x103c, 0x8760, "HP", ALC285_FIXUP_HP_MUTE_LED),
>   SND_PCI_QUIRK(0x103c, 0x877a, "HP", ALC285_FIXUP_HP_MUTE_LED),
>   SND_PCI_QUIRK(0x103c, 0x877d, "HP", ALC236_FIXUP_HP_MUTE_LED),
> + SND_PCI_QUIRK(0x103c, 0x8780, "HP ZBook Fury 17 G7 Mobile Workstation",
> +      ALC285_FIXUP_HP_GPIO_AMP_INIT),
> + SND_PCI_QUIRK(0x103c, 0x8783, "HP ZBook Fury 15 G7 Mobile Workstation",
> +      ALC285_FIXUP_HP_GPIO_AMP_INIT),
>   SND_PCI_QUIRK(0x103c, 0x87f4, "HP", ALC287_FIXUP_HP_GPIO_LED),
>   SND_PCI_QUIRK(0x103c, 0x87f5, "HP", ALC287_FIXUP_HP_GPIO_LED),
>   SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC),
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][F/G/H/U/OEM-5.10][PATCH 0/1] Fix right sounds and mute/micmute LEDs for HP platforms

Khaled Elmously
In reply to this post by Jeremy Szu
Acked-by: Khalid Elmously <[hidden email]>


On 2021-01-08 01:48:25 , Jeremy Szu wrote:

> BugLink: https://bugs.launchpad.net/bugs/1910561
>
> [Impact]
> * Mute and micmute LED are not work accurately on HP ZBook Fury 15/17 G7
>   Mobile Workstation when muting corresponding audio devices.
> * The right channel of internal speaker has not sound.
>
> [Fix]
> Apply ALC285_FIXUP_HP_GPIO_AMP_INIT quirk to expose GPIOs for controlling
> LEDs and initialing AMP.
>
> [Test]
> Built a test kernel with applying this patch, the mute/micmute LEDs are
> work as expected.
> The internal speaker could play the sounds from left and right channels.
>
> [Where problems could occur]
> This quirk is specific for these two platforms. It should not cause the
> regression to other systems.
>
> Jeremy Szu (1):
>   ALSA: hda/realtek: fix right sounds and mute/micmute LEDs for HP
>     machines
>
>  sound/pci/hda/patch_realtek.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> --
> 2.29.2
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED(F,G)/cmt: [SRU][F/G/H/U/OEM-5.10][PATCH 0/1] Fix right sounds and mute/micmute LEDs for HP platforms

Khaled Elmously
In reply to this post by Jeremy Szu
Added BugLink to the commit-msg as it was missing.

Removed SAUCE tag and reference to sound.git repo as pointed out in the reviews.




On 2021-01-08 01:48:25 , Jeremy Szu wrote:

> BugLink: https://bugs.launchpad.net/bugs/1910561
>
> [Impact]
> * Mute and micmute LED are not work accurately on HP ZBook Fury 15/17 G7
>   Mobile Workstation when muting corresponding audio devices.
> * The right channel of internal speaker has not sound.
>
> [Fix]
> Apply ALC285_FIXUP_HP_GPIO_AMP_INIT quirk to expose GPIOs for controlling
> LEDs and initialing AMP.
>
> [Test]
> Built a test kernel with applying this patch, the mute/micmute LEDs are
> work as expected.
> The internal speaker could play the sounds from left and right channels.
>
> [Where problems could occur]
> This quirk is specific for these two platforms. It should not cause the
> regression to other systems.
>
> Jeremy Szu (1):
>   ALSA: hda/realtek: fix right sounds and mute/micmute LEDs for HP
>     machines
>
>  sound/pci/hda/patch_realtek.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> --
> 2.29.2
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team