Ubuntu › kernel-team

[SRU] [F/G/Unstable/OEM-5.10] [PATCH 0/1] Enable mute and micmute LED on HP EliteBook 850 G7

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 6 messages Options
Kai-Heng Feng
Reply | Threaded
Open this post in threaded view
♦
♦
|

[SRU] [F/G/Unstable/OEM-5.10] [PATCH 0/1] Enable mute and micmute LED on HP EliteBook 850 G7

Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1910102

[Impact]
Mute and micmute LED on HP EliteBook 850 G7 don't reflect the mute
status.

[Fix]
Apply an HDA quirk to let HP EliteBook 850 G7 use codec GPIO to control
LED.

[Test]
With the patch applied, both mute and micmute LED can be lit when audio
output or input is muted, respectively.

[Where problems could occur]
This quirk is specific to one model. It's not likely to regress other
systems.

Kai-Heng Feng (1):
  ALSA: hda/realtek: Enable mute and micmute LED on HP EliteBook 850 G7

 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

--
2.29.2


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Kai-Heng Feng
Reply | Threaded
Open this post in threaded view
♦
♦
|

[PATCH] ALSA: hda/realtek: Enable mute and micmute LED on HP EliteBook 850 G7

Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1910102

HP EliteBook 850 G7 uses the same GPIO pins as ALC285_FIXUP_HP_GPIO_LED
to enable mute and micmute LED. So apply the quirk to enable the LEDs.

Signed-off-by: Kai-Heng Feng <[hidden email]>
Cc: <[hidden email]>
Link: https://lore.kernel.org/r/20201230125636.45028-1-kai.heng.feng@...
Signed-off-by: Takashi Iwai <[hidden email]>
(cherry picked from commit a598098cc9737f612dbab52294433fc26c51cc9b linux-next)
Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 8616c5624870..0736b3270040 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7941,6 +7941,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
  SND_PCI_QUIRK(0x103c, 0x8497, "HP Envy x360", ALC269_FIXUP_HP_MUTE_LED_MIC3),
  SND_PCI_QUIRK(0x103c, 0x84e7, "HP Pavilion 15", ALC269_FIXUP_HP_MUTE_LED_MIC3),
  SND_PCI_QUIRK(0x103c, 0x869d, "HP", ALC236_FIXUP_HP_MUTE_LED),
+ SND_PCI_QUIRK(0x103c, 0x8724, "HP EliteBook 850 G7", ALC285_FIXUP_HP_GPIO_LED),
  SND_PCI_QUIRK(0x103c, 0x8729, "HP", ALC285_FIXUP_HP_GPIO_LED),
  SND_PCI_QUIRK(0x103c, 0x8736, "HP", ALC285_FIXUP_HP_GPIO_AMP_INIT),
  SND_PCI_QUIRK(0x103c, 0x8760, "HP", ALC285_FIXUP_HP_MUTE_LED),
--
2.29.2


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Paolo Pisati-5
Reply | Threaded
Open this post in threaded view
♦
♦
|

APPLIED U: Re: [PATCH] ALSA: hda/realtek: Enable mute and micmute LED on HP EliteBook 850 G7

Paolo Pisati-5
On Mon, Jan 04, 2021 at 10:46:19PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1910102

--
bye,
p.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Stefan Bader-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

ACK/Cmnt: [PATCH] ALSA: hda/realtek: Enable mute and micmute LED on HP EliteBook 850 G7

Stefan Bader-2
In reply to this post by Kai-Heng Feng
On 04.01.21 15:46, Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1910102
>
> HP EliteBook 850 G7 uses the same GPIO pins as ALC285_FIXUP_HP_GPIO_LED
> to enable mute and micmute LED. So apply the quirk to enable the LEDs.
>
> Signed-off-by: Kai-Heng Feng <[hidden email]>
> Cc: <[hidden email]>
> Link: https://lore.kernel.org/r/20201230125636.45028-1-kai.heng.feng@...
> Signed-off-by: Takashi Iwai <[hidden email]>
> (cherry picked from commit a598098cc9737f612dbab52294433fc26c51cc9b linux-next)
> Signed-off-by: Kai-Heng Feng <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>
> ---

Patch upstream now with same SHA1, linux-next can be dropped from cherry picked
line when applying.

-Stefan

>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 8616c5624870..0736b3270040 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -7941,6 +7941,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>   SND_PCI_QUIRK(0x103c, 0x8497, "HP Envy x360", ALC269_FIXUP_HP_MUTE_LED_MIC3),
>   SND_PCI_QUIRK(0x103c, 0x84e7, "HP Pavilion 15", ALC269_FIXUP_HP_MUTE_LED_MIC3),
>   SND_PCI_QUIRK(0x103c, 0x869d, "HP", ALC236_FIXUP_HP_MUTE_LED),
> + SND_PCI_QUIRK(0x103c, 0x8724, "HP EliteBook 850 G7", ALC285_FIXUP_HP_GPIO_LED),
>   SND_PCI_QUIRK(0x103c, 0x8729, "HP", ALC285_FIXUP_HP_GPIO_LED),
>   SND_PCI_QUIRK(0x103c, 0x8736, "HP", ALC285_FIXUP_HP_GPIO_AMP_INIT),
>   SND_PCI_QUIRK(0x103c, 0x8760, "HP", ALC285_FIXUP_HP_MUTE_LED),
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
William Breathitt Gray
Reply | Threaded
Open this post in threaded view
♦
♦
|

ACK: [PATCH] ALSA: hda/realtek: Enable mute and micmute LED on HP EliteBook 850 G7

William Breathitt Gray
In reply to this post by Kai-Heng Feng
On Mon, Jan 04, 2021 at 10:46:19PM +0800, Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1910102
>
> HP EliteBook 850 G7 uses the same GPIO pins as ALC285_FIXUP_HP_GPIO_LED
> to enable mute and micmute LED. So apply the quirk to enable the LEDs.
>
> Signed-off-by: Kai-Heng Feng <[hidden email]>
> Cc: <[hidden email]>
> Link: https://lore.kernel.org/r/20201230125636.45028-1-kai.heng.feng@...
> Signed-off-by: Takashi Iwai <[hidden email]>
> (cherry picked from commit a598098cc9737f612dbab52294433fc26c51cc9b linux-next)
> Signed-off-by: Kai-Heng Feng <[hidden email]>
Acked-by: William Breathitt Gray <[hidden email]>

> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 8616c5624870..0736b3270040 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -7941,6 +7941,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>   SND_PCI_QUIRK(0x103c, 0x8497, "HP Envy x360", ALC269_FIXUP_HP_MUTE_LED_MIC3),
>   SND_PCI_QUIRK(0x103c, 0x84e7, "HP Pavilion 15", ALC269_FIXUP_HP_MUTE_LED_MIC3),
>   SND_PCI_QUIRK(0x103c, 0x869d, "HP", ALC236_FIXUP_HP_MUTE_LED),
> + SND_PCI_QUIRK(0x103c, 0x8724, "HP EliteBook 850 G7", ALC285_FIXUP_HP_GPIO_LED),
>   SND_PCI_QUIRK(0x103c, 0x8729, "HP", ALC285_FIXUP_HP_GPIO_LED),
>   SND_PCI_QUIRK(0x103c, 0x8736, "HP", ALC285_FIXUP_HP_GPIO_AMP_INIT),
>   SND_PCI_QUIRK(0x103c, 0x8760, "HP", ALC285_FIXUP_HP_MUTE_LED),
> --
> 2.29.2
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Kelsey Skunberg
Reply | Threaded
Open this post in threaded view
♦
♦
|

APPLIED[F/G]: [SRU] [F/G/Unstable/OEM-5.10] [PATCH 0/1] Enable mute and micmute LED on HP EliteBook 850 G7

Kelsey Skunberg
In reply to this post by Kai-Heng Feng

Applied to F/G master-next. removed 'linux-next' for the cherry picked
line. thank you!

-Kelsey

On 2021-01-04 22:46:18 , Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1910102
>
> [Impact]
> Mute and micmute LED on HP EliteBook 850 G7 don't reflect the mute
> status.
>
> [Fix]
> Apply an HDA quirk to let HP EliteBook 850 G7 use codec GPIO to control
> LED.
>
> [Test]
> With the patch applied, both mute and micmute LED can be lit when audio
> output or input is muted, respectively.
>
> [Where problems could occur]
> This quirk is specific to one model. It's not likely to regress other
> systems.
>
> Kai-Heng Feng (1):
>   ALSA: hda/realtek: Enable mute and micmute LED on HP EliteBook 850 G7
>
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
>
> --
> 2.29.2
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Free forum by Nabble Edit this page