BugLink: https://bugs.launchpad.net/bugs/1908992
[Impact] Pointstick and its left right buttons don't work on EliteBook 859 G7. [Fix] Use the MT_CLS_WIN_8_FORCE_MULTI_INPUT so the usage collection for pointsitck and touchpad won't merge together. [Test] With the patch applied, pointstick and its left and right buttons start to work. [Where problems could occur] The quirk limits to one specific touchpad/pointstick combo, so regression would be highly unlikely. Kai-Heng Feng (1): HID: multitouch: Enable multi-input for Synaptics pointstick/touchpad device drivers/hid/hid-multitouch.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.29.2 -- kernel-team mailing list [hidden email] https://lists.ubuntu.com/mailman/listinfo/kernel-team |
BugLink: https://bugs.launchpad.net/bugs/1908992
Pointstick and its left/right buttons on HP EliteBook 850 G7 need multi-input quirk to work correctly. Signed-off-by: Kai-Heng Feng <[hidden email]> Signed-off-by: Jiri Kosina <[hidden email]> (cherry picked from commit c3d6eb6e54373f297313b65c1f2319d36914d579 linux-next) Signed-off-by: Kai-Heng Feng <[hidden email]> --- drivers/hid/hid-multitouch.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index d670bcd57bde..0743ef51d3b2 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -2054,6 +2054,10 @@ static const struct hid_device_id mt_devices[] = { HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8, USB_VENDOR_ID_SYNAPTICS, 0xce08) }, + { .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT, + HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8, + USB_VENDOR_ID_SYNAPTICS, 0xce09) }, + /* TopSeed panels */ { .driver_data = MT_CLS_TOPSEED, MT_USB_DEVICE(USB_VENDOR_ID_TOPSEED2, -- 2.29.2 -- kernel-team mailing list [hidden email] https://lists.ubuntu.com/mailman/listinfo/kernel-team |
On Tue, Jan 05, 2021 at 06:41:21PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1908992 > > Pointstick and its left/right buttons on HP EliteBook 850 G7 need > multi-input quirk to work correctly. > > Signed-off-by: Kai-Heng Feng <[hidden email]> > Signed-off-by: Jiri Kosina <[hidden email]> > (cherry picked from commit c3d6eb6e54373f297313b65c1f2319d36914d579 linux-next) > Signed-off-by: Kai-Heng Feng <[hidden email]> -- bye, p. -- kernel-team mailing list [hidden email] https://lists.ubuntu.com/mailman/listinfo/kernel-team |
In reply to this post by Kai-Heng Feng
On 05.01.21 11:41, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1908992 > > Pointstick and its left/right buttons on HP EliteBook 850 G7 need > multi-input quirk to work correctly. > > Signed-off-by: Kai-Heng Feng <[hidden email]> > Signed-off-by: Jiri Kosina <[hidden email]> > (cherry picked from commit c3d6eb6e54373f297313b65c1f2319d36914d579 linux-next) > Signed-off-by: Kai-Heng Feng <[hidden email]> Acked-by: Stefan Bader <[hidden email]> > --- Patch now upstream with same SHA1, linux-next can be dropped when applying. -Stefan > drivers/hid/hid-multitouch.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c > index d670bcd57bde..0743ef51d3b2 100644 > --- a/drivers/hid/hid-multitouch.c > +++ b/drivers/hid/hid-multitouch.c > @@ -2054,6 +2054,10 @@ static const struct hid_device_id mt_devices[] = { > HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8, > USB_VENDOR_ID_SYNAPTICS, 0xce08) }, > > + { .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT, > + HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8, > + USB_VENDOR_ID_SYNAPTICS, 0xce09) }, > + > /* TopSeed panels */ > { .driver_data = MT_CLS_TOPSEED, > MT_USB_DEVICE(USB_VENDOR_ID_TOPSEED2, > -- kernel-team mailing list [hidden email] https://lists.ubuntu.com/mailman/listinfo/kernel-team |
Free forum by Nabble | Edit this page |