Ubuntu › kernel-team

[SRU] [F/G/Unstable/OEM-5.10] [PATCH 0/1] Enable pointstick on HP EliteBook 850 G7

‹ Previous Topic Next Topic ›
 
classic Classic list List threaded Threaded
♦
♦
 6 messages Options
Kai-Heng Feng
Reply | Threaded
Open this post in threaded view
♦
♦
|

[SRU] [F/G/Unstable/OEM-5.10] [PATCH 0/1] Enable pointstick on HP EliteBook 850 G7

Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1908992

[Impact]
Pointstick and its left right buttons don't work on EliteBook 859 G7.

[Fix]
Use the MT_CLS_WIN_8_FORCE_MULTI_INPUT so the usage collection for
pointsitck and touchpad won't merge together.

[Test]
With the patch applied, pointstick and its left and right buttons start
to work.

[Where problems could occur]
The quirk limits to one specific touchpad/pointstick combo, so
regression would be highly unlikely.

Kai-Heng Feng (1):
  HID: multitouch: Enable multi-input for Synaptics pointstick/touchpad
    device

 drivers/hid/hid-multitouch.c | 4 ++++
 1 file changed, 4 insertions(+)

--
2.29.2


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Kai-Heng Feng
Reply | Threaded
Open this post in threaded view
♦
♦
|

[PATCH 1/1] HID: multitouch: Enable multi-input for Synaptics pointstick/touchpad device

Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1908992

Pointstick and its left/right buttons on HP EliteBook 850 G7 need
multi-input quirk to work correctly.

Signed-off-by: Kai-Heng Feng <[hidden email]>
Signed-off-by: Jiri Kosina <[hidden email]>
(cherry picked from commit c3d6eb6e54373f297313b65c1f2319d36914d579 linux-next)
Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/hid/hid-multitouch.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index d670bcd57bde..0743ef51d3b2 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -2054,6 +2054,10 @@ static const struct hid_device_id mt_devices[] = {
  HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
  USB_VENDOR_ID_SYNAPTICS, 0xce08) },
 
+ { .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT,
+ HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
+ USB_VENDOR_ID_SYNAPTICS, 0xce09) },
+
  /* TopSeed panels */
  { .driver_data = MT_CLS_TOPSEED,
  MT_USB_DEVICE(USB_VENDOR_ID_TOPSEED2,
--
2.29.2


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Paolo Pisati-5
Reply | Threaded
Open this post in threaded view
♦
♦
|

APPLIED U: Re: [PATCH 1/1] HID: multitouch: Enable multi-input for Synaptics pointstick/touchpad device

Paolo Pisati-5
On Tue, Jan 05, 2021 at 06:41:21PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1908992
>
> Pointstick and its left/right buttons on HP EliteBook 850 G7 need
> multi-input quirk to work correctly.
>
> Signed-off-by: Kai-Heng Feng <[hidden email]>
> Signed-off-by: Jiri Kosina <[hidden email]>
> (cherry picked from commit c3d6eb6e54373f297313b65c1f2319d36914d579 linux-next)
> Signed-off-by: Kai-Heng Feng <[hidden email]>

--
bye,
p.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Stefan Bader-2
Reply | Threaded
Open this post in threaded view
♦
♦
|

ACK/Cmnt: [PATCH 1/1] HID: multitouch: Enable multi-input for Synaptics pointstick/touchpad device

Stefan Bader-2
In reply to this post by Kai-Heng Feng
On 05.01.21 11:41, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1908992
>
> Pointstick and its left/right buttons on HP EliteBook 850 G7 need
> multi-input quirk to work correctly.
>
> Signed-off-by: Kai-Heng Feng <[hidden email]>
> Signed-off-by: Jiri Kosina <[hidden email]>
> (cherry picked from commit c3d6eb6e54373f297313b65c1f2319d36914d579 linux-next)
> Signed-off-by: Kai-Heng Feng <[hidden email]>
Acked-by: Stefan Bader <[hidden email]>
> ---

Patch now upstream with same SHA1, linux-next can be dropped when applying.

-Stefan

>  drivers/hid/hid-multitouch.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index d670bcd57bde..0743ef51d3b2 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -2054,6 +2054,10 @@ static const struct hid_device_id mt_devices[] = {
>   HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
>   USB_VENDOR_ID_SYNAPTICS, 0xce08) },
>  
> + { .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT,
> + HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
> + USB_VENDOR_ID_SYNAPTICS, 0xce09) },
> +
>   /* TopSeed panels */
>   { .driver_data = MT_CLS_TOPSEED,
>   MT_USB_DEVICE(USB_VENDOR_ID_TOPSEED2,
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
William Breathitt Gray
Reply | Threaded
Open this post in threaded view
♦
♦
|

ACK: [PATCH 1/1] HID: multitouch: Enable multi-input for Synaptics pointstick/touchpad device

William Breathitt Gray
In reply to this post by Kai-Heng Feng
On Tue, Jan 05, 2021 at 06:41:21PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1908992
>
> Pointstick and its left/right buttons on HP EliteBook 850 G7 need
> multi-input quirk to work correctly.
>
> Signed-off-by: Kai-Heng Feng <[hidden email]>
> Signed-off-by: Jiri Kosina <[hidden email]>
> (cherry picked from commit c3d6eb6e54373f297313b65c1f2319d36914d579 linux-next)
> Signed-off-by: Kai-Heng Feng <[hidden email]>

Acked-by: William Breathitt Gray <[hidden email]>

> ---
>  drivers/hid/hid-multitouch.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index d670bcd57bde..0743ef51d3b2 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -2054,6 +2054,10 @@ static const struct hid_device_id mt_devices[] = {
>   HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
>   USB_VENDOR_ID_SYNAPTICS, 0xce08) },
>  
> + { .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT,
> + HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
> + USB_VENDOR_ID_SYNAPTICS, 0xce09) },
> +
>   /* TopSeed panels */
>   { .driver_data = MT_CLS_TOPSEED,
>   MT_USB_DEVICE(USB_VENDOR_ID_TOPSEED2,
> --
> 2.29.2
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Kelsey Skunberg
Reply | Threaded
Open this post in threaded view
♦
♦
|

APPLIED[F/G]: [SRU] [F/G/Unstable/OEM-5.10] [PATCH 0/1] Enable pointstick on HP EliteBook 850 G7

Kelsey Skunberg
In reply to this post by Kai-Heng Feng
Applied to F/G master-next. Removed 'linux-next' in the cherry-pick
line. Thank you!

-Kelsey

On 2021-01-05 18:41:20 , Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1908992
>
> [Impact]
> Pointstick and its left right buttons don't work on EliteBook 859 G7.
>
> [Fix]
> Use the MT_CLS_WIN_8_FORCE_MULTI_INPUT so the usage collection for
> pointsitck and touchpad won't merge together.
>
> [Test]
> With the patch applied, pointstick and its left and right buttons start
> to work.
>
> [Where problems could occur]
> The quirk limits to one specific touchpad/pointstick combo, so
> regression would be highly unlikely.
>
> Kai-Heng Feng (1):
>   HID: multitouch: Enable multi-input for Synaptics pointstick/touchpad
>     device
>
>  drivers/hid/hid-multitouch.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> --
> 2.29.2
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Free forum by Nabble Edit this page