[SRU] [F/G/Unstable/OEM-5.6] [PATCH 0/3] Enable brightness control on HP DreamColor panel

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU] [F/G/Unstable/OEM-5.6] [PATCH 0/3] Enable brightness control on HP DreamColor panel

Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1898865

[Impact]
Brightness on HP DreamColor panel, which can be found on new HP Zbook
Studio, cannot be changed.

[Fix]
Let DRM know the panel should use DPCD instead of PWM to control
backlight.

[Test]
With the patch applied, we can change the brightness on HP Zbook Studio.

[Regression Potential]
If there's any panel in the quirk list depends on checking brightness
control capability then this change will have an impact. However it's
rather unlikely because it defeats the purpose of the quirk list.

Kai-Heng Feng (2):
  UBUNTU: SAUCE: drm/i915/dpcd_bl: Skip testing control capability with
    force DPCD quirk
  UBUNTU: SAUCE: drm/dp: HP DreamColor panel brigntness fix

Lyude Paul (1):
  drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam

 drivers/gpu/drm/drm_dp_helper.c                       | 1 +
 drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 9 ++++++---
 2 files changed, 7 insertions(+), 3 deletions(-)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[F/OEM-5.6] [PATCH 1/3] drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam

Kai-Heng Feng
From: Lyude Paul <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1898865

Looks like I accidentally made it so you couldn't force DPCD backlight
support on, whoops. Fix that.

Signed-off-by: Lyude Paul <[hidden email]>
Fixes: 17f5d57915be ("drm/i915: Force DPCD backlight mode on X1 Extreme 2nd Gen 4K AMOLED panel")
Cc: Adam Jackson <[hidden email]>
Cc: Jani Nikula <[hidden email]>
Cc: Joonas Lahtinen <[hidden email]>
Cc: "Ville Syrjälä" <[hidden email]>
Signed-off-by: Jani Nikula <[hidden email]>
Link: https://patchwork.freedesktop.org/patch/msgid/20200413214407.1851002-1-lyude@...
Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
index af6ee93aaed4..50abd2afc133 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
@@ -339,6 +339,7 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector)
  */
  if (dev_priv->vbt.backlight.type !=
     INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE &&
+    i915_modparams.enable_dpcd_backlight != 1 &&
     !drm_dp_has_quirk(&intel_dp->desc, intel_dp->edid_quirks,
       DP_QUIRK_FORCE_DPCD_BACKLIGHT)) {
  DRM_DEV_INFO(dev->dev,
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[F] [PATCH 2/3] UBUNTU: SAUCE: drm/i915/dpcd_bl: Skip testing control capability with force DPCD quirk

Kai-Heng Feng
In reply to this post by Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1898865

HP DreamColor panel needs to be controlled via AUX interface. However,
it has both DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP and
DP_EDP_BACKLIGHT_BRIGHTNESS_PWM_PIN_CAP set, so it fails to pass
intel_dp_aux_display_control_capable() test.

Skip the test if the panel has force DPCD quirk.

Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
index 50abd2afc133..10b4ad9cc8a8 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
@@ -328,9 +328,13 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector)
  struct intel_dp *intel_dp = enc_to_intel_dp(&intel_connector->encoder->base);
  struct drm_device *dev = intel_connector->base.dev;
  struct drm_i915_private *dev_priv = to_i915(dev);
+ bool force_dpcd;
+
+ force_dpcd = drm_dp_has_quirk(&intel_dp->desc, intel_dp->edid_quirks,
+      DP_QUIRK_FORCE_DPCD_BACKLIGHT);
 
  if (i915_modparams.enable_dpcd_backlight == 0 ||
-    !intel_dp_aux_display_control_capable(intel_connector))
+    (!force_dpcd && !intel_dp_aux_display_control_capable(intel_connector)))
  return -ENODEV;
 
  /*
@@ -339,9 +343,7 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector)
  */
  if (dev_priv->vbt.backlight.type !=
     INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE &&
-    i915_modparams.enable_dpcd_backlight != 1 &&
-    !drm_dp_has_quirk(&intel_dp->desc, intel_dp->edid_quirks,
-      DP_QUIRK_FORCE_DPCD_BACKLIGHT)) {
+    i915_modparams.enable_dpcd_backlight != 1 && !force_dpcd) {
  DRM_DEV_INFO(dev->dev,
      "Panel advertises DPCD backlight support, but "
      "VBT disagrees. If your backlight controls "
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[G] [PATCH 2/3] UBUNTU: SAUCE: drm/i915/dpcd_bl: Skip testing control capability with force DPCD quirk

Kai-Heng Feng
In reply to this post by Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1898865

HP DreamColor panel needs to be controlled via AUX interface. However,
it has both DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP and
DP_EDP_BACKLIGHT_BRIGHTNESS_PWM_PIN_CAP set, so it fails to pass
intel_dp_aux_display_control_capable() test.

Skip the test if the panel has force DPCD quirk.

Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
index 0722540d64ad..790fe8be2162 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
@@ -347,9 +347,13 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector)
  struct intel_panel *panel = &intel_connector->panel;
  struct intel_dp *intel_dp = enc_to_intel_dp(intel_connector->encoder);
  struct drm_i915_private *i915 = dp_to_i915(intel_dp);
+ bool force_dpcd;
+
+ force_dpcd = drm_dp_has_quirk(&intel_dp->desc, intel_dp->edid_quirks,
+      DP_QUIRK_FORCE_DPCD_BACKLIGHT);
 
  if (i915_modparams.enable_dpcd_backlight == 0 ||
-    !intel_dp_aux_display_control_capable(intel_connector))
+    (!force_dpcd && !intel_dp_aux_display_control_capable(intel_connector)))
  return -ENODEV;
 
  /*
@@ -358,9 +362,7 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector)
  */
  if (i915->vbt.backlight.type !=
     INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE &&
-    i915_modparams.enable_dpcd_backlight != 1 &&
-    !drm_dp_has_quirk(&intel_dp->desc, intel_dp->edid_quirks,
-      DP_QUIRK_FORCE_DPCD_BACKLIGHT)) {
+    i915_modparams.enable_dpcd_backlight != 1 && !force_dpcd) {
  drm_info(&i915->drm,
  "Panel advertises DPCD backlight support, but "
  "VBT disagrees. If your backlight controls "
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[Unstable] [PATCH 2/3] UBUNTU: SAUCE: drm/i915/dpcd_bl: Skip testing control capability with force DPCD quirk

Kai-Heng Feng
In reply to this post by Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1898865

HP DreamColor panel needs to be controlled via AUX interface. However,
it has both DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP and
DP_EDP_BACKLIGHT_BRIGHTNESS_PWM_PIN_CAP set, so it fails to pass
intel_dp_aux_display_control_capable() test.

Skip the test if the panel has force DPCD quirk.

Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
index acbd7eb66cbe..acf2e1c65290 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
@@ -347,9 +347,13 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector)
  struct intel_panel *panel = &intel_connector->panel;
  struct intel_dp *intel_dp = enc_to_intel_dp(intel_connector->encoder);
  struct drm_i915_private *i915 = dp_to_i915(intel_dp);
+ bool force_dpcd;
+
+ force_dpcd = drm_dp_has_quirk(&intel_dp->desc, intel_dp->edid_quirks,
+      DP_QUIRK_FORCE_DPCD_BACKLIGHT);
 
  if (i915->params.enable_dpcd_backlight == 0 ||
-    !intel_dp_aux_display_control_capable(intel_connector))
+    (!force_dpcd && !intel_dp_aux_display_control_capable(intel_connector)))
  return -ENODEV;
 
  /*
@@ -358,9 +362,7 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector)
  */
  if (i915->vbt.backlight.type !=
     INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE &&
-    i915->params.enable_dpcd_backlight != 1 &&
-    !drm_dp_has_quirk(&intel_dp->desc, intel_dp->edid_quirks,
-      DP_QUIRK_FORCE_DPCD_BACKLIGHT)) {
+    i915->params.enable_dpcd_backlight != 1 && !force_dpcd) {
  drm_info(&i915->drm,
  "Panel advertises DPCD backlight support, but "
  "VBT disagrees. If your backlight controls "
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[OEM-5.6] [PATCH 2/3] UBUNTU: SAUCE: drm/i915/dpcd_bl: Skip testing control capability with force DPCD quirk

Kai-Heng Feng
In reply to this post by Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1898865

HP DreamColor panel needs to be controlled via AUX interface. However,
it has both DP_EDP_BACKLIGHT_BRIGHTNESS_AUX_SET_CAP and
DP_EDP_BACKLIGHT_BRIGHTNESS_PWM_PIN_CAP set, so it fails to pass
intel_dp_aux_display_control_capable() test.

Skip the test if the panel has force DPCD quirk.

Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
index cf6389a7bb7f..7be2e4261fc1 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c
@@ -329,9 +329,13 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector)
  struct intel_dp *intel_dp = enc_to_intel_dp(intel_connector->encoder);
  struct drm_device *dev = intel_connector->base.dev;
  struct drm_i915_private *dev_priv = to_i915(dev);
+ bool force_dpcd;
+
+ force_dpcd = drm_dp_has_quirk(&intel_dp->desc, intel_dp->edid_quirks,
+      DP_QUIRK_FORCE_DPCD_BACKLIGHT);
 
  if (i915_modparams.enable_dpcd_backlight == 0 ||
-    !intel_dp_aux_display_control_capable(intel_connector))
+    (!force_dpcd && !intel_dp_aux_display_control_capable(intel_connector)))
  return -ENODEV;
 
  /*
@@ -340,9 +344,7 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *intel_connector)
  */
  if (dev_priv->vbt.backlight.type !=
     INTEL_BACKLIGHT_VESA_EDP_AUX_INTERFACE &&
-    i915_modparams.enable_dpcd_backlight != 1 &&
-    !drm_dp_has_quirk(&intel_dp->desc, intel_dp->edid_quirks,
-      DP_QUIRK_FORCE_DPCD_BACKLIGHT)) {
+    i915_modparams.enable_dpcd_backlight != 1 && !force_dpcd) {
  DRM_DEV_INFO(dev->dev,
      "Panel advertises DPCD backlight support, but "
      "VBT disagrees. If your backlight controls "
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[F/OEM-5.6] [PATCH 3/3] UBUNTU: SAUCE: drm/dp: HP DreamColor panel brigntness fix

Kai-Heng Feng
In reply to this post by Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1898865

HP DreamColor panel, which is used by new HP ZBook Studio, needs to use
DPCD to control brightness.

Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/gpu/drm/drm_dp_helper.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index d9c9fed0a4c8..3964b82aedf9 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -1337,6 +1337,7 @@ static const struct edid_quirk edid_quirk_list[] = {
  */
  { MFG(0x06, 0xaf), PROD_ID(0x9b, 0x32), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
  { MFG(0x06, 0xaf), PROD_ID(0xeb, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
+ { MFG(0x30, 0xe4), PROD_ID(0x61, 0x06), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
  { MFG(0x4d, 0x10), PROD_ID(0xc7, 0x14), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
  { MFG(0x4d, 0x10), PROD_ID(0xe6, 0x14), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
  { MFG(0x4c, 0x83), PROD_ID(0x47, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[G/Unstable] [PATCH 3/3] UBUNTU: SAUCE: drm/dp: HP DreamColor panel brigntness fix

Kai-Heng Feng
In reply to this post by Kai-Heng Feng
BugLink: https://bugs.launchpad.net/bugs/1898865

HP DreamColor panel, which is used by new HP ZBook Studio, needs to use
DPCD to control brightness.

Signed-off-by: Kai-Heng Feng <[hidden email]>
---
 drivers/gpu/drm/drm_dp_helper.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
index a8f6f93e5fad..c8b70b52b4d9 100644
--- a/drivers/gpu/drm/drm_dp_helper.c
+++ b/drivers/gpu/drm/drm_dp_helper.c
@@ -1317,6 +1317,7 @@ static const struct edid_quirk edid_quirk_list[] = {
  */
  { MFG(0x06, 0xaf), PROD_ID(0x9b, 0x32), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
  { MFG(0x06, 0xaf), PROD_ID(0xeb, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
+ { MFG(0x30, 0xe4), PROD_ID(0x61, 0x06), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
  { MFG(0x4d, 0x10), PROD_ID(0xc7, 0x14), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
  { MFG(0x4d, 0x10), PROD_ID(0xe6, 0x14), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
  { MFG(0x4c, 0x83), PROD_ID(0x47, 0x41), BIT(DP_QUIRK_FORCE_DPCD_BACKLIGHT) },
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/Cmnt: [SRU] [F/G/Unstable/OEM-5.6] [PATCH 0/3] Enable brightness control on HP DreamColor panel

Stefan Bader-2
In reply to this post by Kai-Heng Feng
On 07.10.20 13:53, Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1898865
>
> [Impact]
> Brightness on HP DreamColor panel, which can be found on new HP Zbook
> Studio, cannot be changed.
>
> [Fix]
> Let DRM know the panel should use DPCD instead of PWM to control
> backlight.
>
> [Test]
> With the patch applied, we can change the brightness on HP Zbook Studio.
>
> [Regression Potential]
> If there's any panel in the quirk list depends on checking brightness
> control capability then this change will have an impact. However it's
> rather unlikely because it defeats the purpose of the quirk list.
>
> Kai-Heng Feng (2):
>   UBUNTU: SAUCE: drm/i915/dpcd_bl: Skip testing control capability with
>     force DPCD quirk
>   UBUNTU: SAUCE: drm/dp: HP DreamColor panel brigntness fix
>
> Lyude Paul (1):
>   drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam
>
>  drivers/gpu/drm/drm_dp_helper.c                       | 1 +
>  drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 9 ++++++---
>  2 files changed, 7 insertions(+), 3 deletions(-)
>
For Focal I am not really happy to ack because it seems to add a lot of new
SAUCE which could mean it is not accepted upstream or is rather new that there
was not much baking time. All things that do not really comply with the concept
of a stable release.

Though the first patch now is upstream:

commit d082119f4277ff4a63e44d293864aa9f2112b217
Author: Lyude Paul <[hidden email]>
Date:   Mon Apr 13 17:44:06 2020 -0400
    drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam

So the following should be put before your sign-off when things get committed:

(cherry picked from commit d7fb38ae36a2dc97924b075ad1d1a88792777ea9)
Signed-off-by: Rodrigo Vivi <[hidden email]>

(cherry picked from commit d082119f4277ff4a63e44d293864aa9f2112b217)
Signed-off-by: ...

The other two patches, at least they appear harmless enough, are you planning on
upstreaming those?

For now, as this looks isolated enough...

Acked-by: Stefan Bader <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: ACK/Cmnt: [SRU] [F/G/Unstable/OEM-5.6] [PATCH 0/3] Enable brightness control on HP DreamColor panel

Kai-Heng Feng


> On Oct 8, 2020, at 17:07, Stefan Bader <[hidden email]> wrote:
>
> On 07.10.20 13:53, Kai-Heng Feng wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1898865
>>
>> [Impact]
>> Brightness on HP DreamColor panel, which can be found on new HP Zbook
>> Studio, cannot be changed.
>>
>> [Fix]
>> Let DRM know the panel should use DPCD instead of PWM to control
>> backlight.
>>
>> [Test]
>> With the patch applied, we can change the brightness on HP Zbook Studio.
>>
>> [Regression Potential]
>> If there's any panel in the quirk list depends on checking brightness
>> control capability then this change will have an impact. However it's
>> rather unlikely because it defeats the purpose of the quirk list.
>>
>> Kai-Heng Feng (2):
>>  UBUNTU: SAUCE: drm/i915/dpcd_bl: Skip testing control capability with
>>    force DPCD quirk
>>  UBUNTU: SAUCE: drm/dp: HP DreamColor panel brigntness fix
>>
>> Lyude Paul (1):
>>  drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam
>>
>> drivers/gpu/drm/drm_dp_helper.c                       | 1 +
>> drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 9 ++++++---
>> 2 files changed, 7 insertions(+), 3 deletions(-)
>>
> For Focal I am not really happy to ack because it seems to add a lot of new
> SAUCE which could mean it is not accepted upstream or is rather new that there
> was not much baking time. All things that do not really comply with the concept
> of a stable release.

I hope users who want to stick to GA kernel can get fixes too.

>
> Though the first patch now is upstream:
>
> commit d082119f4277ff4a63e44d293864aa9f2112b217
> Author: Lyude Paul <[hidden email]>
> Date:   Mon Apr 13 17:44:06 2020 -0400
>    drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam
>
> So the following should be put before your sign-off when things get committed:
>
> (cherry picked from commit d7fb38ae36a2dc97924b075ad1d1a88792777ea9)
> Signed-off-by: Rodrigo Vivi <[hidden email]>
>
> (cherry picked from commit d082119f4277ff4a63e44d293864aa9f2112b217)
> Signed-off-by: ...
>
> The other two patches, at least they appear harmless enough, are you planning on
> upstreaming those?

Yes, and it's under review. Will send another SRU if upstream version is different to this one.

Kai-Heng

>
> For now, as this looks isolated enough...
>
> Acked-by: Stefan Bader <[hidden email]>
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: ACK/Cmnt: [SRU] [F/G/Unstable/OEM-5.6] [PATCH 0/3] Enable brightness control on HP DreamColor panel

Stefan Bader-2
On 08.10.20 11:15, Kai-Heng Feng wrote:

>
>
>> On Oct 8, 2020, at 17:07, Stefan Bader <[hidden email]> wrote:
>>
>> On 07.10.20 13:53, Kai-Heng Feng wrote:
>>> BugLink: https://bugs.launchpad.net/bugs/1898865
>>>
>>> [Impact]
>>> Brightness on HP DreamColor panel, which can be found on new HP Zbook
>>> Studio, cannot be changed.
>>>
>>> [Fix]
>>> Let DRM know the panel should use DPCD instead of PWM to control
>>> backlight.
>>>
>>> [Test]
>>> With the patch applied, we can change the brightness on HP Zbook Studio.
>>>
>>> [Regression Potential]
>>> If there's any panel in the quirk list depends on checking brightness
>>> control capability then this change will have an impact. However it's
>>> rather unlikely because it defeats the purpose of the quirk list.
>>>
>>> Kai-Heng Feng (2):
>>>  UBUNTU: SAUCE: drm/i915/dpcd_bl: Skip testing control capability with
>>>    force DPCD quirk
>>>  UBUNTU: SAUCE: drm/dp: HP DreamColor panel brigntness fix
>>>
>>> Lyude Paul (1):
>>>  drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam
>>>
>>> drivers/gpu/drm/drm_dp_helper.c                       | 1 +
>>> drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 9 ++++++---
>>> 2 files changed, 7 insertions(+), 3 deletions(-)
>>>
>> For Focal I am not really happy to ack because it seems to add a lot of new
>> SAUCE which could mean it is not accepted upstream or is rather new that there
>> was not much baking time. All things that do not really comply with the concept
>> of a stable release.
>
> I hope users who want to stick to GA kernel can get fixes too.
Yes, of course. This was not so much about the change itself but more about the
timing. I understand this causes more work but I think a staged approach (first
oem and devel and later stable) would be better. In this case it is probably too
simple to be a risk but as you say it might become a different approach upstream
and so we should avoid back and forth.

-Stefan

>
>>
>> Though the first patch now is upstream:
>>
>> commit d082119f4277ff4a63e44d293864aa9f2112b217
>> Author: Lyude Paul <[hidden email]>
>> Date:   Mon Apr 13 17:44:06 2020 -0400
>>    drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam
>>
>> So the following should be put before your sign-off when things get committed:
>>
>> (cherry picked from commit d7fb38ae36a2dc97924b075ad1d1a88792777ea9)
>> Signed-off-by: Rodrigo Vivi <[hidden email]>
>>
>> (cherry picked from commit d082119f4277ff4a63e44d293864aa9f2112b217)
>> Signed-off-by: ...
>>
>> The other two patches, at least they appear harmless enough, are you planning on
>> upstreaming those?
>
> Yes, and it's under review. Will send another SRU if upstream version is different to this one.
>
> Kai-Heng
>
>>
>> For now, as this looks isolated enough...
>>
>> Acked-by: Stefan Bader <[hidden email]>
>>
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK/cmnt: [SRU] [F/G/Unstable/OEM-5.6] [PATCH 0/3] Enable brightness control on HP DreamColor panel

Kleber Souza
In reply to this post by Kai-Heng Feng
On 07.10.20 13:53, Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1898865
>
> [Impact]
> Brightness on HP DreamColor panel, which can be found on new HP Zbook
> Studio, cannot be changed.
>
> [Fix]
> Let DRM know the panel should use DPCD instead of PWM to control
> backlight.
>
> [Test]
> With the patch applied, we can change the brightness on HP Zbook Studio.
>
> [Regression Potential]
> If there's any panel in the quirk list depends on checking brightness
> control capability then this change will have an impact. However it's
> rather unlikely because it defeats the purpose of the quirk list.
>
> Kai-Heng Feng (2):
>   UBUNTU: SAUCE: drm/i915/dpcd_bl: Skip testing control capability with
>     force DPCD quirk
>   UBUNTU: SAUCE: drm/dp: HP DreamColor panel brigntness fix
>
> Lyude Paul (1):
>   drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam
>
>  drivers/gpu/drm/drm_dp_helper.c                       | 1 +
>  drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 9 ++++++---
>  2 files changed, 7 insertions(+), 3 deletions(-)
>

With the (cherry picked from ...) line added as pointed out by
Stefan:

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: ACK/Cmnt: [SRU] [F/G/Unstable/OEM-5.6] [PATCH 0/3] Enable brightness control on HP DreamColor panel

Kai-Heng Feng
In reply to this post by Stefan Bader-2


> On Oct 8, 2020, at 17:27, Stefan Bader <[hidden email]> wrote:
>
> On 08.10.20 11:15, Kai-Heng Feng wrote:
>>
>>
>>> On Oct 8, 2020, at 17:07, Stefan Bader <[hidden email]> wrote:
>>>
>>> On 07.10.20 13:53, Kai-Heng Feng wrote:
>>>> BugLink: https://bugs.launchpad.net/bugs/1898865
>>>>
>>>> [Impact]
>>>> Brightness on HP DreamColor panel, which can be found on new HP Zbook
>>>> Studio, cannot be changed.
>>>>
>>>> [Fix]
>>>> Let DRM know the panel should use DPCD instead of PWM to control
>>>> backlight.
>>>>
>>>> [Test]
>>>> With the patch applied, we can change the brightness on HP Zbook Studio.
>>>>
>>>> [Regression Potential]
>>>> If there's any panel in the quirk list depends on checking brightness
>>>> control capability then this change will have an impact. However it's
>>>> rather unlikely because it defeats the purpose of the quirk list.
>>>>
>>>> Kai-Heng Feng (2):
>>>> UBUNTU: SAUCE: drm/i915/dpcd_bl: Skip testing control capability with
>>>>   force DPCD quirk
>>>> UBUNTU: SAUCE: drm/dp: HP DreamColor panel brigntness fix
>>>>
>>>> Lyude Paul (1):
>>>> drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam
>>>>
>>>> drivers/gpu/drm/drm_dp_helper.c                       | 1 +
>>>> drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 9 ++++++---
>>>> 2 files changed, 7 insertions(+), 3 deletions(-)
>>>>
>>> For Focal I am not really happy to ack because it seems to add a lot of new
>>> SAUCE which could mean it is not accepted upstream or is rather new that there
>>> was not much baking time. All things that do not really comply with the concept
>>> of a stable release.
>>
>> I hope users who want to stick to GA kernel can get fixes too.
>
> Yes, of course. This was not so much about the change itself but more about the
> timing. I understand this causes more work but I think a staged approach (first
> oem and devel and later stable) would be better. In this case it is probably too
> simple to be a risk but as you say it might become a different approach upstream
> and so we should avoid back and forth.

Ok, will see if I can manage to do that next time...

Kai-Heng

>
> -Stefan
>
>>
>>>
>>> Though the first patch now is upstream:
>>>
>>> commit d082119f4277ff4a63e44d293864aa9f2112b217
>>> Author: Lyude Paul <[hidden email]>
>>> Date:   Mon Apr 13 17:44:06 2020 -0400
>>>   drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam
>>>
>>> So the following should be put before your sign-off when things get committed:
>>>
>>> (cherry picked from commit d7fb38ae36a2dc97924b075ad1d1a88792777ea9)
>>> Signed-off-by: Rodrigo Vivi <[hidden email]>
>>>
>>> (cherry picked from commit d082119f4277ff4a63e44d293864aa9f2112b217)
>>> Signed-off-by: ...
>>>
>>> The other two patches, at least they appear harmless enough, are you planning on
>>> upstreaming those?
>>
>> Yes, and it's under review. Will send another SRU if upstream version is different to this one.
>>
>> Kai-Heng
>>
>>>
>>> For now, as this looks isolated enough...
>>>
>>> Acked-by: Stefan Bader <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED[G/Unstable]: [SRU] [F/G/Unstable/OEM-5.6] [PATCH 0/3] Enable brightness control on HP DreamColor panel

Seth Forshee
In reply to this post by Kai-Heng Feng
On Wed, Oct 07, 2020 at 07:53:56PM +0800, Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1898865
>
> [Impact]
> Brightness on HP DreamColor panel, which can be found on new HP Zbook
> Studio, cannot be changed.
>
> [Fix]
> Let DRM know the panel should use DPCD instead of PWM to control
> backlight.
>
> [Test]
> With the patch applied, we can change the brightness on HP Zbook Studio.
>
> [Regression Potential]
> If there's any panel in the quirk list depends on checking brightness
> control capability then this change will have an impact. However it's
> rather unlikely because it defeats the purpose of the quirk list.

Applied to groovy/master-next and unstable/master, thanks!

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED [OEM-5.6] Re: [SRU] [F/G/Unstable/OEM-5.6] [PATCH 0/3] Enable brightness control on HP DreamColor panel

Timo Aaltonen-6
In reply to this post by Kai-Heng Feng
On 7.10.2020 14.53, Kai-Heng Feng wrote:

> BugLink: https://bugs.launchpad.net/bugs/1898865
>
> [Impact]
> Brightness on HP DreamColor panel, which can be found on new HP Zbook
> Studio, cannot be changed.
>
> [Fix]
> Let DRM know the panel should use DPCD instead of PWM to control
> backlight.
>
> [Test]
> With the patch applied, we can change the brightness on HP Zbook Studio.
>
> [Regression Potential]
> If there's any panel in the quirk list depends on checking brightness
> control capability then this change will have an impact. However it's
> rather unlikely because it defeats the purpose of the quirk list.
>
> Kai-Heng Feng (2):
>    UBUNTU: SAUCE: drm/i915/dpcd_bl: Skip testing control capability with
>      force DPCD quirk
>    UBUNTU: SAUCE: drm/dp: HP DreamColor panel brigntness fix
>
> Lyude Paul (1):
>    drm/i915/dpcd_bl: Unbreak enable_dpcd_backlight modparam
>
>   drivers/gpu/drm/drm_dp_helper.c                       | 1 +
>   drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 9 ++++++---
>   2 files changed, 7 insertions(+), 3 deletions(-)
>

applied to oem-5.6, thanks


--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team