[SRU][OEM-5.6][PATCH 0/1] alsa/hda: The front Mic doesn't work on a HP machine

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][OEM-5.6][PATCH 0/1] alsa/hda: The front Mic doesn't work on a HP machine

Jeremy Szu
BugLink: https://bugs.launchpad.net/bugs/1899508

This fix is only for oem-5.6 kernel, other kernels will merge this
patch with stable update. Our oem project needs this patch to be merged
ASAP.

[Impact]
When using a HP machine, after plugging the headset at front jack,
there is no any input device shows.

[Fix]
The codec of the HP ZCentrol is alc671 and it needs to override the pin
configuration to enable the headset mic.
This patch is going to be merged by upstream, now backport it to
oem-5.6 kernel.

[Test Case]
Boot the system, plug a headset and check the gnome-control-center,
the Mic is active in the UI, and record the sound, it could record
the sound.

[Regression Risk]
Low, this patch is to add a platform specific quirk to override pin
configuration and already tested in this HP machine.

Jeremy Szu (1):
  UBUNTU: SAUCE: ALSA: hda/realtek - The front Mic on a HP machine doesn't work

 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

--
2.28.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][OEM-5.6][PATCH 1/1] UBUNTU: SAUCE: ALSA: hda/realtek - The front Mic on a HP machine doesn't work

Jeremy Szu
BugLink: https://bugs.launchpad.net/bugs/1899508

On a HP ZCentral, the front Mic could not be detected.

The codec of the HP ZCentrol is alc671 and it needs to override the pin
configuration to enable the headset mic.

Signed-off-by: Jeremy Szu <[hidden email]>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index b44219859d82..44144470ef5f 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9311,6 +9311,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = {
  SND_PCI_QUIRK(0x1028, 0x0698, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE),
  SND_PCI_QUIRK(0x1028, 0x069f, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE),
  SND_PCI_QUIRK(0x103c, 0x1632, "HP RP5800", ALC662_FIXUP_HP_RP5800),
+ SND_PCI_QUIRK(0x103c, 0x873e, "HP", ALC671_FIXUP_HP_HEADSET_MIC2),
  SND_PCI_QUIRK(0x1043, 0x1080, "Asus UX501VW", ALC668_FIXUP_HEADSET_MODE),
  SND_PCI_QUIRK(0x1043, 0x11cd, "Asus N550", ALC662_FIXUP_ASUS_Nx50),
  SND_PCI_QUIRK(0x1043, 0x13df, "Asus N550JX", ALC662_FIXUP_BASS_1A),
--
2.28.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/cmnt: [SRU][OEM-5.6][PATCH 1/1] UBUNTU: SAUCE: ALSA: hda/realtek - The front Mic on a HP machine doesn't work

Kleber Souza
On 13.10.20 09:04, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1899508
>
> On a HP ZCentral, the front Mic could not be detected.
>
> The codec of the HP ZCentrol is alc671 and it needs to override the pin
> configuration to enable the headset mic.
>
> Signed-off-by: Jeremy Szu <[hidden email]>

Hi Jeremy,

Do you have a link to the upstream submission for reference? It would be
good to have a reference to the upstream discussion if we have it.
Apart from that the patch looks good.

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index b44219859d82..44144470ef5f 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9311,6 +9311,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = {
>   SND_PCI_QUIRK(0x1028, 0x0698, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE),
>   SND_PCI_QUIRK(0x1028, 0x069f, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE),
>   SND_PCI_QUIRK(0x103c, 0x1632, "HP RP5800", ALC662_FIXUP_HP_RP5800),
> + SND_PCI_QUIRK(0x103c, 0x873e, "HP", ALC671_FIXUP_HP_HEADSET_MIC2),
>   SND_PCI_QUIRK(0x1043, 0x1080, "Asus UX501VW", ALC668_FIXUP_HEADSET_MODE),
>   SND_PCI_QUIRK(0x1043, 0x11cd, "Asus N550", ALC662_FIXUP_ASUS_Nx50),
>   SND_PCI_QUIRK(0x1043, 0x13df, "Asus N550JX", ALC662_FIXUP_BASS_1A),
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: ACK/cmnt: [SRU][OEM-5.6][PATCH 1/1] UBUNTU: SAUCE: ALSA: hda/realtek - The front Mic on a HP machine doesn't work

Jeremy Szu
Hi Kleber,

Thanks for quick response.
Here is upstream link:

On Tue, Oct 13, 2020 at 3:40 PM Kleber Souza <[hidden email]> wrote:
On 13.10.20 09:04, Jeremy Szu wrote:
> BugLink: https://bugs.launchpad.net/bugs/1899508
>
> On a HP ZCentral, the front Mic could not be detected.
>
> The codec of the HP ZCentrol is alc671 and it needs to override the pin
> configuration to enable the headset mic.
>
> Signed-off-by: Jeremy Szu <[hidden email]>

Hi Jeremy,

Do you have a link to the upstream submission for reference? It would be
good to have a reference to the upstream discussion if we have it.
Apart from that the patch looks good.

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index b44219859d82..44144470ef5f 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9311,6 +9311,7 @@ static const struct snd_pci_quirk alc662_fixup_tbl[] = {
>       SND_PCI_QUIRK(0x1028, 0x0698, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE),
>       SND_PCI_QUIRK(0x1028, 0x069f, "Dell", ALC668_FIXUP_DELL_MIC_NO_PRESENCE),
>       SND_PCI_QUIRK(0x103c, 0x1632, "HP RP5800", ALC662_FIXUP_HP_RP5800),
> +     SND_PCI_QUIRK(0x103c, 0x873e, "HP", ALC671_FIXUP_HP_HEADSET_MIC2),
>       SND_PCI_QUIRK(0x1043, 0x1080, "Asus UX501VW", ALC668_FIXUP_HEADSET_MODE),
>       SND_PCI_QUIRK(0x1043, 0x11cd, "Asus N550", ALC662_FIXUP_ASUS_Nx50),
>       SND_PCI_QUIRK(0x1043, 0x13df, "Asus N550JX", ALC662_FIXUP_BASS_1A),
>



--
Sincerely,
Jeremy Su

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED Re: [SRU][OEM-5.6][PATCH 0/1] alsa/hda: The front Mic doesn't work on a HP machine

Timo Aaltonen-6
In reply to this post by Jeremy Szu
On 13.10.2020 10.04, Jeremy Szu wrote:

> BugLink: https://bugs.launchpad.net/bugs/1899508
>
> This fix is only for oem-5.6 kernel, other kernels will merge this
> patch with stable update. Our oem project needs this patch to be merged
> ASAP.
>
> [Impact]
> When using a HP machine, after plugging the headset at front jack,
> there is no any input device shows.
>
> [Fix]
> The codec of the HP ZCentrol is alc671 and it needs to override the pin
> configuration to enable the headset mic.
> This patch is going to be merged by upstream, now backport it to
> oem-5.6 kernel.
>
> [Test Case]
> Boot the system, plug a headset and check the gnome-control-center,
> the Mic is active in the UI, and record the sound, it could record
> the sound.
>
> [Regression Risk]
> Low, this patch is to add a platform specific quirk to override pin
> configuration and already tested in this HP machine.
>
> Jeremy Szu (1):
>    UBUNTU: SAUCE: ALSA: hda/realtek - The front Mic on a HP machine doesn't work
>
>   sound/pci/hda/patch_realtek.c | 1 +
>   1 file changed, 1 insertion(+)
>

as discussed elsewhere, this is fine for oem-5.6, the other kernels will
be handled by another submission as the upstream commit didn't come with
cc: stable.

applied to oem-5.6, thanks


--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team