[SRU][OEM-B-OSP1][PATCH RESEND 0/1] drm/i915: revert the patch of "set disable_power_well=0 for icl temporarily"

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][OEM-B-OSP1][PATCH RESEND 0/1] drm/i915: revert the patch of "set disable_power_well=0 for icl temporarily"

Hui Wang
BugLink: http://bugs.launchpad.net/bugs/1839950

[Impact]
We sent the patch to set disable_power_well=0, this is
because we found sometimes the hdmi audio driver printed out the timeout
errors when accessing the codec. But after the fix of #1847192 is
merged, this issue will not happen anymore, so this patch is useless now,
and it add power consumption to graphic drivers, let us revert this patch.


[Fix]
Revert the patch.

[Test Case]
Tested on the new icl laptops, we have not reproduce the timeout errors,
and The PC can enter PC10.

[Regression Risk]
Low. We have done many tests.

Hui Wang (1):
  Revert "UBUNTU: SAUCE: i915: set disable_power_well=0 for icl
    temporarily"

 drivers/gpu/drm/i915/intel_runtime_pm.c | 5 -----
 1 file changed, 5 deletions(-)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][OEM-B-OSP1][PATCH RESEND 1/1] Revert "UBUNTU: SAUCE: i915: set disable_power_well=0 for icl temporarily"

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1839950

This reverts commit 63361ff9a85dca6bb493638e1fffcff38b755702.

After applying the fix of #1847192, we can't reproduce the hdmi audio
issue anymore on the icl laptop even without disable_power_well=0,
and disable_power_well=0 will prevent the CPU from entering PC10 power
state, let us revert this patch.

Signed-off-by: Hui Wang <[hidden email]>
---
 drivers/gpu/drm/i915/intel_runtime_pm.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index cbe3ac3003c2..a4cd90251491 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -3037,11 +3037,6 @@ static int
 sanitize_disable_power_well_option(const struct drm_i915_private *dev_priv,
    int disable_power_well)
 {
- struct pci_dev *pdev = dev_priv->drm.pdev;
- /* icl hdmi audio needs to set disable_power_well=0 temporarily, will remove it later */
- if ((pdev->device == 0x8a56) || (pdev->device == 0x8a52))
- return 0;
-
  if (disable_power_well >= 0)
  return !!disable_power_well;
 
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/Cmnt: [SRU][OEM-B-OSP1][PATCH RESEND 1/1] Revert "UBUNTU: SAUCE: i915: set disable_power_well=0 for icl temporarily"

Connor Kuehl
On 10/9/19 9:17 PM, Hui Wang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1839950
>
> This reverts commit 63361ff9a85dca6bb493638e1fffcff38b755702.
>
> After applying the fix of #1847192, we can't reproduce the hdmi audio
> issue anymore on the icl laptop even without disable_power_well=0,
> and disable_power_well=0 will prevent the CPU from entering PC10 power
> state, let us revert this patch.
>
> Signed-off-by: Hui Wang <[hidden email]>

Does something else need to be addressed for Comment #1 on the bug
report? I think LP: #1847192 has been applied to OSP1 according to its
LP tasks.

Acked-by: Connor Kuehl <[hidden email]>

> ---
>   drivers/gpu/drm/i915/intel_runtime_pm.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
> index cbe3ac3003c2..a4cd90251491 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> @@ -3037,11 +3037,6 @@ static int
>   sanitize_disable_power_well_option(const struct drm_i915_private *dev_priv,
>     int disable_power_well)
>   {
> - struct pci_dev *pdev = dev_priv->drm.pdev;
> - /* icl hdmi audio needs to set disable_power_well=0 temporarily, will remove it later */
> - if ((pdev->device == 0x8a56) || (pdev->device == 0x8a52))
> - return 0;
> -
>   if (disable_power_well >= 0)
>   return !!disable_power_well;
>  
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED Re: [SRU][OEM-B-OSP1][PATCH RESEND 0/1] drm/i915: revert the patch of "set disable_power_well=0 for icl temporarily"

Timo Aaltonen-6
In reply to this post by Hui Wang
On 10.10.2019 7.17, Hui Wang wrote:

> BugLink: http://bugs.launchpad.net/bugs/1839950
>
> [Impact]
> We sent the patch to set disable_power_well=0, this is
> because we found sometimes the hdmi audio driver printed out the timeout
> errors when accessing the codec. But after the fix of #1847192 is
> merged, this issue will not happen anymore, so this patch is useless now,
> and it add power consumption to graphic drivers, let us revert this patch.
>
>
> [Fix]
> Revert the patch.
>
> [Test Case]
> Tested on the new icl laptops, we have not reproduce the timeout errors,
> and The PC can enter PC10.
>
> [Regression Risk]
> Low. We have done many tests.
>
> Hui Wang (1):
>   Revert "UBUNTU: SAUCE: i915: set disable_power_well=0 for icl
>     temporarily"
>
>  drivers/gpu/drm/i915/intel_runtime_pm.c | 5 -----
>  1 file changed, 5 deletions(-)

applied to ops1 oem-next, thanks!


--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team