[SRU OEM-B][PATCH] UBUNTU: SAUCE: Bluetooth: btrsi: fix l2test data transfer issue

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU OEM-B][PATCH] UBUNTU: SAUCE: Bluetooth: btrsi: fix l2test data transfer issue

Siva Rebbagondla-2
From: Siva Rebbagondla <[hidden email]>

BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1781895
 
Observed bluetooth l2test is getting failed as skb->data is having some
extra bytes rather than expected size, which is Incorrect. Hence, removed
redundant bytes from skb using skb_trim().

Signed-off-by: Siva Rebbagondla <[hidden email]>
---
 drivers/bluetooth/btrsi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btrsi.c b/drivers/bluetooth/btrsi.c
index 3ef62b9..866b232 100644
--- a/drivers/bluetooth/btrsi.c
+++ b/drivers/bluetooth/btrsi.c
@@ -83,6 +83,7 @@ static int rsi_hci_send_pkt(struct hci_dev *hdev, struct sk_buff *skb)
  skb_pull(skb, PTR_ALIGN(skb->data,
  RSI_SDIO_DMA_ALIGN) - skb->data);
  memmove(skb->data, skb_data, skb_len);
+ skb_trim(skb, skb_len);
  }
  }
 
--
2.7.4


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU OEM-B][PATCH] UBUNTU: SAUCE: Bluetooth: btrsi: fix l2test data transfer issue

Shrirang Bagul
On Mon, 2018-07-16 at 16:01 +0530, Siva Rebbagondla wrote:
> From: Siva Rebbagondla <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1781895
>  
> Observed bluetooth l2test is getting failed as skb->data is having some
> extra bytes rather than expected size, which is Incorrect. Hence, removed
> redundant bytes from skb using skb_trim().
>
> Signed-off-by: Siva Rebbagondla <[hidden email]>
Acked-by: Shrirang Bagul <[hidden email]>

> ---
>  drivers/bluetooth/btrsi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/btrsi.c b/drivers/bluetooth/btrsi.c
> index 3ef62b9..866b232 100644
> --- a/drivers/bluetooth/btrsi.c
> +++ b/drivers/bluetooth/btrsi.c
> @@ -83,6 +83,7 @@ static int rsi_hci_send_pkt(struct hci_dev *hdev, struct sk_buff *skb)
>   skb_pull(skb, PTR_ALIGN(skb->data,
>   RSI_SDIO_DMA_ALIGN) - skb->data);
>   memmove(skb->data, skb_data, skb_len);
> + skb_trim(skb, skb_len);
>   }
>   }
>  
--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU OEM-B][PATCH] UBUNTU: SAUCE: Bluetooth: btrsi: fix l2test data transfer issue

Anthony Wong-2
In reply to this post by Siva Rebbagondla-2
On Mon, Jul 16, 2018 at 04:01:39PM +0530, Siva Rebbagondla wrote:

> From: Siva Rebbagondla <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1781895
>  
> Observed bluetooth l2test is getting failed as skb->data is having some
> extra bytes rather than expected size, which is Incorrect. Hence, removed
> redundant bytes from skb using skb_trim().
>
> Signed-off-by: Siva Rebbagondla <[hidden email]>
> ---
>  drivers/bluetooth/btrsi.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/btrsi.c b/drivers/bluetooth/btrsi.c
> index 3ef62b9..866b232 100644
> --- a/drivers/bluetooth/btrsi.c
> +++ b/drivers/bluetooth/btrsi.c
> @@ -83,6 +83,7 @@ static int rsi_hci_send_pkt(struct hci_dev *hdev, struct sk_buff *skb)
>   skb_pull(skb, PTR_ALIGN(skb->data,
>   RSI_SDIO_DMA_ALIGN) - skb->data);
>   memmove(skb->data, skb_data, skb_len);
> + skb_trim(skb, skb_len);
>   }
>   }

Acked-by: Anthony Wong <[hidden email]>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU OEM-B][PATCH] UBUNTU: SAUCE: Bluetooth: btrsi: fix l2test data transfer issue

AceLan Kao
In reply to this post by Siva Rebbagondla-2
Acked-By: AceLan Kao <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team