[SRU][OEM-OSP1-B/E/F/U][PATCH V2 0/1] intel_pch_thermal: Add Comet Lake (CML) platform support

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][OEM-OSP1-B/E/F/U][PATCH V2 0/1] intel_pch_thermal: Add Comet Lake (CML) platform support

You-Sheng Yang
BugLink: https://bugs.launchpad.net/bugs/1853219

[Impact]
Missing thermal_zone info for Intel PCH on Comet Lake (CML) platform.

[Fix]
Commit 35709c4ee772 ("thermal: intel: intel_pch_thermal: Add Comet Lake
(CML) platform support") from v5.6-rc1 to be backported.

[Test Case]
Check if sysfs thermal zone entry of type "pch_cometlake" exists:

  $ cat /sys/class/thermal/thermal_zone*/type | grep pch_cometlake

[Regression Potential]
Low. This affects only CML platforms.

V2: update target series only.

Gayatri Kammela (1):
  thermal: intel: intel_pch_thermal: Add Comet Lake (CML) platform
    support

 drivers/thermal/intel/intel_pch_thermal.c | 8 ++++++++
 1 file changed, 8 insertions(+)

--
2.25.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][OEM-OSP1-B/E/F/U][PATCH V2 1/1] thermal: intel: intel_pch_thermal: Add Comet Lake (CML) platform support

You-Sheng Yang
From: Gayatri Kammela <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1853219

Add Comet Lake to the list of the platforms to support intel_pch_thermal
driver.

Cc: Zhang rui <[hidden email]>
Cc: Srinivas Pandruvada <[hidden email]>
Signed-off-by: Gayatri Kammela <[hidden email]>
Acked-by: Zhang Rui <[hidden email]>
Signed-off-by: Daniel Lezcano <[hidden email]>
Link: https://lore.kernel.org/r/20191211200043.4985-1-gayatri.kammela@...
(cherry picked from commit 35709c4ee772afc3818cd6d42d123d608feeaa33)
Signed-off-by: You-Sheng Yang <[hidden email]>
---
 drivers/thermal/intel/intel_pch_thermal.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/thermal/intel/intel_pch_thermal.c b/drivers/thermal/intel/intel_pch_thermal.c
index 4f0bb8f502e1..9356f3a7f961 100644
--- a/drivers/thermal/intel/intel_pch_thermal.c
+++ b/drivers/thermal/intel/intel_pch_thermal.c
@@ -23,6 +23,7 @@
 #define PCH_THERMAL_DID_SKL_H 0xA131 /* Skylake PCH 100 series */
 #define PCH_THERMAL_DID_CNL 0x9Df9 /* CNL PCH */
 #define PCH_THERMAL_DID_CNL_H 0xA379 /* CNL-H PCH */
+#define PCH_THERMAL_DID_CML_H 0X06F9 /* CML-H PCH */
 
 /* Wildcat Point-LP  PCH Thermal registers */
 #define WPT_TEMP 0x0000 /* Temperature */
@@ -272,6 +273,7 @@ enum board_ids {
  board_wpt,
  board_skl,
  board_cnl,
+ board_cml,
 };
 
 static const struct board_info {
@@ -294,6 +296,10 @@ static const struct board_info {
  .name = "pch_cannonlake",
  .ops = &pch_dev_ops_wpt,
  },
+ [board_cml] = {
+ .name = "pch_cometlake",
+ .ops = &pch_dev_ops_wpt,
+ }
 };
 
 static int intel_pch_thermal_probe(struct pci_dev *pdev,
@@ -398,6 +404,8 @@ static const struct pci_device_id intel_pch_thermal_id[] = {
  .driver_data = board_cnl, },
  { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_CNL_H),
  .driver_data = board_cnl, },
+ { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_CML_H),
+ .driver_data = board_cml, },
  { 0, },
 };
 MODULE_DEVICE_TABLE(pci, intel_pch_thermal_id);
--
2.25.0


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][OEM-OSP1-B/E/F/U][PATCH V2 1/1] thermal: intel: intel_pch_thermal: Add Comet Lake (CML) platform support

Po-Hsu Lin (Sam)
Clean cherry-pick.
Acked-by: Po-Hsu Lin <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][OEM-OSP1-B/E/F/U][PATCH V2 1/1] thermal: intel: intel_pch_thermal: Add Comet Lake (CML) platform support

Kleber Souza
In reply to this post by You-Sheng Yang
On 13.02.20 07:55, You-Sheng Yang wrote:

> From: Gayatri Kammela <[hidden email]>
>
> BugLink: https://bugs.launchpad.net/bugs/1853219
>
> Add Comet Lake to the list of the platforms to support intel_pch_thermal
> driver.
>
> Cc: Zhang rui <[hidden email]>
> Cc: Srinivas Pandruvada <[hidden email]>
> Signed-off-by: Gayatri Kammela <[hidden email]>
> Acked-by: Zhang Rui <[hidden email]>
> Signed-off-by: Daniel Lezcano <[hidden email]>
> Link: https://lore.kernel.org/r/20191211200043.4985-1-gayatri.kammela@...
> (cherry picked from commit 35709c4ee772afc3818cd6d42d123d608feeaa33)
> Signed-off-by: You-Sheng Yang <[hidden email]>

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

> ---
>  drivers/thermal/intel/intel_pch_thermal.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/thermal/intel/intel_pch_thermal.c b/drivers/thermal/intel/intel_pch_thermal.c
> index 4f0bb8f502e1..9356f3a7f961 100644
> --- a/drivers/thermal/intel/intel_pch_thermal.c
> +++ b/drivers/thermal/intel/intel_pch_thermal.c
> @@ -23,6 +23,7 @@
>  #define PCH_THERMAL_DID_SKL_H 0xA131 /* Skylake PCH 100 series */
>  #define PCH_THERMAL_DID_CNL 0x9Df9 /* CNL PCH */
>  #define PCH_THERMAL_DID_CNL_H 0xA379 /* CNL-H PCH */
> +#define PCH_THERMAL_DID_CML_H 0X06F9 /* CML-H PCH */
>  
>  /* Wildcat Point-LP  PCH Thermal registers */
>  #define WPT_TEMP 0x0000 /* Temperature */
> @@ -272,6 +273,7 @@ enum board_ids {
>   board_wpt,
>   board_skl,
>   board_cnl,
> + board_cml,
>  };
>  
>  static const struct board_info {
> @@ -294,6 +296,10 @@ static const struct board_info {
>   .name = "pch_cannonlake",
>   .ops = &pch_dev_ops_wpt,
>   },
> + [board_cml] = {
> + .name = "pch_cometlake",
> + .ops = &pch_dev_ops_wpt,
> + }
>  };
>  
>  static int intel_pch_thermal_probe(struct pci_dev *pdev,
> @@ -398,6 +404,8 @@ static const struct pci_device_id intel_pch_thermal_id[] = {
>   .driver_data = board_cnl, },
>   { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_CNL_H),
>   .driver_data = board_cnl, },
> + { PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCH_THERMAL_DID_CML_H),
> + .driver_data = board_cml, },
>   { 0, },
>  };
>  MODULE_DEVICE_TABLE(pci, intel_pch_thermal_id);
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED: [SRU][OEM-OSP1-B/E/F/U][PATCH V2 0/1] intel_pch_thermal: Add Comet Lake (CML) platform support

Khaled Elmously
In reply to this post by You-Sheng Yang
On 2020-02-13 14:55:38 , You-Sheng Yang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1853219
>
> [Impact]
> Missing thermal_zone info for Intel PCH on Comet Lake (CML) platform.
>
> [Fix]
> Commit 35709c4ee772 ("thermal: intel: intel_pch_thermal: Add Comet Lake
> (CML) platform support") from v5.6-rc1 to be backported.
>
> [Test Case]
> Check if sysfs thermal zone entry of type "pch_cometlake" exists:
>
>   $ cat /sys/class/thermal/thermal_zone*/type | grep pch_cometlake
>
> [Regression Potential]
> Low. This affects only CML platforms.
>
> V2: update target series only.
>
> Gayatri Kammela (1):
>   thermal: intel: intel_pch_thermal: Add Comet Lake (CML) platform
>     support
>
>  drivers/thermal/intel/intel_pch_thermal.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> --
> 2.25.0
>
>
> --
> kernel-team mailing list
> [hidden email]
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED Re: [SRU][OEM-OSP1-B/E/F/U][PATCH V2 0/1] intel_pch_thermal: Add Comet Lake (CML) platform support

Paolo Pisati-5
In reply to this post by You-Sheng Yang
On Thu, Feb 13, 2020 at 02:55:38PM +0800, You-Sheng Yang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1853219
>
> [Impact]
> Missing thermal_zone info for Intel PCH on Comet Lake (CML) platform.
>
> [Fix]
> Commit 35709c4ee772 ("thermal: intel: intel_pch_thermal: Add Comet Lake
> (CML) platform support") from v5.6-rc1 to be backported.
>
> [Test Case]
> Check if sysfs thermal zone entry of type "pch_cometlake" exists:
>
>   $ cat /sys/class/thermal/thermal_zone*/type | grep pch_cometlake
>
> [Regression Potential]
> Low. This affects only CML platforms.
>
> V2: update target series only.

Applied to Focal/linux.
--
bye,
p.

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

APPLIED [OEM-OSP1] Re: [SRU][OEM-OSP1-B/E/F/U][PATCH V2 0/1] intel_pch_thermal: Add Comet Lake (CML) platform support

Timo Aaltonen-6
In reply to this post by You-Sheng Yang
On 13.2.2020 8.55, You-Sheng Yang wrote:

> BugLink: https://bugs.launchpad.net/bugs/1853219
>
> [Impact]
> Missing thermal_zone info for Intel PCH on Comet Lake (CML) platform.
>
> [Fix]
> Commit 35709c4ee772 ("thermal: intel: intel_pch_thermal: Add Comet Lake
> (CML) platform support") from v5.6-rc1 to be backported.
>
> [Test Case]
> Check if sysfs thermal zone entry of type "pch_cometlake" exists:
>
>   $ cat /sys/class/thermal/thermal_zone*/type | grep pch_cometlake
>
> [Regression Potential]
> Low. This affects only CML platforms.
>
> V2: update target series only.
>
> Gayatri Kammela (1):
>   thermal: intel: intel_pch_thermal: Add Comet Lake (CML) platform
>     support
>
>  drivers/thermal/intel/intel_pch_thermal.c | 8 ++++++++
>  1 file changed, 8 insertions(+)

applied to osp1 oem-next, thanks


--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team