[SRU][OEM-OSP1-B][PATCH 0/1] ICL hdmi audio doesn't work stable

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][OEM-OSP1-B][PATCH 0/1] ICL hdmi audio doesn't work stable

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1836916

This patch is needed to be merged to oem-osp1-b kernel ASAP, since
our oem project is waiting for this patch.

After we get the real fix, I will revert this patch.

[Impact]
On a Dell icelake platform, the hdmi audio doesn't work well, it has a
failure rate that the hdmi audio doesn't work.

[Fix]
set disable_power_well=0 for icl graphic card

[Test Case]
after applying the patchset, we plug hdmi cable and the hdmi audio shows up
in the sound-setting and works well, after unplugging the cable, the hdmi
audio disappears as expected. and repeat 20 times,  the hdmi audio always
work well

[Regression Risk]
Low. this patchset is specific to icl graphic card


Hui Wang (1):
  UBUNTU: SAUCE: i915: set disable_power_well=0 for icl temporarily

 drivers/gpu/drm/i915/intel_runtime_pm.c | 5 +++++
 1 file changed, 5 insertions(+)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][OEM-OSP1-B][PATCH 1/1] UBUNTU: SAUCE: i915: set disable_power_well=0 for icl temporarily

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1836916

So far the latest mainline linux can't support the icl hdmi audio
well, we need to apply this workaround temporarily, and Intel is
investigating this issue now, after we get the real fix, I will
revert this patch.

Signed-off-by: Hui Wang <[hidden email]>
---
 drivers/gpu/drm/i915/intel_runtime_pm.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index a4cd90251491..cbe3ac3003c2 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -3037,6 +3037,11 @@ static int
 sanitize_disable_power_well_option(const struct drm_i915_private *dev_priv,
    int disable_power_well)
 {
+ struct pci_dev *pdev = dev_priv->drm.pdev;
+ /* icl hdmi audio needs to set disable_power_well=0 temporarily, will remove it later */
+ if ((pdev->device == 0x8a56) || (pdev->device == 0x8a52))
+ return 0;
+
  if (disable_power_well >= 0)
  return !!disable_power_well;
 
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/Applied[OEM-OSP1-B]: [SRU][OEM-OSP1-B][PATCH 0/1] ICL hdmi audio doesn't work stable

AceLan Kao
In reply to this post by Hui Wang
Applied on Ubuntu-oem-osp1-5.0.0-1016.17
Acked-By: AceLan Kao <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team