[SRU][OEM-OSP1-B][PATCH 0/1] alsa/sof: The definition of ROM state register is not correct

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][OEM-OSP1-B][PATCH 0/1] alsa/sof: The definition of ROM state register is not correct

Hui Wang
BugLink: http://bugs.launchpad.net/bugs/1837500

[Impact]
Intel notified me that they found a critical issue, and this is the
fix for this issue.

[Fix]
correct the status register definition

[Test Case]
After applying this patch, I can't reproduce "load fw failed ret: -110"
error anymore.

[Regression Risk]
Low. This Rom is developed by Intel. they provided the patch.

Keyon Jie (1):
  ASoC: SOF: Intel: HDA: correct ROM state mask

 sound/soc/sof/intel/hda.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][OEM-OSP1-B][PATCH 1/1] ASoC: SOF: Intel: HDA: correct ROM state mask

Hui Wang
From: Keyon Jie <[hidden email]>

BugLink: http://bugs.launchpad.net/bugs/1837500

The ROM state is represented by the 24 LSB bits in the ROM status
register, so the mask should be 0xffffff instead of 0xf.

Signed-off-by: Keyon Jie <[hidden email]>
(cherry picked from commit f745362cc60dd62b825a4afacf7457430dce3565
git://github.com/thesofproject/linux.git)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/soc/sof/intel/hda.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sof/intel/hda.h b/sound/soc/sof/intel/hda.h
index 1475d8a51a7e..3ab90266244a 100644
--- a/sound/soc/sof/intel/hda.h
+++ b/sound/soc/sof/intel/hda.h
@@ -169,7 +169,7 @@
 #define HDA_DSP_STACK_DUMP_SIZE 32
 
 /* ROM  status/error values */
-#define HDA_DSP_ROM_STS_MASK 0xf
+#define HDA_DSP_ROM_STS_MASK GENMASK(23, 0)
 #define HDA_DSP_ROM_INIT 0x1
 #define HDA_DSP_ROM_FW_MANIFEST_LOADED 0x3
 #define HDA_DSP_ROM_FW_FW_LOADED 0x4
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/APPLIED[OEM-OSP1-B]: [SRU][OEM-OSP1-B][PATCH 0/1] alsa/sof: The definition of ROM state register is not correct

AceLan Kao
In reply to this post by Hui Wang
Applied on Ubuntu-oem-osp1-5.0.0-1016.17

Acked-By: AceLan Kao <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team