[SRU][OEM-OSP1-B][PATCH 0/1] alsa/sof: the headphone doesn't work when sound-setting opens

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][OEM-OSP1-B][PATCH 0/1] alsa/sof: the headphone doesn't work when sound-setting opens

Hui Wang
BugLink: http://bugs.launchpad.net/bugs/1837900

[Impact]
When the sound-setting opens and users plug a headphone, the headphone
usually doesn't work (can't hear sound from headphone), it has a failure
rate about 8/10.

[Fix]
Intel provide a patch to revert the powersave setting patch.

[Test Case]
With the sound-setting is opening, plug a headphone, and play
sound from headphone, it works well. I test 20 times, it all work well.

[Regression Risk]
Low. Intel used this patch for a long time on many platforms, no regression
found so far.


Rander Wang (1):
  Revert "ASoC: SOF: hda: set autosuspend delay for hda bus device"

 sound/soc/sof/intel/hda-codec.c | 4 ----
 1 file changed, 4 deletions(-)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][OEM-OSP1-B][PATCH 1/1] Revert "ASoC: SOF: hda: set autosuspend delay for hda bus device"

Hui Wang
From: Rander Wang <[hidden email]>

BugLink: https://bugs.launchpad.net/bugs/1837900

This reverts commit 69964d0992a29b95b63e519f2dd7ded2e953fd88

This patch causes a bug: playback and catpure don't work
if playback and catpure are started when ubuntu is just set up.
The hda codec is suspended immediately after initialized in
legacy hda driver and then it works after resume. This patch
breaks the flow in SOF, so just remove it.

Signed-off-by: Rander Wang <[hidden email]>
(cherry picked from commit 52d426d2b84fc5e029a8c23048dc4ae5ad78e0f6
git://github.com/thesofproject/linux.git)
Signed-off-by: Hui Wang <[hidden email]>
---
 sound/soc/sof/intel/hda-codec.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/sound/soc/sof/intel/hda-codec.c b/sound/soc/sof/intel/hda-codec.c
index edac308fcf9e..c711792534da 100644
--- a/sound/soc/sof/intel/hda-codec.c
+++ b/sound/soc/sof/intel/hda-codec.c
@@ -138,7 +138,6 @@ static int hda_codec_probe(struct snd_sof_dev *sdev, int address)
 int hda_codec_probe_bus(struct snd_sof_dev *sdev)
 {
  struct hdac_bus *bus = sof_to_bus(sdev);
- struct hda_bus *hbus = sof_to_hbus(sdev);
  int i, ret;
 
  /* probe codecs in avail slots */
@@ -155,9 +154,6 @@ int hda_codec_probe_bus(struct snd_sof_dev *sdev)
  }
  }
 
- /* set autosuspend delay for hda bus device */
- snd_hda_set_power_save(hbus, SND_SOF_SUSPEND_DELAY_MS);
-
  return 0;
 }
 EXPORT_SYMBOL(hda_codec_probe_bus);
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK/APPLIED[OEM-B]: [SRU][OEM-OSP1-B][PATCH 0/1] alsa/sof: the headphone doesn't work when sound-setting opens

AceLan Kao
In reply to this post by Hui Wang
Applied on Ubuntu-oem-osp1-5.0.0-1016.18

Acked-By: AceLan Kao <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team