[SRU][OEM-OSP1-B][PATCH 0/1] drm/i915: revert the patch of "set disable_power_well=0 for icl temporarily"

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][OEM-OSP1-B][PATCH 0/1] drm/i915: revert the patch of "set disable_power_well=0 for icl temporarily"

Hui Wang
BugLink: http://bugs.launchpad.net/bugs/1839950

[Impact]
Two weeks ago, we sent the patch to set disable_power_well=0, this is
because we found sometimes the hdmi audio driver printed out the timeout
errors when accessing the codec. But recently the ODM told us those
machines had some HW or BIOS issues, we can't reproduce the timeout
errors on the new machines anymore even without this patch. And moreover
we need put the CPU into PC10 power state to meet the E-star starndard,
we need to revert this patch.

[Fix]
Revert the patch.

[Test Case]
Tested on the new icl laptops, we have not reproduce the timeout errors,
and The PC can enter PC10.

[Regression Risk]
Low. We have done many tests.


Hui Wang (1):
  Revert "UBUNTU: SAUCE: i915: set disable_power_well=0 for icl
    temporarily"

 drivers/gpu/drm/i915/intel_runtime_pm.c | 5 -----
 1 file changed, 5 deletions(-)

--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][OEM-OSP1-B][PATCH 1/1] Revert "UBUNTU: SAUCE: i915: set disable_power_well=0 for icl temporarily"

Hui Wang
BugLink: https://bugs.launchpad.net/bugs/1839950

This reverts commit 02a7f5d9b444d19ea915c6568bd11c6d22306899.

We can't reproduce the hdmi audio issue anymore on the icl laptop even
without disable_power_well=0, and disable_power_well=0 will prevent
the CPU from entering PC10 power state, let us revert this patch.

Signed-off-by: Hui Wang <[hidden email]>
---
 drivers/gpu/drm/i915/intel_runtime_pm.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index cbe3ac3003c2..a4cd90251491 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -3037,11 +3037,6 @@ static int
 sanitize_disable_power_well_option(const struct drm_i915_private *dev_priv,
    int disable_power_well)
 {
- struct pci_dev *pdev = dev_priv->drm.pdev;
- /* icl hdmi audio needs to set disable_power_well=0 temporarily, will remove it later */
- if ((pdev->device == 0x8a56) || (pdev->device == 0x8a52))
- return 0;
-
  if (disable_power_well >= 0)
  return !!disable_power_well;
 
--
2.17.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][OEM-OSP1-B][PATCH 0/1] drm/i915: revert the patch of "set disable_power_well=0 for icl temporarily"

Anthony Wong-2
In reply to this post by Hui Wang
On Tue, Aug 13, 2019 at 06:08:55PM +0800, Hui Wang wrote:

> BugLink: http://bugs.launchpad.net/bugs/1839950
>
> [Impact]
> Two weeks ago, we sent the patch to set disable_power_well=0, this is
> because we found sometimes the hdmi audio driver printed out the timeout
> errors when accessing the codec. But recently the ODM told us those
> machines had some HW or BIOS issues, we can't reproduce the timeout
> errors on the new machines anymore even without this patch. And moreover
> we need put the CPU into PC10 power state to meet the E-star starndard,
> we need to revert this patch.
>
> [Fix]
> Revert the patch.
>
> [Test Case]
> Tested on the new icl laptops, we have not reproduce the timeout errors,
> and The PC can enter PC10.
>
> [Regression Risk]
> Low. We have done many tests.
>
>
> Hui Wang (1):
>   Revert "UBUNTU: SAUCE: i915: set disable_power_well=0 for icl
>     temporarily"
>
>  drivers/gpu/drm/i915/intel_runtime_pm.c | 5 -----
>  1 file changed, 5 deletions(-)
>

Acked-by: Anthony Wong <[hidden email]>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

NAK: Re: [SRU][OEM-OSP1-B][PATCH 0/1] drm/i915: revert the patch of "set disable_power_well=0 for icl temporarily"

Timo Aaltonen-6
In reply to this post by Hui Wang
On 13.8.2019 13.08, Hui Wang wrote:

> BugLink: http://bugs.launchpad.net/bugs/1839950
>
> [Impact]
> Two weeks ago, we sent the patch to set disable_power_well=0, this is
> because we found sometimes the hdmi audio driver printed out the timeout
> errors when accessing the codec. But recently the ODM told us those
> machines had some HW or BIOS issues, we can't reproduce the timeout
> errors on the new machines anymore even without this patch. And moreover
> we need put the CPU into PC10 power state to meet the E-star starndard,
> we need to revert this patch.
>
> [Fix]
> Revert the patch.
>
> [Test Case]
> Tested on the new icl laptops, we have not reproduce the timeout errors,
> and The PC can enter PC10.
>
> [Regression Risk]
> Low. We have done many tests.
>
>
> Hui Wang (1):
>   Revert "UBUNTU: SAUCE: i915: set disable_power_well=0 for icl
>     temporarily"
>
>  drivers/gpu/drm/i915/intel_runtime_pm.c | 5 -----
>  1 file changed, 5 deletions(-)
>

apparently the workaround is still needed

--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [SRU][OEM-OSP1-B][PATCH 0/1] drm/i915: revert the patch of "set disable_power_well=0 for icl temporarily"

Hui Wang
In reply to this post by Hui Wang
Timo & Acelan,

Don't forget to merge this one to osp1 if it is possible.

On 2019/8/13 下午6:08, Hui Wang wrote:

> BugLink: http://bugs.launchpad.net/bugs/1839950
>
> [Impact]
> Two weeks ago, we sent the patch to set disable_power_well=0, this is
> because we found sometimes the hdmi audio driver printed out the timeout
> errors when accessing the codec. But recently the ODM told us those
> machines had some HW or BIOS issues, we can't reproduce the timeout
> errors on the new machines anymore even without this patch. And moreover
> we need put the CPU into PC10 power state to meet the E-star starndard,
> we need to revert this patch.
>
> [Fix]
> Revert the patch.
>
> [Test Case]
> Tested on the new icl laptops, we have not reproduce the timeout errors,
> and The PC can enter PC10.
>
> [Regression Risk]
> Low. We have done many tests.
>
>
> Hui Wang (1):
>    Revert "UBUNTU: SAUCE: i915: set disable_power_well=0 for icl
>      temporarily"
>
>   drivers/gpu/drm/i915/intel_runtime_pm.c | 5 -----
>   1 file changed, 5 deletions(-)
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [SRU][OEM-OSP1-B][PATCH 0/1] drm/i915: revert the patch of "set disable_power_well=0 for icl temporarily"

Timo Aaltonen-6
On 10.10.2019 3.55, Hui Wang wrote:
> Timo & Acelan,
>
> Don't forget to merge this one to osp1 if it is possible.

You need to resend it, this was NAKed seven weeks ago.


--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [SRU][OEM-OSP1-B][PATCH 0/1] drm/i915: revert the patch of "set disable_power_well=0 for icl temporarily"

Hui Wang
OK, will resend it.

thx.

On 2019/10/10 上午11:40, Timo Aaltonen wrote:
> On 10.10.2019 3.55, Hui Wang wrote:
>> Timo & Acelan,
>>
>> Don't forget to merge this one to osp1 if it is possible.
> You need to resend it, this was NAKed seven weeks ago.
>
>

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team