[SRU][OEM-OSP1-B][PATCH] spi-nor: intel-spi: Add support for Intel Comet Lake SPI serial flash

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[SRU][OEM-OSP1-B][PATCH] spi-nor: intel-spi: Add support for Intel Comet Lake SPI serial flash

Timo Aaltonen-6
From: Mika Westerberg <[hidden email]>

BugLink: http://bugs.launchpad.net/bugs/1843774

Intel Comet Lake has the same SPI serial flash controller as Ice Lake.
Add Comet Lake PCI ID to the driver list of supported devices.

Signed-off-by: Mika Westerberg <[hidden email]>
Reviewed-by: Tudor Ambarus <[hidden email]>
Signed-off-by: Tudor Ambarus <[hidden email]>
(cherry picked from commit e43f53c22a937d024f070907d02539e413f20c15)
Signed-off-by: Timo Aaltonen <[hidden email]>
---
 drivers/mtd/spi-nor/intel-spi-pci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/spi-nor/intel-spi-pci.c b/drivers/mtd/spi-nor/intel-spi-pci.c
index 872b40922608..bfbfc17ed6aa 100644
--- a/drivers/mtd/spi-nor/intel-spi-pci.c
+++ b/drivers/mtd/spi-nor/intel-spi-pci.c
@@ -63,6 +63,7 @@ static void intel_spi_pci_remove(struct pci_dev *pdev)
 }
 
 static const struct pci_device_id intel_spi_pci_ids[] = {
+ { PCI_VDEVICE(INTEL, 0x02a4), (unsigned long)&bxt_info },
  { PCI_VDEVICE(INTEL, 0x18e0), (unsigned long)&bxt_info },
  { PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info },
  { PCI_VDEVICE(INTEL, 0x34a4), (unsigned long)&bxt_info },
--
2.20.1


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

[SRU][D] Re: [SRU][OEM-OSP1-B][PATCH] spi-nor: intel-spi: Add support for Intel Comet Lake SPI serial flash

Timo Aaltonen-6
On 3.10.2019 20.59, Timo Aaltonen wrote:

> From: Mika Westerberg <[hidden email]>
>
> BugLink: http://bugs.launchpad.net/bugs/1843774
>
> Intel Comet Lake has the same SPI serial flash controller as Ice Lake.
> Add Comet Lake PCI ID to the driver list of supported devices.
>
> Signed-off-by: Mika Westerberg <[hidden email]>
> Reviewed-by: Tudor Ambarus <[hidden email]>
> Signed-off-by: Tudor Ambarus <[hidden email]>
> (cherry picked from commit e43f53c22a937d024f070907d02539e413f20c15)
> Signed-off-by: Timo Aaltonen <[hidden email]>
> ---
>   drivers/mtd/spi-nor/intel-spi-pci.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi-nor/intel-spi-pci.c b/drivers/mtd/spi-nor/intel-spi-pci.c
> index 872b40922608..bfbfc17ed6aa 100644
> --- a/drivers/mtd/spi-nor/intel-spi-pci.c
> +++ b/drivers/mtd/spi-nor/intel-spi-pci.c
> @@ -63,6 +63,7 @@ static void intel_spi_pci_remove(struct pci_dev *pdev)
>   }
>  
>   static const struct pci_device_id intel_spi_pci_ids[] = {
> + { PCI_VDEVICE(INTEL, 0x02a4), (unsigned long)&bxt_info },
>   { PCI_VDEVICE(INTEL, 0x18e0), (unsigned long)&bxt_info },
>   { PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info },
>   { PCI_VDEVICE(INTEL, 0x34a4), (unsigned long)&bxt_info },
>

applies to disco as well

--
t

--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team
Reply | Threaded
Open this post in threaded view
|

Re: [SRU][D] Re: [SRU][OEM-OSP1-B][PATCH] spi-nor: intel-spi: Add support for Intel Comet Lake SPI serial flash

Stefan Bader-2
On 03.10.19 20:20, Timo Aaltonen wrote:

> On 3.10.2019 20.59, Timo Aaltonen wrote:
>> From: Mika Westerberg <[hidden email]>
>>
>> BugLink: http://bugs.launchpad.net/bugs/1843774
>>
>> Intel Comet Lake has the same SPI serial flash controller as Ice Lake.
>> Add Comet Lake PCI ID to the driver list of supported devices.
>>
>> Signed-off-by: Mika Westerberg <[hidden email]>
>> Reviewed-by: Tudor Ambarus <[hidden email]>
>> Signed-off-by: Tudor Ambarus <[hidden email]>
>> (cherry picked from commit e43f53c22a937d024f070907d02539e413f20c15)
>> Signed-off-by: Timo Aaltonen <[hidden email]>
>> ---
>>   drivers/mtd/spi-nor/intel-spi-pci.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi-nor/intel-spi-pci.c
>> b/drivers/mtd/spi-nor/intel-spi-pci.c
>> index 872b40922608..bfbfc17ed6aa 100644
>> --- a/drivers/mtd/spi-nor/intel-spi-pci.c
>> +++ b/drivers/mtd/spi-nor/intel-spi-pci.c
>> @@ -63,6 +63,7 @@ static void intel_spi_pci_remove(struct pci_dev *pdev)
>>   }
>>     static const struct pci_device_id intel_spi_pci_ids[] = {
>> +    { PCI_VDEVICE(INTEL, 0x02a4), (unsigned long)&bxt_info },
>>       { PCI_VDEVICE(INTEL, 0x18e0), (unsigned long)&bxt_info },
>>       { PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info },
>>       { PCI_VDEVICE(INTEL, 0x34a4), (unsigned long)&bxt_info },
>>
>
> applies to disco as well
>
Then it would be better to re-submit as a separate mail, not a reply to a
submission which was only for the osp1 kernel. Because in a threaded view this
tends to be hidden.

-Stefan


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

ACK: [SRU][D] Re: [SRU][OEM-OSP1-B][PATCH] spi-nor: intel-spi: Add support for Intel Comet Lake SPI serial flash

Kleber Souza
In reply to this post by Timo Aaltonen-6
On 03.10.19 20:20, Timo Aaltonen wrote:

> On 3.10.2019 20.59, Timo Aaltonen wrote:
>> From: Mika Westerberg <[hidden email]>
>>
>> BugLink: http://bugs.launchpad.net/bugs/1843774
>>
>> Intel Comet Lake has the same SPI serial flash controller as Ice Lake.
>> Add Comet Lake PCI ID to the driver list of supported devices.
>>
>> Signed-off-by: Mika Westerberg <[hidden email]>
>> Reviewed-by: Tudor Ambarus <[hidden email]>
>> Signed-off-by: Tudor Ambarus <[hidden email]>
>> (cherry picked from commit e43f53c22a937d024f070907d02539e413f20c15)
>> Signed-off-by: Timo Aaltonen <[hidden email]>

Acked-by: Kleber Sacilotto de Souza <[hidden email]>

>> ---
>>   drivers/mtd/spi-nor/intel-spi-pci.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/spi-nor/intel-spi-pci.c b/drivers/mtd/spi-nor/intel-spi-pci.c
>> index 872b40922608..bfbfc17ed6aa 100644
>> --- a/drivers/mtd/spi-nor/intel-spi-pci.c
>> +++ b/drivers/mtd/spi-nor/intel-spi-pci.c
>> @@ -63,6 +63,7 @@ static void intel_spi_pci_remove(struct pci_dev *pdev)
>>   }
>>  
>>   static const struct pci_device_id intel_spi_pci_ids[] = {
>> + { PCI_VDEVICE(INTEL, 0x02a4), (unsigned long)&bxt_info },
>>   { PCI_VDEVICE(INTEL, 0x18e0), (unsigned long)&bxt_info },
>>   { PCI_VDEVICE(INTEL, 0x19e0), (unsigned long)&bxt_info },
>>   { PCI_VDEVICE(INTEL, 0x34a4), (unsigned long)&bxt_info },
>>
>
> applies to disco as well
>


--
kernel-team mailing list
[hidden email]
https://lists.ubuntu.com/mailman/listinfo/kernel-team